07/05/2020 13:41, Ophir Munk: > From: Thomas Monjalon <tho...@monjalon.net> > > 07/05/2020 10:56, Ophir Munk: > > > Move mlx5 symbols in the map file to the INTERNAL section and add > > > __internal tags to their definitions. > > > Those symbols were exported in 20.02 and now (20.05) they are removed. > > [...] > > > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > > > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > > > @@ -1,8 +1,10 @@ > > > -DPDK_21 { > > > +INTERNAL { > > > > I think you forgot the EXPERIMENTAL section. > > In my opinion, everything should be in INTERNAL and marked with > > __rte_internal in source code. > > > > I moved all EXPERIMENTAL to INTERNAL and sent V4. > A general question: what is the difference between EXPERIMENTAL and INTERNAL > functionalities? > In the end both indicate to skip ABI check.
Regarding ABI check, yes the result is the same. Regarding API, it is different: INTERNAL is forbidden to applications, while EXPERIMENTAL is to be used with cautious as compatibility is not guaranteed.