Re: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in output

[Ivan Dyukov]

07.05.2020 13:28, Thomas Monjalon пишет:
> 01/05/2020 15:15, Andrew Rybchenko:
>> On 4/27/20 12:57 PM, Ivan Dyukov wrote:
>>> Signed-off-by: Ivan Dyukov <i.dyu...@samsung.com>
>>> ---
>>>    app/test-pmd/testpmd.c   | 2 +-
>>>    app/test/test_pmd_perf.c | 2 +-
>>>    2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
>>> index 99bacddbf..d4df23a93 100644
>>> --- a/app/test-pmd/testpmd.c
>>> +++ b/app/test-pmd/testpmd.c
>>> @@ -3005,7 +3005,7 @@ check_all_ports_link_status(uint32_t port_mask)
>>>                                     "Port%d Link Up. speed %u Mbps- %s\n",
>>>                                     portid, link.link_speed,
>>>                             (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
>>> -                                   ("full-duplex") : ("half-duplex\n"));
>>> +                                   ("full-duplex") : ("half-duplex"));
>>>                             else
>>>                                     printf("Port %d Link Down\n", portid);
>>>                             continue;
>>> diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
>>> index d61be58bb..352cd4715 100644
>>> --- a/app/test/test_pmd_perf.c
>>> +++ b/app/test/test_pmd_perf.c
>>> @@ -151,7 +151,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t 
>>> port_mask)
>>>                                     "Port%d Link Up. Speed %u Mbps - %s\n",
>>>                                             portid, link.link_speed,
>>>                             (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
>>> -                                   ("full-duplex") : ("half-duplex\n"));
>>> +                                   ("full-duplex") : ("half-duplex"));
>>>                                     if (link_mbps == 0)
>>>                                             link_mbps = link.link_speed;
>>>                             } else
>>>
>>
>> I think Fixes: tag is required here.
>>
>> Acked-by: Andrew Rybchenko <arybche...@solarflare.com>
> Yes please, we would like to backport it.
>
>
>
Ok. I'll make separate patch for that.  There are about 24 same 
'copy/paste' in example folder.