On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote:
> From: Tal Shnaiderman <tal...@mellanox.com>
>
> Added off_t in Windows header file as a supported
> type since it is needed by PCI.
>
> Signed-off-by: Tal Shnaiderman <tal...@mellanox.com>
> ---
> lib/librte_eal/windows/include/rte_os.h | 1 +
> lib/meson.build | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/windows/include/rte_os.h
> b/lib/librte_eal/windows/include/rte_os.h
> index 62805a307..1c433b976 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -48,6 +48,7 @@ extern "C" {
>
> /* as in <windows.h> */
> typedef long long ssize_t;
> +typedef long off_t;
Windows actually has off_t in <sys/types.h>, where it is by POSIX. Shouldn't
rte_pci.h include <sys/types.h> instead? IMO, shims should be kept at minimum.
--
Dmitry Kozlyuk
