Re: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: report header improvement

2019-07-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Artur Trybula > Sent: Friday, July 5, 2019 12:00 PM > To: dev@dpdk.org; fiona.tr...@intel.com; > shally.ve...@caviumnetworks.com; adamx.dybkow...@intel.com; > arturx.tryb...@intel.com; akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH v2 1/1]

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: memory orderings to avoid race conditions for v1604

2019-07-04 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Friday, July 5, 2019 04:25 > To: Ruifeng Wang (Arm Technology China) > Cc: dev@dpdk.org; vladimir.medved...@intel.com; > bruce.richard...@intel.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: Re: [dpdk

[dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: report header improvement

2019-07-04 Thread Artur Trybula
This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out on the screen. Signed-off-by: Artur Trybula --- .../comp_perf_test_common.c | 94 ++-

[dpdk-dev] [PATCH v2 1/1] net/hinic: use mutex replace spin lock

2019-07-04 Thread Ziyang Xuan
Using spin lock to protect critical resources of sending mgmt messages. This will make high CPU usage for rte_delay_ms when sending mgmt messages frequently. We can use mutex to protect the critical resources and usleep to reduce CPU usage while keep functioning properly. Signed-off-by: Ziyang Xua

[dpdk-dev] [PATCH v2 0/1] add extra features to test-compress-perf

2019-07-04 Thread Artur Trybula
v2 changes: - merged with the series "add multiple cores feature to test-compress-perf" - function renamed: print_report_header() -> print_test_dynamics() This patch depends on the series "add multiple cores feature to test-compress-perf" https://patches.dpdk.org/c

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Thomas Monjalon
05/07/2019 08:14, Honnappa Nagarahalli: > > 02/07/2019 23:16, Honnappa Nagarahalli: > > > v2 > > > - Dropped moving the tbl_chng_cnt to the beginning of the cache line > > >commit > > > - Changed the commit log for patch 1 to indicate that it improves > > >performance (Yipeng) > > > - Ch

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Honnappa Nagarahalli
> 02/07/2019 23:16, Honnappa Nagarahalli: > > v2 > > - Dropped moving the tbl_chng_cnt to the beginning of the cache line > >commit > > - Changed the commit log for patch 1 to indicate that it improves > >performance (Yipeng) > > - Changed the comment in the search_one_bucket_lf function

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Honnappa Nagarahalli
> [Snip] > > > The first patch in this series moves the signature comparison before > > the load- acquire of the key_index. This does not result in any issues > > because of the full key comparison which is done after the load-acquire of > the key_index. > > Performance improvements: > > Lookup Hi

Re: [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare

2019-07-04 Thread Honnappa Nagarahalli
> >Subject: RE: [PATCH 2/3] lib/hash: load pData after full key compare > > > >Thank you Yipeng for your comments. > > > >> > > >> >When a hash entry is added, there are 2 sets of stores. > >> > > >> >1) The application writes its data to memory (whose address is > >> >provided in rte_hash_add_key_

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-04 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Honnappa >Nagarahalli >Sent: Friday, July 5, 2019 9:51 AM >To: Jerin Jacob Kollanukkaran ; Phil Yang (Arm >Technology China) ; dev@dpdk.org >Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Gavin Hu (Arm >Technology China) ; Honnappa Nagarahal

[dpdk-dev] [PATCH v2] mempool/octeontx2: fix arm64 clang build failure

2019-07-04 Thread pbhagavatula
From: Pavan Nikhilesh The ARMv8.1 CASP instruction works with even register pairs and since there no register constraint in older versions of GCC/Clang, use explicit register allocation to satisfy CASP requirements. Remove function level optimization specification as Clang doesnt have support for

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-04 Thread Honnappa Nagarahalli
> > > Subject: [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare > > > exchange > > > > > > Add 128-bit atomic compare exchange on aarch64. > > > > > > Signed-off-by: Phil Yang > > > Tested-by: Honnappa Nagarahalli > > > Reviewed-by: Honnappa Nagarahalli > > > --- > > > v3: > > > 1. A

Re: [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations

2019-07-04 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Friday, July 5, 2019 4:16 AM > To: dev@dpdk.org; Phil Yang (Arm Technology China) > Cc: david.h...@intel.com; reshma.pat...@intel.com; Gavin Hu (Arm > Technology China) ; Honnappa Nagarahalli > ; nd ; > bruce.richard...@intel.com; konst

Re: [dpdk-dev] [PATCH v11 0/4] rawdev driver for ntb

2019-07-04 Thread Li, Xiaoyun
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, July 4, 2019 20:30 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v11 0/4] rawdev driver for ntb > > This patch set adds support for Intel NTB device with Skylake platform. > I

[dpdk-dev] [PATCH v6 3/4] net/mlx5: match GRE's key and present bits

2019-07-04 Thread Xiaoyu Min
support matching on the present bits (C,K,S) as well as the optional key field. If the rte_flow_item_gre_key is specified in pattern, it will set K present match automatically. Signed-off-by: Xiaoyu Min --- doc/guides/rel_notes/release_19_08.rst | 5 ++ drivers/net/mlx5/mlx5_flow.c |

[dpdk-dev] [PATCH v6 2/4] net/mlx5: support match GRE protocol on DR engine

2019-07-04 Thread Xiaoyu Min
DR engine support matching on GRE protocol field without MPLS supports. So bypassing the MPLS check when DR is enabled. Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c ind

[dpdk-dev] [PATCH v6 1/4] ethdev: add GRE key field to flow API

2019-07-04 Thread Xiaoyu Min
Add new rte_flow_item_gre_key in order to match the optional key field. Acked-by: Ori Kam Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 9 + lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 13 + 3 files changed, 23 insert

[dpdk-dev] [PATCH v6 4/4] app/testpmd: match GRE's key and present bits

2019-07-04 Thread Xiaoyu Min
support matching on GRE key and present bits (C,K,S) example testpmd command could be: testpmd>flow create 0 ingress group 1 pattern eth / ipv4 / gre / gre_key value is 0x12345678 / end actions rss queues 1 0 end / mark id 196 / end Which will match GRE packet with k present

[dpdk-dev] [PATCH v6 0/4] match on GRE's key

2019-07-04 Thread Xiaoyu Min
This series patchs are based on RFC [1], which enable the matching on GRE's key field. And enabled MLX5 device supports on this. [1] https://patches.dpdk.org/patch/53432/ --- v2: * remove struct rte_flow_item_gre_key in order to comply new convention v3: * updated release note * fixed one b

Re: [dpdk-dev] [PATCH v10 1/5] raw/ntb: introduce ntb rawdev driver

2019-07-04 Thread Li, Xiaoyun
Sorry. Miss the first question. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 4, 2019 18:32 > To: Li, Xiaoyun > Cc: dev@dpdk.org; Wu, Jingjing ; Wiles, Keith > ; Liang, Cunming ; Maslekar, > Omkar ; Richardson, Bruce > ; Yigit, Ferruh >

Re: [dpdk-dev] [PATCH v10 1/5] raw/ntb: introduce ntb rawdev driver

2019-07-04 Thread Li, Xiaoyun
Sure. Thanks. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 4, 2019 18:32 > To: Li, Xiaoyun > Cc: dev@dpdk.org; Wu, Jingjing ; Wiles, Keith > ; Liang, Cunming ; Maslekar, > Omkar ; Richardson, Bruce > ; Yigit, Ferruh > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected skip fdir setup

2019-07-04 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, July 4, 2019 10:18 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix unexpected skip fdir setup > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Wednesday, July

Re: [dpdk-dev] [PATCH] doc: update bnxt PMD guide

2019-07-04 Thread Ferruh Yigit
On 7/3/2019 12:42 PM, Lance Richardson wrote: > - Include list of supported adapters. > - Include list of supported features. > - Document requirements for vector mode PMD. > - Remove obsolete limitation (scatter rx has been supported for > some time). > - Fixed broken links. > > Acked-by: Ajit

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue

2019-07-04 Thread Ferruh Yigit
On 7/4/2019 9:53 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Zhao1, Wei >> Sent: Thursday, July 4, 2019 6:36 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Iremonger, Bernard ; >> Zhao1, Wei >> Subject: [PATCH v2] app/testpmd: fix to add offloads confguration for queue >>

[dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-04 Thread Yongseok Koh
A tag is a transient data which can be used during flow match. This can be used to store match result from a previous table so that the same pattern need not be matched again on the next table. Even if outer header is decapsulated on the previous match, the match result can be kept. Some device ex

[dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-04 Thread Yongseok Koh
Currently, metadata can be set on egress path via mbuf tx_meatadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata. This patch extends the usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a rule and match

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30

2019-07-04 Thread Ferruh Yigit
On 7/3/2019 4:23 PM, Iremonger, Bernard wrote: > > >>> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue >>> rule failure on fedora30 >>> >>> On 06/25, Haiyue Wang wrote: Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, otherwise, the pop 'arg' i

Re: [dpdk-dev] [PATCH v5 0/9] raw/ioat: driver for Intel QuickData Technology

2019-07-04 Thread Ferruh Yigit
On 7/2/2019 3:12 PM, Bruce Richardson wrote: > This patch series adds support for the Intel QuickData Technology > device, part of the Intel I/O Acceleration Technology (Intel I/OAT). It > is a raw device for allowing hardware DMA i.e. data copies in hardware. > > Performing the copies in hardware

Re: [dpdk-dev] [PATCH v3] test/eal: add ut for eal options proc-type and uio

2019-07-04 Thread Thomas Monjalon
03/07/2019 15:06, Lavanya Govindarajan: > Added unit test cases for EAL flags --proc-type=auto and > --create-uio-dev in order to cover the below functions > eal_proc_type_detect() > rte_eal_create_uio_dev() > > Signed-off-by: Lavanya Govindarajan > Reviewed-by: David Marchand > Acked-by: Anatol

Re: [dpdk-dev] [PATCH v3] test: reduce test duration for efd autotest

2019-07-04 Thread Thomas Monjalon
Still no review for this patch? 20/01/2019 22:25, Thomas Monjalon: > Any review please? > > 29/11/2018 08:36, Jananee Parthasarathy: > > Reduced test time for efd_autotest. > > Key length is updated, invoke times of random function is reduced. > > Different value is updated for each hash key entr

Re: [dpdk-dev] [PATCH v2] usertools: update to usertool for baseband device

2019-07-04 Thread Thomas Monjalon
24/06/2019 10:50, Mokhtar, Amr: > From: Chautru, Nicolas > > > > Allows binding of baseband devices > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Amr Mokhtar Applied, thanks Note: while rebasing the patch, I sorted baseband between network and crypto. I suggest to use this order in ot

Re: [dpdk-dev] [PATCH v4] test/eal: add ut cases for in-memory and single-file-segment

2019-07-04 Thread Thomas Monjalon
03/07/2019 09:13, Pallantla Poornima: > Added unit test case for eal command line '--in-memory' option > which will cover below functions. > get_seg_memfd() > test_memfd_create() > pagesz_flags() > > Added unit test case for eal command line '--single-file-segments' option > which will cover resiz

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6

2019-07-04 Thread Thomas Monjalon
02/07/2019 13:50, Dumitrescu, Cristian: > From: David Marchand [mailto:david.march...@redhat.com] > On Tue, Jul 2, 2019 at 1:22 PM Jananee Parthasarathy > mailto:jananeex.m.parthasara...@intel.com>> > wrote: > Unit test table_autotest results in segmentation fault. > Crash occurs in test_table_lp

Re: [dpdk-dev] [PATCH v2] app/test: fix autotest_runner crash

2019-07-04 Thread Thomas Monjalon
12/06/2019 16:48, Burakov, Anatoly: > On 12-Jun-19 3:46 PM, Herakliusz Lipiec wrote: > > On some systems when dpdk test is executed with make test command > > autotest_runner crashes in first_cpu_on_node. This happens when list > > of available cpus contains something that is not a cpu as first ele

Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools: Fix clearing any old data

2019-07-04 Thread Thomas Monjalon
04/06/2019 09:20, David Marchand: > On Fri, May 31, 2019 at 3:37 PM Luca Boccassi wrote: > > On Fri, 2019-05-31 at 13:11 +0200, Timothy Redaelli wrote: > > > Currently clear_data (dpdk-devbind.py) doesn't work as expected since > > > "global devices" is missing and so "devices" is considered a loc

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: add multi-proc shared lib mempool note

2019-07-04 Thread Thomas Monjalon
21/06/2019 00:07, Gage Eads: > The mempool library assigns handler ops indexes based on the dynamic load > order of mempool handlers. Indexes are used so a mempool can be used by > multiple processes, but this only works if all processes agree on the > mapping from index to mempool handler. > > Wh

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: check port ownership

2019-07-04 Thread Thomas Monjalon
We need a review here. 04/06/2019 00:28, Stephen Hemminger: > From: Stephen Hemminger > > The mp_server would accept a port mask that included hidden (owned) > ports and which later caused either lost packets or failed initialization. > > This fixes explicitly checks for ownership when parsing

Re: [dpdk-dev] [PATCH] devtools: pass custom options to checkpatch

2019-07-04 Thread Thomas Monjalon
24/05/2019 15:45, Ferruh Yigit: > On 5/23/2019 8:45 AM, Olivier Matz wrote: > > Add the ability to pass custom options to checkpatch script. An example > > of use is to change the output format so it can run in emacs compilation > > mode: > > > > DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/check

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: memory orderings to avoid race conditions for v1604

2019-07-04 Thread Thomas Monjalon
03/07/2019 07:44, Ruifeng Wang: > v4: updated test data > v3: updated test data > v2: no changes Ruifeng, it is not easy to follow your changes because you don't use --in-reply-to when sending new versions. So they are not in the same mail thread. It would also help to make a cover letter and make

Re: [dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-07-04 Thread Thomas Monjalon
01/07/2019 22:41, Bruce Richardson: > On Mon, Jul 01, 2019 at 09:30:02PM +0200, Thomas Monjalon wrote: > > 29/05/2019 17:41, Bruce Richardson: > > > Use the flag checking functions and a couple of empty stubs to remove the > > > ifdefs from the middle of the C code, and replace them with more reada

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-04 Thread Thomas Monjalon
We need a review here. 16/04/2019 05:43, ogawa.yasuf...@lab.ntt.co.jp: > From: Yasufumi Ogawa > > In secondary_msl_create_walk(), it creates a file for fbarrays with its > PID for reserving unique name among secondary processes. However, it > does not work if secondary is run as app container be

Re: [dpdk-dev] [PATCH v4 0/3] example and test cases optimizations

2019-07-04 Thread Thomas Monjalon
08/04/2019 05:02, Phil Yang: > Phil Yang (3): > packet_ordering: add statistics for each worker thread > test/distributor: replace sync builtins with atomic builtins > test/ring_perf: replace sync builtins with atomic builtins No more update regarding the performance gain or loss? Any decis

Re: [dpdk-dev] [PATCH v1 0/3] MCS queued lock implementation

2019-07-04 Thread Thomas Monjalon
05/06/2019 17:58, Phil Yang: > This patch set added MCS lock library and its unit test. > > The MCS lock (proposed by JOHN M. MELLOR-CRUMMEY and MICHAEL L. SCOTT) > provides > scalability by spinning on a CPU/thread local variable which avoids expensive > cache bouncings. It provides fairness by

Re: [dpdk-dev] [PATCH v4 0/2] Fifo per core

2019-07-04 Thread Thomas Monjalon
13/06/2019 11:21, Hajkowski: > Marcin Hajkowski (2): > power: add fifo per core for JSON interface > doc: update according to the fifo per core impl We are missing a review of these patches.

Re: [dpdk-dev] [PATCH v4] power: update for handling fifo path string

2019-07-04 Thread Thomas Monjalon
17/04/2019 14:21, Hunt, David: > > On 16/4/2019 11:20 AM, Lukasz Gosiewski wrote: > > From: Lukasz Krakowiak > > > > Removed doubled created fifo path string for channel info. > > > > Signed-off-by: Lukasz Krakowiak > > Signed-off-by: Lukasz Gosiewski > > Acked-by: David Hunt Applied, thanks

Re: [dpdk-dev] [PATCH 0/3] Core capabilities query

2019-07-04 Thread Thomas Monjalon
30/05/2019 18:15, Hajkowski: > Please note that these changes depends on > (http://patchwork.dpdk.org/cover/52335/) and > (http://patchwork.dpdk.org/cover/52213/) which should be applied first. > > Marcin Hajkowski (3): > power: add new packet type for capabilities > examples/power_manager: se

Re: [dpdk-dev] [PATCH 0/4] Frequency list query

2019-07-04 Thread Thomas Monjalon
03/04/2019 19:15, Hajkowski: > Marcin Hajkowski (4): > power: extend guest channel for query freq. > power: process cpu freq. query > power: add mechanism to disable queries > power: add cmd to query CPU freq. This is the same status as for 19.05, there is no review, so it cannot be merged

Re: [dpdk-dev] [PATCH v5 0/4] bidirect guest channel

2019-07-04 Thread Thomas Monjalon
24/04/2019 10:44, Thomas Monjalon: > 24/04/2019 10:38, Hunt, David: > > On 22/4/2019 9:36 PM, Thomas Monjalon wrote: > > > 05/04/2019 15:24, Hajkowski: > > >> From: Marcin Hajkowski > > >> > > >> Extend guest channel API to allow bidirectional > > >> communication. Modify power manager host and gu

Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public

2019-07-04 Thread Thomas Monjalon
04/07/2019 10:09, David Marchand: > I just want to state two approaches to merge these changes: > - the first one would be to split this series in two > - take the first part of this series now, but mark the new API > "experimental" > - postpone the merge to 19.11 of the second part, which star

Re: [dpdk-dev] [PATCH v3 09/14] eal: hide shared memory config

2019-07-04 Thread Thomas Monjalon
27/06/2019 13:39, Anatoly Burakov: > +/** > + * the structure for the memory configuration for the RTE. > + * Used by the rte_config structure. It is separated out, as for > multi-process > + * support, the memory details should be shared across instances > + */ > +struct rte_mem_config { > +

Re: [dpdk-dev] [PATCH] maintainers: update for Mellanox

2019-07-04 Thread Asaf Penso
Shahaf, thank you very much for all the wonderful support and work during past years. I wish you many successes and challenges and for sure will see you around 😊 Raslan, welcome and good luck. I'm confident you will do a great job! Regards, Asaf Penso > -Original Message- > From: dev O

Re: [dpdk-dev] [PATCH] net/af_packet: append system error to error msgs

2019-07-04 Thread Ferruh Yigit
On 7/4/2019 3:39 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Print system error to make easier diagnosis of errors with af_packet. > > Signed-off-by: Krzysztof Kanas > --- > drivers/net/af_packet/rte_eth_af_packet.c | 47 --- > 1 file changed, 24 insertions(+)

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-07-04 Thread Ferruh Yigit
On 4/16/2019 4:13 PM, Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 08:03:36AM -0700, Stephen Hemminger wrote: >> On Tue, 16 Apr 2019 10:42:13 +0100 >> Bruce Richardson wrote: >> >>> On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: On 4/12/2019 11:08 PM, Stephen Hemminger wro

Re: [dpdk-dev] [RFC v2] net: fix rte_vlan_insert with shared mbuf

2019-07-04 Thread Ferruh Yigit
On 4/12/2019 5:35 PM, Ferruh Yigit wrote: > On 3/28/2019 8:53 PM, Stephen Hemminger wrote: >> If mbuf is shared then rte_vlan_insert() would clobber the original >> Ethernet header. The changed version handles this by getting >> an mbuf that will hold the new Ethernet and VLAN header followed >> by

Re: [dpdk-dev] [PATCH v3 00/58] OCTEON TX2 Ethdev driver

2019-07-04 Thread Ferruh Yigit
On 7/3/2019 9:22 PM, Jerin Jacob Kollanukkaran wrote: >> -Original Message- >> From: jer...@marvell.com >> Sent: Wednesday, July 3, 2019 2:12 PM >> To: dev@dpdk.org >> Cc: Jerin Jacob Kollanukkaran >> Subject: [dpdk-dev] [PATCH v3 00/58] OCTEON TX2 Ethdev driver >> >> From: Jerin Jacob >

Re: [dpdk-dev] [PATCH v2 3/3] bus/pci: only consider usable devices to select IOVA mode

2019-07-04 Thread Stephen Hemminger
On Fri, 14 Jun 2019 11:39:17 +0200 David Marchand wrote: > /* Supports only RTE_KDRV_NIC_UIO */ > + if (pdev->kdrv != RTE_KDRV_NIC_UIO) > + RTE_LOG(DEBUG, EAL, "Unsupported kernel driver? Defaulting to > IOVA as 'PA'\n"); Maybe NOTICE level, rather than DEBUG which is usua

Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

2019-07-04 Thread Thomas Monjalon
26/06/2019 23:10, Thomas Monjalon: > 18/05/2019 17:18, Ananyev, Konstantin: > > > > Hi, > > > > > Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags > > > during fragmentation and reassemble operation implicitly. > > > Because of this, application is forced to use checksum offload > > >

Re: [dpdk-dev] [PATCH v2] telemetry: fix build warnings seen when using gcc 9

2019-07-04 Thread Thomas Monjalon
03/07/2019 18:39, Laatz, Kevin: > On 03/07/2019 10:23, Flavia Musatescu wrote: > > Suppress the unaligned packed member address warnings by extending > > the telemetry library build flags with -Wno-address-of-packed-member > > option, through the WERROR_FLAGS makefile variable. > > > > With this ch

Re: [dpdk-dev] [PATCH] net/netvsc: fix definition of offload values

2019-07-04 Thread Ferruh Yigit
On 7/3/2019 4:50 PM, Stephen Hemminger wrote: > The definition of ipsec and rsc offloads was incorrect. > Neither one of these is used by current driver, but the values > should be fixed now for future RSC support. > > Signed-off-by: Stephen Hemminger Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-

Re: [dpdk-dev] [PATCH] net/tap: fix Rx miss the packets

2019-07-04 Thread Thomas Monjalon
04/07/2019 18:11, donald_...@trendmicro.com: > After pmd_rx_burst be triggered, it doesn't retrieve all the frames. > It may leave some pending frames there. > > Signed-off-by: Donald Lee Thank you for the patch. There are two issues which may prevent from merging this patch: 1/ It was not rec

[dpdk-dev] [PATCH] net/tap: fix Rx miss the packets

2019-07-04 Thread donald_...@trendmicro.com
From: Donald Lee After pmd_rx_burst be triggered, it doesn't retrieve all the frames. It may leave some pending frames there. Signed-off-by: Donald Lee --- drivers/net/tap/rte_eth_tap.c | 7 ++- drivers/net/tap/rte_eth_tap.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v5 4/4] app/testpmd: match GRE's key and present bits

2019-07-04 Thread Xiaoyu Min
support matching on GRE key and present bits (C,K,S) example testpmd command could be: testpmd>flow create 0 ingress group 1 pattern eth / ipv4 / gre / gre_key value is 0x12345678 / end actions rss queues 1 0 end / mark id 196 / end Which will match GRE packet with k present

[dpdk-dev] [PATCH v5 3/4] net/mlx5: match GRE's key and present bits

2019-07-04 Thread Xiaoyu Min
support matching on the present bits (C,K,S) as well as the optional key field. If the rte_flow_item_gre_key is specified in pattern, it will set K present match automatically. Signed-off-by: Xiaoyu Min --- doc/guides/rel_notes/release_19_08.rst | 5 ++ drivers/net/mlx5/mlx5_flow.c |

[dpdk-dev] [PATCH 7/7] net/mlx5: add minimal required Tx data inline

2019-07-04 Thread Viacheslav Ovsiienko
Tx data packet data may be inlined into transmit descriptor. At some circumstances ConnectX NICs may require data to be inlined for correct operation. The exact data amount may depend on NIC operation mode, requested Tx offloads, E-Switch configuration, etc. The number of data bytes to inline may

[dpdk-dev] [PATCH v5 1/4] ethdev: add GRE key field to flow API

2019-07-04 Thread Xiaoyu Min
Add new rte_flow_item_gre_key in order to match the optional key field. Acked-by: Ori Kam Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 9 + lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 13 + 3 files changed, 23 insert

[dpdk-dev] [PATCH v5 2/4] net/mlx5: support match GRE protocol on DR engine

2019-07-04 Thread Xiaoyu Min
DR engine support matching on GRE protocol field without MPLS supports. So bypassing the MPLS check when DR is enabled. Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c ind

[dpdk-dev] [PATCH v5 0/4] match on GRE's key

2019-07-04 Thread Xiaoyu Min
This series patchs are based on RFC [1], which enable the matching on GRE's key field. And enabled MLX5 device supports on this. [1] https://patches.dpdk.org/patch/53432/ --- v2: * remove struct rte_flow_item_gre_key in order to comply new convention v3: * updated release note * fixed one b

[dpdk-dev] [PATCH 5/7] net/mlx5: introduce Tx burst routine template

2019-07-04 Thread Viacheslav Ovsiienko
Mellanox NICs support the wide set of Tx offloads. The supported offloads are reported by the mlx5 PMD in rte_eth_dev_info tx_offload_capa field. An application may choose any combination of supported offloads and configure the device appropriately. Some of Tx offloads may be not requested by appli

[dpdk-dev] [PATCH 6/7] net/mlx5: implement Tx burst template

2019-07-04 Thread Viacheslav Ovsiienko
This patch adds the implementation of tx_burst routine template. The template supports all Tx offloads and multiple optimized tx_burst routines can be generated by compiler from this one. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 2869

[dpdk-dev] [PATCH 3/7] net/mlx5: update Tx datapath definitions

2019-07-04 Thread Viacheslav Ovsiienko
This patch updates Tx datapath definitions, mostly hardware related. The Tx descriptor structures are redefined with required fields, size definitions are renamed to reflect the meanings in more appropriate way. This is a preparation step before introducing the new Tx datapath implementation. Sign

[dpdk-dev] [PATCH 1/7] net/mlx5: remove Tx datapath implementation

2019-07-04 Thread Viacheslav Ovsiienko
This patch removes the existing Tx datapath code as preparation step before introducing the new implementation. The following entities are being removed: - obsolete devargs - tx_burst() routines - related PRM definitions - SQ configuration code - Tx routine selection code - incompatible Tx complet

[dpdk-dev] [PATCH 4/7] net/mlx5: add Tx datapath configuration and setup

2019-07-04 Thread Viacheslav Ovsiienko
This patch updates the Tx datapath control and configuration structures and code for mananging Tx datapath settings. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 4 +- drivers/net/mlx5/mlx5_rxtx.h | 55 + drivers/net/mlx5/mlx5_txq.c | 182 +++

[dpdk-dev] [PATCH 2/7] net/mlx5: add Tx datapath related devargs

2019-07-04 Thread Viacheslav Ovsiienko
This patch introduces new mlx5 PMD devarg options: - txq_inline_min - specifies minimal amount of data to be inlined into WQE during Tx operations. NICs may require this minimal data amount to operate correctly. The exact value may depend on NIC operation mode, requested offloads, etc. - tx

Re: [dpdk-dev] [PATCH] app/pdump: enforcing pdump to use sw mempool

2019-07-04 Thread Thomas Monjalon
15/03/2019 16:27, Harman Kalra: > Since pdump uses SW rings to manage packets hence > pdump should use SW ring mempool for managing its > own copy of packets. I'm not sure to understand the reasoning. Reshma, Olivier, Andrew, any opinion? Let's take a decision for this very old patch.

[dpdk-dev] [PATCH 0/7] net/mlx5: consolidate Tx datapath

2019-07-04 Thread Viacheslav Ovsiienko
This patchset introduces the new implementation of tx_burst routine of mlx5 PMD. The existing implementation is based on the several branches of tx_burst routines optimizied for most common sets of Tx hardware offload, supported by Mellanox NICs. It was not very easy to update, support and develop

Re: [dpdk-dev] [PATCH] test: fix build without timer

2019-07-04 Thread Bruce Richardson
On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote: > The action for timer_secondary_spawn_wait should be enabled only when > CONFIG_RTE_LIBRTE_TIMER is enabled. > > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") > Cc: erik.g.carri...@intel.com > Cc: sta..

Re: [dpdk-dev] [PATCH] maintainers: update for Mellanox

2019-07-04 Thread Ferruh Yigit
On 7/4/2019 11:01 AM, Shahaf Shuler wrote: > Due to position change, cannot be a full time maintainer anymore. > The git tree dpdk-next-net-mlx will be managed by Raslan, as approved by > the DPDK Technical Board. > For mlx5 PMD, Slava is added as additional maintainer. > > Will continue to be inv

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 0/2] define ipv4 ihl and vhl

2019-07-04 Thread Ferruh Yigit
On 7/4/2019 8:33 AM, Saleh Alsouqi wrote: > v3: > - Include sys/types.h in librte_net/rte_ip.h, > to fix undefined types in freebsd systems. > > - Split commits into 2, definition in librte_net/rte_ip, > and the usage in app/testpmd. > > - Add "RTE" pre

Re: [dpdk-dev] [PATCH v2 1/2] test/distributor: flush with worker shutdown test fails

2019-07-04 Thread Thomas Monjalon
29/03/2019 23:54, Thomas Monjalon: > 18/02/2019 15:51, Harman Kalra: > > On restarting worker 0 after shutdown, packets handled by > > worker 0 must be incremented only when a packet is received by > > it. > > > > Signed-off-by: Harman Kalra > > It looks to be a fix, so the tag Fixes: should be

Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

2019-07-04 Thread Thomas Monjalon
02/07/2019 23:16, Honnappa Nagarahalli: > v2 > - Dropped moving the tbl_chng_cnt to the beginning of the cache line >commit > - Changed the commit log for patch 1 to indicate that it improves >performance (Yipeng) > - Changed the comment in the search_one_bucket_lf function (Yipeng) > -

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Luca Boccassi
On Thu, 2019-07-04 at 16:17 +0100, Bruce Richardson wrote: > On Thu, Jul 04, 2019 at 04:44:48PM +0200, Thomas Monjalon wrote: > > 04/07/2019 16:20, Bruce Richardson: > > > On Thu, Jul 04, 2019 at 02:18:28PM +, Jerin Jacob > > > Kollanukkaran wrote: > > > > After inspecting the PATH. Its found t

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-04 Thread Thomas Monjalon
Please, any review or ack for this patch? 07/06/2019 04:28, Takeshi Yoshimura: > sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > However, Linux 4.17 or before returns incorrect page_shift for Power9. > I added the code for retrying creation of sPAPR DMA window. > > Signed

Re: [dpdk-dev] [PATCH] config: update RTE_MAX_LCORE for ppc build

2019-07-04 Thread Thomas Monjalon
06/06/2019 01:21, David Christensen: > > Setting RTE_MAX_LCORE to reflect the largest available configuration. > > > > Signed-off-by: David Wilder > > --- > > I am splitting my previous patch "meson: Update flags and values for ppc_64" > > into two separate patches (not a series). This is the se

Re: [dpdk-dev] [PATCH] config: update for ppc build with meson

2019-07-04 Thread Thomas Monjalon
06/06/2019 01:22, David Christensen: > > Adding defines for missing RTE_MACHINE_CPUFLAGs. > > > > Signed-off-by: David Wilder > > --- > > I am splitting my previous patch "meson: Update flags and values for ppc_64" > > into two separate patches (not a series). This is the first patch. > > Acked

[dpdk-dev] [PATCH] test: fix build without timer

2019-07-04 Thread Timothy Redaelli
The action for timer_secondary_spawn_wait should be enabled only when CONFIG_RTE_LIBRTE_TIMER is enabled. Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") Cc: erik.g.carri...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- app/test/test.c | 2 ++ 1 fi

Re: [dpdk-dev] [PATCH v3 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc

2019-07-04 Thread Natanael Copa
On Thu, 04 Jul 2019 15:20:55 +0200 Thomas Monjalon wrote: > 04/07/2019 14:16, Natanael Copa: > > On Sat, 30 Mar 2019 23:22:27 +0100 > > Thomas Monjalon wrote: > > > > > 13/03/2019 18:06, Natanael Copa: > > > > Add a fallback for non-GNU libc systems like musl libc for the > > > > non-standa

Re: [dpdk-dev] [PATCH v2] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool

2019-07-04 Thread Thomas Monjalon
09/04/2019 16:56, Li Qiang: > When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing > 'bp' thus leading resource leak. This patch avoids this. > > Spotted by Coverity: CID 337679 > > Signed-off-by: Li Qiang Applied, thanks Sorry for the delay, I missed the ack from Hemant which was

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Bruce Richardson
On Thu, Jul 04, 2019 at 04:44:48PM +0200, Thomas Monjalon wrote: > 04/07/2019 16:20, Bruce Richardson: > > On Thu, Jul 04, 2019 at 02:18:28PM +, Jerin Jacob Kollanukkaran wrote: > > > After inspecting the PATH. Its found that archlinux has very latest > > > pkgconf(1.6.1). > > > Pkgconf was ov

Re: [dpdk-dev] [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto

2019-07-04 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 3, 2019 4:38 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shally.ve...@caviumnetworks.com; > Kusztal, ArkadiuszX > Subject: [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto > >

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Thursday, July 4, 2019 7:50 PM > To: Jerin Jacob Kollanukkaran > Cc: Luca Boccassi ; dev ; > tho...@monjalon.net > Subject: Re: [EXT] Re: meson build issue > > On Thu, Jul 04, 2019 at 02:18:28PM +, Jerin Jacob Kollanukkaran wro

Re: [dpdk-dev] [PATCH] event/octeontx2: add libatomic dependency for 32-bit clang

2019-07-04 Thread Thomas Monjalon
04/07/2019 10:59, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > When compiling with clang on 32-bit platforms, we are missing > copies of 64-bit atomic functions. We can solve this by linking > against libatomic for the drivers and libs which need those > atomic ops. > > Signed-off-by: P

Re: [dpdk-dev] [PATCH] drivers: fix ICC compilation issue with i686 for octeontx2

2019-07-04 Thread Thomas Monjalon
01/07/2019 20:03, jer...@marvell.com: > From: Amit Gupta > > Fix the following ICC specific compilation issue with i686 build. > > dpdk/drivers/common/octeontx2/otx2_mbox.c(47): error #2259: > non-pointer conversion from "unsigned long long" to "struct mbox_hdr *" > may lose significant bits > (

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Thomas Monjalon
04/07/2019 16:20, Bruce Richardson: > On Thu, Jul 04, 2019 at 02:18:28PM +, Jerin Jacob Kollanukkaran wrote: > > After inspecting the PATH. Its found that archlinux has very latest > > pkgconf(1.6.1). > > Pkgconf was overridden by a armv7 cross compile toolchain from linaro. > > > Ok, thanks

Re: [dpdk-dev] Running dpdk application inside virtual machine created on VirtualBox

2019-07-04 Thread Stephen Hemminger
On Thu, 4 Jul 2019 11:28:13 +0530 Shailja Pandey wrote: > Hi, > > I am trying to run dpdk application inside a virtual machine (Ubuntu > 16.04) deployed in Oracle Virtualbox. The host machine is also the same > Ubuntu 16.04. I am running l2fwd application in the VM and the packets > are being

Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use

2019-07-04 Thread Thomas Monjalon
29/03/2019 15:17, Olivier Matz: > Hi, > > On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote: > > Currently, the flush is done by dequeuing the ring in a while loop. It is > > much simpler to flush the queue by resetting the head and tail indices. > > > > Fixes: af75078fece3 ("first public

[dpdk-dev] [PATCH] net/af_packet: append system error to error msgs

2019-07-04 Thread kkanas
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a

[dpdk-dev] Dpdk version 17.11.4 (i40e) switchover is not working

2019-07-04 Thread chetan bhasin
Hello folks, I am using dpdk 17.11.4 version , it's a bare metal server with intel X722 nic with firm-ware version 4.0. The problem is switch-over is not working, looks like dpdk is not able to get link down trigger. Can anybody guide us please . Thanks, Chetan Bhasin

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Bruce Richardson
On Thu, Jul 04, 2019 at 02:18:28PM +, Jerin Jacob Kollanukkaran wrote: > > > > -Original Message- > > From: Luca Boccassi > > Sent: Thursday, July 4, 2019 7:45 PM > > To: Bruce Richardson ; Jerin Jacob > > Kollanukkaran > > Cc: dev ; tho...@monjalon.net > > Subject: [EXT] Re: meson

Re: [dpdk-dev] [EXT] Re: meson build issue

2019-07-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Luca Boccassi > Sent: Thursday, July 4, 2019 7:45 PM > To: Bruce Richardson ; Jerin Jacob > Kollanukkaran > Cc: dev ; tho...@monjalon.net > Subject: [EXT] Re: meson build issue > > On Thu, 2019-07-04 at 15:01 +0100, Bruce Richardson wrote: > > On Thu, Jul 0

Re: [dpdk-dev] meson build issue

2019-07-04 Thread Luca Boccassi
On Thu, 2019-07-04 at 15:01 +0100, Bruce Richardson wrote: > On Thu, Jul 04, 2019 at 01:57:14PM +, Jerin Jacob Kollanukkaran > wrote: > > > > > -Original Message- > > > From: Bruce Richardson < > > > bruce.richard...@intel.com > > > > > > > Sent: Thursday, July 4, 2019 7:21 PM > > > To

  1   2   >