On 7/4/2019 3:39 PM, kka...@marvell.com wrote:
> From: Krzysztof Kanas <kka...@marvell.com>
> 
> Print system error to make easier diagnosis of errors with af_packet.
> 
> Signed-off-by: Krzysztof Kanas <kka...@marvell.com>
> ---
>  drivers/net/af_packet/rte_eth_af_packet.c | 47 ++++++++++++-----------
>  1 file changed, 24 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c 
> b/drivers/net/af_packet/rte_eth_af_packet.c
> index f396f8b22a55..94ae4b13398d 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -13,7 +13,9 @@
>  #include <rte_malloc.h>
>  #include <rte_kvargs.h>
>  #include <rte_bus_vdev.h>
> +#include <rte_errno.h>
>  
> +#include <errno.h>
>  #include <linux/if_ether.h>
>  #include <linux/if_packet.h>
>  #include <arpa/inet.h>
> @@ -605,8 +607,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
>       }
>       if (ioctl(sockfd, SIOCGIFINDEX, &ifr) == -1) {
>               PMD_LOG(ERR,
> -                     "%s: ioctl failed (SIOCGIFINDEX)",
> -                     name);
> +                     "%s: ioctl failed (SIOCGIFINDEX):%s",
> +                     name, rte_strerror(errno));

What do you think adding an new macro that adds ":%s, rte_strerror(errno)" part
automatically and just change the macro on selected logs?

Reply via email to