On 4/12/2019 5:35 PM, Ferruh Yigit wrote: > On 3/28/2019 8:53 PM, Stephen Hemminger wrote: >> If mbuf is shared then rte_vlan_insert() would clobber the original >> Ethernet header. The changed version handles this by getting >> an mbuf that will hold the new Ethernet and VLAN header followed >> by another mbuf (cloned) for the data. > > Hi Stephen, Chas, > > Since this patch is still an RFC, and we are after RC1, I think it is better > to > consider this patch for next release. > > But for this release, what do you think having a patch to return error on > 'rte_vlan_insert()' for shared mbufs?
nack for this patch The other approach to not support the shared mbuf merged: https://git.dpdk.org/dpdk/commit/?id=15a74163b12
