[dpdk-dev] [Bug 263] ixgbe does not support 10GBASE-T copper SFP+

2019-04-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=263 Bug ID: 263 Summary: ixgbe does not support 10GBASE-T copper SFP+ Product: DPDK Version: 17.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON Tx

2019-04-30 Thread Shahaf Shuler
Wednesday, May 1, 2019 4:37 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON > Tx > > BlueField SmartNIC has 0xa2d2 as PCI device ID on both ARM and x86 host. > On ARM side, Tx inlining need not be used as PCI bandwidth is not > bottleneck. > Vectorized T

Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Shahaf Shuler
Wednesday, May 1, 2019 4:16 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: check Tx queue size overflow > > > > On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > > > If Tx packet inlining is enabled, rdma-core library should allocate > > large Tx WQ enough to support it. It is better f

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix E-Switch flow without port item

2019-04-30 Thread Shahaf Shuler
Thursday, April 25, 2019 8:54 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: fix E-Switch flow without port item > > > > > On Apr 25, 2019, at 5:20 AM, Ori Kam wrote: > > > > When creating a flow rule without the port_id pattern item, always the > > PF was selected. > > > > This commit f

[dpdk-dev] [PATCH v9 4/4] doc: added RCU to the release notes

2019-04-30 Thread Honnappa Nagarahalli
Added RCU library addition to the release notes Signed-off-by: Honnappa Nagarahalli --- doc/guides/rel_notes/release_19_05.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index d5ed564ab..687c01bc1 1

[dpdk-dev] [PATCH v9 1/4] rcu: add RCU library supporting QSBR mechanism

2019-04-30 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

[dpdk-dev] [PATCH v9 3/4] doc/rcu: add lib_rcu documentation

2019-04-30 Thread Honnappa Nagarahalli
Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Marko Kovacevic --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 509 ++

[dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional tests

2019-04-30 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Konstantin Ananyev --- app/test/Makefile |2 +

[dpdk-dev] [PATCH v9 0/4] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-30 Thread Honnappa Nagarahalli
Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

Re: [dpdk-dev] [Bug 261] DPDK 18.11 bug on rte_hash_free_key_with_position

2019-04-30 Thread Dharmik Thakkar
I am taking a look at this bug. Will update ASAP. Did you run any test case to detect the bug? Thank you! > On Apr 30, 2019, at 4:03 AM, bugzi...@dpdk.org wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=261 > >Bug ID: 261 > Summary: DPDK 18.11 bug on rte_hash_free_key_wi

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-04-30 Thread Anoob Joseph
Hi Akhil, > One more thing, is this patch applicable for backport to stable release? Yes. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, April 30, 2019 7:21 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/5] eal: add accessor functions for lcore_config

2019-04-30 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 1, 2019 2:23 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for > lcore_config > On Tue, 16 Apr 2019 17:03:47 + > Jerin Jacob Kollanu

[dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON Tx

2019-04-30 Thread Yongseok Koh
BlueField SmartNIC has 0xa2d2 as PCI device ID on both ARM and x86 host. On ARM side, Tx inlining need not be used as PCI bandwidth is not bottleneck. Vectorized Tx can still be used up to 16 queues. For other archs (e.g., x86), keep using the default value. Fixes: 09d8b41699bb ("net/mlx5: make ve

Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > If Tx packet inlining is enabled, rdma-core library should allocate large > Tx WQ enough to support it. It is better for PMD to calculate the size of > WQ based on the parameters and return error with appropriate message if it > exceeds the

Re: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-04-30 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, April 30, 2019 3:12 PM > To: dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Cc: Wang, Haiyue > Subject: [PATCH v1] net/ice: add link-up and link-down functions > > Support link up and down functions for ice, and when stop the ice

Re: [dpdk-dev] [PATCH] net/i40e: fix link speed issue for X722

2019-04-30 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, April 30, 2019 2:57 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix link speed issue for X722 > > If disable LSC when launching testpmd with X722, shown link speed is 20G but > not 10G.

[dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
If Tx packet inlining is enabled, rdma-core library should allocate large Tx WQ enough to support it. It is better for PMD to calculate the size of WQ based on the parameters and return error with appropriate message if it exceeds the device capability. Cc:sta...@dpdk.org Signed-off-by: Yongseok

Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 5:43 PM, Yongseok Koh wrote: > >> >> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger >> wrote: >> >> On Tue, 30 Apr 2019 12:04:26 -0700 >> Yongseok Koh wrote: >> >>> + priv->sh->device_attr.orig_attr.max_qp_wr) { >>> + DRV_LOG(DEBUG, >>> +

Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger > wrote: > > On Tue, 30 Apr 2019 12:04:26 -0700 > Yongseok Koh wrote: > >> +priv->sh->device_attr.orig_attr.max_qp_wr) { >> +DRV_LOG(DEBUG, >> +"port %u Tx WQEBB count exceeds the limit (%d)," >> +

[dpdk-dev] [PATCH 3/4] test: change memory barrier vriables to uint64_t

2019-04-30 Thread David Christensen
Memory barrier failures can be intermittent. Increase the size of the sum/val/iteration variables to allow tests that can run for days so that sporadic errors can be identified. Signed-off-by: David Christensen --- app/test/test_barrier.c | 25 + 1 file changed, 13 insert

[dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs

2019-04-30 Thread David Christensen
The memory barrier test fails on IBM Power 9 systems. Add additional barriers to accommodate the weakly ordered model used on Power CPUs. Signed-off-by: David Christensen --- app/test/test_barrier.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test/test_barrie

[dpdk-dev] [PATCH 2/4] test: verify calloc succeeded for sum variable

2019-04-30 Thread David Christensen
Code tested calloc failures for pt & lpt variables but not for the sum variable. Add a test for calloc failure of sum. Signed-off-by: David Christensen --- app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_barrier.c b/app/test/test_barrier.

[dpdk-dev] [PATCH 1/4] test: fix typo in print statement

2019-04-30 Thread David Christensen
Change "much" to "match" in a printf. Signed-off-by: David Christensen --- app/test/test_barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c index 82b572c..c219d56 100644 --- a/app/test/test_barrier.c +++ b/app/test/test

Re: [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for lcore_config

2019-04-30 Thread Stephen Hemminger
On Tue, 16 Apr 2019 17:03:47 + Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Wednesday, April 10, 2019 10:46 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v2 2/5] eal: add accessor fu

Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Stephen Hemminger
On Tue, 30 Apr 2019 12:04:26 -0700 Yongseok Koh wrote: > + priv->sh->device_attr.orig_attr.max_qp_wr) { > + DRV_LOG(DEBUG, > + "port %u Tx WQEBB count exceeds the limit (%d)," > + " try smaller queue size again", > +

[dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
If Tx packet inlining is enabled, rdma-core library should allocate large Tx WQ enough to support it. It is better for PMD to calculate the size of WQ based on the parameters and return error with appropriate message if it exceeds the device capability. Signed-off-by: Yongseok Koh --- drivers/ne

Re: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-04-30 Thread Stillwell Jr, Paul M
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, April 30, 2019 10:19 AM > To: Stillwell Jr, Paul M ; dev@dpdk.org; Zhang, > Qi Z ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down > functions > > > -Original Message- > > From: Stillw

[dpdk-dev] [PATCH v2 2/2] net/netvsc: free all queues on close

2019-04-30 Thread Stephen Hemminger
From: Stephen Hemminger When dev_close is called, the netvsc driver will clean up all queues including the primary ring buffer. Signed-off-by: Stephen Hemminger --- v2 - fix logic on close of primary avoid double free if close is called twice drivers/net/netvsc/hn_ethdev.c | 8 -- d

[dpdk-dev] [PATCH v2 1/2] net/netvsc: reset mbuf port on VF receive

2019-04-30 Thread Stephen Hemminger
From: Stephen Hemminger Redo the receive logic to set m->port on packets received on VF. When using VF, still need to check for packets and completions arriving on the VMBus path even if application is not doing bursting (ie n_rx == 0). Also, fix comment. Signed-off-by: Stephen Hemminger Fixe

[dpdk-dev] [PATCH v2 0/2] netvsc PMD fixes for 19.05

2019-04-30 Thread Stephen Hemminger
Netvsc needed to reset incoming port as was recently done for failsafe. Implement the new close semantics. Stephen Hemminger (2): net/netvsc: reset mbuf port on VF receive net/netvsc: free all queues on close drivers/net/netvsc/hn_ethdev.c | 8 ++- drivers/net/netvsc/hn_rxtx.c | 93 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/multi_process: fix buffer underrun

2019-04-30 Thread Yongseok Koh
> On Apr 11, 2019, at 12:18 AM, Yongseok Koh wrote: > >> On Apr 10, 2019, at 12:41 PM, Yongseok Koh wrote: >> >> For client_server_mp, the total number of buffers for the mbuf mempool >> should be correctly calculated. Otherwise, having more clients will stop >> traffic. >> >> Fixes: af75078

Re: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-04-30 Thread Wang, Haiyue
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Wednesday, May 1, 2019 00:24 > To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Lu, Wenzhuo > Cc: Wang, Haiyue > Subject: RE: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down > functions > > > > -Original Message

[dpdk-dev] [PATCH] app/compress-perf: add info about socket id used by app and by the driver

2019-04-30 Thread Trahe, Fiona
Added info about socket id used by compression perf test process and by the driver Signed-off-by: Tomasz Cel Signed-off-by: Fiona Trahe --- Target 19.08 release app/test-compress-perf/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-compress-perf/main.c b/app/test-compre

Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues

2019-04-30 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, April 30, 2019 3:14 PM > To: Jerin Jacob Kollanukkaran ; Gujjar, Abhinandan S > ; jerin.ja...@caviumnetworks.com; > dev@dpdk.org > Cc: Vangati, Narender > Subject: [EXT] RE: [dpdk-dev] [PATCH] eventdev: fix control flow issue

Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Burakov, Anatoly
On 30-Apr-19 12:25 PM, Suanming.Mou wrote: On 2019/4/30 17:42, Burakov, Anatoly wrote: On 30-Apr-19 12:35 PM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Suggested-by: Varghese, Vipin Sugge

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Burakov, Anatoly
On 30-Apr-19 11:37 AM, Varghese, Vipin wrote: snipped Thanks for the patch work with rte_eal_alaram. But I am not able to find 1. the documentation update. 2. cover letter. Why would a single patch need a cover letter? I don't think it's needed in this case. The commit message is enough. In

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-30 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Thursday, April 18, 2019 1:12 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila > Sahu ; sta...@dpdk.org > Subject: RE: [PATCH v2] doc/compress: cla

Re: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-04-30 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Haiyue Wang > Sent: Tuesday, April 30, 2019 12:12 AM > To: dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Cc: Wang, Haiyue > Subject: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions > > Support

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-04-30 Thread Lukas Bartosik
From: Ananyev, Konstantin Sent: Tuesday, April 30, 2019 5:05 PM To: Lukas Bartosik Cc: dev@dpdk.org; Anoob Joseph Subject: RE: [PATCH] ipsec: include high order bytes of esn in pkt len > -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@ma

Re: [dpdk-dev] rte_eth_tx_burst improperly freeing mbufs from KNI mbuf pool

2019-04-30 Thread Paras Jha
Sorry, I meant that "the mbufs will not be freed as the threshold for freeing seems to not be based on the pool the mbuf originated from, but based on the pool the PMD is configured to use" On Tue, Apr 30, 2019 at 11:37 AM Paras Jha wrote: > Hi, > > I think this issue seems to be due to how the

Re: [dpdk-dev] rte_eth_tx_burst improperly freeing mbufs from KNI mbuf pool

2019-04-30 Thread Paras Jha
Hi, I think this issue seems to be due to how the PMD frees mbufs. If the PMD is configured with pool X, and KNI configured with pool Y, and pool Y has far fewer mbufs available than pool X, when an application calls tx_burst on the PMD, the mbufs will not be freed as the threshold for freeing see

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

2019-04-30 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Wednesday, April 24, 2019 1:37 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes > > Add deprecation note for m

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: reset mbuf port on VF receive

2019-04-30 Thread Stephen Hemminger
On Mon, 29 Apr 2019 13:33:24 -0700 Stephen Hemminger wrote: > Redo the receive logic to set m->port on packets received on VF. > > When using VF, still need to check for packets and completions > arriving on the VMBus path even if application is not doing bursting > (ie n_rx == 0). > > Also, fi

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-04-30 Thread Ananyev, Konstantin
> -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@marvell.com] > Sent: Tuesday, April 30, 2019 3:56 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; ano...@marvell.com; Lukasz Bartosik > Subject: [PATCH] ipsec: include high order bytes of esn in pkt len > > When esn is us

Re: [dpdk-dev] rte_eth_tx_burst improperly freeing mbufs from KNI mbuf pool

2019-04-30 Thread Ferruh Yigit
On 4/10/2019 2:10 PM, Paras Jha wrote: > Hi all, > > I've been chasing down a strange issue related to rte_kni_tx_burst. > > My application calls rte_kni_rx_burst, which allocates from a discrete mbuf > pool using kni_allocate_mbufs. That traffic is immediately sent to > rte_eth_tx_burst which do

[dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

2019-04-30 Thread Lukasz Bartosik
When esn is used then high-order 32 bits are included in ICV calculation however are not transmitted. Update packet length to be consistent with auth data offset and length before crypto operation. High-order 32 bits of esn will be removed from packet length in crypto post processing. Change-Id: I

Re: [dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux

2019-04-30 Thread David Marchand
On Tue, Apr 30, 2019 at 4:04 PM Bruce Richardson wrote: > Small cleanups to shorten the meson.build file in the kernel/linux > directory, removing the unneeded version check and taking advantage of the > subdir_done() function introduced in meson 0.46. > > These should be fairly harmless, but giv

Re: [dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary meson version check

2019-04-30 Thread Bruce Richardson
On Tue, Apr 30, 2019 at 03:03:23PM +0100, Bruce Richardson wrote: > The check for meson version 0.44 is not redundant since the minimum "not", in this case, being used as a synonym for "now" :-) > supported version for the project as a whole is 0.47. > > Signed-off-by: Bruce Richardson > --- >

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2019-04-30 Thread Thomas Monjalon
30/04/2019 14:45, Nithin Dabilpuram: > On Mon, Apr 29, 2019 at 10:30:00PM +0200, Thomas Monjalon wrote: > > 29/04/2019 18:51, Ferruh Yigit: > > > I would like to detail a little more what needs to be done, mainly for > > > the sake > > > of the discussion, please comment if something missing/wrong

[dpdk-dev] [PATCH 19.08 2/3] kernel/linux: reduce unneeded indents in meson build file

2019-04-30 Thread Bruce Richardson
Since meson 0.46, meson has supported the subdir_done() function, which allows us to abort processing of a file early. Using this we can reduce the indentation in our files by eliminating unnecessary else blocks. Signed-off-by: Bruce Richardson --- Note: though the diff here seems fairly big, a l

[dpdk-dev] [PATCH 19.08 3/3] kernel/linux: remove unneeded local variables

2019-04-30 Thread Bruce Richardson
The local variables for the error message aren't needed, since the messages aren't used more than once, and the indent levels are now such that the lines printing the message are not much longer than the lines defining the variables to hold the messages themselves. Therefore the use of the variable

[dpdk-dev] [PATCH 19.08 1/3] kernel/linux: remove unnecessary meson version check

2019-04-30 Thread Bruce Richardson
The check for meson version 0.44 is not redundant since the minimum supported version for the project as a whole is 0.47. Signed-off-by: Bruce Richardson --- kernel/linux/meson.build | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/linux/meson.build b/kernel/linux

[dpdk-dev] [PATCH 19.08 0/3] cleanup kernel meson.build file for linux

2019-04-30 Thread Bruce Richardson
Small cleanups to shorten the meson.build file in the kernel/linux directory, removing the unneeded version check and taking advantage of the subdir_done() function introduced in meson 0.46. These should be fairly harmless, but given the stage of development we are at for 19.05, targetting them to

Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple

2019-04-30 Thread Akhil Goyal
> NULL cipher algo of 4-byte multiple and other sizes caused firmware hang > due to use of wrong mode. Changed from ECB mode to CTR mode to fix. > > Fixes: 98f060891615 ("crypto/qat: add symmetric session file") > cc: sta...@dpdk.org > > Signed-off-by: Fiona Trahe > --- Applied to dpdk-next-c

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-04-30 Thread Akhil Goyal
Hi Anoob, > > Hi Akhil, > > This is a fix and I would like this to be part of 19.05 release. Hope you can > apply > this before RC4. > > Thanks, > Anoob Ok will take this patch. And Sorry for a typo, Actually it is RC3 and not RC4. One more thing, is this patch applicable for backport to st

Re: [dpdk-dev] [EXT] [PATCH 1/3] acl: fix arm argument types

2019-04-30 Thread Aaron Conole
Aaron Conole writes: > Jerin Jacob Kollanukkaran writes: > >> On Wed, 2019-04-10 at 11:52 -0400, Aaron Conole wrote: >>> Jerin Jacob Kollanukkaran writes: >>> >>> > On Mon, 2019-04-08 at 14:24 -0400, Aaron Conole wrote: >>> > > --- >>

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2019-04-30 Thread Nithin Dabilpuram
On Mon, Apr 29, 2019 at 10:30:00PM +0200, Thomas Monjalon wrote: > 29/04/2019 18:51, Ferruh Yigit: > > On 4/18/2019 11:59 AM, Thomas Monjalon wrote: > > > Hi all, > > > > > > Since DPDK 18.11, the behaviour of the close operation is changed > > > if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the drive

Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou > Sent: Tuesday, April 30, 2019 12:35 PM > To: dev@dpdk.org > Cc: Varghese, Vipin ; Burakov, Anatoly > > Subject: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary > support. > > When p

Re: [dpdk-dev] [PATCH v2 1/2] doc: fix spelling errors reported by aspell

2019-04-30 Thread Mcnamara, John
> If it agreed that change to CollectD should be reverted, not sure that a new > V3 should be sent, this is a huge patch; if reverting can be done via merge, > it will be better. Agreed. Also the following change is incorrect: -uin8t_t priority = RTE_EVENT_DEV_PRIORITY_NORM

Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Suanming . Mou
On 2019/4/30 17:42, Burakov, Anatoly wrote: On 30-Apr-19 12:35 PM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Suggested-by: Varghese, Vipin Suggested-by: Burakov, Anatoly Signed-off-by: S

Re: [dpdk-dev] [PATCH] net/bonding: fix test bonding MAC assignment

2019-04-30 Thread Ferruh Yigit
On 4/29/2019 5:45 PM, Chas Williams wrote: > Seems fine. > > Acked-by: Chas Williams Applied to dpdk-next-net/master, thanks. > > On 4/29/19 10:56 AM, Ferruh Yigit wrote: >> On 4/26/2019 11:30 PM, kka...@marvell.com wrote: >>> From: Krzysztof Kanas >>> >>> Fix test_set_bonded_port_initializat

Re: [dpdk-dev] [PATCH v2] doc: update references to removed function

2019-04-30 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Erik Gabriel Carrillo > Sent: Monday, April 29, 2019 3:38 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: update references to removed function >

Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity

2019-04-30 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yipeng Wang > Sent: Monday, April 29, 2019 10:40 AM > To: Wang, Yipeng1 ; De Lara Guarch, Pablo > ; gentoor...@gmail.com; Burakov, Anatoly > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix rte_hash_has

Re: [dpdk-dev] [PATCH v3] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Ferruh Yigit
On 4/30/2019 9:39 AM, Xiaolong Ye wrote: > Since 18.11, it is suggested that driver should release all its private > resources at the dev_close routine. So all resources previously released > in remove routine are now released at the dev_close routine, and the > dev_close routine will be called in

Re: [dpdk-dev] [Bug 262] Error: Invalid memory for eth_virtio_dev_init()

2019-04-30 Thread David Marchand
On Tue, Apr 30, 2019 at 12:49 PM wrote: > https://bugs.dpdk.org/show_bug.cgi?id=262 > > Bug ID: 262 >Summary: Error: Invalid memory for eth_virtio_dev_init() >Product: DPDK >Version: 18.11 > Hardware: x86 > OS: Linux >

Re: [dpdk-dev] [PATCH v8 1/4] rcu: add RCU library supporting QSBR mechanism

2019-04-30 Thread Hemant Agrawal
> -Original Message- > Subject: Re: [dpdk-dev] [PATCH v8 1/4] rcu: add RCU library supporting QSBR > mechanism > Importance: High > > > Compiled DPDK as both static library and shared library. > > Ran UT on ARMv8 LS2088a DPAA2 platform, 3 to 8 cores were used, tests > passed. > > > > Teste

[dpdk-dev] [Bug 262] Error: Invalid memory for eth_virtio_dev_init()

2019-04-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=262 Bug ID: 262 Summary: Error: Invalid memory for eth_virtio_dev_init() Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-30 Thread Ferruh Yigit
On 4/29/2019 3:02 PM, Burakov, Anatoly wrote: > On 29-Apr-19 2:53 PM, Ferruh Yigit wrote: >> On 4/25/2019 6:17 PM, Herakliusz Lipiec wrote: >>> When secondary to primary process synchronization occours >>> there is no check for number of fds which could cause buffer overrun. >>> >>> Bugzilla ID: 25

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Varghese, Vipin
snipped > > Thanks for the patch work with rte_eal_alaram. But I am not able to > > find > > > > 1. the documentation update. > > 2. cover letter. > > Why would a single patch need a cover letter? I don't think it's needed in > this > case. The commit message is enough. In my opinion, the cover

Re: [dpdk-dev] [PATCH] test: clean remaining trace of removed devargs ut

2019-04-30 Thread Gaëtan Rivet
Hello David, On Mon, Apr 29, 2019 at 04:32:45PM +0200, David Marchand wrote: > This test has been removed by the commit 83945fbd7c49 ("test: remove > devargs unit tests") which left some trace in meson and reintroduced in > autotest by the second commit 9eabcb682493 ("test: update autotest > list"

Re: [dpdk-dev] [PATCH] test/crypto: added NULL algo tests to loop test mechanism

2019-04-30 Thread Trahe, Fiona
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, April 30, 2019 8:20 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: tho...@monjalon.net; Kusztal, ArkadiuszX ; > Iremonger, Bernard > ; ano...@marvell.com > Subject: RE: [PATCH] test/crypto: added

Re: [dpdk-dev] [PATCH] eventdev: fix control flow issues

2019-04-30 Thread Mcnamara, John
> > Coverity issue: 279439 Dereference null return value Coverity issue: > > 279446 Logically dead code Coverity issue: 279450 Logically dead code > Coverity issue: > > 279462 Logically dead code > > Fixes: 7901eac3409 ("eventdev: add crypto adapter implementation") > > Cc: sta...@dpdk.org > > >

Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Burakov, Anatoly
On 30-Apr-19 12:35 PM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Suggested-by: Varghese, Vipin Suggested-by: Burakov, Anatoly Signed-off-by: Suanming.Mou --- static void +disable_pr

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Burakov, Anatoly
On 30-Apr-19 3:33 AM, Varghese, Vipin wrote: Thanks for the patch work with rte_eal_alaram. But I am not able to find 1. the documentation update. 2. cover letter. Why would a single patch need a cover letter? I don't think it's needed in this case. The commit message is enough. 3. for sig

[dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support.

2019-04-30 Thread Suanming . Mou
When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Suggested-by: Varghese, Vipin Suggested-by: Burakov, Anatoly Signed-off-by: Suanming.Mou --- app/pdump/main.c | 43 ++- 1 file

[dpdk-dev] [PATCH v5] Make pdump exits with primary.

2019-04-30 Thread Suanming . Mou
When primary exits, pdump as the sencondary keeps running will make primary fail to restart. Add the primary monitor in pdump to make it eixts with primary. Note: One more thing still not confirmed is that if it can be set default. In the V5 patch, it is still set as default. Since it seems there

Re: [dpdk-dev] Hugepages not being deleted

2019-04-30 Thread Burakov, Anatoly
On 23-Apr-19 4:15 PM, Michael Santana Francisco wrote: Hello, I am currently working on a patch to fix the eal_flags_autotest test as it currently fails on many platforms. I have made some progress, however I stumbled upon a possible issue with EAL and hugepages. Looking at the code and some d

[dpdk-dev] [Bug 261] DPDK 18.11 bug on rte_hash_free_key_with_position

2019-04-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=261 Bug ID: 261 Summary: DPDK 18.11 bug on rte_hash_free_key_with_position Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal

Re: [dpdk-dev] ABI and inline functions

2019-04-30 Thread Thomas Monjalon
24/04/2019 14:22, Ray Kinsella: > On 24/04/2019 12:08, Burakov, Anatoly wrote: > > To me, part of the problem is that DPDK is an "everything and the > > kitchen sink" kind of library where there is a bunch of drivers, a whole > > quasi-OS layer of dealing with hardware in a cross-platform manner, a

[dpdk-dev] [PATCH v3] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Xiaolong Ye
Since 18.11, it is suggested that driver should release all its private resources at the dev_close routine. So all resources previously released in remove routine are now released at the dev_close routine, and the dev_close routine will be called in driver remove routine in order to support removin

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Ye Xiaolong
On 04/30, Ferruh Yigit wrote: >On 4/30/2019 3:06 AM, Ye Xiaolong wrote: >> Hi, Ferruh >> >> On 04/29, Ferruh Yigit wrote: >>> On 4/26/2019 6:09 AM, Xiaolong Ye wrote: Since 18.11, it is suggested that driver should release all its private resources at the dev_close routine. So all resour

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-04-30 Thread Anoob Joseph
Hi Akhil, This is a fix and I would like this to be part of 19.05 release. Hope you can apply this before RC4. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, April 30, 2019 12:33 PM > To: Anoob Joseph ; Pablo de Lara > > Cc: Jerin Jacob Kollanukkaran ; Narayan

Re: [dpdk-dev] [PATCH v3] vhost: support inflight share memory protocol feature

2019-04-30 Thread lin li
Tiwei Bie 于2019年4月29日周一 下午6:55写道: > > On Mon, Apr 29, 2019 at 12:07:05PM +0800, lin li wrote: > > Tiwei Bie 于2019年4月28日周日 下午7:18写道: > > > On Fri, Apr 26, 2019 at 05:40:21AM -0400, Li Lin wrote: > [...] > > > > @@ -98,12 +102,26 @@ struct rte_vhost_memory { > > > > struct rte_vhost_mem_regio

Re: [dpdk-dev] [PATCH 2/2] net/netvsc: free all queues on close

2019-04-30 Thread Ferruh Yigit
On 4/29/2019 9:33 PM, Stephen Hemminger wrote: > When dev_close is called, the netvsc driver will clean up all > queues including the primary ring buffer. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/netvsc/hn_ethdev.c | 8 +-- > drivers/net/netvsc/hn_rxtx.c | 39 +

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Ferruh Yigit
On 4/30/2019 8:55 AM, Thomas Monjalon wrote: > 30/04/2019 09:33, Ferruh Yigit: >> On 4/29/2019 11:34 PM, Thomas Monjalon wrote: >>> 30/04/2019 00:28, Ferruh Yigit: On 4/29/2019 9:14 PM, Thomas Monjalon wrote: > 29/04/2019 19:00, Ferruh Yigit: >> On 4/26/2019 6:09 AM, Xiaolong Ye wrote:

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: reset mbuf port on VF receive

2019-04-30 Thread Ferruh Yigit
On 4/29/2019 9:33 PM, Stephen Hemminger wrote: > Redo the receive logic to set m->port on packets received on VF. > > When using VF, still need to check for packets and completions > arriving on the VMBus path even if application is not doing bursting > (ie n_rx == 0). > > Also, fix comment. > >

Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-30 Thread Thomas Monjalon
30/04/2019 06:20, Honnappa Nagarahalli: > > > > Please, could you check details like alignment or alphabetical sorting? > I don't see any alignment issues (there is mixed use of tabs and spaces in > this file, will use the same). > > > Thanks > > > > 26/04/2019 06:39, Honnappa Nagarahalli: > >

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Thomas Monjalon
30/04/2019 09:33, Ferruh Yigit: > On 4/29/2019 11:34 PM, Thomas Monjalon wrote: > > 30/04/2019 00:28, Ferruh Yigit: > >> On 4/29/2019 9:14 PM, Thomas Monjalon wrote: > >>> 29/04/2019 19:00, Ferruh Yigit: > On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > > Since 18.11, it is suggested that drive

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Ferruh Yigit
On 4/30/2019 3:06 AM, Ye Xiaolong wrote: > Hi, Ferruh > > On 04/29, Ferruh Yigit wrote: >> On 4/26/2019 6:09 AM, Xiaolong Ye wrote: >>> Since 18.11, it is suggested that driver should release all its private >>> resources at the dev_close routine. So all resources previously released >>> in remove

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-30 Thread Ferruh Yigit
On 4/29/2019 11:34 PM, Thomas Monjalon wrote: > 30/04/2019 00:28, Ferruh Yigit: >> On 4/29/2019 9:14 PM, Thomas Monjalon wrote: >>> 29/04/2019 19:00, Ferruh Yigit: On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > Since 18.11, it is suggested that driver should release all its private > resou

Re: [dpdk-dev] [PATCH] test/crypto: added NULL algo tests to loop test mechanism

2019-04-30 Thread Akhil Goyal
Hi Fiona, I believe this patch is for 19.08, we normally do not accept such changes in RC4. Also the patch http://patches.dpdk.org/patch/53117/ looks to be meaningful if this patch is accepted. Do you want we to apply the fix in driver in this release and add the test cases in the next release

Re: [dpdk-dev] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-04-30 Thread Shally Verma
> -Original Message- > From: Anoob Joseph > Sent: Thursday, April 18, 2019 10:50 AM > To: Akhil Goyal ; Pablo de Lara > > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Shally Verma ; > dev@dpdk.org > Subject: [PATCH v2] crypto/octeontx: use distinct

[dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-04-30 Thread Haiyue Wang
Support link up and down functions for ice, and when stop the ice, makes the link down also. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 83 1 file changed, 83 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ic

Re: [dpdk-dev] [PATCH] doc: add description to release note

2019-04-30 Thread Akhil Goyal
Hi Tomasz, > > > Added description about compression QAT PMD improvement > > Signed-off-by: Tomasz Jozwiak > --- > doc/guides/rel_notes/release_19_05.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/release_19_05.rst > b/doc/guides/rel_notes/release_19_05.

Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

2019-04-30 Thread Akhil Goyal
Hi Anoob, I believe this patch is for 19.08 release. This patch is not acked and we are about to close the RC4. -Akhil > > > The metabuf pool is shared across all queue pairs belonging to the > PMD. In order to prevent one queue pair from starving another, > use a distinct mempool for each qu