30/04/2019 06:20, Honnappa Nagarahalli:
> >
> > Please, could you check details like alignment or alphabetical sorting?
> I don't see any alignment issues (there is mixed use of tabs and spaces in
> this file, will use the same).
>
> > Thanks
> >
> > 26/04/2019 06:39, Honnappa Nagarahalli:
> > > --- a/app/test/meson.build
> > > +++ b/app/test/meson.build
> > > @@ -111,6 +111,8 @@ test_sources = files('commands.c',
> > > 'test_timer_racecond.c',
> > > 'test_timer_secondary.c',
> > > 'test_ticketlock.c',
> > > + 'test_rcu_qsbr.c',
> > > + 'test_rcu_qsbr_perf.c',
> > > 'test_version.c',
> > > 'virtual_pmd.c'
> > > )
> > > @@ -137,7 +139,8 @@ test_deps = ['acl',
> > > 'reorder',
> > > 'ring',
> > > 'stack',
> > > - 'timer'
> > > + 'timer',
> > > + 'rcu'
> > > ]
> > >
> > > # All test cases in fast_parallel_test_names list are parallel @@
> > > -176,6 +179,7 @@ fast_parallel_test_names = [
> > > 'ring_autotest',
> > > 'ring_pmd_autotest',
> > > 'rwlock_autotest',
> > > + 'rcu_qsbr_autotest',
> > > 'sched_autotest',
> > > 'spinlock_autotest',
> > > 'stack_autotest',
> > > @@ -243,6 +247,7 @@ perf_test_names = [
> This list is not sorted, is it on purpose? If yes, are we supposed to be
> adding at the end of the list?
It looks mostly sorted.
I think you should insert rcu before red.
> > > 'red_perf',
> > > 'distributor_perf_autotest',
> > > 'ring_pmd_perf_autotest',
> > > + 'rcu_qsbr_perf_autotest',
> > > 'pmd_perf_autotest',
> > > 'stack_perf_autotest',
> > > 'stack_nb_perf_autotest',
