On 30-Apr-19 11:37 AM, Varghese, Vipin wrote:
snipped
Thanks for the patch work with rte_eal_alaram. But I am not able to
find
1. the documentation update.
2. cover letter.
Why would a single patch need a cover letter? I don't think it's needed in this
case. The commit message is enough.
In my opinion, the cover letter is to be added as it is new feature and
explains the reasoning behind the new change. Please let me know if there
change in the same?
snipped
I'm obviously not an expert in cover letters, but in my view, cover
letter is only necessary whenever there is a complex patchset that
requires some explanation, background, etc. If there is only one patch,
everything that you could reasonably put in the cover letter should go
either into the commit message itself, or into commit notes if there is
some supplemental data (e.g. benchmark results etc.). Creating cover
letters for single patches is just unnecessary work IMO.
--
Thanks,
Anatoly
