[dpdk-dev] [PATCH] doc: fix interactive commands in testpmd guide

2019-04-15 Thread Agalya Babu RadhaKrishnan
From: Agalya Babu RadhaKrishnan Added some missing documentation for interactive mode commands Fixes: 01b2092a5e ("testpmd: add dump commands for debug") Fixes: caf05a1b86 ("app/testpmd: new command to dump log types") Signed-off-by: Agalya Babu RadhaKrishnan --- doc/guides/testpmd_app_ug/tes

Re: [dpdk-dev] [EXT] [PATCH 0/6] build: fix build for arm64

2019-04-15 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, April 16, 2019 2:26 AM > To: Jerin Jacob Kollanukkaran > Cc: bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula > ; Shahaf Shuler ; > dev@dpdk.org; Thomas Monjalon ; > gavin...@arm.com; honnappa.nagaraha...@arm.com > Subje

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor

2019-04-15 Thread Shahaf Shuler
Monday, April 15, 2019 12:12 PM, Slava Ovsiienko: > Subject: RE: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF > representor > > Hi, Shahaf > > > -Original Message- > > From: Shahaf Shuler > > Sent: Sunday, April 14, 2019 10:43 > > To: Slava Ovsiienko ; dev@dpdk.org > > Subject: RE:

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > wrote: > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based memory > > > > > > > > reclamation > > > > > > > method. > > > > > > > > This library helps identify the quiescent state of the

Re: [dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure

2019-04-15 Thread Tiwei Bie
On Mon, Apr 15, 2019 at 10:48:18AM -0400, Aaron Conole wrote: > When eth_virtio_dev_init() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to a double free. > > Found during unit-test fixes. > > Fixes: 43d18765c027 ("net/virtio: fix memory leak on failu

Re: [dpdk-dev] [PATCH v5 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > Just to let you know - observed some failures with it for meson. > Fixed it locally by: > > diff --git a/app/test/meson.build b/app/test/meson.build index > 1a2ee18a5..e3e566bce 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -138,7 +138,7 @@ test_deps = ['acl', >

[dpdk-dev] [PATCH v3] kni: add IOVA va support for kni

2019-04-15 Thread kirankumark
From: Kiran Kumar K With current KNI implementation kernel module will work only in IOVA=PA mode. This patch will add support for kernel module to work with IOVA=VA mode. The idea is to get the physical address from iova address using api iommu_iova_to_phys. Using this API, we will get the physi

Re: [dpdk-dev] [PATCH] doc: update ICE doc

2019-04-15 Thread Lu, Wenzhuo
Hi Rami, From: Rami Rosen [mailto:ramir...@gmail.com] Sent: Tuesday, April 16, 2019 5:55 AM To: Lu, Wenzhuo Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc Hi, In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html, MDD does not appear. [Wenzhuo] As I know, this

[dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-04-15 Thread ogawa . yasufumi
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized secondary has PID 1. To reserve unique name, use hostn

[dpdk-dev] [PATCH v2 0/1] Get fbarrays from containerized secondary

2019-04-15 Thread ogawa . yasufumi
From: Yasufumi Ogawa Fix spell miss in commit message. Yasufumi Ogawa (1): fbarray: get fbarrays from containerized secondary lib/librte_eal/linux/eal/eal_memalloc.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) -- 2.17.1

[dpdk-dev] [PATCH v9 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-04-15 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. Signed-off-by: Rosen Xu Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/Makefile | 1 + drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 244 +++- drivers/raw/ifpga_r

[dpdk-dev] [PATCH v9 13/14] raw/ifpga_rawdev: using prefix name for feature and its ops

2019-04-15 Thread Rosen Xu
From: Tianfei zhang Using prefix name "ifpga_" for feature and feature_ops data struct on ifpga base code, which is suggested by Yigit, Ferruh. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c | 8 +-- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c | 4 +-

[dpdk-dev] [PATCH v9 12/14] raw/ifpga_rawdev: add version description on README

2019-04-15 Thread Rosen Xu
From: Tianfei zhang add verion description on READ about ifpga base code. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/README | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/raw/ifpga_rawdev/base/README b/drivers/raw/ifpga_rawdev/base/README inde

[dpdk-dev] [PATCH v9 09/14] raw/ifpga_rawdev: add SPI and MAX10 device driver

2019-04-15 Thread Rosen Xu
From: Tianfei zhang There is a SPI bus link between A10 FPGA and MAX10 FPGA. MAX10 is in charge of board management, like power management, sensors, flash devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile | 3 + drivers/raw/ifpga_rawdev/base/ifpga_d

[dpdk-dev] [PATCH v9 10/14] raw/ifpga_rawdev: add I2C and at24 EEPROM driver

2019-04-15 Thread Rosen Xu
From: Tianfei zhang 1. Add Altera I2C master device driver 2. Add at24 eeprom driver which is i2c slave device 3. Introducing a new ops for opae_manager: opae_manager_networking_ops. This ops will include some networking operation by FPGA, like vBNG operation, MAC ROM operation and so on. Signed

[dpdk-dev] [PATCH v9 11/14] raw/ifpga_rawdev: add eth group driver

2019-04-15 Thread Rosen Xu
From: Tianfei zhang There is two eth group devices in PAC N3000 card, each eth group include PHY device and MAC device. Exposing APIs for DPDK PMD driver to access those devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile| 1 + drivers/raw/ifpga_rawde

[dpdk-dev] [PATCH v9 08/14] raw/ifpga_rawdev: store private features in FME and Port

2019-04-15 Thread Rosen Xu
From: Tianfei zhang Get private features attrubite like size, id, address after enumeration, and insert into FEM or Port dedicate list. when initial the private feature driver, we just compare the private feature id between the list and feature drivers array to match the proper drivers. This pa

[dpdk-dev] [PATCH v9 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-15 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- MAINTAINERS | 7 + config/common_base| 4 + doc/guides/nics/features/ipn3ke.ini | 55

[dpdk-dev] [PATCH v9 07/14] raw/ifpga_rawdev: clean up code for ifpga share code

2019-04-15 Thread Rosen Xu
From: Tianfei zhang clean up code: 1. use opae_memcpy instead of memcpy 2. use opae_memset instead of memset 3. disable opae_adapter_dump by default Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 2 +- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev

[dpdk-dev] [PATCH v9 06/14] net/ipn3ke: add IPN3KE Flow of PMD driver

2019-04-15 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE Flow of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |5 + drivers/net/ipn3ke/ipn3ke_ethdev.h |1 + drivers/ne

[dpdk-dev] [PATCH v9 04/14] net/ipn3ke: add IPN3KE representor of PMD driver

2019-04-15 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE representor of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile | 2 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 4 +- drivers/net/ipn3ke/ipn3ke_ethdev.h | 25 + drive

[dpdk-dev] [PATCH v9 05/14] net/ipn3ke: add IPN3KE TM of PMD driver

2019-04-15 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE TM of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |3 + drivers/net/ipn3ke/ipn3ke_ethdev.h |7 + drivers/net/

[dpdk-dev] [PATCH v9 02/14] bus/ifpga: add function for AFU search by name

2019-04-15 Thread Rosen Xu
In many scenarios, AFU is needed searched by name, this function add the feature. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/ifpga_bus.c | 13 + drivers/bus/ifpga/rte_bus_ifpga.h | 9 + drivers/bus/ifpga/rte_bus_ifpga_versi

[dpdk-dev] [PATCH v9 00/14] Add patch set for IPN3KE

2019-04-15 Thread Rosen Xu
v9 updates: = - Fix v8 comments - 02/14 patch check error, just follow Ferruh's v8 comments v8 updates: = - Fix meter color definition replacement v7 updates: = - Fix Stephen comments v6 updates: == - Fix v5 comments - Fix TM Shaper rate issue v5 updates: =

[dpdk-dev] [PATCH v9 01/14] bus/ifpga: add AFU shared data

2019-04-15 Thread Rosen Xu
AFU can be implemented into many different acceleration devices, these devices need shared data to store private information when they are handled by users. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/rte_bus_ifpga.h | 7 +++ 1 file changed, 7 insertions(+) diff -

Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

2019-04-15 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 15, 2019 20:28 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia ; > Thomas Monjalon > Subject: Re: [P

Re: [dpdk-dev] [PATCH] net/i40e: fix crash when calling i40e_vsi_delete_mac

2019-04-15 Thread wangyunjian
> > That is not specific to i40e or macvlan filter. > If inside your app several threads concurrently access/modify NIC config, > then you need to provide some synchronization mechanism for them. > DPDK ethdev API (as most others) on itself doesn't provide any > synchronization, leaving it up to t

[dpdk-dev] [PATCH] fbarray: get fbarrays from containerized secondary

2019-04-15 Thread ogawa . yasufumi
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work as expected if secondary is run as app container becuase each of containerized secondary has PID 1. To reserve unique nam

Re: [dpdk-dev] [PATCH] devtools: add git log checks for TPID, LACP and RETA

2019-04-15 Thread Thomas Monjalon
08/04/2019 18:37, Ferruh Yigit: > Add case check to TPID, LACP and RETA abbreviations. > > Signed-off-by: Ferruh Yigit > --- > -e ':.*\' \ > -e ':.*\' \ > + -e ':.*\' \ > -e ':.*\' \ Applied with alphabetical order fixed, thanks

Re: [dpdk-dev] [PATCH] devtools: accept experimental symbol promotion

2019-04-15 Thread Thomas Monjalon
05/04/2019 13:22, Neil Horman: > On Fri, Apr 05, 2019 at 10:17:47AM +0200, David Marchand wrote: > > Currently, when symbols get promoted from the EXPERIMENTAL section to a > > stable ABI section, the script complains they should go to the > > EXPERIMENTAL section. > > > > Example: > > ERROR: symb

Re: [dpdk-dev] [PATCH] doc: update ICE doc

2019-04-15 Thread Rami Rosen
Hi, In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html, MDD does not appear. In IXGBE DPDK nic guide, https://doc.dpdk.org/guides/nics/ixgbe.html, MDD appears, but in the known issues section. I think MDD is supported on both. just wonder, for the sake of consistency, is it wort

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-04-15 Thread Carrillo, Erik G
Hi Robert, I'm back in the office now; I just submitted an updated patch series to address some of the points you made below. I'll add responses in-line: > -Original Message- > From: Sanford, Robert [mailto:rsanf...@akamai.com] > Sent: Wednesday, March 20, 2019 8:53 AM > To: Carrillo,

[dpdk-dev] [PATCH v5 2/2] timer: add function to stop all timers in a list

2019-04-15 Thread Erik Gabriel Carrillo
Add a function to the timer API that allows a caller to traverse a specified set of timer lists, stopping each timer in each list, and invoking a callback function. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 38 ++ lib/librte

[dpdk-dev] [PATCH v5 1/2] timer: allow timer management in shared memory

2019-04-15 Thread Erik Gabriel Carrillo
Currently, the timer library uses a per-process table of structures to manage skiplists of timers presumably because timers contain arbitrary function pointers whose value may not resolve properly in other processes. However, if the same callback is used handle all timers, and that callback is onl

[dpdk-dev] [PATCH v5 0/2] Timer library changes

2019-04-15 Thread Erik Gabriel Carrillo
This patch series modifies the timer library in such a way that structures that used to be statically allocated in a process's data segment are now allocated in shared memory. As these structures contain lists of timers, new APIs are introduced that allow a caller to specify the particular structu

Re: [dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode

2019-04-15 Thread Rami Rosen
Wang Ying A ‏: > When device promiscuous mode has already been enabled, > if user re-enables the promisc mode, he/she should be > prompted with "Promisc has already been enabled" > rather than "Failed to enable promisc". > > Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") > Cc: sta...@dp

Re: [dpdk-dev] 17.11.6-rc1 patches review and test

2019-04-15 Thread Yongseok Koh
> On Mar 27, 2019, at 3:05 PM, Yongseok Koh wrote: > > Hi all, > > Here is a list of patches targeted for LTS release 17.11.6. Please help review > and test. The planned date for the final release is April 8, Before that, > please > shout if anyone has objection with these patches being appli

Re: [dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-15 Thread Rami Rosen
>Using a local (pointer) variable for dev->data->dev_conf.rxmode.offloads >would make the code more readable and lines shorter. +1

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 17:39:07 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, April 15, 2019 4:39 PM > > To: Ananyev, Konstantin > > Cc: Honnappa Nagarahalli ; > > paul...@linux.ibm.com; Kovacevic

Re: [dpdk-dev] [PATCH v10 1/4] mk: introduce helper to check valid compiler argument

2019-04-15 Thread Thomas Monjalon
13/04/2019 22:19, jer...@marvell.com: > Change history of this series: > > v10 Changes: > - Fix the following checkpatch warning > http://mails.dpdk.org/archives/test-report/2019-April/080453.html > > v9 Changes: > - Remove compiler version check as it is now done using >cc.has_argument(). >

Re: [dpdk-dev] [EXT] [PATCH 0/6] build: fix build for arm64

2019-04-15 Thread Yongseok Koh
> On Apr 13, 2019, at 12:12 AM, Jerin Jacob Kollanukkaran > wrote: > > Other than 1/1, I don't think, this patches series fixing any build for arm64. That's one of reasons for the title. > It is adding features required for Mellanox BlueField support. Hard to agree. > Please change subject

Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-15 Thread Honnappa Nagarahalli
> > > >> > > --- > - > -- Per the email discussion [1], the default cache line size of > armv8 > cortex-a72 is changed to 64 bytes. > >>> > >>> IMO, In git commit you remove the reference to specific discu

Re: [dpdk-dev] [RFC 08/12] hash: add support for s390x architecture

2019-04-15 Thread Dharmik Thakkar
Hi, Please find the inline comment. > On Apr 9, 2019, at 2:06 PM, Vivian Kong wrote: > > Add big endian support for s390x architecture. > > Signed-off-by: Vivian Kong > --- > lib/librte_hash/rte_fbk_hash.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/librte_hash/rte_fbk_

Re: [dpdk-dev] [PATCH v1] test/ticketlock: implement ticketlock autotest

2019-04-15 Thread Thomas Monjalon
> > Add ticketlock_autotest implementation in python. > > > > Fixes: efbcdaa55b93 ("test/ticketlock: add test cases") > > > > Signed-off-by: Joyce Kong > Reviewed-by: Phil Yang > Tested-by: Phil Yang Applied, thanks

Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-15 Thread Yongseok Koh
> On Apr 15, 2019, at 6:40 AM, Honnappa Nagarahalli > wrote: > >> -- Per the email discussion [1], the default cache line size of armv8 cortex-a72 is changed to 64 bytes. >>> >>> IMO, In git commit

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-04-15 Thread Honnappa Nagarahalli
> >> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto > >> extension > >> > >> CONFIG_RTE_MACHINE="armv8a" > >> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y > > > > This approach is not scalable. Even, it is not good for BlueField as > > you you need to maintain two images. > > > > Unlike other C

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-15 Thread Yongseok Koh
> On Apr 15, 2019, at 2:19 AM, Bruce Richardson > wrote: > > On Fri, Apr 12, 2019 at 04:24:48PM -0700, Yongseok Koh wrote: >> If MLNX_OFED is installed, there's no .pc file installed for libraries and >> dependency() can't find libraries by pkg-config. By adding fallback of >> using cc.find_li

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-15 Thread Yongseok Koh
Hi, Thanks, Yongseok > On Apr 15, 2019, at 3:12 AM, Luca Boccassi wrote: > > On Fri, 2019-04-12 at 16:24 -0700, Yongseok Koh wrote: >> If MLNX_OFED is installed, there's no .pc file installed for >> libraries and >> dependency() can't find libraries by pkg-config. By adding fallback >> of >

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > > > > > On Wed, Apr 10, 2019 at 06:20:04AM -0500, Honnappa Nagarahalli > > > wrote: > > > > > > Add RCU library supporting quiescent state based memory > > > > > > reclamation > > > > > method. > > > > > > This library helps identify the quiescent state of the reader > > > > > > thre

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > > > > > > After evaluating long term API/ABI issues, I think you need to > > > > > > get rid of almost all use of inline and visible structures. > > > > > > Yes it might be marginally slower, but you thank me the first time > you have to fix something. > > > > > > > > > > > Agree, I w

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-04-15 Thread Yongseok Koh
> On Apr 13, 2019, at 12:22 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Yongseok Koh >> Sent: Saturday, April 13, 2019 4:55 AM >> To: bruce.richard...@intel.com; Jerin Jacob Kollanukkaran >> ; Pavan Nikhilesh Bhagavatula >> ; shah...@mellanox.com >> Cc: dev

Re: [dpdk-dev] [EXT] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64

2019-04-15 Thread Yongseok Koh
> On Apr 12, 2019, at 10:52 PM, Pavan Nikhilesh Bhagavatula > wrote: > > Hi Yongseok, > >> -- >> Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler >> error" >> for aarch64 >> >> Fixes: bd77f2d64c44

Re: [dpdk-dev] [PATCH v2 3/3] cryptodev: fix uninitialized session clear

2019-04-15 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Monday, April 15, 2019 4:05 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Zhao, XinfengX > ; > akhil.go...@nxp.com; Kovacevic, Marko ; Zhang, Roy > Fan > ; sta...@dpdk.org > Subject: [dpd

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, April 15, 2019 4:39 PM > To: Ananyev, Konstantin > Cc: Honnappa Nagarahalli ; > paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org; Gavin Hu (Arm Technology China) > ; Dharmik Thak

Re: [dpdk-dev] [PATCH v5 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
Hi quys, > -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, April 12, 2019 9:21 PM > To: Ananyev, Konstantin ; > step...@networkplumber.org; paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; ga

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
> > > > > > > > On Wed, Apr 10, 2019 at 06:20:04AM -0500, Honnappa Nagarahalli > > wrote: > > > > > Add RCU library supporting quiescent state based memory > > > > > reclamation > > > > method. > > > > > This library helps identify the quiescent state of the reader > > > > > threads so that the w

Re: [dpdk-dev] [PATCH] examples/vm_power: add conditional compilation for PMD specific code

2019-04-15 Thread Kevin Traynor
On 02/04/2019 19:14, David Christensen wrote: I think it should have Fixes: and probably stable tags. > Signed-off-by: David Christensen > --- > Running the devtools/test-build.sh script on IBM Power systems fails > because the IXGBE_PMD is explicity disabled for Power as an untested > driver, b

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 17:11:10 +0100 "Liang, Ma" wrote: > > pi->turbo_enable = 0; > > > > - > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { You (don't) need (so many) parenthesis.

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Liang, Ma
Acked-by: Liang Ma On 12 Apr 16:57, Lee Daly wrote: > This patch will ensure the correct max frequency of a core is set in > the lcore_power_info struct when disabling turbo, while using the > intel pstate driver. > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Cc: liang.

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-15 Thread Ferruh Yigit
On 4/12/2019 10:31 PM, Stephen Hemminger wrote: > On Fri, 12 Apr 2019 18:29:46 +0100 > Ferruh Yigit wrote: > >> On 4/12/2019 6:25 PM, Ferruh Yigit wrote: >>> On 4/12/2019 6:15 PM, Ananyev, Konstantin wrote: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.or

Re: [dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-15 Thread Stephen Hemminger
On Sun, 14 Apr 2019 16:41:42 +0530 wrote: > > + cur = !!(offload_mask & ETH_QINQ_STRIP_OFFLOAD); > + org = !!(dev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_QINQ_STRIP); > + if (cur != org) { > + if (cur) > + dev->data->dev_conf

Re: [dpdk-dev] [PATCH v3] power: update for handling fifo path string

2019-04-15 Thread Hunt, David
Hi Lukasz, On 15/4/2019 11:01 AM, Lukasz Gosiewski wrote: From: Lukasz Krakowiak Removed doubled created fifo path string for channel info. --- v3: *improvement to coding style v2: * rebase to master changes Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- examples/vm

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 9:37 AM, Igor Ryzhov wrote: > Hi Ferruh, > > To be absolutely sure, I performed a test using the test application. > > When I send pings from an interface: > 3: ens8: mtu 1500 qdisc pfifo_fast state > UP mode DEFAULT group default qlen 1000 > link/ether 52:54:00:c8:79:c6 brd ff:

Re: [dpdk-dev] [PATCH v1] test/ticketlock: implement ticketlock autotest

2019-04-15 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Joyce Kong > Sent: Monday, April 15, 2019 5:05 PM > To: dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > david.march...@redhat.com; step...@networkplumber.org; > jerin.ja...@caviumnetworks.com; konstantin.anan...@intel.com; > Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH] eal: fix large multiple calculation in reciprocal division

2019-04-15 Thread Stephen Hemminger
On Sun, 14 Apr 2019 10:52:59 +0530 wrote: > + int64_t i; Since i only does 1..64 it can be int. > + uint64_t t; > + > + for (i = 1; i <= 64; i++) { > + t = x >> 63; > + x = (x << 1) | (y >> 63); > + y = y << 1; > + if ((x | t) >= z) { >

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 12:24:47 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Saturday, April 13, 2019 12:06 AM > > To: Honnappa Nagarahalli > > Cc: Ananyev, Konstantin ; > > paul...@linux.ibm.com; Kovace

Re: [dpdk-dev] [PATCH v2 2/3] test: remove prefix _acpi from UT power function/test names

2019-04-15 Thread Kevin Traynor
On 03/04/2019 11:32, Lukasz Krakowiak wrote: > This patch remove prefix _acpi from power UT function/test names. > Hi, why is it better? Asking because it might mean you have to send some future fixes separately to stable branches. > Signed-off-by: Lukasz Krakowiak > ---

Re: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature

2019-04-15 Thread Hunt, David
On 3/4/2019 11:32 AM, Lukasz Krakowiak wrote: Add UT check_power_turbo. Signed-off-by: Lukasz Krakowiak --- app/test/test_power_cpufreq.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c i

Re: [dpdk-dev] [PATCH v2 2/3] test: remove prefix _acpi from UT power function/test names

2019-04-15 Thread Hunt, David
On 3/4/2019 11:32 AM, Lukasz Krakowiak wrote: This patch remove prefix _acpi from power UT function/test names. Signed-off-by: Lukasz Krakowiak --- I would agree with Thomas, this patch should probably be merged with the file rename patch. Rgds, Dave.

Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface

2019-04-15 Thread Hunt, David
On 29/3/2019 10:22 AM, Lukasz Krakowiak wrote: Updated doc for JSON sample code related to vm_power_manager fifo interface: "command": "destroy", "command": "power". Corrected typo in doc vm_power_management.rst: 'json' instead of 'jason'. --- v2: * coding style improved Signed-off-by: Lukasz

[dpdk-dev] [PATCH v2 2/3] examples/fips_validation: fix cmac test failure

2019-04-15 Thread Marko Kovacevic
As a result of the cmac test running the test where PT len is 65536 it should give a result back to the user USER1: Error -1: Prepare op USER1: PT len 65536 as this MSG len is not supported. Issue was that the application was not freeing the op properly after a while causing the app to fail. CRYPT

[dpdk-dev] [PATCH v2 3/3] cryptodev: fix uninitialized session clear

2019-04-15 Thread Marko Kovacevic
added check to see if a session for a device has been initialised if it has return 0. Fixes: 5d6c73dd5938 ("cryptodev: add reference count to session private data") Cc: roy.fan.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Marko Kovacevic --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1

[dpdk-dev] [PATCH v2 1/3] examples/fips: fix hmac test failure

2019-04-15 Thread Marko Kovacevic
Application was failing as the HMAC and Plain SHA fips request files are similar in a way that they both have SHA- in the top section to determine the hash algo and hash sizes. And HMAC having the algo in the second line but the Plain SHA in the third meant that when the HMAC files was used once it

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination

2019-04-15 Thread Hunt, David
On 9/4/2019 5:00 PM, Reshma Pattan wrote: After the read() the jason_data null termination is missing for the case "indent < 0", for "indent > 0" and "indent == 0" cases null termination is already handled. So add the missing case "indent < 0" to the existing "indent == 0" case to fix null ter

[dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure

2019-04-15 Thread Aaron Conole
When eth_virtio_dev_init() is cleaning up, it does not correctly set the mac_addrs variable to NULL, which will lead to a double free. Found during unit-test fixes. Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") Cc: sta...@dpdk.org Reported-by: Michael Santana Signed-off-by: Aaro

Re: [dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-15 Thread Ye Xiaolong
Hi, David Thanks for you detailed review comment. On 04/15, David Marchand wrote: >On Fri, Apr 12, 2019 at 4:54 PM Xiaolong Ye wrote: > >> As David pointed out, if we reserve N slots, but only submit n slots, >> we would end up with an incorrect opinion of the number of available slots >> later

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string overflow

2019-04-15 Thread Hunt, David
On 10/4/2019 3:54 PM, Reshma Pattan wrote: Use strlcpy instead of strcpy to fix string overflow. Coverity issue: 337671 Fixes: a63504a90f ("examples/power: add JSON string handling") CC: david.h...@intel.com CC: sta...@dpdk.org Signed-off-by: Reshma Pattan --- examples/vm_power_manager/chann

Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > > > > -- Per the email discussion [1], the default cache line size of > > > armv8 > > > cortex-a72 is changed to 64 bytes. > > > > IMO, In git commit you remove the reference to specific discussion and > > Update th

Re: [dpdk-dev] [PATCH v8 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-04-15 Thread Xu, Rosen
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 15, 2019 20:29 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia > Subject: Re: [PATCH v8 1

Re: [dpdk-dev] [PATCH] net/i40e: fix crash when calling i40e_vsi_delete_mac

2019-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Monday, April 15, 2019 8:21 PM > To: wangyunjian ; dev@dpdk.org > Cc: xudin...@huawei.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix crash when calling > i40e_vsi

Re: [dpdk-dev] [PATCH 1/2] net/ice: code clean

2019-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wang Ying A > Sent: Friday, April 12, 2019 9:52 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/ice: code clean Better to change ti

Re: [dpdk-dev] [PATCH v8 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-15 Thread Xu, Rosen
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 15, 2019 20:29 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia > Subject: Re: [PATCH v8 0

[dpdk-dev] [PATCH] app/test: add unit test cases for mbuf library APIs

2019-04-15 Thread Lavanya Govindarajan
added new unit test cases for rte_validate_tx_offload, rte_pktmbuf_alloc_bulk, rte_pktmbuf_read, rte_pktmbuf_ext_shinfo_init_helper, rte_pktmbuf_attach_extbuf, rte_mbuf_ext_refcnt_read, rte_mbuf_ext_refcnt_update, rte_mbuf_ext_refcnt_set, rte_pktmbuf_detach_extbuf Signed-off-by: Lavanya Govindaraj

Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

2019-04-15 Thread Xu, Rosen
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 15, 2019 20:28 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia ; > Thomas Monjalon > Subj

Re: [dpdk-dev] [PATCH v8 00/14] Add patch set for IPN3KE

2019-04-15 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 15, 2019 20:28 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia > Subject: Re: [PATCH v8 00/14] Add

Re: [dpdk-dev] [PATCH v8 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 6:07 AM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. > > Signed-off-by: Rosen Xu > Signed-off-by: Tianfei Zhang > Signed-off-by: Andy Pei <...> > @@ -128,6 +137,45 @@ > return; > } > } > + > + /*

Re: [dpdk-dev] [PATCH v8 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 6:06 AM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > Signed-off-by: Dan Wei <...> > @@ -633,6 +633,12 @@ F: drivers/net/ice/ > F: doc/guides/nics/ice.rst > F: doc/guides/nics/features/ice.in

Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 6:06 AM, Rosen Xu wrote: > In many scenarios, AFU is needed searched by name, this > function add the feature. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > --- > drivers/bus/ifpga/ifpga_bus.c | 13 + > drivers/bus/ifpga/rte_bus_ifpga.h

Re: [dpdk-dev] [PATCH v8 00/14] Add patch set for IPN3KE

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 6:06 AM, Rosen Xu wrote: > v8 updates: > = > - Fix meter color definition replacement > > v7 updates: > = > - Fix Stephen comments > > v6 updates: > == > - Fix v5 comments > - Fix TM Shaper rate issue > > v5 updates: > == > - Fix EXPERIMENTAL sym

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, April 13, 2019 12:06 AM > To: Honnappa Nagarahalli > Cc: Ananyev, Konstantin ; > paul...@linux.ibm.com; Kovacevic, Marko ; > dev@dpdk.org; Gavin Hu (Arm Technology China) ; Dharmik > T

Re: [dpdk-dev] [PATCH] net/i40e: fix crash when calling i40e_vsi_delete_mac

2019-04-15 Thread Ananyev, Konstantin
Hi, > Now the macvlan filter list may be accessed in the same time by two > different threads and may cause a lot of optional errors. This patch > protects the macvlan filter access with a spinlock. > > Call Trace: > #1 0x7ffb4cbe2e3c in i40e_vsi_delete_mac (vsi=vsi@entry= > 0x400052

Re: [dpdk-dev] [PATCH] net/ice: enable RSS for IPv4/IPv6 packets

2019-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Monday, April 15, 2019 2:04 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH] net/ice: enable RSS for IPv4/IPv6 packets > > Signed-off-by: Ley

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-15 Thread Ananyev, Konstantin
Hi Shreyansh, > > > I tried this patch on MacchiatoBin + 82599 NIC. > > > Compared with global-pool mode, per-port-pool mode showed slightly > > lower performance in single core test. > > > > That was my thought too - for the case when queues from multiple ports > > are handled by the same core

[dpdk-dev] [PATCH] doc: fix heading levels in bbdev test guide

2019-04-15 Thread Thomas Monjalon
The section "Test Vector files" should not be at the same level as the main title "dpdk-test-bbdev Application". Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Cc: amr.mokh...@intel.com Signed-off-by: Thomas Monjalon --- doc/guides/tools/testbbdev.rst

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-15 Thread Shreyansh Jain
Hello Ruifeng, > > > Hi Shreyansh, > > > -Original Message- > > From: Shreyansh Jain > > Sent: Monday, April 15, 2019 14:48 > > To: Ruifeng Wang (Arm Technology China) ; > > Ananyev, Konstantin ; dev@dpdk.org > > Cc: nd ; nd > > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: support

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-15 Thread Luca Boccassi
On Fri, 2019-04-12 at 16:24 -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for > libraries and > dependency() can't find libraries by pkg-config. By adding fallback > of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("buil

[dpdk-dev] [PATCH] net/bonding: fix potential out of bounds read

2019-04-15 Thread Radu Nicolau
Add validation to pointer constructed from the IPv4 header length in order to prevent malformed packets from generating a potential out of bounds memory read. Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) di

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-15 Thread Hunt, David
On 12/4/2019 4:57 PM, Lee Daly wrote: This patch will ensure the correct max frequency of a core is set in the lcore_power_info struct when disabling turbo, while using the intel pstate driver. Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Cc: liang.j...@intel.com Cc: sta...@

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-15 Thread Bruce Richardson
On Fri, Apr 12, 2019 at 04:24:48PM -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for libraries and > dependency() can't find libraries by pkg-config. By adding fallback of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("b

Re: [dpdk-dev] [PATCH] examples/vm_power: add conditional compilation for PMD specific code

2019-04-15 Thread Hunt, David
Hi David, On 2/4/2019 7:14 PM, David Christensen wrote: Signed-off-by: David Christensen --- Running the devtools/test-build.sh script on IBM Power systems fails because the IXGBE_PMD is explicity disabled for Power as an untested driver, but the examples/vm_power_manager application has a hard

  1   2   >