On 4/15/2019 6:07 AM, Rosen Xu wrote:
> Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev.
>
> Signed-off-by: Rosen Xu <rosen...@intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zh...@intel.com>
> Signed-off-by: Andy Pei <andy....@intel.com>
<...>
> @@ -128,6 +137,45 @@
> return;
> }
> }
> +
> + /* get opae_manager to rawdev */
> + mgr = opae_adapter_get_mgr(adapter);
> + if (mgr) {
> + //get LineSide BAR Index
Please prefer c89 comments, /* */
<...>
> + }
> + if (!strcmp(attr_name, "NICSideLinkStatus")) {
> + /*
> + *
> + */
Please add some comments or drop.
> + return 0;
> + }
> + if (!strcmp(attr_name, "NICSideBARIndex")) {
> + /* eth_group 1 on FPGA connect to NicSide */
> + if (opae_manager_get_eth_group_region_info(mgr, 1,
> + &opae_eth_grp_reg_info))
> + return -1;
> + *attr_value = (uint64_t)opae_eth_grp_reg_info.mem_idx;
> + return 0;
> + }
> +
> + IFPGA_RAWDEV_PMD_ERR("attr_name not support");
It can be useful to print requested attr_name
<...>
> @@ -8,8 +8,8 @@
> extern int ifpga_rawdev_logtype;
>
> #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
> - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
> - __func__, ##args)
> + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifpga_rawdev: " fmt, \
> + ##args)
Are you sure about this change? Another commit in this release [1] updates
"ifgpa" -> "%s", __func__; but this commit revert it back to "ifpga_rawdev: "
[1]
Fixes: a3a6a3d94f7e ("raw/ifpga: modify log output")
Cc: andy....@intel.com
