On Sun, 14 Apr 2019 16:41:42 +0530 <viveksha...@marvell.com> wrote: > > + cur = !!(offload_mask & ETH_QINQ_STRIP_OFFLOAD); > + org = !!(dev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_QINQ_STRIP); > + if (cur != org) { > + if (cur) > + dev->data->dev_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_QINQ_STRIP; > + else > + dev->data->dev_conf.rxmode.offloads &= > + ~DEV_RX_OFFLOAD_QINQ_STRIP; > + mask |= ETH_QINQ_STRIP_MASK; > + } > + > /*no change*/
Using a local (pointer) variable for dev->data->dev_conf.rxmode.offloads would make the code more readable and lines shorter.