Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

On 3/23/19 10:12 PM, David Marchand wrote: On Fri, Mar 22, 2019 at 6:43 PM David Marchand wrote: On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko < arybche...@solarflare.com> wrote: In fact bad Rx checksum counters follow and I think they should be in this line. That's why there is no \n he

[dpdk-dev] [PATCH v5 5/5] net/af_xdp: enable zero copy

Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 130 1 file ch

[dpdk-dev] [PATCH v5 2/5] lib/mbuf: introduce helper to create mempool with flags

This allows applications to create mbuf mempool with specific flags such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mbuf/rte_mbuf.c | 29 ++ lib/librte_mbuf/rte_mbuf.h | 45

[dpdk-dev] [PATCH v5 3/5] lib/mempool: allow page size aligned mempool

Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mempool/rte_mempool.c | 3 +++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempo

[dpdk-dev] [PATCH v5 4/5] net/af_xdp: use mbuf mempool for buffer management

Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf allocated from rte_mempool can be converted to xdp_desc's address and vice versa. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 117 +--- 1 file changed, 72 insertions(+), 45 delet

[dpdk-dev] [PATCH v5 0/5] Introduce AF_XDP PMD

Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v5 1/5] net/af_xdp: introduce AF XDP PMD driver

Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

[dpdk-dev] [PATCH v6 6/8] net/ice: support Rx AVX2 vector

Signed-off-by: Wenzhuo Lu --- drivers/net/ice/Makefile| 19 ++ drivers/net/ice/ice_rxtx.c | 16 +- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c | 622 drivers/net/ice/meson.build | 15 + 5 fil

[dpdk-dev] [PATCH v6 7/8] net/ice: support Rx scatter AVX2 vector

Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 10 -- drivers/net/ice/ice_rxtx.h | 3 ++ drivers/net/ice/ice_rxtx_vec_avx2.c | 64 + 3 files changed, 74 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/

[dpdk-dev] [PATCH v6 8/8] net/ice: support vector AVX2 in TX

Signed-off-by: Wenzhuo Lu --- doc/guides/nics/ice.rst| 18 doc/guides/rel_notes/release_19_05.rst | 4 + drivers/net/ice/ice_rxtx.c | 13 ++- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c| 158 +

[dpdk-dev] [PATCH v6 3/8] net/ice: support vector SSE in RX

Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 33 +++ drivers/net/ice/Makefile | 3 + drivers/net/ice/ice_ethdev.c | 2 - drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_rxtx.c| 27 +- drivers/net/ice/ice_rxtx.h

[dpdk-dev] [PATCH v6 5/8] net/ice: support Tx SSE vector

Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 2 + drivers/net/ice/ice_rxtx.c| 17 + drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_common.h | 133 + drivers/net/ice/ice_rxtx_vec_sse.c| 135

[dpdk-dev] [PATCH v6 4/8] net/ice: support Rx scatter SSE vector

Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 16 +++ drivers/net/ice/ice_rxtx.h | 2 ++ drivers/net/ice/ice_rxtx_vec_sse.c | 41 ++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_rx

[dpdk-dev] [PATCH v6 1/8] net/ice: fix Tx function setting

The TX setting functions is not called. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index a23c6

[dpdk-dev] [PATCH v6 2/8] net/ice: add pointer for queue buffer release

Add function pointers of buffer releasing for RX and TX queues, for vector functions will be added for RX and TX. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 24 +++- drivers/net/ice/ice_rxtx.h | 5 + 2 files changed, 20 insertions(+), 9 deletions(-) diff

[dpdk-dev] [PATCH v6 0/8] Support vector instructions on ICE

Use SSE and AVX2 instructions in ICE RX and TX path. --- v2: - Updated feature doc. - Fixed checklog and checkpatch issues. v3: - Fixed potential compile issue on non-X86 platform. v4: - Removed compile configure, CONFIG_RTE_LIBRTE_ICE_INC_VECTOR. - Fixed checkpatch warnings. - Added more

[dpdk-dev] [PATCH v4 38/38] net/ice/base: rework on bit ops

Move all bit ops related functions from ice_osdep.h into ice_bitops.h. Also remove the limitation that bitmap can only be 64 bits in ice_set_bit and ice_clear_bit. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/b

[dpdk-dev] [PATCH v4 33/38] net/ice/base: change profile priority for RSS reply

1. Add call to replay RSS configurations 2. Add RSS configurations to end of list and not the head to avoid inversion on replay. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base

[dpdk-dev] [PATCH v4 32/38] net/ice/base: add FDIR support

Add flow director related support base code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/Makefile | 1 + drivers/net/ice/base/ice_adminq_cmd.h | 13 + drivers/net/ice/base/ice_common.c | 3

[dpdk-dev] [PATCH v4 36/38] net/ice/base: increase prototol offset size

OS package's format is changed, field vector's protocol offset size is changed from 8 bit to 16 bit. So base code also need to align to this, or PMD will not be able to load OS package correctly. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr Reviewed-by: Qiming Yang Reviewed-by: We

[dpdk-dev] [PATCH v4 37/38] net/ice/base: revert the workaround for resource allocation

Revert the workaround for allocating TCAM and FV entries to align with latest firmware. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_common.c| 11 +- drivers/net/ice/bas

[dpdk-dev] [PATCH v4 35/38] net/ice/base: fix minor issues

1. clean flow entry's action structure after remove it. 2. initialized priority when add a new flow entry 3. remove RSS configuration before deleting the flow profile. Fixes: aa1cd410fa64 ("net/ice/base: add flow module") Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-o

[dpdk-dev] [PATCH v4 34/38] net/ice/base: fix duplicate resource allocations

This patch ensure that TCAM allocations made by a newly added VSIG that has the same characteristic list of an existing VSIG are removed. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v4 28/38] net/ice/base: return config error without queue to disable

If there is no queue to disable, return appropriate configuration error earlier without acquiring the lock. Signed-off-by: Akeem G Abodunrin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_common.c | 17

[dpdk-dev] [PATCH v4 30/38] net/ice/base: change profile id reference counting

Improved the profile reference counting, by moving it from being based on how many TCAM entries using the profile to how many profile map entries are using the profile. Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: We

[dpdk-dev] [PATCH v4 31/38] net/ice/base: add DCB support

Add module to support DCB related features. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/Makefile |1 + drivers/net/ice/base/ice_adminq_cmd.h | 243 ++ drivers/net/ice/base/ice_common.c

[dpdk-dev] [PATCH v4 25/38] net/ice/base: fix minor issues

1. Fix some problems with filling the HW tables. 2. Fix a logic error in ice_rem_prof_from_list. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/

[dpdk-dev] [PATCH v4 29/38] net/ice/base: add function to check FW recovery mode

Code added to check the FW recovery mode. This function will be used by the drivers during init to check whether the FW is in recovery mode or not. If FW is in recovery mode then the drivers need to run in a recovery mode where it can allow only limited operations. Link should be down, allow only c

[dpdk-dev] [PATCH v4 27/38] net/ice/base: fix Klockwork analysis reported issues

Klocwork points out some code is unreachable in ice_get_itr_intrl_gran and ice_ptg_find_ptype. The patch removed the unreachable code and resolved the static analysis reported issues. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Fixes: 453d087ccaff ("net/ice/base: add common

[dpdk-dev] [PATCH v4 26/38] net/ice/base: update copyright time

Update copyright time to 2019. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_adminq_cmd.h| 2 +- drivers/net/ice/base/ice_alloc.h | 2 +- drivers/net/ice/base/ice_common.c| 2 +- dri

[dpdk-dev] [PATCH v4 24/38] net/ice/base: remove local VSIG allocations

If allocating a VSI to a VSIG fails the local allocations made for VSIG profiles and change-lists will not be removed. Adding calls to free these entries on error in VSIG management calls. Signed-off-by: Vignesh Sridhar Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qim

[dpdk-dev] [PATCH v4 20/38] net/ice/base: ensure only valid bits are set

In the ice_aq_set_phy_cfg AQ command, the 16.4 bit is reserved. This patch will make sure that this bit will never be set to 1. Signed-off-by: Chinh T Cao Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_

[dpdk-dev] [PATCH v4 18/38] net/ice/base: clean code

Change below function as static and also relocated code line to align with kernel driver. ice_aq_move_sched_elems ice_sched_get_agg_node ice_sched_set_node_bw_lmt ice_sched_cfg_node_bw_alloc ice_sched_add_agg_cfg ice_sched_rm_agg_cfg ice_sched_move_vsi_to_agg ice_sched_del_rl_profile ice_sched_rm_

[dpdk-dev] [PATCH v4 23/38] net/ice/base: do not write TCAM entries back

Profile TCAM entry removal is handled by the firmware when freeing the resource, so the driver does not need to write these default entries back with an update Package action. This patch removes writing of the TCAM entry using Update Package command when removing it, since the entry has already be

[dpdk-dev] [PATCH v4 22/38] net/ice/base: add RSS key related macro and structures

Add define for 52 byte RSS hash key size, and add struct ice_aqc_get_set_rss_keys comments regarding setting 40 bytes and 52 byte hash key. Signed-off-by: Paul Greenwalt Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/ne

[dpdk-dev] [PATCH v4 19/38] net/ice/base: enable VSI queue context

The patch added to retrieve the queue context and update the queue handle for lan queues. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_common.c | 60 +

[dpdk-dev] [PATCH v4 16/38] net/ice/base: fix minor issues

1. ICE_SW_LKUP_LAST need to be handled correctly in ice_aq_alloc_free_vsi_list and ice_update_vsi_list_rule 2. ICE_SW_LKUP_ETHERTYPE_MAC need to be handled correctly in ice_update_vsi_lkup_fltr 3. free package segment pointer during ice_deinit_hw Fixes: c7dd15931183 ("net/ice/base: add virtual swi

[dpdk-dev] [PATCH v4 21/38] net/ice/base: enhance get link status command

Extend the functionality of the admin queue command by including additional status and ID bits to improve link topology configuration. Signed-off-by: Matthew Vick Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/b

[dpdk-dev] [PATCH v4 17/38] net/ice/base: update macros

Update macros for metadata and package flags. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_common.c| 36 - drivers/net/ice/base/ice_flow.h | 17 ++-- drivers/net/ice/base/i

[dpdk-dev] [PATCH v4 15/38] net/ice/base: add two helper functions for flow management

1. ice_rem_all_sw_rules_info - remove all switch rules. 2. ice_reply_all_fltr - replay all filters stored in book keeping list. These APIs will be used when switch rule feature is enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo

[dpdk-dev] [PATCH v4 13/38] net/ice/base: add APIs to get VSI promiscuous mode

1. ice_get_vsi_promisc - get promiscuous mode of give VSI. 2. ice_get_vsi_vlan_promisc - get VLAN promiscuous mode of given VSI. PMD may use these APIs to check the real HW status, but not rely on a software flag when something abnormal. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH v4 14/38] net/ice/base: add MAC filter with marker and counter

1. ice_add_mac_with_sw_marker - add filter with software marker. 2. ice_add_mac_with_counter - add filter with counter enabled. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_switch.c | 328 +

[dpdk-dev] [PATCH v4 10/38] net/ice/base: add APIs to add remove ethertype filter

Add API ice_remove_eth_mac and ice_add_eth_mac to support adding / removing ethertype (or MAC) based filter rules. PMD driver can use these APIs to enable related rte_flow rule. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- dr

[dpdk-dev] [PATCH v4 12/38] net/ice/base: add APIs to alloc/free resource counter

1. ice_alloc_res_cntr - allocate resource counter 2. ice_free_res_cntr - free resource counter 3. ice_alloc_vlan_res_counter - allocate vlan resource counter 4. ice_free_vlan_res_counter - free vlan resource counter These APIs will be used when try to count the number of a flow be hitted. Signed-

[dpdk-dev] [PATCH v4 11/38] net/ice/base: add APIs to get allocated resources

1. ice_aq_get_res_alloc - get allocated resources. 2. ice_aq_get_res_descs - get allocated resource descriptors. These APIs may help to PMD to enable some debug utilities to dump the resource allocation status. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang

[dpdk-dev] [PATCH v4 09/38] net/ice/base: add VSI queue context framework

Added code to allocate VSI queue contexts to save the queue specific information like bandwidth etc. Signed-off-by: Victor Raj Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_sched.c | 52 ++

[dpdk-dev] [PATCH v4 06/38] net/ice/base: clean code

Remove unnecessary macro and data structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_adminq_cmd.h | 2 - drivers/net/ice/base/ice_flex_pipe.c | 2 - drivers/net/ice/base/ice_flow.c | 13

[dpdk-dev] [PATCH v4 07/38] net/ice/base: declare functions as external

Remove static of below functions and declare them as external APIs. ice_aq_add_vsi ice_aq_free_vsi ice_aq_update_vsi ice_aq_add_lan_txq ice_init_pkg So far the purpose is just to sync with kernel driver. They are reserved for future use. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v4 08/38] net/ice/base: add more APIs in switch module

Add below APIs in switch module 1. ice_aq_get_vsi_params - get VSI context info 2. ice_aq_add_update_mir_rule - add/update mirror rule 3. ice_aq_delete_mir_rule - delete mirror rule 4. ice_aq_set_storm_ctrl - set storm control configuration 5. ice_aq_get_storm_ctrl - get storm control configurati

[dpdk-dev] [PATCH v4 05/38] net/ice/base: allow package copy to be used after resets

For components that make a copy of an external pipeline package file (i.e. the Linux and FreeBSD drivers), save the size of the package file along with the copy so that both can be used when calling ice_init_pkg() after a CORER/GLOBR reset. Also, do not free the copy of the package file in ice_ini

[dpdk-dev] [PATCH v4 03/38] net/ice/base: add two helper functions

Add two helper functions in common module. 1. ice_aq_set_mac_cfg to help configure maximum frame size with AQ command 2. ice_get_ctx help to extract context bits from a packet structure. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu

[dpdk-dev] [PATCH v4 04/38] net/ice/base: add helper macros

1. Add macro ice_for_each_traffic_class to loop for each traffic class. 2. Add macro MIN_T to wrap min with type conversion. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_common.c | 2 +- drivers/net/i

[dpdk-dev] [PATCH v4 01/38] net/ice/base: add switch resource allocation and free

Add two APIs ice_alloc_sw and ice_free_sw to support switch related resource allocation and free. These APIs are required when we enable switch flow. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Reviewed-by: Qiming Yang Reviewed-by: Wenzhuo Lu --- drivers/net/ice/base/ice_switc

[dpdk-dev] [PATCH v4 00/38] ice share code update.

Sync to latest kernel driver, main changes: 1. add DCB/FDIR support. 2. add more APIs in switch module. 3. code clean and bug fix. v4: - revert the fix for UDP PTYPE setup (PATCH 38/38 on v3) since its invalid. - move bit ops to dedicate file and remove the 64 bit limitation of bitmap. - improved

[dpdk-dev] [PATCH] net/virtio: define avail and used flags as constants

We are consistently passing 1 as the argument in the data path, so there is no need to define avail/used flags as function-like macros anymore. This patch changes the avail and used flags to constants. And a frequently used combination is also introduced. Signed-off-by: Tiwei Bie --- drivers/net

Re: [dpdk-dev] [PATCH v5 0/3] enable package download in ice driver

> -Original Message- > From: dev On Behalf Of Qiming Yang > Sent: Sunday, March 24, 2019 7:30 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH v5 0/3] enable package download in ice driver > > This patch set enabled package downloading to the device

[dpdk-dev] [PATCH] net/virtio-user: fix multi-process support

This patch fixes the multi-process support for virtio-user. Currently virtio-user just provides some limited secondary process supports. Only some basic operations can be done in secondary process on virtio-user port, e.g. getting port stats. Actions which will trigger the communication with vhost

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, March 22, 2019 10:56 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string > parser for flow

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

On 03/24, Luca Boccassi wrote: >On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> On 03/02, Ye Xiaolong wrote: >> > > >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += >> > > > -lrte_pmd_af_packet >> > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += >> > > > -lrte_pmd_af_xdp >> > > > -le

[dpdk-dev] [PATCH v5 2/3] net/ice: add safe mode

If E810 download package failed, driver need to go to safe mode. In the safe mode, some advanced features will not be supported. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/ice/ice_ethdev.c | 48 ++ drivers/n

[dpdk-dev] [PATCH v5 3/3] net/ice: enable RSS when device init

This patch enabled RSS for UPD/TCP/SCTP+IPV4/IPV6 packets. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 1 + drivers/net/ice/ice_ethdev.c | 39 ++ 2 files changed, 40 insertions(+) diff --git a/doc/guides/rel_notes/release_19

[dpdk-dev] [PATCH v5 1/3] net/ice: load OS default package

This patch enables package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. There is no per device package be supported so far, all the devices can only download the same pac

[dpdk-dev] [PATCH v5 0/3] enable package download in ice driver

This patch set enabled package downloading to the device. The package is to be in the /lib/firmware/intel/ice/ddp directory and named ice.pkg. The package is shared by the kernel driver and the DPDK PMD. If package download failed, driver need to go to safe mode. This patch set disabled RSS, QINQ,

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, March 22, 2019 6:12 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector > > +#ifndef RTE_LIBRTE_ICE_16BYTE_RX_DESC > > I

Re: [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx SSE vector

Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, March 22, 2019 5:59 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx SSE vector > > > + > > +static __rte_always_inline void > > +

Re: [dpdk-dev] [PATCH v5 3/8] net/ice: support vector SSE in RX

Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, March 22, 2019 5:43 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 3/8] net/ice: support vector SSE in RX > > > + > > +static inline uint16_t > > +reassembl

Re: [dpdk-dev] [PATCH v4] build: move variable definition to top level

07/03/2019 12:28, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/m

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes

On Sun, Mar 24, 2019 at 6:24 PM Chas Williams <3ch...@gmail.com> wrote: > On 3/24/19 1:11 PM, David Marchand wrote: > > On Sun, Mar 24, 2019 at 2:35 PM Chas Williams <3ch...@gmail.com > > > wrote: > > > > Have you ever experienced this problem in practice? I ask becaus

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes

On 3/24/19 1:11 PM, David Marchand wrote: On Sun, Mar 24, 2019 at 2:35 PM Chas Williams <3ch...@gmail.com > wrote: Have you ever experienced this problem in practice? I ask because I am considering some fixes that would limit the number of slaves to a more

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types

On Sun, Mar 24, 2019 at 2:28 PM Chas Williams <3ch...@gmail.com> wrote: > See inline. > > On 3/21/19 4:28 PM, David Marchand wrote: > > From: Zhaohui > > > > mode_bond_id and mode_band_id are slave ids, stored on 16bits. > > Please change mode_bond_id to mode_count_id in this commit message. > Ot

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes

On Sun, Mar 24, 2019 at 2:35 PM Chas Williams <3ch...@gmail.com> wrote: > Have you ever experienced this problem in practice? I ask because I am > considering some fixes that would limit the number of slaves to a more > reasonable number (and reduce the over stack usage of the bonding driver > in

Re: [dpdk-dev] [PATCH v4 1/5] net/af_xdp: introduce AF XDP PMD driver

24/03/2019 13:10, Luca Boccassi: > On Fri, 2019-03-22 at 21:01 +0800, Xiaolong Ye wrote: > > diff --git a/drivers/net/af_xdp/rte_pmd_af_xdp_version.map > > b/drivers/net/af_xdp/rte_pmd_af_xdp_version.map > > new file mode 100644 > > index 0..c6db030fe > > --- /dev/null > > +++ b/drivers/net

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes

Have you ever experienced this problem in practice? I ask because I am considering some fixes that would limit the number of slaves to a more reasonable number (and reduce the over stack usage of the bonding driver in general). On 3/21/19 4:28 PM, David Marchand wrote: From: Zhaohui slave a

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types

See inline. On 3/21/19 4:28 PM, David Marchand wrote: From: Zhaohui mode_bond_id and mode_band_id are slave ids, stored on 16bits. Please change mode_bond_id to mode_count_id in this commit message. Otherwise, this looks fine. Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: sta.

Re: [dpdk-dev] [PATCH v4 1/5] net/af_xdp: introduce AF XDP PMD driver

On Fri, 2019-03-22 at 21:01 +0800, Xiaolong Ye wrote: > diff --git a/drivers/net/af_xdp/rte_pmd_af_xdp_version.map > b/drivers/net/af_xdp/rte_pmd_af_xdp_version.map > new file mode 100644 > index 0..c6db030fe > --- /dev/null > +++ b/drivers/net/af_xdp/rte_pmd_af_xdp_version.map > @@ -0,0 +1

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: > On 03/02, Ye Xiaolong wrote: > > > >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += > > > > -lrte_pmd_af_packet > > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += > > > > -lrte_pmd_af_xdp > > > > -lelf -lbpf > > > > > > Are symbols from

Re: [dpdk-dev] [PATCH v4 4/5] net/af_xdp: use mbuf mempool for buffer management

On 03/24, Ye Xiaolong wrote: >>> - ret = xsk_umem__create(&umem->umem, bufs, >>> + ret = xsk_umem__create(&umem->umem, base_addr, >>>ETH_AF_XDP_NUM_BUFFERS * ETH_AF_XDP_FRAME_SIZE, >>>&umem->fq, &umem->cq, >>>&u

Re: [dpdk-dev] [EXT] Re: [PATCH v3] net/kni: calc mbuf&mtu according to given mb_pool

Fixed. thanks From: Rami Rosen Sent: Saturday, March 23, 2019 23:49 To: Liron Himi Cc: ferruh.yi...@intel.com; dev@dpdk.org; Alan Winkowski Subject: [EXT] Re: [dpdk-dev] [PATCH v3] net/kni: calc mbuf&mtu according to given mb_pool External Email mailto:lir...

[dpdk-dev] [PATCH v4] net/kni: calc mbuf&mtu according to given mb_pool

From: Liron Himi - mbuf_size and mtu are now being calculated according to the given mb-pool. - max_mtu is now being set according to the given mtu the above two changes provide the ability to work with jumbo frames Signed-off-by: Liron Himi --- doc/guides/nics/kni.rst

Re: [dpdk-dev] [PATCH v4 1/5] net/af_xdp: introduce AF XDP PMD driver

On 03/22, Maxime Coquelin wrote: > > >On 3/22/19 2:01 PM, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla version PMD which just uses a raw buf

Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check

Thursday, March 21, 2019 11:34 AM, Dekel Peled: > Subject: RE: [PATCH] net/mlx5: add missing return value check > > > -Original Message- > > From: Ali Alnubani > > Sent: Thursday, March 21, 2019 11:07 AM > > To: dev@dpdk.org > > Cc: Shahaf Shuler ; Dekel Peled > > > > Subject: [PATCH] net

Re: [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules

Thursday, March 21, 2019 4:12 PM, Slava Ovsiienko: > Subject: RE: [PATCH 14/14] net/mlx5: add source vport match to the ingress > rules > > > > > > Signed-off-by: Viacheslav Ovsiienko [...] > > > + flow_dv_translate_source_vport(matcher.mask.buf, > > > +

Re: [dpdk-dev] [PATCH v4 2/5] lib/mbuf: introduce helper to create mempool with flags

On 03/22, Maxime Coquelin wrote: > > >On 3/22/19 2:01 PM, Xiaolong Ye wrote: >> This allows applications to create mbuf mempool with specific flags >> such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. >> >> Signed-off-by: Qi Zhang >> Signed-off-by: Xiaolong Ye >> --- >> lib/l

Re: [dpdk-dev] [PATCH v4 4/5] net/af_xdp: use mbuf mempool for buffer management

On 03/22, Maxime Coquelin wrote: > > >On 3/22/19 2:01 PM, Xiaolong Ye wrote: >> Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be >s/mbuf be allocated/mbuf allocated/ >> allocated from rte_mempool can be convert to xdp_desc's address and vice >s/convert/converted/ >> versa. W

Re: [dpdk-dev] [PATCH 12/14] net/mlx5: update install/uninstall int handler routines

Thursday, March 21, 2019 4:02 PM, Slava Ovsiienko: > To: Shahaf Shuler ; dev@dpdk.org > Subject: RE: [PATCH 12/14] net/mlx5: update install/uninstall int handler > routines > > > > Thursday, March 21, 2019 10:11 AM, Viacheslav Ovsiienko: > > > Subject: [PATCH 12/14] net/mlx5: update install/uninsta

Re: [dpdk-dev] [PATCH 05/14] net/mlx5: add multiport IB device support to probing

Thursday, March 21, 2019 2:58 PM, Slava Ovsiienko: > Subject: RE: [PATCH 05/14] net/mlx5: add multiport IB device support to > probing > > Sorry, missed some comments. Here is my extra answers. > [...] > > -Original callback to sort device data. > > > > * > > > > @@ -1380,7 +1381,9 @@ st

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

Thursday, March 21, 2019 3:52 PM, Ananyev, Konstantin: > Subject: RE: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw > Tx offload value > > Hi Shahaf, > > > Hi Konstantin, > > > > Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev: > > > /** > > > * The generic rte_mbuf, conta