On 3/23/19 10:12 PM, David Marchand wrote:
On Fri, Mar 22, 2019 at 6:43 PM David Marchand <david.march...@redhat.com>
wrote:

On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko <
arybche...@solarflare.com> wrote:

In fact bad Rx checksum counters follow and I think they should be in
this line.

That's why there is no \n here from the very beginning.

My fix for the bug (local) just add \n in else branch below.

Just to be clear.

origin/master:
- iofwd engine:
   ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0
-------
   RX-packets: 121811360      TX-packets: 121811392      TX-dropped:
0               RX-bursts : 3806605 [100% of 32 pkts]
   TX-bursts : 3806606 [100% of 32 pkts]

- csum engine:
   ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0
-------
   RX-packets: 5467488        TX-packets: 5467520        TX-dropped:
0               RX- bad IP checksum: 0               Rx- bad L4 checksum:
0              Rx- bad outer L4 checksum: 0
   RX-bursts : 170859 [100% of 32 pkts]
   TX-bursts : 170860 [100% of 32 pkts]


So, as suggested, I added a printf("\n") in the else for the csum engine
block:

- iofwd engine:
   ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0
-------
   RX-packets: 259770560      TX-packets: 259770592      TX-dropped:
0
   RX-bursts : 8117830 [100% of 32 pkts]
   TX-bursts : 8117831 [100% of 32 pkts]

- csum engine:
   ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0
-------
   RX-packets: 7834016        TX-packets: 7834048        TX-dropped:
0               RX- bad IP checksum: 0               Rx- bad L4 checksum:
0              Rx- bad outer L4 checksum: 0
   RX-bursts : 244813 [100% of 32 pkts]
   TX-bursts : 244814 [100% of 32 pkts]


deal ?

Yes, thanks a lot.

Andrew.

Reply via email to