[dpdk-dev] [PATCH v4 7/8] net/ice: support Rx scatter AVX2 vector

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 10 -- drivers/net/ice/ice_rxtx.h | 3 ++ drivers/net/ice/ice_rxtx_vec_avx2.c | 64 + 3 files changed, 74 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/

[dpdk-dev] [PATCH v4 8/8] net/ice: support vector AVX2 in TX

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/ice.rst| 17 doc/guides/rel_notes/release_19_05.rst | 4 + drivers/net/ice/ice_rxtx.c | 13 ++- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c| 158 +

[dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting

2019-03-20 Thread Wenzhuo Lu
The TX setting functions is not called. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index a23c6

[dpdk-dev] [PATCH v4 5/8] net/ice: support Tx SSE vector

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 2 + drivers/net/ice/ice_rxtx.c| 17 + drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_common.h | 133 + drivers/net/ice/ice_rxtx_vec_sse.c| 135

[dpdk-dev] [PATCH v4 6/8] net/ice: support Rx AVX2 vector

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/Makefile| 19 ++ drivers/net/ice/ice_rxtx.c | 16 +- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c | 622 drivers/net/ice/meson.build | 15 + 5 fil

[dpdk-dev] [PATCH v4 4/8] net/ice: support Rx scatter SSE vector

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 16 +++ drivers/net/ice/ice_rxtx.h | 2 ++ drivers/net/ice/ice_rxtx_vec_sse.c | 41 ++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_rx

[dpdk-dev] [PATCH v4 2/8] net/ice: add pointer for queue buffer release

2019-03-20 Thread Wenzhuo Lu
Add function pointers of buffer releasing for RX and TX queues, for vector functions will be added for RX and TX. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c | 24 +++- drivers/net/ice/ice_rxtx.h | 5 + 2 files changed, 20 insertions(+), 9 deletions(-) diff

[dpdk-dev] [PATCH v4 3/8] net/ice: support vector SSE in RX

2019-03-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 33 +++ drivers/net/ice/Makefile | 3 + drivers/net/ice/ice_ethdev.c | 2 - drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_rxtx.c| 27 +- drivers/net/ice/ice_rxtx.h

[dpdk-dev] [PATCH v4 0/8] Support vector instructions on ICE

2019-03-20 Thread Wenzhuo Lu
Use SSE and AVX2 instructions in ICE RX and TX path. --- v2: - Updated feature doc. - Fixed checklog and checkpatch issues. v3: - Fixed potential compile issue on non-X86 platform. v4: - Removed compile configure, CONFIG_RTE_LIBRTE_ICE_INC_VECTOR. - Fixed checkpatch warnings. - Added more

Re: [dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard

2019-03-20 Thread Rami Rosen
On Wed, Mar 20, 2019 at 3:58 PM Andrius Sirvys wrote: > The LGTM static code analysis tool is reporting > > "The macro name '_VHOST_NET_USER_H' of this include guard is used > in 2 different header files." > > lib/librte_vhost/vhost_user.h has the same include guard. > Renamed the include guard i

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Shahaf Shuler
Hi Konstantin, Wednesday, March 20, 2019 8:47 PM, Konstantin Ananyev: > Subject: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx > offload value > > Operations to set/update bit-fields often cause compilers to generate > suboptimal code. > To help avoid such situation for tx_offlo

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Jerin Jacob Kollanukkaran
> > +static inline uint64_t I like this idea. I prefer to add __rte_always_inline for this function. > +rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, > uint64_t tso, > + uint64_t ol3, uint64_t ol2) > +{ > + return il2 << RTE_MBUF_L2_LEN_OFS | > + il3 << RTE_MB

Re: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number configuration error

2019-03-20 Thread Zhao1, Wei
> -Original Message- > From: Stillwell Jr, Paul M > Sent: Tuesday, March 19, 2019 12:17 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number > configuration error > > > > -Origi

Re: [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX

2019-03-20 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 21, 2019 1:35 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX > > On 3/18/2019 1:22 AM, Lu, Wenzhuo wrote: > > Hi Ferruh, > > > >> -Original Me

Re: [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector

2019-03-20 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 21, 2019 1:37 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector > > On 3/18/2019 1:37 AM, Lu, Wenzhuo wrote: > > Hi Ferruh, > > > > > >> -Original

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting

2019-03-20 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, March 21, 2019 1:22 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting > > On 3/18/2019 1:08 AM, Lu, Wenzhuo wrote: > > Hi Ferruh, > > > >> -Original Mes

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-20 Thread Carrillo, Erik G
Hi Robert, Thanks for the review and suggestions. I’m out of the office on bonding leave for the next few weeks, but I’ll update the patch to address your points below when I return. Thanks, Erik > On Mar 20, 2019, at 8:53 AM, Sanford, Robert wrote: > > Hi Erik, > > I have a few questions

[dpdk-dev] [PATCH 2/2] test/hash: lock-free rw concurrency test ext bkt

2019-03-20 Thread Dharmik Thakkar
Add unit test to check for hash lookup and bulk-lookup perf. Test with lock-free enabled and with lock-free disabled. Test include: - hash lookup on keys in ext bkt, hash delete causing key-shifts of keys from ext bkt to secondary bkt Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Th

[dpdk-dev] [PATCH 1/2] hash: add lock free support for extendable bucket

2019-03-20 Thread Dharmik Thakkar
This patch enables lock-free read-write concurrency support for extendable bucket feature. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- doc/guides/prog_guide/hash_lib.rst | 3 +- lib/

[dpdk-dev] [PATCH 0/2] hash: add lock free support for ext bkt

2019-03-20 Thread Dharmik Thakkar
This patch series: - Enables lock-free read-write concurrency support for extendable bucket feature. - Adds lock-free read-write concurrency tests for ext bkt Dharmik Thakkar (2): hash: add lock free support for extendable bucket test/hash: lock-free rw concurrency test ext bkt app/test/tes

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-20 Thread Luca Boccassi
On Wed, 2019-03-20 at 15:28 -0400, Michael Santana Francisco wrote: > > > +matrix: > > > + include: > > > + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1 > > > +compiler: gcc > > > +addons: > > > + apt: > > > +packages: > > > + - [libnuma-dev, linux-h

Re: [dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat

2019-03-20 Thread Ferruh Yigit
On 3/18/2019 12:41 PM, Chaitanya Babu Talluri wrote: > strcat does not check the destination length and there might be > chances of string overflow so instead of strcat, strlcat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > C

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix stdout flush absence after printing stats

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 1:21 PM, Iremonger, Bernard wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko [mailto:arybche...@solarflare.com] >> Sent: Monday, March 18, 2019 11:36 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; Igor Romanov ; >> st

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-20 Thread Ferruh Yigit
On 3/17/2019 9:43 AM, Liron Himi wrote: > > > -Original Message- > From: Ferruh Yigit > Sent: Friday, March 15, 2019 19:59 > To: Liron Himi > Cc: dev@dpdk.org; Alan Winkowski > Subject: Re: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool > > On 3/15/2019 5:02 PM, Liron H

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-20 Thread Michael Santana Francisco
Thank you for taking at look at this On 3/20/19 12:01 PM, Thomas Monjalon wrote: Hi, 04/03/2019 17:12, Michael Santana: .ci/linux-build.sh | 21 + .ci/linux-setup.sh | 3 ++ .travis.yml | 73 + Pl

Re: [dpdk-dev] [RFC] cryptodev/sym: GCM IV len != 12 byte case

2019-03-20 Thread Liron Himi
+ Michael From: Kusztal, ArkadiuszX Sent: Wednesday, March 20, 2019 20:47 To: dev@dpdk.org; Trahe, Fiona ; Doherty, Declan ; De Lara Guarch, Pablo ; akhil.go...@nxp.com; ravi1.ku...@amd.com; t...@semihalf.com; Liron Himi ; Alan Winkowski Subject: [EXT] [RFC] cryptodev/sym: GCM IV len != 12 b

[dpdk-dev] [PATCH v2 7/7] ipsec: reorder packet process for esp inbound

2019-03-20 Thread Konstantin Ananyev
Change the order of operations for esp inbound post-process: - read mbuf metadata and esp tail first for all packets in the burst first to minimize stalls due to load latency. - move code that is common for both transport and tunnel modes into separate functions to reduce code duplication. - ad

[dpdk-dev] [PATCH v2 3/7] ipsec: change the order in filling crypto op

2019-03-20 Thread Konstantin Ananyev
Right now we first fill crypto_sym_op part of crypto_op, then in a separate cycle we fill crypto op fields. It makes more sense to fill whole crypto-op in one go instead. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 46 --- 1 file changed,

[dpdk-dev] [PATCH v2 5/7] ipsec: move inbound and outbound code into different files

2019-03-20 Thread Konstantin Ananyev
sa.c becomes too big, so decided to split it into 3 chunks: - sa.c - control path related functions (init/fini, etc.) - esp_inb.c - ESP inbound packet processing - esp_outb.c - ESP outbound packet processing Plus few changes in internal function names to follow the same code convention. No func

[dpdk-dev] [PATCH v2 6/7] ipsec: reorder packet check for esp inbound

2019-03-20 Thread Konstantin Ananyev
Right now check for packet length and padding is done inside cop_prepare(). It makes sense to have all necessary checks in one place at early stage: inside pkt_prepare(). That allows to simplify (and later hopefully) optimize cop_prepare() part. Signed-off-by: Konstantin Ananyev --- lib/librte_i

[dpdk-dev] [RFC] cryptodev/sym: GCM IV len != 12 byte case

2019-03-20 Thread Kusztal, ArkadiuszX
Hi all, There is a proposition to amend a bit API due to the following lines: * - For GCM mode, this is either 12 (for 96-bit IVs) * or 16, in which case data points to J0. ... } iv; /**< Initialisation vector parameters */ Problem arise when driver cannot support J0 input, right now we k

[dpdk-dev] [PATCH v2 4/7] ipsec: change the way unprocessed mbufs are accounted

2019-03-20 Thread Konstantin Ananyev
As was pointed in one of previous reviews - we can avoid updating contents of mbuf array for successfully processed packets. Instead store indexes of failed packets, to move them beyond the good ones later. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 166 +++

[dpdk-dev] [PATCH v2 2/7] ipsec: add Tx offload template into SA

2019-03-20 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To avoid such negative effect, use tx_offload raw value and mask to update l2_len and l3_len fields within mbufs. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 23 ++- lib/l

[dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To help avoid such situation for tx_offload fields: introduce new enum for tx_offload bit-fields lengths and offsets, and new function to generate raw tx_offload value. Signed-off-by: Konstantin Ananyev --- li

[dpdk-dev] [PATCH v2 0/7] Few small improvements for ipsec library

2019-03-20 Thread Konstantin Ananyev
v1 -> v2 Add patch to improve a bit esp inbound pkt_process code The first patch in this series introduce new function to set raw value for rte_mbuf tx_offload. Remaining ones are cleanups and small performance improvements (on IA ~3-6% depending on the test-case) for ipsec library. Konstantin A

Re: [dpdk-dev] [PATCH v2 3/3] doc: update documentation

2019-03-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 28, 2019 11:36 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De > Lara Guarch, Pablo > Subject: [PATCH v2 3/3] doc: update documentation I think you can merge this patch with patch 1. > > This

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Wiles, Keith
> On Mar 20, 2019, at 10:24 AM, Konstantin Ananyev > wrote: > > Operations to set/update bit-fields often cause compilers > to generate suboptimal code. > To help avoid such situation for tx_offload fields: > introduce new enum for tx_offload bit-fields lengths and offsets, > and new function

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: enable out of place processing

2019-03-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, February 28, 2019 11:36 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; De > Lara Guarch, Pablo ; Trahe, Fiona > ; Luse, Paul E > Subject: [PATCH v2 1/3] crypto/aesni_mb: enable out of place processing > >

Re: [dpdk-dev] [PATCH v3] ethdev: check for invalid device name

2019-03-20 Thread Stephen Hemminger
On Wed, 20 Mar 2019 14:28:22 + Ferruh Yigit wrote: > On 3/14/2019 4:20 PM, Stephen Hemminger wrote: > > Do not allow creating a ethernet device with a name over the > > allowed maximum (or zero length). This is safer than silently truncating > > which is what happens now. > > > > Signed-off-

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-20 Thread Stephen Hemminger
On Wed, 20 Mar 2019 12:40:26 +0800 Tiwei Bie wrote: > > I agree the vq_ prefix is not needed and I think the code is more > > readable in general seeing the packed/split name when using the struct. > > > > Please also consider that cosmetic changes in multiple places likely > > mean backports wi

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version library only

2019-03-20 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Monday, March 4, 2019 2:58 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Trahe, > Fiona > Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: support newer version > library onl

Re: [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector

2019-03-20 Thread Ferruh Yigit
On 3/18/2019 1:37 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, March 16, 2019 1:54 AM >> To: Lu, Wenzhuo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector >> >> On 3/15/2019 6:22 AM, Wenzhuo

Re: [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX

2019-03-20 Thread Ferruh Yigit
On 3/18/2019 1:22 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, March 16, 2019 1:54 AM >> To: Lu, Wenzhuo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX >> >> On 3/15/2019 6:22 AM, Wenzhuo L

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-20 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, March 20, 2019 2:32 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Trahe, > Fiona ; Kusztal, ArkadiuszX > > Subject: [PATCH v3] cryptodev: make xform key pointer constant > > This patch changes the key po

[dpdk-dev] [PATCH v2 3/7] ipsec: change the order in filling crypto op

2019-03-20 Thread Konstantin Ananyev
Right now we first fill crypto_sym_op part of crypto_op, then in a separate cycle we fill crypto op fields. It makes more sense to fill whole crypto-op in one go instead. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 46 --- 1 file changed,

[dpdk-dev] [PATCH v2 7/7] ipsec: reorder packet process for esp inbound

2019-03-20 Thread Konstantin Ananyev
Change the order of operations for esp inbound post-process: - read mbuf metadata and esp tail first for all packets in the burst first to minimize stalls due to load latency. - move code that is common for both transport and tunnel modes into separate functions to reduce code duplication. - ad

[dpdk-dev] [PATCH v2 6/7] ipsec: reorder packet check for esp inbound

2019-03-20 Thread Konstantin Ananyev
Right now check for packet length and padding is done inside cop_prepare(). It makes sense to have all necessary checks in one place at early stage: inside pkt_prepare(). That allows to simplify (and later hopefully) optimize cop_prepare() part. Signed-off-by: Konstantin Ananyev --- lib/librte_i

[dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To help avoid such situation for tx_offload fields: introduce new enum for tx_offload bit-fields lengths and offsets, and new function to generate raw tx_offload value. Signed-off-by: Konstantin Ananyev --- li

[dpdk-dev] [PATCH v2 5/7] ipsec: move inbound and outbound code into different files

2019-03-20 Thread Konstantin Ananyev
sa.c becomes too big, so decided to split it into 3 chunks: - sa.c - control path related functions (init/fini, etc.) - esp_inb.c - ESP inbound packet processing - esp_outb.c - ESP outbound packet processing Plus few changes in internal function names to follow the same code convention. No func

[dpdk-dev] [PATCH v2 4/7] ipsec: change the way unprocessed mbufs are accounted

2019-03-20 Thread Konstantin Ananyev
As was pointed in one of previous reviews - we can avoid updating contents of mbuf array for successfully processed packets. Instead store indexes of failed packets, to move them beyond the good ones later. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 166 +++

[dpdk-dev] [PATCH v2 0/7] Few small improvements for ipsec library

2019-03-20 Thread Konstantin Ananyev
v1 -> v2 Add patch to improve a bit esp inbound pkt_process code The first patch in this series introduce new function to set raw value for rte_mbuf tx_offload. Remaining ones are cleanups and small performance improvements (on IA ~3-6% depending on the test-case) for ipsec library. Konstantin A

[dpdk-dev] [PATCH v2 2/7] ipsec: add Tx offload template into SA

2019-03-20 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To avoid such negative effect, use tx_offload raw value and mask to update l2_len and l3_len fields within mbufs. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 23 ++- lib/l

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting

2019-03-20 Thread Ferruh Yigit
On 3/18/2019 1:08 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, March 16, 2019 1:52 AM >> To: Lu, Wenzhuo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting >> >> On 3/15/2019 6:22 AM, Wenzhuo Lu

Re: [dpdk-dev] [PATCH] release notes: added release notes for macswap change

2019-03-20 Thread Ferruh Yigit
On 3/18/2019 3:49 AM, Ruifeng Wang wrote: > Updated release notes for the testpmd change which used neon intrinsics > to do MAC swap on ARM platform. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu Squashed into relevant commit [1] in next-net, thanks. [1] app/testpmd: optimize MAC swa

Re: [dpdk-dev] [PATCH 2/2] doc: update Mellanox supported OFED version

2019-03-20 Thread Tom Barbette
I completely removed with apt remove --purge all packages installed by the OFED, deleted with rm -rf /usr/include/infiniband/ and then installed the OFED with --dpdk --upstream-libs (--force) and nothing else and I get the compilation error (with 19.02). Indeed /usr/include/infiniband/mlx5_api

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 3:32 PM, Thomas Monjalon wrote: > 20/03/2019 16:25, Ferruh Yigit: >> On 3/20/2019 2:26 PM, Thomas Monjalon wrote: >>> 19/03/2019 14:21, Yigit, Ferruh: On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > The patch series tries to improve documentation of what is retained > acr

[dpdk-dev] [PATCH] usertools: replace unsafe input function

2019-03-20 Thread Andrius Sirvys
LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel.com Signed-off-by: Andrius Sirvys --- user

Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories

2019-03-20 Thread Thomas Monjalon
Hi, 04/03/2019 17:12, Michael Santana: > .ci/linux-build.sh | 21 + > .ci/linux-setup.sh | 3 ++ > .travis.yml | 73 + Please, could you explain somewhere what is the relationship between these files? W

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-20 Thread Andrew Rybchenko
On 3/20/19 5:48 PM, Thomas Monjalon wrote: 19/03/2019 14:32, Yigit, Ferruh: On 1/8/2019 11:30 AM, Tom Barbette wrote: Ferruh Yigit wrote: Why timestamp offloading become useless? When timestamp offloading enabled, device fills 'mbuf.timestamp' and you can use it. But the frequency is unknown,

[dpdk-dev] [PATCH v5 5/5] doc: update release note

2019-03-20 Thread Fan Zhang
This patch updates the 19.05 release note with IPsec library updates for the newly added AES-CTR and 3DES-CBC algorithm support. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/release_19_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b

[dpdk-dev] [PATCH v5 4/5] ipsec-secgw: add 3des test files

2019-03-20 Thread Fan Zhang
This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/test/run_test.sh | 10 ++- .../test/trs_3descbc_sha1_common_defs.sh | 7

[dpdk-dev] [PATCH v5 2/5] ipsec-secgw: add test scripts for aes ctr

2019-03-20 Thread Fan Zhang
This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Updated a bit on common_defs to use "mktemp" instead of "tempfile" as Fedora does not like the command. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- examples/i

[dpdk-dev] [PATCH v5 3/5] ipsec: support 3DES-CBC

2019-03-20 Thread Fan Zhang
This patch adds triple-des CBC mode cipher algorithm to ipsec library. Signed-off-by: Fan Zhang Acked-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 40 ++-- lib/librte_ipsec/sa.h | 6 ++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git

[dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR

2019-03-20 Thread Fan Zhang
This patch adds AES-CTR cipher algorithm support to ipsec library. Signed-off-by: Fan Zhang Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- lib/librte_ipsec/crypto.h | 17 ++ lib/librte_ipsec/sa.c | 133 ++ lib/librte_ipsec/sa.h |

[dpdk-dev] [PATCH v5 0/5] ipsec: support AES-CTR and 3DES-CBC

2019-03-20 Thread Fan Zhang
This patchset adds the AES-CTR and 3DES-CBC cipher algorithms support to ipsec library. The test scripts for ipsec-secgw sample application are added. v5: - updated ipsec-secgw run_test.sh script - updated release note v4: - changed patch titles. - changed ALGO_TYPE naming for 3DES-CBC v3: - fix

[dpdk-dev] [PATCH 3/3] net/mlx5: add jump action support for NIC

2019-03-20 Thread Ori Kam
When using Direct Rules we can add actions to jump between tables. This is extra useful since rule insertion rate is much higher on other tables compared to table zero. if no group is selected the rule is added to group 0. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 6 + driv

[dpdk-dev] [PATCH 2/3] net/mlx5: add Direct Rules API

2019-03-20 Thread Ori Kam
Adds calls to the Direct Rules API inside the glue functions. Due to difference in parameters between the Direct Rules and Direct Verbs some of the glue functions API was updated. Signed-off-by: Ori Kam --- drivers/net/mlx5/Makefile | 5 ++ drivers/net/mlx5/mlx5.c | 21 + dr

[dpdk-dev] [PATCH 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-03-20 Thread Ori Kam
This is the first patch of a series that is designed to enable the Direct Rules API. The main difference between Direct Verbs and Direct Rules from API prespective, is that in Direct Rules each action has it's own create function and the object itself is of type void. In this patch I'm adding fun

[dpdk-dev] [PATCH 0/3]net/mlx5: Add Direct Rule support

2019-03-20 Thread Ori Kam
This patch set adds support for Direct Rules API for MLX5 driver. As more and more applications like OVS are inserting and removing large number of flows, the flow insertion rate become more critical. In current MLX5 PMD rules are inserted to the device using the FW, this limits the max insertion

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2019-03-20 Thread Thomas Monjalon
20/03/2019 16:25, Ferruh Yigit: > On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > > 19/03/2019 14:21, Yigit, Ferruh: > >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > >>> The patch series tries to improve documentation of what is retained > >>> across default restart. > >>> > >>> Andrew Rybchenk

Re: [dpdk-dev] [PATCH] ethdev: claim device reset as async

2019-03-20 Thread Stephen Hemminger
On Wed, 20 Mar 2019 12:54:03 +0800 Qi Zhang wrote: > + ret = rte_ctrl_thread_create(&tid, pthread_name, NULL, > + do_dev_reset, args); > + > + return ret; combine the ret = and return (ie make it a tail call)

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter

2019-03-20 Thread Ye Xiaolong
On 03/20, David Marchand wrote: >On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < >jer...@marvell.com> wrote: > >> On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: >> > When create rte_mempool, flags can be parsed from command line. >> > Now, it is possible for testpmd to create a

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 2:26 PM, Thomas Monjalon wrote: > 19/03/2019 14:21, Yigit, Ferruh: >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >>> The patch series tries to improve documentation of what is retained >>> across default restart. >>> >>> Andrew Rybchenko (3): >>> ethdev: advertise MTU as retained

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-20 Thread Ye Xiaolong
Thanks for your comments. On 03/20, David Marchand wrote: >On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > >> diff --git a/doc/guides/nics/features/af_xdp.ini >> b/doc/guides/nics/features/af_xdp.ini >> new file mode 100644 >> index 0..7b8fcce00 >> --- /dev/null >> +++ b/doc/guides/n

Re: [dpdk-dev] [PATCH] test: fix build when pdump config is disabled

2019-03-20 Thread Rami Rosen
pdump unit test has dependency on pthread code in test.c and process.h to run send_pkts(), this code should be enabled only when CONFIG_RTE_LIBRTE_PDUMP is enabled. Bugzilla ID: 222 Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") CC: sta...@dpdk.org Signed-off-by: Reshma Pattan

Re: [dpdk-dev] [pull-request] next-eventdev 18.05 PRE-RC1

2019-03-20 Thread Thomas Monjalon
15/03/2019 06:50, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name

2019-03-20 Thread Ferruh Yigit
On 3/19/2019 10:19 PM, Stephen Hemminger wrote: > On Tue, 19 Mar 2019 18:59:21 + > Ferruh Yigit wrote: > >> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote: >>> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote: The octeontx driver is creating vdev with name "OCTEONTX_P

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-20 Thread Thomas Monjalon
19/03/2019 14:32, Yigit, Ferruh: > On 1/8/2019 11:30 AM, Tom Barbette wrote: > > Ferruh Yigit wrote: > >> Why timestamp offloading become useless? When timestamp offloading enabled, > >> device fills 'mbuf.timestamp' and you can use it. > > But the frequency is unknown, and the reference time neith

Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

2019-03-20 Thread Stojaczyk, Dariusz
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 20, 2019 8:35 AM > To: dev@dpdk.org; i.maxim...@samsung.com; Liu, Changpeng > ; Bie, Tiwei ; Stojaczyk, > Dariusz > Subject: Re: [PATCH v3 0/2] vhost: Support external backend only vh

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/enic: fix max MTU calculation

2019-03-20 Thread Ferruh Yigit
On 3/14/2019 11:05 AM, Hyong Youb Kim wrote: > The maximum packet length (max_pkt_len) from the firmware does not > include CRC, so do not subtract 4 when deriving the max MTU. This > change effectively increases the max MTU by 4B. Apps often assume max > MTU = max_rx_pkt_len - 14 (ethernet header)

Re: [dpdk-dev] [PATCH v3] ethdev: check for invalid device name

2019-03-20 Thread Ferruh Yigit
On 3/14/2019 4:20 PM, Stephen Hemminger wrote: > Do not allow creating a ethernet device with a name over the > allowed maximum (or zero length). This is safer than silently truncating > which is what happens now. > > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko > --- > v3 -- fi

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

2019-03-20 Thread Thomas Monjalon
19/03/2019 14:21, Yigit, Ferruh: > On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: > > The patch series tries to improve documentation of what is retained > > across default restart. > > > > Andrew Rybchenko (3): > > ethdev: advertise MTU as retained across device stop/start > > ethdev: adverti

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

2019-03-20 Thread David Marchand
Hello Zhaohui, On Wed, Mar 20, 2019 at 2:54 PM Zhaohui (zhaohui, Polestar) < zhaoh...@huawei.com> wrote: > Well done, Can you fix it? > > thanks > > by zhaohui > I can take it as part of my series yes. I will keep your SoB on this part.

[dpdk-dev] [dpdk-announce] DPDK 16.11.9 (LTS) released

2019-03-20 Thread Luca Boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-16.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=16.11 Known issues in this release include non-working GRE checksum offload on i40e, intermittent issues with link-state change with PF/V

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Thomas Monjalon
20/03/2019 14:56, Ferruh Yigit: > On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > > 20/03/2019 14:46, Ferruh Yigit: > >> Applied to dpdk-next-net/master, thanks. > >> > >> (only this patch merged, not series. Other patch seems waiting for > >> comment.) > > > > Applying half of patchset makes trac

Re: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

2019-03-20 Thread Igor Russkikh
Hi Ferruh, Sorry forgot that. Coverity issue: 187034 On 20.03.2019 16:24, Ferruh Yigit wrote: > On 3/12/2019 3:24 PM, Igor Russkikh wrote: >> Found by Coverity scan. Checks are useless >> because at these code places err is always zero. > > Can you please add Coverity issue number, I can squash

Re: [dpdk-dev] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics

2019-03-20 Thread Andrew Rybchenko
On 3/20/19 1:02 PM, David Marchand wrote: Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

[dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard

2019-03-20 Thread Andrius Sirvys
The LGTM static code analysis tool is reporting "The macro name '_VHOST_NET_USER_H' of this include guard is used in 2 different header files." lib/librte_vhost/vhost_user.h has the same include guard. Renamed the include guard in vhost.h to differentiate. Fixes: 6a84c37e3975 ("net/virtio-user:

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Ferruh Yigit
On 3/20/2019 1:51 PM, Thomas Monjalon wrote: > 20/03/2019 14:46, Ferruh Yigit: >> Applied to dpdk-next-net/master, thanks. >> >> (only this patch merged, not series. Other patch seems waiting for comment.) > > Applying half of patchset makes tracking of patches less obvious. > I prefer we avoid su

Re: [dpdk-dev] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits

2019-03-20 Thread Andrew Rybchenko
On 3/20/19 1:02 PM, David Marchand wrote: fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 429800 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381TX-packet

[dpdk-dev] [PATCH v4 4/4] ipsec-secgw: add 3des test files

2019-03-20 Thread Fan Zhang
This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/run_test.sh | 8 ++- .../test/trs_3descbc_sha1_common_defs.sh | 73 ++ exam

[dpdk-dev] [PATCH v4 3/4] ipsec: support 3DES-CBC

2019-03-20 Thread Fan Zhang
This patch adds triple-des CBC mode cipher algorithm to ipsec library. Signed-off-by: Fan Zhang --- lib/librte_ipsec/sa.c | 40 ++-- lib/librte_ipsec/sa.h | 6 ++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/lib/librte_ipsec/sa.c b/lib

Re: [dpdk-dev] [PATCH v4 1/2] timer: allow timer management in shared memory

2019-03-20 Thread Sanford, Robert
Hi Erik, I have a few questions and comments on this patch series. 1. Don't you think we need new tests (in test/test/) to verify the secondary-process APIs? 2. I suggest we define default_data_id as const, and explicitly set it to 0. 3. The outer for-loop in rte_timer_alt_manage() touches beyon

[dpdk-dev] [PATCH v4 0/4] ipsec: support AES-CTR and 3DES-CBC

2019-03-20 Thread Fan Zhang
This patchset adds the AES-CTR and 3DES-CBC cipher algorithms support to ipsec library. The test scripts for ipsec-secgw sample application are added. v4: - changed patch titles. - changed ALGO_TYPE naming for 3DES-CBC v3: - fixed a bug in 3DES. v2: - removed unsupported tests. Fan Zhang (4):

[dpdk-dev] [PATCH v4 2/4] ipsec-secgw: add test scripts for aes ctr

2019-03-20 Thread Fan Zhang
This patch adds the functional test scripts to ipsec-secgw sample application for both transport and tunnel working mode. Updated a bit on common_defs to use "mktemp" instead of "tempfile" as Fedora does not like the command. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/test/common_defs.sh

[dpdk-dev] [PATCH v4 1/4] ipsec: support AES-CTR

2019-03-20 Thread Fan Zhang
This patch adds AES-CTR cipher algorithm support to ipsec library. Signed-off-by: Fan Zhang Acked-by: Akhil Goyal --- lib/librte_ipsec/crypto.h | 17 ++ lib/librte_ipsec/sa.c | 133 ++ lib/librte_ipsec/sa.h | 18 +++ 3 files changed,

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Thomas Monjalon
20/03/2019 14:46, Ferruh Yigit: > Applied to dpdk-next-net/master, thanks. > > (only this patch merged, not series. Other patch seems waiting for comment.) Applying half of patchset makes tracking of patches less obvious. I prefer we avoid such practice.

Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics

2019-03-20 Thread Andrew Rybchenko
On 3/20/19 1:02 PM, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkt

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-20 Thread Ferruh Yigit
On 3/13/2019 5:41 PM, Rami Rosen wrote: > On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: >>> The default config is used if the setup parameter is NULL. >>> No need to query the default config with rte_eth_dev_info_get(). >>> The function call will be removed with another useless i

Re: [dpdk-dev] [PATCH] net/bonding: fix Segfault when eal thread executing nic‘s lsc event for mode 4

2019-03-20 Thread David Marchand
On Wed, Mar 20, 2019 at 2:26 PM Zhaohui (zhaohui, Polestar) < zhaoh...@huawei.com> wrote: > Hi: > When the number of slave slave devices exceeds 8, it will cause > the array subscript to cross the boundary. > According to the suggestions, Modified array subscript to > RTE_MAX_ETH

  1   2   >