[dpdk-dev] [PATCH 2/3] ethdev: remove ethdev rmv interrupt

2018-12-13 Thread Jeff Guo
Since eal device event had been introduced, and application could monitor eal device event and accordingly handle hot-unplug for device, so the ethdev rmv event could be replaced by eal device event. This patch aim to abandon ethdev rmv interrupt, its every usages in pmd and testpmd will be removed

[dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option

2018-12-13 Thread Jeff Guo
This command-line option will enable hotplug event detecting and enable hotplug handling for device hotplug. Signed-off-by: Jeff Guo --- lib/librte_eal/bsdapp/eal/eal.c| 16 lib/librte_eal/common/eal_common_options.c | 5 + lib/librte_eal/common/eal_internal_cfg

[dpdk-dev] [PATCH 3/3] testpmd: remove device detach into eal

2018-12-13 Thread Jeff Guo
Assume that eal detect the removal event and handle hot-unplug, so device detach should be located in eal framework, the sequence should be eal detect and handle hot-unplug event at first, then eal notify app to finish pre-detach prepare, such as stop forwarding and clean ports, finally device be d

[dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug

2018-12-13 Thread Jeff Guo
This patch set aim to use a common eal device event mechanism to manage devices for hot-unplug whatever device types, so the previous ethdev remove event will be deleted and the device detach will be remove from app into eal framework. Jeff Guo (3): eal: add --dev-hotplug option ethdev: remove

[dpdk-dev] [PATCH v4 0/2] Support request more queues

2018-12-13 Thread Zhirun Yan
V4 - create new branch for case VIRTCHNL_OP_REQUEST_QUEUES. - put the "int ret" declaration in the new block and left the return i40evf_init_vlan(dev); as it is. - fix some warning when start the application. DPDK VF send VIRTCHNL_OP_REQUEST_QUEUES to kernel PF or DPDK VF for requesting more que

[dpdk-dev] [PATCH v4 1/2] net/i40e: support VF request more queues

2018-12-13 Thread Zhirun Yan
Before this patch, VF gets a default number of queues from the PF. This patch enables VF to request a different number. When VF configures more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more queues, if success, PF will reset the VF. User can run "port stop all", "port config

[dpdk-dev] [PATCH v4 2/2] net/i40e: support PF respond VF request more queues

2018-12-13 Thread Zhirun Yan
This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and process to allocated more queues for the requested VF. If successful, PF will notify VF to reset. If unsuccessful, PF will send message to inform VF. Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e

[dpdk-dev] how to disbale bnx2x vlan strip in dpdk-17.11

2018-12-13 Thread zhang_bia...@126.com
hi, all I use dpdk-17.11, and bind card with vfio-pci driver,It works. but the valn was stripped when recv pkts. how to disable hardware vlan stripping(offload), i set hw_vlan_strip to 0 in rte_eth_conf, but not works. My env info: card: NetXtreme II BCM57810

Re: [dpdk-dev] Setting intel_iommu, iommu, hugepagesz, hugepages

2018-12-13 Thread Stephen Hemminger
On Fri, 14 Dec 2018 05:16:47 + "Dipesh Gorashia (dipeshg)" wrote: > Hello, > > I am on Ubuntu 18.04 and would like to set these linux boot params. > > intel_iommu=on iommu=pt hugepagesz=2M hugepages=1024 > > I am bit new to this and was wondering if there is a guide that shows how to > se

[dpdk-dev] Setting intel_iommu, iommu, hugepagesz, hugepages

2018-12-13 Thread Dipesh Gorashia (dipeshg)
Hello, I am on Ubuntu 18.04 and would like to set these linux boot params. intel_iommu=on iommu=pt hugepagesz=2M hugepages=1024 I am bit new to this and was wondering if there is a guide that shows how to set these linux boot params. Thanks, Dipesh

Re: [dpdk-dev] [PATCH v3 00/34] A new net PMD - ice

2018-12-13 Thread Varghese, Vipin
Hi Wenzhuo, snipped > > > > Thanks for the update, couple of suggestion in my opinion shared below > > > > Snipped > > > > [PATCH v2 02/20] net/ice: support device initialization > > > > > +# Compile burst-oriented ICE PMD driver # > > > > CONFIG_RTE_LIBRTE_ICE_PMD=y > > > > > > > > Based on ' htt

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: support VF request more queues

2018-12-13 Thread Yan, Zhirun
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 6:49 PM > To: Yan, Zhirun ; dev@dpdk.org > Cc: Wang, Haiyue > Subject: RE: [PATCH v3 1/2] net/i40e: support VF request more queues > > > > > -Original Message- > > From: Yan, Zhirun > > Sent: Th

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: support VF request more queues

2018-12-13 Thread Yan, Zhirun
Hi David, The i40evf_init_vlan() always returns 0. So the change doesn’t affect it. I agree with you. So I will put the "int ret" declaration in the new block in next version. Thanks. From: David Marchand [mailto:david.march...@redhat.com] Sent: Thursday, December 13, 2018 4:26 PM To: Yan, Zhir

Re: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update

2018-12-13 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, December 14, 2018 8:36 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > Hi Qi, > > > -Original Message- > >

Re: [dpdk-dev] [PATCH v3 33/34] doc: add ICE description and update release note

2018-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 14, 2018 5:34 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 33/34] doc: add ICE description and > update release note > > On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > > Signed-off-by: We

Re: [dpdk-dev] [PATCH v3 32/34] net/ice: support descriptor ops

2018-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 14, 2018 5:30 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing ; Olivier MATZ > > Subject: Re: [dpdk-dev] [PATCH v3 32/34] net/ice: support descriptor ops > > On 12/12/201

Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build

2018-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 14, 2018 5:16 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build > > On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > > Signed-off-by: Wenzhuo Lu > > --- > >

Re: [dpdk-dev] [PATCH v3 21/34] net/ice: support MTU setting

2018-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 14, 2018 5:06 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v3 21/34] net/ice: support MTU setting > > On 12/12/2018 6:59 AM, Wenzhuo L

Re: [dpdk-dev] [PATCH v3 16/34] net/ice: support device initialization

2018-12-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 13, 2018 11:14 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v3 16/34] net/ice: support device > initialization > > On 12/13/2018 2:39

Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case

2018-12-13 Thread Gavin Hu (Arm Technology China)
Hi Stephen, Thanks for your comment and sharing the link! We are looking into it and it may take more time for performance profiling. Best Regards, Gavin > -Original Message- > From: Stephen Hemminger > Sent: Thursday, December 13, 2018 1:27 PM > To: Joyce Kong (Arm Technology China) >

[dpdk-dev] [PATCH 2/3] net/netvsc: cleanup transmit descriptor pool

2018-12-13 Thread Stephen Hemminger
On device close or startup errors, the transmit descriptor pool was being left behind. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/netvsc/hn_rxtx.c | 11 +++ drivers/net/netvsc/hn_var.h| 1 + 3 files changed, 14 insertions(+) diff --gi

[dpdk-dev] [PATCH 3/3] net/netvsc: not finding VF should not cause failure

2018-12-13 Thread Stephen Hemminger
It is possible that the VF device exists but DPDK doesn't know about it. This could happen if device was blacklisted or more likely the necessary device (Mellanox) was not part of the DPDK configuration. In either case, the right thing to do is just keep working but only with the slower para-virtu

[dpdk-dev] [PATCH 0/3] net/netvsc: misc fixes

2018-12-13 Thread Stephen Hemminger
Minor updates to netvsc driver. Stephen Hemminger (3): net/netvsc: support receive without vlan strip net/netvsc: cleanup transmit descriptor pool net/netvsc: not finding VF should not cause failure drivers/net/netvsc/hn_ethdev.c | 6 +- drivers/net/netvsc/hn_rxtx.c | 19 +++

[dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip

2018-12-13 Thread Stephen Hemminger
In some cases, VLAN stripping is not desireable. If necessary re-insert stripped vlan tag. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/netvsc/hn_rxtx.c | 8 drivers/net/netvsc/hn_var.h| 5 +++-- 3 files changed, 13 insertions(+), 2 delet

Re: [dpdk-dev] [PATCH] app/test-pmd: add IFPGA AFU register read/write access for testpmd

2018-12-13 Thread Xu, Rosen
Hi Iremonger, All the warnings have been fixed. Thanks a lot. > -Original Message- > From: Iremonger, Bernard > Sent: Friday, December 07, 2018 18:25 > To: Xu, Rosen ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Subject: RE: [PATCH] app/test-pmd: add IFPGA AFU regis

[dpdk-dev] [PATCH v2] app/test-pmd: add IFPGA AFU register read/write access for testpmd

2018-12-13 Thread Rosen Xu
Currently register read/write of testpmd is only for PCI device, but more and more IFPGA based AFU devices need this feature to access registers, this patch will add support for it. Signed-off-by: Rosen Xu --- app/test-pmd/config.c | 113 - app/te

Re: [dpdk-dev] [PATCH v3 00/34] A new net PMD - ice

2018-12-13 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Thursday, December 13, 2018 9:10 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 00/34] A new net PMD - ice > > Hi Wenzhuo, > > Thanks for the update, couple of suggestion in my opinion shared below >

Re: [dpdk-dev] [PATCH v1] net/i40e: clear VF reset flags after resetting done

2018-12-13 Thread Zhang, Qi Z
> -Original Message- > From: Yan, Zhirun > Sent: Thursday, December 13, 2018 11:47 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yan, Zhirun ; Wang, Haiyue > Subject: [PATCH v1] net/i40e: clear VF reset flags after resetting done > > The reset flags vf->vf_reset and vf->pend_msg are set wh

Re: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information

2018-12-13 Thread Lu, Wenzhuo
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 5:10 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > information > > >

Re: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops

2018-12-13 Thread Lu, Wenzhuo
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 5:00 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops > > > -Original Message--

Re: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update

2018-12-13 Thread Lu, Wenzhuo
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 4:47 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Li, Xiaoyun ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > Hi Wenzhuo: > > > --

Re: [dpdk-dev] [PATCH 0/3] Fix handling of block size in qat for hash

2018-12-13 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, December 12, 2018 12:59 PM > To: akhil.go...@nxp.com > Cc: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > > Subject: [PATCH 0/3] Fix handling of block size in qat for hash > > This patchset fixes invalid message wh

Re: [dpdk-dev] [PATCH v12 03/10] net/virtio: add packed virtqueue helpers

2018-12-13 Thread Jens Freimann
On Thu, Dec 13, 2018 at 05:09:03PM +0100, Maxime Coquelin wrote: On 12/13/18 1:34 PM, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 72 +- 1 file changed, 7

Re: [dpdk-dev] [PATCH v12 00/10] implement packed virtqueues

2018-12-13 Thread Jens Freimann
On Thu, Dec 13, 2018 at 05:38:02PM +0100, Maxime Coquelin wrote: On 12/13/18 1:34 PM, Jens Freimann wrote: This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.

Re: [dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs

2018-12-13 Thread Jens Freimann
On Thu, Dec 13, 2018 at 05:42:02PM +0100, Maxime Coquelin wrote: It seems check-git-log.sh returns an error for this one. On 12/13/18 1:34 PM, Jens Freimann wrote: Until we have support for ctrl virtqueues let's disable it and exit if specified as a parameter. Signed-off-by: Jens Freimann ---

[dpdk-dev] [PATCH v3 2/2] timer: add function to stop all timers in a list

2018-12-13 Thread Erik Gabriel Carrillo
Add a function to the timer API that allows a caller to traverse a specified set of timer lists, stopping each timer in each list, and invoking a callback function. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 39 ++ lib/librte

[dpdk-dev] [PATCH v3 0/2] Timer library changes

2018-12-13 Thread Erik Gabriel Carrillo
This patch series modifies the timer library in such a way that structures that used to be statically allocated in a process's data segment are now allocated in shared memory. As these structures contain lists of timers, new APIs are introduced that allow a caller to specify the particular structu

[dpdk-dev] [PATCH v3 1/2] timer: allow timer management in shared memory

2018-12-13 Thread Erik Gabriel Carrillo
Currently, the timer library uses a per-process table of structures to manage skiplists of timers presumably because timers contain arbitrary function pointers whose value may not resolve properly in other processes. However, if the same callback is used handle all timers, and that callback is onl

Re: [dpdk-dev] [dpdk-techboard] DPDK techboard minutes of November 21

2018-12-13 Thread Thomas Monjalon
Hi, 13/12/2018 19:20, Dumitrescu, Cristian: > Hi Techboard members, > > It would be great if we could get the meeting notes in a more timely manner. Sorry, we are not good at making reports, but we try to improve. > Can we also get a link to the full IRC log of the meeting as part of the > mee

[dpdk-dev] [PATCH] mem: add --match-allocations

2018-12-13 Thread Jim Harris
SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creates internal malloc_elem structures for these allocated regions. As users malloc and fre

Re: [dpdk-dev] [PATCH v3 33/34] doc: add ICE description and update release note

2018-12-13 Thread Ferruh Yigit
On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu > --- > MAINTAINERS| 1 + > doc/guides/nics/features/ice.ini | 38 + > doc/guides/nics/ice.rst| 101 > + Need to update doc/guides

Re: [dpdk-dev] [PATCH v3 32/34] net/ice: support descriptor ops

2018-12-13 Thread Ferruh Yigit
On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > Add below ops, > rx_descriptor_done > rx_descriptor_status > tx_descriptor_status I guess this is our mistake to not clarify this, sorry about it, but "rx_descriptor_status" replaces "rx_descriptor_done", it is and extended version, cc'ed Olivier to corre

Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build

2018-12-13 Thread Ferruh Yigit
On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ice/base/meson.build | 30 ++ > drivers/net/ice/meson.build | 15 +++ > drivers/net/meson.build | 1 + I think it is better to add meson file with on the

Re: [dpdk-dev] [PATCH v3 21/34] net/ice: support MTU setting

2018-12-13 Thread Ferruh Yigit
On 12/12/2018 6:59 AM, Wenzhuo Lu wrote: > Add ops mtu_set. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Qiming Yang > Signed-off-by: Xiaoyun Li > Signed-off-by: Jingjing Wu > --- > drivers/net/ice/ice_ethdev.c | 34 ++ Can you please update the ice.ini file

Re: [dpdk-dev] [PATCH] baseband: enhancement of offload cost test

2018-12-13 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday 6 December 2018 12:03 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; akhil.go...@nxp.com; > Chalupnik, KamilX > Subject: [PATCH] baseband: enhancement of offload cost test > > Offload cost test was improved in order to collect > m

Re: [dpdk-dev] [PATCH v2 4/4] baseband: enhancement of interrupt test

2018-12-13 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Friday 7 December 2018 15:16 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; akhil.go...@nxp.com; > Chalupnik, KamilX > Subject: [PATCH v2 4/4] baseband: enhancement of interrupt test > > Improvements added to interrupt test: > - test is ru

Re: [dpdk-dev] [PATCH v2 3/4] baseband: support bigger Transpor Block

2018-12-13 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Friday 7 December 2018 15:16 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; akhil.go...@nxp.com; > Chalupnik, KamilX > Subject: [PATCH v2 3/4] baseband: support bigger Transpor Block > > Test application and Turbo Software driver were adap

Re: [dpdk-dev] [PATCH v2 2/4] baseband: enhancement of throughput test

2018-12-13 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Friday 7 December 2018 15:16 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; akhil.go...@nxp.com; > Chalupnik, KamilX > Subject: [PATCH v2 2/4] baseband: enhancement of throughput test > > Improvements added to throughput test: > - test is

Re: [dpdk-dev] [PATCH v2 1/4] baseband: enhancement of offload cost test

2018-12-13 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Friday 7 December 2018 15:16 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; akhil.go...@nxp.com; > Chalupnik, KamilX > Subject: [PATCH v2 1/4] baseband: enhancement of offload cost test > > Offload cost test was improved in order to collec

Re: [dpdk-dev] [EXT] [PATCH v2 2/3] app/testpmd: improve MAC swap performance for x86

2018-12-13 Thread Jerin Jacob Kollanukkaran
On Tue, 2018-12-11 at 13:55 +0800, Qi Zhang wrote: > > The patch optimizes the mac swap operation by taking advantage > of SSE instructions, it only impacts x86 platform. > > Signed-off-by: Qi Zhang > --- > app/test-pmd/macswap.c| 4 > app/test-pmd/macswap_common.h | 1 - > app/t

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to remove rte meter color

2018-12-13 Thread Singh, Jasvinder
> -Original Message- > From: Pattan, Reshma > Sent: Wednesday, December 12, 2018 4:38 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Pattan, Reshma > > Subject: [PATCH] doc: add deprecation notice to remove rte meter color > > Added deprecation notice to replace rte_meter_color with rt

Re: [dpdk-dev] DPDK techboard minutes of November 21

2018-12-13 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Wednesday, December 12, 2018 5:02 PM > To: dev@dpdk.org > Cc: techbo...@dpdk.org > Subject: [dpdk-dev] DPDK techboard minutes of November 21 > > Meeting notes for the DPDK technical board

Re: [dpdk-dev] The performance of test-pipeline and l2fwd?

2018-12-13 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of bai bakari > Sent: Thursday, December 13, 2018 9:50 AM > To: dev > Subject: [dpdk-dev] The performance of test-pipeline and l2fwd? > > Hi, > > I test the performance of test-pipeline and l2fwd, and get the con

[dpdk-dev] [PATCH v3 2/2] mbuf: implement generic format for sched field

2018-12-13 Thread Reshma Pattan
This patch implements the changes proposed in the deprecation notes [1][2]. librte_mbuf changes: The mbuf::hash::sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. Added public APIs to set

[dpdk-dev] [PATCH v3 1/2] eal: add new rte color definition

2018-12-13 Thread Reshma Pattan
Added new rte_color definition in eal to consolidate color definition which is currently replicated in various places such as rte_meter.h, rte_tm.h and rte_mtr.h Created aliases for rte_tm_color, rte_mtr_color and rte_meter_color to use new rte_color values. The definitions of rte_tm_color, rte_m

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-13 Thread Stephen Hemminger
On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > + > +typedef uint16_t memif_region_index_t; > +typedef uint32_t memif_region_offset_t; > +typedef uint64_t memif_region_size_t; > +typedef uint16_t memif_ring_index_t; > +typedef uint32_t memif_interface_id_t; > +typedef uint16_t memif_ve

Re: [dpdk-dev] [PATCH] pdump: remove deprecated APIs

2018-12-13 Thread Pattan, Reshma
Hi, > -Original Message- > From: Bie, Tiwei > Sent: Monday, December 3, 2018 2:59 AM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Mcnamara, John > ; Kovacevic, Marko > Subject: [PATCH] pdump: remove deprecated APIs > > We already changed to use generic IPC in pdump since below commit: > >

Re: [dpdk-dev] [PATCH v1 3/4] examples/power: allow vms to use lcores over 63

2018-12-13 Thread Hunt, David
Hi Anatoly, On 10/12/2018 1:06 PM, Burakov, Anatoly wrote: On 22-Nov-18 5:02 PM, David Hunt wrote: Extending the functionality to allow vms to power manage cores beyond 63. Signed-off-by: David Hunt ---   examples/vm_power_manager/channel_manager.c | 59 -   examples/vm_po

Re: [dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs

2018-12-13 Thread Maxime Coquelin
It seems check-git-log.sh returns an error for this one. On 12/13/18 1:34 PM, Jens Freimann wrote: Until we have support for ctrl virtqueues let's disable it and exit if specified as a parameter. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++--

Re: [dpdk-dev] [PATCH v12 00/10] implement packed virtqueues

2018-12-13 Thread Maxime Coquelin
On 12/13/18 1:34 PM, Jens Freimann wrote: This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/

Re: [dpdk-dev] [PATCH v12 06/10] net/virtio: implement receive path for packed queues

2018-12-13 Thread Maxime Coquelin
On 12/13/18 1:34 PM, Jens Freimann wrote: Implement the receive part. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 61 +++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_rxtx.c | 385 ++

Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool

2018-12-13 Thread Varghese, Vipin
HI Reshma > -Original Message- > From: Pattan, Reshma > Sent: Thursday, December 13, 2018 8:13 PM > To: Varghese, Vipin ; Ananyev, Konstantin > ; step...@networkplumber.org; > dev@dpdk.org; Mcnamara, John > Cc: tho...@monjalon.net; Byrne, Stephen1 ; > Patel, Amol > Subject: RE: [PATCH v7

Re: [dpdk-dev] [PATCH v12 01/10] net/virtio: vring init for packed queues

2018-12-13 Thread Maxime Coquelin
On 12/13/18 1:34 PM, Jens Freimann wrote: Add and initialize descriptor data structures. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 36 +++--- drivers/net/virtio/virtio_pci.h| 7 drivers/net/virtio/virtio_ring.h

Re: [dpdk-dev] [PATCH v12 03/10] net/virtio: add packed virtqueue helpers

2018-12-13 Thread Maxime Coquelin
On 12/13/18 1:34 PM, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/net/virti

[dpdk-dev] [PATCH v2] crypto/aesni_mb: add plain sha support

2018-12-13 Thread Fan Zhang
From: Damian Nowak This patch adds the plain SHAx algorithm support to AESNI-MB PMD. This patch depends on the following patch: "crypto/aesni_mb: use architure independent marcos" (http://patchwork.dpdk.org/patch/48633/";). Signed-off-by: Damian Nowak Signed-off-by: Lukasz Krakowiak Acked-by:

Re: [dpdk-dev] [PATCH v3 16/34] net/ice: support device initialization

2018-12-13 Thread Ferruh Yigit
On 12/13/2018 2:39 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, December 13, 2018 2:18 AM >> To: Lu, Wenzhuo ; dev@dpdk.org >> Cc: Yang, Qiming ; Li, Xiaoyun >> ; Wu, Jingjing >> Subject: Re: [dpdk-dev] [PATCH v3 16/34] net/ice: sup

[dpdk-dev] [PATCH 4/4] net/cxgbe: fix other misc build issues for Windows

2018-12-13 Thread Rahul Lakkireddy
Fix following build errors: warning: function declaration is incompatible with definition error : expected an expression error : expression must be a pointer to a complete object type Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 2 +- drivers/net/cxgbe/cxgbe_compat.h |

[dpdk-dev] [PATCH 3/4] net/cxgbe: only redefine symbols when not available for Windows

2018-12-13 Thread Rahul Lakkireddy
Redefine symbols only when they are not available for Windows Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 4 ++-- drivers/net/cxgbe/base/t4vf_hw.c | 2 +- drivers/net/cxgbe/cxgbe_compat.h | 29 - 3 files changed, 31 insertions(+), 4 deleti

[dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows

2018-12-13 Thread Rahul Lakkireddy
Replace "args..." with "fmt, ..." and directly use __VA_ARGS__. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_compat.h | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_compat.h b/drivers/net/cxgbe/cxgbe_c

[dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for including header files

2018-12-13 Thread Rahul Lakkireddy
Explicitly state header file location using relative paths. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/Makefile | 2 -- drivers/net/cxgbe/base/adapter.h | 4 ++-- drivers/net/cxgbe/base/common.h| 2 +- drivers/net/cxgbe/clip_tbl.c | 2 +- drivers/net/cxgbe/cxgbe.h

[dpdk-dev] [PATCH 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-13 Thread Rahul Lakkireddy
This series of patches fix compilation warning and errors seen while building CXGBE PMD in preparation for Microsoft Windows OS support. Patch 1 uses relative paths for including header files. Patch 2 fixes macros related to rte_log(). Patch 3 only redefines symbols when they are not available. Pa

Re: [dpdk-dev] DPDK Release Status Meeting 13/12/2018

2018-12-13 Thread Ian Stokes
On 12/13/2018 2:08 PM, Ferruh Yigit wrote: Minutes 13 December 2018 Agenda: * Release Dates * Integration deadline * Subtrees * Bugzilla * OvS * Conferences * Opens Participants: * Arm * Broadcom * Debian * Intel * Mellanox * RedHat Release Dates - * v19

Re: [dpdk-dev] [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool

2018-12-13 Thread Pattan, Reshma
Hi > -Original Message- > From: Varghese, Vipin > Sent: Thursday, December 13, 2018 5:09 AM > To: Ananyev, Konstantin ; > step...@networkplumber.org; Pattan, Reshma ; > dev@dpdk.org; Mcnamara, John > Cc: tho...@monjalon.net; Byrne, Stephen1 ; > Patel, Amol ; Varghese, Vipin > > Subject:

Re: [dpdk-dev] [PATCH] Fix a memnory leak bug due to malloc unproperly.

2018-12-13 Thread Burakov, Anatoly
Hi Andy, The patch headline should say what the fix is for, e.g. raw/ifpga: fix this or that. If this is fixing a bug, a Fixes: tag should also be present, indicating the original commit that introduced the issue. If this issue is present in earlier releases, a Cc: sta...@dpdk.org should als

[dpdk-dev] DPDK Release Status Meeting 13/12/2018

2018-12-13 Thread Ferruh Yigit
Minutes 13 December 2018 Agenda: * Release Dates * Integration deadline * Subtrees * Bugzilla * OvS * Conferences * Opens Participants: * Arm * Broadcom * Debian * Intel * Mellanox * RedHat Release Dates - * v19.02 dates: * Integration deadline: December

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Burakov, Anatoly
On 13-Dec-18 1:46 PM, Liang, Ma wrote: 13 Dec 11:16, Burakov, Anatoly wrote: On 13-Dec-18 10:58 AM, Liang, Ma wrote: On 10 Dec 16:08, Burakov, Anatoly wrote: Hi Liang, General comment: please do not break up log strings onto multiple lines. It makes it harder to grep the codebase. Checkpat

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Liang, Ma
13 Dec 11:16, Burakov, Anatoly wrote: > On 13-Dec-18 10:58 AM, Liang, Ma wrote: > > On 10 Dec 16:08, Burakov, Anatoly wrote: > > > > > Hi Liang, > > > > > > General comment: please do not break up log strings onto multiple lines. > > > It > > > makes it harder to grep the codebase. Checkpatch w

[dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-13 Thread Jakub Grajciar
Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar --- config/common_base |5 + config/common_linuxapp |1 + doc/guides/nics/memif.rst | 80 ++ drivers/net

Re: [dpdk-dev] [PATCH v3 00/34] A new net PMD - ice

2018-12-13 Thread Varghese, Vipin
Hi Wenzhuo, Thanks for the update, couple of suggestion in my opinion shared below Snipped > > [PATCH v2 02/20] net/ice: support device initialization > > > +# Compile burst-oriented ICE PMD driver # > > CONFIG_RTE_LIBRTE_ICE_PMD=y > > > > Based on ' https://patches.dpdk.org/patch/48488/' it is s

Re: [dpdk-dev] [PATCH v3 9/9] test/ipsec: introduce functional test

2018-12-13 Thread Doherty, Declan
Can you add a note to the commit message that tests require the null crypto pmd to pass successfully, and also an ERR message in the test suite initialisation if no null pmd would be good. On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Create functional test for librte_ipsec. Signed-off-by:

[dpdk-dev] [PATCH v12 10/10] net/virtio: enable packed virtqueues by default

2018-12-13 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 5cf295418

[dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs

2018-12-13 Thread Jens Freimann
Until we have support for ctrl virtqueues let's disable it and exit if specified as a parameter. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_use

[dpdk-dev] [PATCH v12 08/10] net/virtio-user: add option to use packed queues

2018-12-13 Thread Jens Freimann
From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- .../net/virtio/virtio_user/virtio_user_dev.c | 18 ++ .../net/virtio/virtio_user/virtio_user_dev.h | 2 +- drivers/net/virtio/virtio_user_ethdev.c| 1

[dpdk-dev] [PATCH v12 07/10] net/virtio: add virtio send command packed queue support

2018-12-13 Thread Jens Freimann
Use packed virtqueue format when reading and writing descriptors to/from the ring. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt

[dpdk-dev] [PATCH v12 06/10] net/virtio: implement receive path for packed queues

2018-12-13 Thread Jens Freimann
Implement the receive part. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 61 +++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_rxtx.c | 385 - drivers/net/virtio/virtqueue.c | 22 ++

[dpdk-dev] [PATCH v12 04/10] net/virtio: dump packed virtqueue data

2018-12-13 Thread Jens Freimann
Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtqueue.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h inde

[dpdk-dev] [PATCH v12 03/10] net/virtio: add packed virtqueue helpers

2018-12-13 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h in

[dpdk-dev] [PATCH v12 02/10] net/virtio: add packed virtqueue defines

2018-12-13 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index e155eb17d..9ab007c11 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ri

[dpdk-dev] [PATCH v12 00/10] implement packed virtqueues

2018-12-13 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf A packed

[dpdk-dev] [PATCH v12 05/10] net/virtio: implement transmit path for packed queues

2018-12-13 Thread Jens Freimann
This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 54 --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 235 +

[dpdk-dev] [PATCH v12 01/10] net/virtio: vring init for packed queues

2018-12-13 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 36 +++--- drivers/net/virtio/virtio_pci.h| 7 drivers/net/virtio/virtio_ring.h | 60 ++ drivers/net/

Re: [dpdk-dev] [PATCH v3 02/34] net/ice: Add basic structures

2018-12-13 Thread Stillwell Jr, Paul M
The "ice_hw_autogen.h" file is an auto generated file from the HW engineers. It is not created dynamically when the driver is built. I'm not sure why they didn't call it ice_registers.h, but that was their decision. Paul -Original Message- From: Yigit, Ferruh Sent: Wednesday, December

Re: [dpdk-dev] [RFC 2/3] tqs: add thread quiescent state library

2018-12-13 Thread Burakov, Anatoly
On 11-Dec-18 6:40 AM, Honnappa Nagarahalli wrote: + +/* Add a reader thread, running on an lcore, to the list of +threads + * reporting their quiescent state on a TQS variable. + */ +int __rte_experimental +rte_tqs_register_lcore(struct rte_tqs *v, unsigned int lcore_id) { + TQS_RETURN_

[dpdk-dev] [PATCH] examples/ip_fragmentation: support bigger packets

2018-12-13 Thread Noa Ezra
Adding MTU and mbuf size configuration to the application's command line, in order to be able to receive all packet sizes by the NIC and DPDK application. The maximum transmission unit (MTU) is the largest size packet in bytes that can be sent on the network, therefore before adding MTU parameter,

Re: [dpdk-dev] [PATCH v3 8/9] ipsec: helper functions to group completed crypto-ops

2018-12-13 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH v3 7/9] ipsec: rework SA replay window/SQN for MT environment

2018-12-13 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window opera

Re: [dpdk-dev] [PATCH v1 2/4] examples/power: remove mask functions

2018-12-13 Thread Burakov, Anatoly
On 13-Dec-18 12:13 PM, Hunt, David wrote: Hi Anatoly, On 10/12/2018 12:30 PM, Burakov, Anatoly wrote: On 22-Nov-18 5:02 PM, David Hunt wrote: since we're moving to allowing greater than 64 cores, the mask functions that use uint64_t to perform functions on a masked set of cores are no longer f

Re: [dpdk-dev] [PATCH v1 2/4] examples/power: remove mask functions

2018-12-13 Thread Hunt, David
Hi Anatoly, On 10/12/2018 12:30 PM, Burakov, Anatoly wrote: On 22-Nov-18 5:02 PM, David Hunt wrote: since we're moving to allowing greater than 64 cores, the mask functions that use uint64_t to perform functions on a masked set of cores are no longer feasable, so removing them. Perhaps "neede

Re: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.

2018-12-13 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leonid Myravjev > Sent: Wednesday, December 5, 2018 8:35 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Leonid Myravjev > Subject: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added. > > Signed-off-

Re: [dpdk-dev] [PATCH v1 1/4] examples/power: change 64-bit masks to arrays

2018-12-13 Thread Hunt, David
Hi Anatoly, On 10/12/2018 12:18 PM, Burakov, Anatoly wrote: On 22-Nov-18 5:02 PM, David Hunt wrote: vm_power_manager currently makes use of uint64_t masks to keep track of cores in use, limiting use of the app to only being able to manage the first 64 cores in a multi-core system. Many modern s

  1   2   >