Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, December 13, 2018 5:10 PM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming > <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu, Jingjing > <jingjing...@intel.com> > Subject: RE: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > information > > > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Wednesday, December 12, 2018 3:00 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming > > <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu, > > Jingjing <jingjing...@intel.com> > > Subject: [dpdk-dev] [PATCH v3 18/34] net/ice: support getting device > > information > > > > Add ops dev_infos_get. > > > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > Signed-off-by: Qiming Yang <qiming.y...@intel.com> > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > > Signed-off-by: Jingjing Wu <jingjing...@intel.com> > > --- > > drivers/net/ice/ice_ethdev.c | 123 > > +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 123 insertions(+) > > > > > } > > + > > +static void > > +ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info > > +*dev_info) { > > + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > + struct ice_vsi *vsi = pf->main_vsi; > > + struct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(dev->device); > > + > > + dev_info->min_rx_bufsize = ICE_BUF_SIZE_MIN; > > + dev_info->max_rx_pktlen = ICE_FRAME_SIZE_MAX; > > + dev_info->max_rx_queues = vsi->nb_qps; > > + dev_info->max_tx_queues = vsi->nb_qps; > > + dev_info->max_mac_addrs = vsi->max_macaddrs; > > + dev_info->max_vfs = pci_dev->max_vfs; > > + > > + dev_info->rx_offload_capa = > > + DEV_RX_OFFLOAD_VLAN_STRIP | > > + DEV_RX_OFFLOAD_IPV4_CKSUM | > > + DEV_RX_OFFLOAD_UDP_CKSUM | > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > + DEV_RX_OFFLOAD_JUMBO_FRAME; > > I think we missed some offload here which ice driver does support > > Rx port offload > DEV_RX_OFFLOAD_KEEP_CRC > DEV_RX_OFFLOAD_SCATTER > DEV_RX_OFFLOAD_VLAN_FILTER > > Tx queue offload > DEV_TX_OFFLOAD_MBUF_FAST_FREE Thanks. Will add it in v4.
> > > + dev_info->tx_offload_capa = > > + DEV_TX_OFFLOAD_VLAN_INSERT | > > + DEV_TX_OFFLOAD_QINQ_INSERT | > > + DEV_TX_OFFLOAD_IPV4_CKSUM | > > + DEV_TX_OFFLOAD_UDP_CKSUM | > > + DEV_TX_OFFLOAD_TCP_CKSUM | > > + DEV_TX_OFFLOAD_SCTP_CKSUM | > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_TX_OFFLOAD_TCP_TSO; > > + dev_info->rx_queue_offload_capa = 0; > > + dev_info->tx_queue_offload_capa = 0; > > > +
