HI Reshma > -----Original Message----- > From: Pattan, Reshma > Sent: Thursday, December 13, 2018 8:13 PM > To: Varghese, Vipin <vipin.vargh...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; step...@networkplumber.org; > dev@dpdk.org; Mcnamara, John <john.mcnam...@intel.com> > Cc: tho...@monjalon.net; Byrne, Stephen1 <stephen1.by...@intel.com>; > Patel, Amol <amol.pa...@intel.com> > Subject: RE: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool > > Hi > > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Thursday, December 13, 2018 5:09 AM > > To: Ananyev, Konstantin <konstantin.anan...@intel.com>; > > step...@networkplumber.org; Pattan, Reshma > <reshma.pat...@intel.com>; > > dev@dpdk.org; Mcnamara, John <john.mcnam...@intel.com> > > Cc: tho...@monjalon.net; Byrne, Stephen1 <stephen1.by...@intel.com>; > > Patel, Amol <amol.pa...@intel.com>; Varghese, Vipin > > <vipin.vargh...@intel.com> > > Subject: [PATCH v7 0/9] app/proc-info: improve debug of proc-info tool > > > > This patch adds new debug functions to existing proc-info tool. > > > > Motivation > > ========== > > > > DPDK proc-info tool is been widely used as secondary process to > > collect stats for any primary process. But these are limited to DPDK > > NIC ports and basic memory usage. > > > > Motivation > > ========== > > > > This patch tries to address the short coming by adding debug for port, > > traffic manager, crypto, ring and mempool. With these additional > > information in tool will be able to deliver helpful data to debug issues and > performance variance. > > > > Status > > ====== > > > > With the following patch set debug data has been collected from > > customers using DPDK instances. Analysing the information helped to > > suggest the next debug steps and solutions for fixing the issues. > > > > Next Steps > > ========== > > > > - add event dev debug information. > > - enhance iter_mempool for INLINE crypto entries. > > - add debug for libraries like hash and acl. > > - explore debug possibility for ring and list. > > - add links and reference to 'how to guide' for 'debug and troubleshoot'. > > > > Patch set Information > > ===================== > > > > Patch includes set of 9 patches: > > * 0 : to introduce the debug function enhancement for proc-info > > * 1 : MACRO and help usage for new functions > > * 2 : string compare for new functions > > * 3 : invocation for the new prototypes > > * 4 : show port > > * 5 : show tm > > * 6 : show crypto > > * 7 : ring element debug > > * 8 : mempool element debug > > * 9 : iterate mempoool elements > > > > Small nits > 9th patch in this set is doc. So above info need to be corrected. > if you are addressing my earlier comment of separating out mempool element > iteration changes in to separate new patch 9/10 .Please keep my ack in next > version
Thanks for pointing this out, Like updated in email and chat I am not planning to split it. Hence no version 8. > > Reviewed-by: Reshma Pattan <reshma.pat...@intel.com> > Acked-by: Reshma Pattan <reshma.pat...@intel.com> > > > > >
