Hi Ferruh,
> -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, December 14, 2018 5:16 AM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 34/34] net/ice: support meson build > > On 12/12/2018 7:00 AM, Wenzhuo Lu wrote: > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > --- > > drivers/net/ice/base/meson.build | 30 > ++++++++++++++++++++++++++++++ > > drivers/net/ice/meson.build | 15 +++++++++++++++ > > drivers/net/meson.build | 1 + > > I think it is better to add meson file with on the patch Makefile added and > update in patches where required, instead of having a separate patch for it Discussed the same with Vipin, will change it. > > > 3 files changed, 46 insertions(+) > > create mode 100644 drivers/net/ice/base/meson.build create mode > > 100644 drivers/net/ice/meson.build > > > > diff --git a/drivers/net/ice/base/meson.build > > b/drivers/net/ice/base/meson.build > > new file mode 100644 > > index 0000000..5aafff3 > > --- /dev/null > > +++ b/drivers/net/ice/base/meson.build > > @@ -0,0 +1,30 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel > > +Corporation > > + > > +sources = [ > > + 'ice_controlq.c', > > + 'ice_common.c', > > + 'ice_sched.c', > > + 'ice_switch.c', > > + 'ice_nvm.c', > > ice_dcb.c? It is in base folder, isn't is compiled? Currently we don’t use it. Just leave it uncompiled. > > <...> > > > @@ -0,0 +1,15 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel > > +Corporation > > + > > +cflags += ['-DALLOW_EXPERIMENTAL_API'] > > Makefile doesn't have this flag, I guess it is not needed, base folder meson > file also has it. Thanks for the reminder. Will remove it.
