Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-23 Thread Wiles, Keith
> On Nov 19, 2018, at 10:45 PM, Zhang, Qi Z wrote: > > The patch optimizes the mac swap operation by taking advantage > of SSE instructions, it only impacts x86 platform. > > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > app/test-pmd/macswap.c | 16 +++- > 1 file change

Re: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance

2018-11-23 Thread Wiles, Keith
> On Nov 19, 2018, at 10:45 PM, Zhang, Qi Z wrote: > > The patch optimizes the mac swap operation by taking advantage > of SSE instructions, it only impacts x86 platform. > > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > app/test-pmd/macswap.c | 16 +++- > 1 file change

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Thomas Monjalon
23/11/2018 21:07, Kevin Traynor: > On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: > >> On 23.11.2018 18:41, Maxime Coquelin wrote: > >>> Hi, > >>> > >>> On 11/23/18 4:39 PM, Ilya Maximets wrote: > Patches primary targeted to fix OVS unit

Re: [dpdk-dev] [PATCH v3] dev: don't remove devargs that are still referenced

2018-11-23 Thread Stojaczyk, Dariusz
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, November 23, 2018 6:05 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: gaetan.ri...@6wind.com; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v3] dev: don't remove devargs that are stil

[dpdk-dev] [PATCH v2] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Darek Stojaczyk
When primary process receives an IPC attach request of a device that's already locally-attached, it doesn't setup its variables properly and is prone to segfaulting on a subsequent rollback. `ret = local_dev_probe(req->devargs, &dev)` The above function will set `dev` pointer to the proper device

Re: [dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Stojaczyk, Dariusz
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, November 23, 2018 8:11 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: tho...@monjalon.net > Subject: RE: [PATCH] dev: fix attach rollback of a device that was already > attached > > > > > -Original Message- > > From: S

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Kevin Traynor
On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: >> On 23.11.2018 18:41, Maxime Coquelin wrote: >>> Hi, >>> >>> On 11/23/18 4:39 PM, Ilya Maximets wrote: Patches primary targeted to fix OVS unit test failures with DPDK 18.11 due to following

Re: [dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request

2018-11-23 Thread Zhang, Qi Z
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Friday, November 23, 2018 6:11 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Stojaczyk, Dariusz ; > Zhang, Qi Z > Subject: [PATCH] dev: fix devargs memleak on IPC detach request > > Device detach triggered through IPC leaked so

Re: [dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Zhang, Qi Z
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Friday, November 23, 2018 6:45 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Stojaczyk, Dariusz ; > Zhang, Qi Z > Subject: [PATCH] dev: fix attach rollback of a device that was already > attached > > When primary process recei

Re: [dpdk-dev] [PATCH] dev: don't fail the hotplug request if device is attached in secondary

2018-11-23 Thread Zhang, Qi Z
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Friday, November 23, 2018 6:58 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Stojaczyk, Dariusz ; > Zhang, Qi Z > Subject: [PATCH] dev: don't fail the hotplug request if device is attached in > secondary > > Consider the follow

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Maxime Coquelin
On 11/23/18 4:39 PM, Ilya Maximets wrote: In case of running with not enough capabilities, i.e. running as non-root user any application linked with DPDK prints the message about IOPL call failure even if it was just called like './testpmd --help'. For example, this breaks most of the OVS unit

Re: [dpdk-dev] [PATCH v3 1/2] eal/bsd: fix possible IOPL fd leak

2018-11-23 Thread Maxime Coquelin
On 11/23/18 4:39 PM, Ilya Maximets wrote: If rte_eal_iopl_init() will be called more than once we'll leak the file descriptor. Fixes: b46fe31862ec ("eal/bsd: fix virtio on FreeBSD") Cc: sta...@dpdk.org Signed-off-by: Ilya Maximets --- lib/librte_eal/bsdapp/eal/eal.c | 6 -- 1 file ch

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Stephen Hemminger
On Fri, 23 Nov 2018 15:05:07 + "Varghese, Vipin" wrote: > > > > > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > > + > > > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Timothy Redaelli
On Fri, 23 Nov 2018 17:36:20 +0300 Ilya Maximets wrote: > In case of running with not enough capabilities, i.e. running as > non-root user any application linked with DPDK prints the message > about IOPL call failure even if it was just called like > './testpmd --help'. For example, this beaks mo

Re: [dpdk-dev] [PATCH v3] dev: don't remove devargs that are still referenced

2018-11-23 Thread Maxime Coquelin
Hi, On 11/23/18 4:43 PM, Darek Stojaczyk wrote: Even if a device failed to plug, it's still a device object that references the devargs. Those devargs will be freed automatically together with the device, but freeing them any earlier - like it's done in the hotplug error handling path right now

[dpdk-dev] [PATCH] mbuf: implement generic format for sched field

2018-11-23 Thread Jasvinder Singh
This patch implements the changes proposed in the deprecation notes [1][2]. The opaque mbuf->hash.sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. In addtion, following API functions of t

Re: [dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed mem structure

2018-11-23 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Nov 2018 12:46:42 + > From: "Burakov, Anatoly" > To: Shreyansh Jain , "dev@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed > mem structure > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100

Re: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array

2018-11-23 Thread Jerin Jacob
-Original Message- > Date: Thu, 15 Nov 2018 13:08:14 + > From: Shreyansh Jain > To: "dev@dpdk.org" > CC: Shreyansh Jain > Subject: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed > array > x-mailer: git-send-email 2.17.1 > > > rte_rawdevs is expected to be deprecate

Re: [dpdk-dev] [PATCH v2] doc: announce kvargs API change

2018-11-23 Thread Jerin Jacob
-Original Message- > Date: Thu, 22 Nov 2018 17:08:56 + > From: Ferruh Yigit > To: Olivier Matz , Thomas Monjalon > > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: announce kvargs API change > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 > Thu

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Maxime Coquelin
On 11/23/18 4:53 PM, Ilya Maximets wrote: On 23.11.2018 18:41, Maxime Coquelin wrote: Hi, On 11/23/18 4:39 PM, Ilya Maximets wrote: Patches primary targeted to fix OVS unit test failures with DPDK 18.11 due to following error: 'IOPL call failed - cannot use virtio PMD'. You mention

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Ilya Maximets
On 23.11.2018 18:41, Maxime Coquelin wrote: > Hi, > > On 11/23/18 4:39 PM, Ilya Maximets wrote: >> Patches primary targeted to fix OVS unit test failures with >> DPDK 18.11 due to following error: >> 'IOPL call failed - cannot use virtio PMD'. > > You mention v18.11, do you mean this is a re

[dpdk-dev] [PATCH v3] dev: don't remove devargs that are still referenced

2018-11-23 Thread Darek Stojaczyk
Even if a device failed to plug, it's still a device object that references the devargs. Those devargs will be freed automatically together with the device, but freeing them any earlier - like it's done in the hotplug error handling path right now - will give us a dangling pointer and a segfault sc

Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Jozwiak, TomaszX
> -Original Message- > From: Richardson, Bruce > Sent: Friday, November 23, 2018 4:25 PM > To: Varghese, Vipin > Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; shally.ve...@cavium.com; > akhil.go...@nxp.com > Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser >

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Maxime Coquelin
Hi, On 11/23/18 4:39 PM, Ilya Maximets wrote: Patches primary targeted to fix OVS unit test failures with DPDK 18.11 due to following error: 'IOPL call failed - cannot use virtio PMD'. You mention v18.11, do you mean this is a regression? We can avoid test failures in OVS by filtering

[dpdk-dev] [PATCH v3 2/2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Ilya Maximets
In case of running with not enough capabilities, i.e. running as non-root user any application linked with DPDK prints the message about IOPL call failure even if it was just called like './testpmd --help'. For example, this breaks most of the OVS unit tests if it built with DPDK support. Let's re

[dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-23 Thread Ilya Maximets
Patches primary targeted to fix OVS unit test failures with DPDK 18.11 due to following error: 'IOPL call failed - cannot use virtio PMD'. We can avoid test failures in OVS by filtering the output like this: https://patchwork.ozlabs.org/project/openvswitch/list/?series=77706 but it still loo

[dpdk-dev] [PATCH v3 1/2] eal/bsd: fix possible IOPL fd leak

2018-11-23 Thread Ilya Maximets
If rte_eal_iopl_init() will be called more than once we'll leak the file descriptor. Fixes: b46fe31862ec ("eal/bsd: fix virtio on FreeBSD") Cc: sta...@dpdk.org Signed-off-by: Ilya Maximets --- lib/librte_eal/bsdapp/eal/eal.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Varghese, Vipin
Thank you for the update

Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Bruce Richardson
On Fri, Nov 23, 2018 at 03:10:51PM +, Varghese, Vipin wrote: > > > > +#define MAX_DRIVER_NAME64 > > +#define MAX_INPUT_FILE_NAME64 > > > > > +comp_perf_options_check(struct comp_test_data *test_data) { > > + if (strcmp(test_data->driver_name, "") == 0) { > > Should w

Re: [dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Jozwiak, TomaszX
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 4:00 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; Jozwiak, TomaszX > ; shally.ve...@cavium.com; > akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files > >

Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Varghese, Vipin
> +#define MAX_DRIVER_NAME 64 > +#define MAX_INPUT_FILE_NAME 64 > +comp_perf_options_check(struct comp_test_data *test_data) { > + if (strcmp(test_data->driver_name, "") == 0) { Should we use strncmp for boundary? > + RTE_LOG(ERR, USER1, "Driver name has to be s

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > + > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > > > > Check is done for 'if either ret is not 0 or if it ret is 0 > > > > > > but

Re: [dpdk-dev] [PATCH v2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread David Marchand
On Fri, Nov 23, 2018 at 3:36 PM Ilya Maximets wrote: > In case of running with not enough capabilities, i.e. running as > non-root user any application linked with DPDK prints the message > about IOPL call failure even if it was just called like > './testpmd --help'. For example, this beaks most

Re: [dpdk-dev] [PATCH v3 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Jozwiak, TomaszX
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 3:53 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; Jozwiak, TomaszX > ; shally.ve...@cavium.com; > akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH v3 3/5] doc/guides/tools: add doc files > >

Re: [dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Varghese, Vipin
Apologies Tomasz, I shared my comments in v3. sharing for v4 > Crypto performance test application > M: Declan Doherty > F: app/test-crypto-perf/ > diff --git a/doc/guides/rel_notes/release_18_11.rst > b/doc/guides/rel_notes/release_18_11.rst > index 32ff0e5..d44cf30 100644 > --- a/doc/guides/

[dpdk-dev] [PATCH] dev: don't fail the hotplug request if device is attached in secondary

2018-11-23 Thread Darek Stojaczyk
Consider the following scenario: 1) primary process (A) starts, probes the bus 2) a secondary process (B) starts, probes the bus 3) yet another secondary process (C) starts 4) (C) registers the pci driver and hotplugs the device * an IPC attach req is sent to the primary (A) * (A) ig

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 1:56 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH v3 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Varghese, Vipin
Hi Tomasz, > +dpdk-test-compress-perf Application > +=== > + Suggestion to remove extra '=' > +The ``dpdk-test-compress-perf`` tool is a Data Plane Development Kit > +(DPDK) utility that allows measuring performance parameters of PMDs Is this test application o

[dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Darek Stojaczyk
When primary process receives an IPC attach request of a device that's already locally-attached, it doesn't setup its variables properly and is prone to segfaulting on a subsequent rollback. `ret = local_dev_probe(req->devargs, &dev)` The above function will set `dev` pointer to the proper device

Re: [dpdk-dev] [PATCH v2] lib/efd: fix to free tail queue entry after use

2018-11-23 Thread Maxime Coquelin
On 11/23/18 2:30 PM, Maxime Coquelin wrote: On 11/14/18 12:17 PM, Hari Kumar Vemula wrote: In rte_efd_create() allocated memory for tail queue entry but not freed. Added freeing the tail queue entry. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH v2] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Ilya Maximets
In case of running with not enough capabilities, i.e. running as non-root user any application linked with DPDK prints the message about IOPL call failure even if it was just called like './testpmd --help'. For example, this beaks most of the OVS unit tests if it built with DPDK support. Let's reg

[dpdk-dev] [PATCH v4 4/5] app/compress-perf: add dynamic compression test

2018-11-23 Thread Tomasz Jozwiak
Added dynamic compression feature into compression perf. test. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 6 +- doc/guides/rel_notes/release_18_11.rst | 3 +-- doc/guides/tools/comp_perf.rst | 4 ++-- 3 files changed,

[dpdk-dev] [PATCH v4 5/5] app/compress-perf: code refactoring

2018-11-23 Thread Tomasz Jozwiak
Code refactoring to separate validation from benchmarking part. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 2 + app/test-compress-perf/comp_perf_options.h| 12 + app/test-compress-perf/comp_perf_test_benchmark.c | 292 + app/t

[dpdk-dev] [PATCH v4 2/5] app/compress-perf: add performance measurement

2018-11-23 Thread Tomasz Jozwiak
Added performance measurement part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 8 +- app/test-compress-perf/main.c| 886 ++- 2 files changed, 883

[dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Tomasz Jozwiak
Added parser part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/Makefile | 4 + app/meson.build | 1 + app/test-compress-perf/Makefile | 16 + app

[dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Tomasz Jozwiak
Added: - initial version of compression performance test description file. - release note in release_18_11.rst Updated index.rst file Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- MAINTAINERS| 5 +++ doc/guides/rel_notes/release_18_

[dpdk-dev] [PATCH v4 0/5] add initial version of compress-perf

2018-11-23 Thread Tomasz Jozwiak
This patchset adds initial version of compression performance test. v4 changes: - fixed checkpatch issues - code cleanup Note: The 19.02 release notes will be updated once the file has been created v3 changes: - Added dynamic compression - Code refactoring to separate validation fr

[dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request

2018-11-23 Thread Darek Stojaczyk
Device detach triggered through IPC leaked some memory. It allocated a devargs objects just to use it for parsing the devargs string in order to retrieve the device name. Those devargs weren't passed anywhere and were never freed. First of all, let's put those devargs on the stack, so they doesn't

[dpdk-dev] [PATCH] net/virtio: avoid annoying IOPL call related errors

2018-11-23 Thread Ilya Maximets
In case of running with not enough capabilities, i.e. running as non-root user any application linked with DPDK prints the message about IOPL call failure even if it was just called like './testpmd --help'. For example, this beaks most of the OVS unit tests if it built with DPDK support. Let's reg

[dpdk-dev] [PATCH] crypto/aesni_mb: use of archtecture independent macros

2018-11-23 Thread Fan Zhang
This patch updates the aesni_mb to use IMB_* arch independent macros to reduce the code size and future maintaining effort. Signed-off-by: Fan Zhang --- This patch targets 19.02 release drivers/crypto/aesni_mb/aesni_mb_ops.h | 302 - drivers/crypto/aesni_mb/rte_a

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> -Original Message- > From: Pattan, Reshma > Sent: Friday, November 23, 2018 7:04 PM > To: Varghese, Vipin ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed mem structure

2018-11-23 Thread Maxime Coquelin
On 11/15/18 2:29 PM, Shreyansh Jain wrote: rte_dpaa2_memsegs is no more required once the dpaax (pa-va) translation library has been introduced. This can be made internal (for fallback operations) in subsequent release. Signed-off-by: Shreyansh Jain --- This diff was generated over a previ

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Friday, November 23, 2018 1:29 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/pro

Re: [dpdk-dev] [PATCH v2] lib/efd: fix to free tail queue entry after use

2018-11-23 Thread Maxime Coquelin
On 11/14/18 12:17 PM, Hari Kumar Vemula wrote: In rte_efd_create() allocated memory for tail queue entry but not freed. Added freeing the tail queue entry. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Hari Kumar Vemula Acked-by: Reshma

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Varghese, Vipin
> -Original Message- > From: Pattan, Reshma > Sent: Friday, November 23, 2018 5:21 PM > To: Varghese, Vipin ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/proc

Re: [dpdk-dev] [PATCH] vfio: don't needlessly setup devices in secondary process

2018-11-23 Thread Maxime Coquelin
On 11/21/18 7:41 PM, Darek Stojaczyk wrote: Setting up a device that wasn't setup in the primary process will possibly break the primary process. That's because the IPC message to retrieve the group fd in the primary will also *open* that group if it wasn't opened before. Even though the secon

Re: [dpdk-dev] [PATCH] doc: announce kvargs API change

2018-11-23 Thread Maxime Coquelin
On 11/21/18 4:45 PM, Thomas Monjalon wrote: In some usages, kvlist is processed one time in rte_kvargs_process(), and it is processed a second time if need to check whether it was matched. In order to simplify implementation of kvargs checks, a new callback may be used for "no match" cases. T

[dpdk-dev] [PATCH v3 5/5] app/compress-perf: code refactoring

2018-11-23 Thread Tomasz Jozwiak
Code refactoring to separate validation from benchmarking part. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 2 + app/test-compress-perf/comp_perf_options.h| 12 + app/test-compress-perf/comp_perf_test_benchmark.c | 291 + app/t

[dpdk-dev] [PATCH v3 3/5] doc/guides/tools: add doc files

2018-11-23 Thread Tomasz Jozwiak
Added: - initial version of compression performance test description file. - release note in release_18_11.rst Updated index.rst file Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- MAINTAINERS| 5 +++ doc/guides/rel_notes/release_18_

[dpdk-dev] [PATCH v3 4/5] app/compress-perf: add dynamic compression test

2018-11-23 Thread Tomasz Jozwiak
Added dynamic compression feature into compression perf. test. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 6 +- doc/guides/rel_notes/release_18_11.rst | 3 +-- doc/guides/tools/comp_perf.rst | 4 ++-- 3 files changed,

[dpdk-dev] [PATCH v3 1/5] app/compress-perf: add parser

2018-11-23 Thread Tomasz Jozwiak
Added parser part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/Makefile | 4 + app/meson.build | 1 + app/test-compress-perf/Makefile | 16 + app

[dpdk-dev] [PATCH v3 2/5] app/compress-perf: add performance measurement

2018-11-23 Thread Tomasz Jozwiak
Added performance measurement part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 8 +- app/test-compress-perf/main.c| 886 ++- 2 files changed, 883

[dpdk-dev] [PATCH v3 0/5] add initial version of compress-perf

2018-11-23 Thread Tomasz Jozwiak
This patchset adds initial version of compression performance test. v3 changes: - Added dynamic compression - Code refactoring to separate validation from benchmarking part - Updated documentation - Added fail detection from rte_compressdev_enqueue_burst and rte_compressdev_dequeue

Re: [dpdk-dev] [PATCH] doc: announce deprecation of dpaa2 exposed mem structure

2018-11-23 Thread Burakov, Anatoly
On 15-Nov-18 1:29 PM, Shreyansh Jain wrote: rte_dpaa2_memsegs is no more required once the dpaax (pa-va) translation library has been introduced. This can be made internal (for fallback operations) in subsequent release. Signed-off-by: Shreyansh Jain --- This diff was generated over a previou

[dpdk-dev] [PATCH] crypto/openssl: Remove if condition prior to BN_free

2018-11-23 Thread Akash Saxena
Remove if() condition prior to calling BN_free() as BN_free(a) does nothing if a is NULL. Signed-off-by: Akash Saxena Signed-off-by: Shally Verma --- drivers/crypto/openssl/rte_openssl_pmd.c | 21 + drivers/crypto/openssl/rte_openssl_pmd_ops.c | 45 ++--

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-23 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, November 22, 2018 1:28 PM > To: Pattan, Reshma ; dev@dpdk.org; > tho...@monjalon.net; step...@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol > Subject: RE: [PATCH v4 5/9] app/p

[dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-11-23 Thread Liang Ma
Previously, in order to use the power library, it was necessary for the user to disable the intel_pstate driver by adding “intel_pstate=disable” to the kernel command line for the system, which causes the acpi_cpufreq driver to be loaded in its place. This patch adds the ability for the power libr

[dpdk-dev] 19.02 Intel Roadmap

2018-11-23 Thread O'Driscoll, Tim
As discussed at yesterday's Release Status Meeting, we need to update our Roadmap page (http://core.dpdk.org/roadmap/) for 19.02. The features that we plan to contribute are described below. We'll submit a patch to update the roadmap page with this info. vDPA Live Migration Software Fallback:

Re: [dpdk-dev] [PATCH] bus/pci: fix allocation of PCI device path

2018-11-23 Thread Maxime Coquelin
On 11/23/18 1:29 AM, Ferruh Yigit wrote: The pci_resource_by_index called strlen() on uninitialized memory which would lead to the wrong size of memory allocated for the path portion of the resource map. This would either cause excessively large allocation, or worse memory corruption. Coverit

Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice

2018-11-23 Thread Thomas Monjalon
Hi Wenzhuo, 23/11/2018 07:56, Wenzhuo Lu: > net/ice: add base code This first patch is really too big. Please could you try to split it logically?

Re: [dpdk-dev] [PATCH] bus/pci: fix allocation of PCI device path

2018-11-23 Thread Andrew Rybchenko
On 11/23/18 1:45 PM, Thomas Monjalon wrote: Please, anyone for a review and a test? 23/11/2018 01:29, Ferruh Yigit: The pci_resource_by_index called strlen() on uninitialized memory which would lead to the wrong size of memory allocated for the path portion of the resource map. This would eithe

Re: [dpdk-dev] [PATCH v2] doc: document all EAL parameters in one place

2018-11-23 Thread Thomas Monjalon
19/11/2018 14:10, Anatoly Burakov: > Currently, the most complete (but still incomplete) user guide for > EAL command-line parameters resides in user guide for testpmd. > This is wrong on multiple levels, and should not be the case. > > To fix it, we have to create a document that lists all suppor

Re: [dpdk-dev] [PATCH] bus/pci: fix allocation of PCI device path

2018-11-23 Thread Thomas Monjalon
Please, anyone for a review and a test? 23/11/2018 01:29, Ferruh Yigit: > The pci_resource_by_index called strlen() on uninitialized > memory which would lead to the wrong size of memory allocated > for the path portion of the resource map. This would either cause > excessively large allocation, o

Re: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting

2018-11-23 Thread Varghese, Vipin
HI Wenzhou, Following is a thought but not an issue. Can you please let me know your thought? > +static int > +ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + struct rte_eth_dev_data *dev_data = pf->dev_dat

Re: [dpdk-dev] [PATCH v2] doc: document all EAL parameters in one place

2018-11-23 Thread Thomas Monjalon
23/11/2018 10:20, Burakov, Anatoly: > On 22-Nov-18 5:27 PM, Thomas Monjalon wrote: > > 19/11/2018 14:10, Anatoly Burakov: > >> --- /dev/null > >> +++ b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst > >> @@ -0,0 +1,20 @@ > >> +.. SPDX-License-Identifier: BSD-3-Clause > >> +Copyright(c) 2018

Re: [dpdk-dev] [PATCH v2] devbind: don't display non-existent device categories

2018-11-23 Thread Burakov, Anatoly
On 22-Nov-18 5:12 PM, Thomas Monjalon wrote: 19/11/2018 11:33, Anatoly Burakov: If there aren't any devices of a particular category on user's system, we still display them, which is bad for usability. Fix devbind to not print out a category unless there are devices in it. Signed-off-by: Anatol

Re: [dpdk-dev] [PATCH v2] doc: document all EAL parameters in one place

2018-11-23 Thread Burakov, Anatoly
On 22-Nov-18 5:27 PM, Thomas Monjalon wrote: 19/11/2018 14:10, Anatoly Burakov: --- /dev/null +++ b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst @@ -0,0 +1,20 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright(c) 2018 Intel Corporation. + +EAL parameters +== + +This do

Re: [dpdk-dev] [PATCH] ethdev: fix memory leak on removing eth rxtx callback

2018-11-23 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 21, 2018 2:49 PM > To: wanlebing ; dev@dpdk.org; Ananyev, Konstantin > > Cc: wanlebing > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix memory leak on removing eth rxtx > callback > > On 11/21/2018 1:11 PM, wanlebing

Re: [dpdk-dev] [PATCH] vfio: don't needlessly setup devices in secondary process

2018-11-23 Thread Burakov, Anatoly
On 21-Nov-18 6:41 PM, Darek Stojaczyk wrote: Setting up a device that wasn't setup in the primary process will possibly break the primary process. That's because the IPC message to retrieve the group fd in the primary will also *open* that group if it wasn't opened before. Even though the seconda

[dpdk-dev] [PATCH] fix repopulation of tx_mbufs table

2018-11-23 Thread Rafal Kozik
If in one TX cycle NIC does not send any packet, pktgen tries to allocate 0 mbufs from pool. In such case DPDK return error and packets will not be send. As no packet will be send in next iteration this situation will repeat. Checking if taking more mbufs is needed will prevent this situation. Fi

Re: [dpdk-dev] [PATCH v1 1/1] doc: announce ethdev ABI change for rte_eth_dev_info.

2018-11-23 Thread Andrew Rybchenko
On 11/22/18 9:27 PM, Ferruh Yigit wrote: On 11/22/2018 12:09 PM, Ian Stokes wrote: Maximum and minimum MTU values vary between hardware devices. In hardware agnostic DPDK applications access to such information would allow a more accurate way of validating and setting supported MTU values on a p

[dpdk-dev] [PATCH v2] mlx5: Report imissed stat

2018-11-23 Thread Tom Barbette
The imissed counters (number of packets dropped because the queues were full) were actually reported through xstats as "rx_out_of_buffer" but was not reported through stats. Following a recent discussion on the ML, as there is no way to tell the user if a counter is implemented or not, this should