Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

[Jozwiak, TomaszX]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, November 23, 2018 4:25 PM
> To: Varghese, Vipin <vipin.vargh...@intel.com>
> Cc: Jozwiak, TomaszX <tomaszx.jozw...@intel.com>; dev@dpdk.org; Trahe,
> Fiona <fiona.tr...@intel.com>; shally.ve...@cavium.com;
> akhil.go...@nxp.com
> Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser
> 
> On Fri, Nov 23, 2018 at 03:10:51PM +0000, Varghese, Vipin wrote:
> > <snipped>
> >
> > > +#define MAX_DRIVER_NAME          64
> > > +#define MAX_INPUT_FILE_NAME      64
> >
> > <snipped>
> >
> > > +comp_perf_options_check(struct comp_test_data *test_data) {
> > > + if (strcmp(test_data->driver_name, "") == 0) {
> >
> > Should we use strncmp for boundary?
> >
> Shouldn't be necessary here, but a better check might be just to check if
> test_data->driver_name[0] == '\0'. No need to use a string function for
> checking for an empty string.
> 
> /Bruce


True Bruce :D , thx, will update these lines.