[dpdk-dev] [PATCH v4 4/4] vfio: enable vfio hotplug by req notifier handler

2018-10-03 Thread Jeff Guo
When device is be hot-unplugged, the vfio kernel module will sent req notifier to request user space to release the allocated resources at first. After that, vfio kernel module will detect the device disappear, and then delete the device in kernel. This patch aim to add req notifier processing to

[dpdk-dev] [PATCH v4 3/4] pci: add req handler field to generic pci device

2018-10-03 Thread Jeff Guo
There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, they could be useful for device error monitoring. And these corresponding interrupt handler is different from the other interrupt handler that register in PMDs, so a new int

[dpdk-dev] [PATCH v4 2/4] eal: modify device event callback process func

2018-10-03 Thread Jeff Guo
This patch modify the device event callback process function name to be more explicit, change the variable to be const. And more, because not only eal device helper will use the callback, but also vfio bus will use the callback to handle hot-unplug, so exposure the API out from private eal. The bus

[dpdk-dev] [PATCH v4 0/4] Enable hotplug in vfio

2018-10-03 Thread Jeff Guo
As we may know that the process of hotplug is different between igb_uio and vfio. For igb_uio, it could use uevent notification and memory failure handle mechanism for hot-unplug. But for vfio, when device is be hot-unplugged, the uevent can not be detected immediately, because of the vfio kernel m

[dpdk-dev] [PATCH v4 1/4] eal: add a new req notifier to eal interrupt

2018-10-03 Thread Jeff Guo
Add a new req notifier in eal interrupt for enable vfio hotplug. Signed-off-by: Jeff Guo --- v4->v3: no change. --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++ 2 files changed, 72 insertions(+) diff -

[dpdk-dev] [PATCH v13 7/7] app/testpmd: use hotplug failure handler

2018-10-03 Thread Jeff Guo
This patch use testpmd for example, to show how an app smoothly handle failure when device be hot-unplug. Except that app should enabled the device event monitor and register the hotplug event’s callback, it also need enable hotplug handle mechanism before running. Once app detect the removal event

[dpdk-dev] [PATCH v13 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-03 Thread Jeff Guo
The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure of the corresponding device by invoke the hot-unplug handler. It could prevent the applicat

[dpdk-dev] [PATCH v13 4/7] bus/pci: implement sigbus handler ops

2018-10-03 Thread Jeff Guo
This patch implements the ops for the PCI bus sigbus handler. It finds the PCI device that is being hot-unplugged and calls the relevant ops of the hot-unplug handler to handle the hot-unplug failure of the device. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v13->v12: use local variable to

[dpdk-dev] [PATCH v13 5/7] bus: add helper to handle sigbus

2018-10-03 Thread Jeff Guo
This patch aims to add a helper to iterate over all buses to find the relevant bus to handle the sigbus error. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v13->v12: no change. --- lib/librte_eal/common/eal_common_bus.c | 43 ++ lib/librte_eal/common/eal_pri

[dpdk-dev] [PATCH v13 3/7] bus: add sigbus handler

2018-10-03 Thread Jeff Guo
When a device is hot-unplugged, a sigbus error will occur of the datapath can still read/write to the device. A handler is required here to capture the sigbus signal and handle it appropriately. This patch introduces a bus ops to handle sigbus errors. Each bus can implement its own case-dependent

[dpdk-dev] [PATCH v13 2/7] bus/pci: implement hot-unplug handler ops

2018-10-03 Thread Jeff Guo
This patch implements the ops to handle hot-unplug on the PCI bus. For UIO PCI, it could avoids BARs read/write errors by creating a new dummy memory to remap the memory where the failure is. For VFIO or other kernel driver, it could specific implement function to handle hot-unplug case by case. S

[dpdk-dev] [PATCH v13 0/7] hot-unplug failure handle mechanism

2018-10-03 Thread Jeff Guo
Hotplug is an important feature for use-cases like the datacenter device's fail-safe and for SRIOV Live Migration in SDN/NFV. It could bring higher flexibility and continuality to networking services in multiple use-cases in the industry. So let's see how DPDK can help users implement hotplug solut

[dpdk-dev] [PATCH v13 1/7] bus: add hot-unplug handler

2018-10-03 Thread Jeff Guo
A hot-unplug failure and app crash can be caused, when a device is hot-unplugged but the application still try to access the device by reading or writing from the BARs, which is already invalid but still not timely be unmap or released. This patch introduces bus ops to handle hot-unplug failures.

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Jerin Jacob
-Original Message- > Date: Wed, 3 Oct 2018 22:47:15 +0300 > From: Andrew Rybchenko > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Olivier Matz , > dev@dpdk.org, shah...@mellanox.com, "A

[dpdk-dev] [PATCH v2] net/mlx5: fix Direct Verbs flow matcher caching

2018-10-03 Thread Ori Kam
The Direct Verbs are using matcher object to filter flows, This object can be reused for all flows that are using the same flow items and masks. This was implemented with an issue, that the list pointer pointed to incorrect list type, this resulted in compilation error when using GCC greater then

Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-03 Thread Ilya Maximets
On 03.10.2018 17:49, Maxime Coquelin wrote: > > > On 10/03/2018 03:26 PM, Ilya Maximets wrote: >> On 02.10.2018 12:36, Maxime Coquelin wrote: >>> VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE >>> and VHOST_USER_SET_LOG_BASE require replies, so their handlers >>> should return VH_RES

Re: [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-03 Thread Ilya Maximets
On 03.10.2018 17:39, Maxime Coquelin wrote: > > > On 10/03/2018 11:07 AM, Ilya Maximets wrote: >> On 03.10.2018 11:32, Ilya Maximets wrote: >>> On 03.10.2018 11:02, Maxime Coquelin wrote: On 10/03/2018 09:57 AM, Ilya Maximets wrote: > On 03.10.2018 10:50, Maxime Coquelin wrote:

Re: [dpdk-dev] [PATCH v3 4/4] vfio: enable vfio hotplug by req notifier handler

2018-10-03 Thread Jeff Guo
On 10/2/2018 10:15 PM, Burakov, Anatoly wrote: On 02-Oct-18 1:58 PM, Jeff Guo wrote: When device is be hot-unplugged, the vfio kernel module will sent req notifier to request user space to release the allocated resources at first. After that, vfio kernel module will detect the device disappear

Re: [dpdk-dev] [PATCH v12 4/7] bus/pci: implement sigbus handler ops

2018-10-03 Thread Jeff Guo
On 10/2/2018 10:39 PM, Burakov, Anatoly wrote: On 02-Oct-18 1:35 PM, Jeff Guo wrote: This patch implements the ops for the PCI bus sigbus handler. It finds the PCI device that is being hot-unplugged and calls the relevant ops of the hot-unplug handler to handle the hot-unplug failure of the d

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-03 Thread Honnappa Nagarahalli
> > > >-Original Message- > > >From: Van Haaren, Harry > > >> > > > > /** > > >> > > > > * Add a key to an existing hash table. > > >> > > > >@@ -222,7 +222,7 @@ rte_hash_add_key(const struct rte_hash > > >> > > > >*h, const void > > >> > > *key); > > >> > > > > * array of user data.

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-03 Thread Honnappa Nagarahalli
> > > >> >-Original Message- > >> >From: Van Haaren, Harry > >> >> > > > > /** > >> >> > > > > * Add a key to an existing hash table. > >> >> > > > >@@ -222,7 +222,7 @@ rte_hash_add_key(const struct rte_hash > >> >> > > > >*h, const void > >> >> > > *key); > >> >> > > > > * array of u

Re: [dpdk-dev] [PATCH v12 3/7] bus: add sigbus handler

2018-10-03 Thread Jeff Guo
On 10/2/2018 10:32 PM, Burakov, Anatoly wrote: On 02-Oct-18 1:35 PM, Jeff Guo wrote: When a device is hot-unplugged, a sigbus error will occur of the datapath can still read/write to the device. A handler is required here to capture the sigbus signal and handle it appropriately. This patch

Re: [dpdk-dev] [PATCH v12 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-03 Thread Jeff Guo
On 10/2/2018 11:53 PM, Burakov, Anatoly wrote: On 02-Oct-18 1:35 PM, Jeff Guo wrote: The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure o

Re: [dpdk-dev] [PATCH v12 7/7] testpmd: use hot-unplug failure handle mechanism

2018-10-03 Thread Jeff Guo
hi, bernard thanks for your review, comment as below. On 10/2/2018 11:21 PM, Iremonger, Bernard wrote: Hi Jeff, Subject: [PATCH v12 7/7] testpmd: use hot-unplug failure handle mechanism ./devtools/check-git-log.sh -1 Wrong headline label: testpmd: use hot-unplug failure handle me

[dpdk-dev] [PATCH] fix static variables

2018-10-03 Thread Ferruh Yigit
Make variables static as much as possible. For the ones can't be done static, prefix the variable name with component name. Also some cleanup and fix done related static usage while around. Signed-off-by: Ferruh Yigit --- app/pdump/main.c | 6 +-- drivers/bus/dpaa

Re: [dpdk-dev] [PATCH v12 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-03 Thread Jeff Guo
On 10/2/2018 9:34 PM, Ananyev, Konstantin wrote: Hi Jeff, Looks ok to me in general, just one thing I missed before: +static void sigbus_handler(int signum, siginfo_t *info, + void *ctx __rte_unused) +{ + int ret; + + RTE_LOG(INFO, EAL, "Thread[%d] c

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask

2018-10-03 Thread Hu, Jiayu
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 6:52 PM > To: Olivier Matz > Cc: dev@dpdk.org; Jerin Jacob ; > sta...@dpdk.org; Hu, Jiayu > Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask > > Fixes missing

Re: [dpdk-dev] [PATCH v4 2/4] hash: add extendable bucket feature

2018-10-03 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> >-Original Message- >> >From: Stephen Hemminger [mailto:step...@networkplumber.org] >> >On Fri, 28 Sep 2018 10:23:44 -0700 >> >Yipeng Wang wrote: >> > >> >> + /* clear free extendable bucket ri

Re: [dpdk-dev] [PATCH v5 0/4] hash: add extendable bucket and partial key hashing

2018-10-03 Thread Wang, Yipeng1
>> -- >> 2.7.4 >> >Acked-by: Dharmik Thakkar [Wang, Yipeng] Thanks for testing, Dharmik!

Re: [dpdk-dev] [PATCH] net/mlx5: flow counters support on the Linux-rdma v19 base

2018-10-03 Thread Yongseok Koh
On Wed, Oct 03, 2018 at 03:29:12PM +, Slava Ovsiienko wrote: > Mellanox mlx5 PMD supports Flow Counters via Verbs library. > The current implementation is based on the Mellanox proprietary > Verbs library included in MLNX OFED packages. The Flow Counter > support is recently added into linux-rd

[dpdk-dev] [PATCH v5 5/5] eal: simplify parameters of hotplug functions

2018-10-03 Thread Thomas Monjalon
All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex and support matching multiple devices in one st

[dpdk-dev] [PATCH v5 4/5] eal: remove experimental flag of hotplug functions

2018-10-03 Thread Thomas Monjalon
These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- lib/librte_

[dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure

2018-10-03 Thread Thomas Monjalon
When a device is added with a devargs (hotplug or whitelist), the bus pointer can be retrieved via its devargs. But there is no such devargs.bus in case of standard scan. A pointer to the rte_bus handle is added to rte_device. When a device is allocated (during a scan), the pointer to its bus is a

[dpdk-dev] [PATCH v5 1/5] devargs: remove deprecated functions

2018-10-03 Thread Thomas Monjalon
rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it was renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their implementation body renamed. All these functions were

[dpdk-dev] [PATCH v5 2/5] devargs: simplify parameters of removal function

2018-10-03 Thread Thomas Monjalon
The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future. Signed-off-by: Thomas Monjalon Reviewed-by:

[dpdk-dev] [PATCH v5 0/5] eal: simplify devargs and hotplug functions

2018-10-03 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprec

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-03 Thread Ola Liljedahl
On 03/10/2018, 20:00, "Wang, Yipeng1" wrote: >-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, October 3, 2018 10:33 AM >To: Wang, Yipeng1 ; Van Haaren, Harry ; Richardson, Bruce > >Cc: De Lara Gua

Re: [dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

2018-10-03 Thread Thomas Monjalon
28/09/2018 17:25, Bruce Richardson: > On Wed, Aug 29, 2018 at 12:56:14PM +0100, Anatoly Burakov wrote: > > This patchset fixes numerous issues with musl compatibility > > in the core EAL libraries. It does not fix anything beyond > > core EAL (so, PCI driver is still broken, so are a few other > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix matcher caching

2018-10-03 Thread Yongseok Koh
On Wed, Oct 03, 2018 at 01:23:40PM -0700, Ori Kam wrote: > The Direct Verbs are using matcher object to filter flows, This object > can be reused for all flows that are using the same flow items and > masks. > > This was implemented with an issue, that the list pointer pointed > to incorrect list

Re: [dpdk-dev] [PATCH v3] pci/vfio: allow mapping MSI-X BARs if kernel allows it

2018-10-03 Thread Thomas Monjalon
20/09/2018 15:11, Anatoly Burakov: > Currently, DPDK will skip mapping some areas (or even an entire BAR) > if MSI-X table happens to be in them but is smaller than page size. > > Kernels 4.16+ will allow mapping MSI-X BARs [1], and will report this > as a capability flag. Capability flags themsel

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: fix undefined behavior in NUMA code

2018-10-03 Thread Thomas Monjalon
21/09/2018 13:02, Ilya Maximets: > On 21.09.2018 12:27, Anatoly Burakov wrote: > > When NUMA-aware hugepages config option is set, we rely on > > libnuma to tell the kernel to allocate hugepages on a specific > > NUMA node. However, we allocate node mask before we check if > > NUMA is available in

Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config

2018-10-03 Thread Thomas Monjalon
20/09/2018 17:41, Anatoly Burakov: > Currently, command-line switches for legacy mem mode or single-file > segments mode are only stored in internal config. This leads to a > situation where these flags have to always match between primary > and secondary, which is bad for usability. > > Fix this

[dpdk-dev] [PATCH v3 3/3] doc: document --iova-mode EAL option

2018-10-03 Thread eric zhang
This patch updates Programmer's Guide and EAL parameter guides to show EAL option "--iova-mode" support. Signed-off-by: eric zhang --- doc/guides/prog_guide/env_abstraction_layer.rst | 8 doc/guides/testpmd_app_ug/run_app.rst | 4 2 files changed, 12 insertions(+) diff -

[dpdk-dev] [PATCH v3 2/3] eal: force IOVA to a particular mode

2018-10-03 Thread eric zhang
This patch uses EAL option "--iova-mode" to force the IOVA mode to a particular value. There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detectioni of the IOVA mode based on probing the PCI bus and IOMMU configuration may not report the required addr

[dpdk-dev] [PATCH v3 1/3] eal: add eal option to configure iova mode

2018-10-03 Thread eric zhang
From: Santosh Shukla In the case of user don't want to use bus iova scheme and want to override. For that, Adding eal option --iova-mode= where valid input string is 'pa' or 'va'. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Signed-off-by: eric zhang --- lib/librte_eal/common/ea

[dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode

2018-10-03 Thread eric zhang
This patchset introduces an EAL command line option "--iova-mode" to give the user a facility to force IOVA mode to a special value. Auto detection of the IOVA mode, based on probing the bus and IOMMU configuration, may not report the desired addressing mode when virtual devices that are not direc

Re: [dpdk-dev] [PATCH v3 0/3] support meadata as flow rule criteria

2018-10-03 Thread Thomas Monjalon
27/09/2018 15:57, Dekel Peled: > Dekel Peled (3): > ethdev: support metadata as flow rule criteria > app/testpmd: support metadata as flow rule criteria > app/testpmd: add debug command Tx metadata set Anyone to review this series, please?

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-03 Thread Thomas Monjalon
+ Cc more people 27/09/2018 13:26, Alejandro Lucero: > Primary and secondary processes share a per-device private data. With > current design it is not possible to have data per-device per-process. > This is required for handling properly the CPP interface inside the NFP > PMD with multiprocess su

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-03 Thread Thomas Monjalon
26/09/2018 23:00, Ori Kam: > Ori Kam (3): > ethdev: add generic L2/L3 tunnel encapsulation actions > app/testpmd: convert testpmd encap commands to new API > ethdev: remove vxlan and nvgre encapsulation commands If no more comment, I think we should accept this series.

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: add generic TTL rewrite actions

2018-10-03 Thread Thomas Monjalon
25/09/2018 16:37, Xiaoyu Min: > Xiaoyu Min (3): > ethdev: add generic TTL rewrite actions > app/testpmd: add commands of modify TTL > net/mlx5: eswitch-modify TTL actions If no more comment, I think we should accept this series.

Re: [dpdk-dev] [PATCH 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-10-03 Thread Thomas Monjalon
24/09/2018 10:28, Rahul Lakkireddy: > Rahul Lakkireddy (3): > ethdev: add flow api actions to modify IP addresses > ethdev: add flow api actions to modify TCP/UDP port numbers > net/cxgbe: add flow actions to modify IP and TCP/UDP port address If no more comment, I think we should accept thi

Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter

2018-10-03 Thread Thomas Monjalon
31/08/2018 13:32, Nélio Laranjeiro: > On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote: > > This is a follow up to the "Flow API helpers enhancements" series submitted > > almost a year ago [1]. The new title is due to the reduced scope of this > > version. > > > > rte_flow_conv()

[dpdk-dev] [PATCH] net/mlx5: fix matcher caching

2018-10-03 Thread Ori Kam
The Direct Verbs are using matcher object to filter flows, This object can be reused for all flows that are using the same flow items and masks. This was implemented with an issue, that the list pointer pointed to incorrect list type, this resulted in compilation error when using GCC greater then

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify MAC address actions

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 11:03:40PM +0800, Xiaoyu Min wrote: > Offload following modify MAC address actions to E-Switch > via TC-Flower driver > > - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > - RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > The corresponding rte_flow_item_eth must be present in > rte_flow pattern >

[dpdk-dev] [PATCH v4 2/2] net/enic: add AVX2 based vectorized Rx handler

2018-10-03 Thread John Daley
From: Hyong Youb Kim Add the vectorized version of the no-scatter Rx handler. It aims to process 8 descriptors per loop using AVX2 SIMD instructions. This handler is in its own file enic_rxtx_vec_avx2.c, and makefile and meson.build are modified to compile it when the compiler supports AVX2. Unde

[dpdk-dev] [PATCH v4 1/2] net/enic: move common Rx functions to a new header file

2018-10-03 Thread John Daley
From: Hyong Youb Kim Move a number of Rx functions to the header file so that the avx2 based Rx handler can use them. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- v2: remove bool type from stucture (found by checkpatch) v3: re-add Reviewed-by v4: Address Ferruh's comments regardin

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: add commands of modify MAC address

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 11:03:39PM +0800, Xiaoyu Min wrote: > add commands to support following actions: > > - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > - RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > Signed-off-by: Xiaoyu Min > --- Acked-by: Yongseok Koh Thanks > app/test-pmd/cmdline_flow.c

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Thomas Monjalon
03/10/2018 21:47, Andrew Rybchenko: > On 03.10.2018 21:14, Jerin Jacob wrote: > > From: Andrew Rybchenko > >>> From: Jerin Jacob > From: Andrew Rybchenko > > On 10/2/18 10:24 PM, Jerin Jacob wrote: > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > PKT

Re: [dpdk-dev] [PATCH 1/3] ethdev: add generic MAC address rewrite actions

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 11:03:38PM +0800, Xiaoyu Min wrote: > rte_flow actions: > - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > - RTE_FLOW_ACTION_TYPE_SET_MAC_DST > added in order to offload to NIC > > The rte_flow_itme_eth must be present in rte_flow pattern > > Signed-off-by: Xiaoyu Min > --- Acked-by

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify TTL actions

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 09:47:18PM +0800, Xiaoyu Min wrote: > Offload following modify TTL actions to E-Swtich via > TC-Flower driver > > - RTE_FLOW_ACTION_TYPE_SET_TTL > - RTE_FLOW_ACTION_TYPE_DEC_TTL > > The corresponding IP protocol rte_flow_item_ipv[4|6] > must be present in rte_flow pattern

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: add commands of modify TTL

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 10:37:18PM +0800, Xiaoyu Min wrote: > add commands which supports following TTL actions: > - RTE_FLOW_ACTION_TYPE_DEC_TTL > - RTE_FLOW_ACTION_TYPE_SET_TTL > > Signed-off-by: Xiaoyu Min Acked-by: Yongseok Koh Thanks > --- > app/test-pmd/cmdline_flow.c |

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add generic TTL rewrite actions

2018-10-03 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 10:37:17PM +0800, Xiaoyu Min wrote: > rewrite TTL by decrease or just set it directly > it's not necessary to check if the final result > is zero or not > > This is slightly different from the one defined > by openflow and more generic > > Signed-off-by: Xiaoyu Min > ---

Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Mattias Rönnblom
On 2018-10-03 21:36, Thomas Monjalon wrote: 03/10/2018 20:40, Mattias Rönnblom: On 2018-10-03 19:36, Kevin Laatz wrote: +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry" + FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive macro name would be in order, too. Kevin, you sh

Re: [dpdk-dev] [PATCH v5 0/4] introduces the enetc PMD driver

2018-10-03 Thread Ferruh Yigit
On 10/3/2018 2:36 PM, Gagandeep Singh wrote: > *ENETC* PMD driver which integrates with the existing PCI bus. > Document is also part of the set > > v4->v5 Change-log: > * missing commit info added in patch [3/4] > * dev_close API implemented > * link_update API updated > * all comments handled >

Re: [dpdk-dev] [PATCH v5 4/4] doc: add usage doc for ENETC PMD

2018-10-03 Thread Ferruh Yigit
On 10/3/2018 2:36 PM, Gagandeep Singh wrote: > Add enetc usage document to compile and run the > DPDK application on enetc supported platform. > This document introduces the enetc driver, supported > platforms and supported features. > > Signed-off-by: Gagandeep Singh <...> > @@ -50,6 +50,11 @@

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Andrew Rybchenko
Hi Jerin, On 03.10.2018 21:14, Jerin Jacob wrote: -Original Message- Date: Wed, 3 Oct 2018 21:00:37 +0300 From: Andrew Rybchenko To: Jerin Jacob CC: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Olivier Matz ,

Re: [dpdk-dev] [PATCH v5 1/4] net/enetc: add ENETC PMD with basic operations

2018-10-03 Thread Ferruh Yigit
On 10/3/2018 2:36 PM, Gagandeep Singh wrote: > This patch introduces the enetc PMD with basic > initialisation functions includes probe, teardown, > hardware initialisation > > Signed-off-by: Gagandeep Singh <...> > @@ -135,6 +135,7 @@ endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lr

Re: [dpdk-dev] [PATCH v7 0/8] Add Marvell NETA PMD

2018-10-03 Thread Ferruh Yigit
On 10/3/2018 2:25 PM, Ferruh Yigit wrote: > On 10/3/2018 8:22 AM, Andrzej Ostruszka wrote: >> From: Andrzej Ostruszka >> >> This patch series introduces new PMD for Marvell NETA adapters (MVNETA). >> See the documentation for more info. >> >> It is split for easier reviewing. >> >> v7: >> Addres

[dpdk-dev] [PATCH 2/2] devargs: rename enum items with singular form

2018-10-03 Thread Thomas Monjalon
The enum names are *_params (plural form). And the items are also using the plural form: *_PARAMS_*. It looks more natural to use the singular form *_PARAM_* for items. Signed-off-by: Thomas Monjalon --- drivers/bus/pci/pci_params.c | 10 +- drivers/bus/vdev/vdev_params.c| 4 ++

[dpdk-dev] [PATCH 1/2] bus/pci: rename devargs parameter id to addr

2018-10-03 Thread Thomas Monjalon
We could match devices by their PCI id (vendor id, device id, etc). But for now, only matching by PCI address is implemented. The devargs parameter "id" is renamed "addr" to reflect its real meaning. Signed-off-by: Thomas Monjalon --- drivers/bus/pci/pci_params.c | 6 +++--- 1 file changed, 3 in

Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Thomas Monjalon
03/10/2018 20:40, Mattias Rönnblom: > On 2018-10-03 19:36, Kevin Laatz wrote: > > +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry" > > + > > FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive > macro name would be in order, too. Kevin, you should use eal_get_runtime_dir(). Y

Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc

2018-10-03 Thread Ferruh Yigit
On 10/3/2018 9:13 AM, Mattias Rönnblom wrote: > Make the -Wno-format-nonliteral flag conditional, and only set in > clang and gcc builds, since this flag is not supported (nor needed) > when building with icc. > > Signed-off-by: Mattias Rönnblom perhaps simply: "event/dsw: fix icc build" Fixes:

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-10-03 Thread Thomas Monjalon
03/10/2018 16:11, Ferruh Yigit: > On 9/25/2018 10:04 AM, Thomas Monjalon wrote: > > 25/09/2018 10:03, Ferruh Yigit: > >> On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2025,7 +2025,7 @@ ixgbe_recv_pk

Re: [dpdk-dev] [PATCH v5 0/4] hash: add extendable bucket and partial key hashing

2018-10-03 Thread Dharmik Thakkar
Tested OK on Qualcomm Centriq 2400. > On Oct 1, 2018, at 1:34 PM, Yipeng Wang wrote: > > This patch set made two major optimizations over the current rte_hash > library. > > First, it adds Extendable Bucket Table feature: a new structure that can > accommodate keys that failed to get inserted in

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-10-03 Thread Dan Gora
On Fri, Sep 28, 2018 at 5:03 AM Ferruh Yigit wrote: > > On 9/28/2018 12:51 AM, Dan Gora wrote: > > On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit > > wrote: > >>> Well, yes the link_status (link up, link down) _is_ applied to the KNI > >>> interface. When that occurs, most people want to know wh

Re: [dpdk-dev] [PATCH v2 03/10] telemetry: add client feature and sockets

2018-10-03 Thread Mattias Rönnblom
On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to e

Re: [dpdk-dev] [PATCH v4 0/4] hash: add extendable bucket and partial key hashing

2018-10-03 Thread Dharmik Thakkar
Tested OK on Qualcomm Centriq 2400. > On Sep 28, 2018, at 12:23 PM, Yipeng Wang wrote: > > This patch set made two major optimizations over the current rte_hash > library. > > First, it adds Extendable Bucket Table feature: a new structure that can > accommodate keys that failed to get inserted

[dpdk-dev] [PATCH v9] app/testpmd: add noisy neighbour forwarding mode

2018-10-03 Thread Jens Freimann
This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footprint utilization from va

Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-03 Thread Yongseok Koh
> On Oct 3, 2018, at 10:37 AM, Ophir Munk wrote: > > Applications which add an RSS flow must supply an RSS key table and an > RSS key length. If an application needs to add the default RSS flow it > should not care about the exact RSS default key table and its length. > By setting key length to

[dpdk-dev] [PATCH] app/testpmd: add noisy neighbour forwarding mode

2018-10-03 Thread Jens Freimann
This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footprint utilization from va

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add SCTP Rx checksum offload support

2018-10-03 Thread Ferruh Yigit
On 10/2/2018 11:51 AM, Jerin Jacob wrote: > Added SCTP Rx checksum offload support > > Signed-off-by: Jerin Jacob For series, Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

2018-10-03 Thread Jens Freimann
On Tue, Oct 02, 2018 at 11:20:14AM +, Iremonger, Bernard wrote: Hi Jens, -Original Message- From: Jens Freimann [mailto:jfreim...@redhat.com] Sent: Tuesday, October 2, 2018 8:44 AM To: dev@dpdk.org Cc: ai...@redhat.com; jan.scheur...@ericsson.com; Richardson, Bruce ; tho...@monjalon

Re: [dpdk-dev] [PATCH v3 02/22] net/atlantic: logging macroes and some typedefs

2018-10-03 Thread Ferruh Yigit
On 9/29/2018 11:30 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Aquantia Corporation > + */ > +#ifndef ATL_LOGS_H > +#define ATL_LOGS_H > + > +#include > + > +e

Re: [dpdk-dev] [PATCH v3 01/22] net/atlantic: atlantic PMD driver skeleton

2018-10-03 Thread Ferruh Yigit
On 9/29/2018 11:30 AM, Igor Russkikh wrote: > From: Pavel Belous > > Makefile/meson build infrastructure, atl_ethdev minimal skeleton, > header with aquantia aQtion NIC device and vendor IDs. > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous > --- > config/common_base

Re: [dpdk-dev] [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-10-03 Thread Ferruh Yigit
On 9/29/2018 11:30 AM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nati

Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket

2018-10-03 Thread Mattias Rönnblom
On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage

[dpdk-dev] [PATCH v3 3/4] app/testpmd: add outer UDP HW checksum support

2018-10-03 Thread Jerin Jacob
Added outer-udp Tx HW checksum support for csum forward engine if device supports DEV_TX_OFFLOAD_OUTER_UDP_CKSUM. Signed-off-by: Jerin Jacob Acked-by: Bernard Iremonger --- v3: - Added Acked-by: Bernard Iremonger v2: - Added outer-udp support for csum engine --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v3 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Jerin Jacob
Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and PKT_TX_OUTER_UDP_CKSUM mbuf ol_flags to enable Tx outer UDP checksum offload. To use hardware Tx outer UDP checksum offload, the user needs to, - enable following in mbuf: a) fill outer_l2_len and outer_l3_len in mbuf b) set the PKT_TX_O

[dpdk-dev] [PATCH v3 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Jerin Jacob
Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum failure. - To use hardware Rx outer UDP checksum offload, the user needs to configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. - Driver updates the PKT_RX

[dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

2018-10-03 Thread Jerin Jacob
Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. Signed-off-by: Jerin Jacob Reviewed-by: Andrew Rybchenko --- v3: - Added Reviewed-by: Andrew Rybchenko - Removed unnecessary extra empty line(Andrew Rybchenko) - Simplify calculation rx_bad_outer_l4_csum logic(Andrew Rybchenko)

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Jerin Jacob
-Original Message- > Date: Wed, 3 Oct 2018 21:00:37 +0300 > From: Andrew Rybchenko > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Olivier Matz , > dev@dpdk.org, shah...@mellanox.com, "A

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-03 Thread Andrew Rybchenko
On 03.10.2018 20:12, Jerin Jacob wrote: -Original Message- Date: Wed, 3 Oct 2018 13:27:13 +0530 From: Jerin Jacob To: Andrew Rybchenko CC: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Olivier Matz , dev@dp

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-03 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, October 3, 2018 10:33 AM >To: Wang, Yipeng1 ; Van Haaren, Harry >; Richardson, Bruce > >Cc: De Lara Guarch, Pablo ; dev@dpdk.org; >Gavin Hu (Arm Technology China) >; Steve Capper ; O

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-03 Thread Ferruh Yigit
On 10/2/2018 11:34 AM, Raslan Darawsheh wrote: > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secondary process >

Re: [dpdk-dev] [PATCH v4 1/2] net/tap: change queue fd to be pointers to process private

2018-10-03 Thread Ferruh Yigit
On 10/2/2018 11:34 AM, Raslan Darawsheh wrote: > change the fds for the queues to be pointers and add new process private > structure and make the queue fds point to it. > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/tap/rte_eth_tap.c | 63 > ---

Re: [dpdk-dev] [PATCH v4 2/4] hash: add extendable bucket feature

2018-10-03 Thread Honnappa Nagarahalli
> > >-Original Message- > >From: Stephen Hemminger [mailto:step...@networkplumber.org] > >On Fri, 28 Sep 2018 10:23:44 -0700 > >Yipeng Wang wrote: > > > >> + /* clear free extendable bucket ring and memory */ > >> + if (h->ext_table_support) { > >> + memset(h->buckets_ext, 0, h

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-03 Thread Honnappa Nagarahalli
> >-Original Message- > >[Wang, Yipeng] I was thinking about another corner case and wondering > >if the version counter needs to be done on key deletion as well. > >For example, a reader reads out the index and falsely matches a > >signature, before it reads out the data and the key, the k

[dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS

2018-10-03 Thread Ophir Munk
Applications which add an RSS flow must supply an RSS key table and an RSS key length. If an application needs to add the default RSS flow it should not care about the exact RSS default key table and its length. By setting key length to 0 - the PMD will know that it should use the default RSS key t

[dpdk-dev] [PATCH v2 09/10] doc: add telemetry documentation

2018-10-03 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: K

[dpdk-dev] [PATCH v2 06/10] telemetry: format json response when sending stats

2018-10-03 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

  1   2   3   >