On 9/29/2018 11:30 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh <igor.russk...@aquantia.com> > Signed-off-by: Pavel Belous <pavel.bel...@aquantia.com>
<...> > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Aquantia Corporation > + */ > +#ifndef ATL_LOGS_H > +#define ATL_LOGS_H > + > +#include <rte_log.h> > + > +extern int atl_logtype_init; > + > +#define PMD_INIT_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, atl_logtype_init, \ > + "%s(): " fmt "\n", __func__, ##args) You didn't initialize the "atl_logtype_init" at this stage yet. <...> > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Aquantia Corporation > + */ > +#ifndef ATL_TYPES_H > +#define ATL_TYPES_H > + > +#include <stdint.h> > +#include <stddef.h> > +#include <inttypes.h> > +#include <string.h> > + > +typedef uint8_t u8; > +typedef int8_t s8; > +typedef uint16_t u16; > +typedef int16_t s16; > +typedef uint32_t u32; > +typedef int32_t s32; > +typedef uint64_t u64; > +#ifndef __cplusplus > +typedef int bool; > +#endif There is already a patch trying to remove these kind of usage, and replace with "#include <stdbool.h>", is it possible to do same? https://patches.dpdk.org/patch/44988/
