> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Tuesday, October 2, 2018 6:52 PM
> To: Olivier Matz <olivier.m...@6wind.com>
> Cc: dev@dpdk.org; Jerin Jacob <jerin.ja...@caviumnetworks.com>;
> sta...@dpdk.org; Hu, Jiayu <jiayu...@intel.com>
> Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask
>
> Fixes missing PKT_TX_UDP_SEG,
> PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4,
> PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK.
>
> Also sort them in bit wise order to recognize missing items later.
>
> Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload")
> Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels")
> Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx
> ones")
> Cc: sta...@dpdk.org
> Cc: jiayu...@intel.com
>
> Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
Acked-by: Jiayu Hu <jiayu...@intel.com>
Thanks,
Jiayu
> ---
> v2:
> - Add all missing PKT_TX_ types
> - Sort them in bit mask order(Ferruh Yigit)
> ---
> lib/librte_mbuf/rte_mbuf.h | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index a50b05c64..c8ebc3230 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -334,16 +334,21 @@ extern "C" {
> * which can be set for packet.
> */
> #define PKT_TX_OFFLOAD_MASK ( \
> + PKT_TX_OUTER_IPV6 | \
> + PKT_TX_OUTER_IPV4 | \
> + PKT_TX_OUTER_IP_CKSUM | \
> + PKT_TX_VLAN_PKT | \
> + PKT_TX_IPV6 | \
> + PKT_TX_IPV4 | \
> PKT_TX_IP_CKSUM | \
> PKT_TX_L4_MASK | \
> - PKT_TX_OUTER_IP_CKSUM | \
> - PKT_TX_TCP_SEG | \
> PKT_TX_IEEE1588_TMST | \
> + PKT_TX_TCP_SEG | \
> PKT_TX_QINQ_PKT | \
> - PKT_TX_VLAN_PKT | \
> PKT_TX_TUNNEL_MASK | \
> PKT_TX_MACSEC | \
> - PKT_TX_SEC_OFFLOAD)
> + PKT_TX_SEC_OFFLOAD | \
> + PKT_TX_UDP_SEG)
>
> /**
> * Mbuf having an external buffer attached. shinfo in mbuf must be filled.
> --
> 2.19.0
