On 10/2/2018 10:32 PM, Burakov, Anatoly wrote:
On 02-Oct-18 1:35 PM, Jeff Guo wrote:
When a device is hot-unplugged, a sigbus error will occur of the
datapath
can still read/write to the device. A handler is required here to
capture
the sigbus signal and handle it appropriately.
This patch introduces a bus ops to handle sigbus errors. Each bus can
implement its own case-dependent logic to handle the sigbus errors.
Signed-off-by: Jeff Guo <jia....@intel.com>
Acked-by: Shaopeng He <shaopeng...@intel.com>
---
v12->v11:
no change.
---
lib/librte_eal/common/include/rte_bus.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_bus.h
b/lib/librte_eal/common/include/rte_bus.h
index 1bb53dc..201454a 100644
--- a/lib/librte_eal/common/include/rte_bus.h
+++ b/lib/librte_eal/common/include/rte_bus.h
@@ -182,6 +182,21 @@ typedef int (*rte_bus_parse_t)(const char *name,
void *addr);
typedef int (*rte_bus_hot_unplug_handler_t)(struct rte_device *dev);
/**
+ * Implement a specific sigbus handler, which is responsible for
handling
+ * the sigbus error which is either original memory error, or
specific memory
+ * error that caused of device be hot-unplugged. When sigbus error
be captured,
+ * it could call this function to handle sigbus error.
+ * @param failure_addr
+ * Pointer of the fault address of the sigbus error.
+ *
+ * @return
+ * 0 for success handle the sigbus.
+ * 1 for no bus handle the sigbus.
I think the comment here should be reworded. I can't parse "no bus
handle the sigbus" - what does that mean, and how is it different from
an error?
ok, let me detail more.
