Re: [dpdk-dev] [PATCH v1] net/mlx5: fix flow director rule deletion crash

2018-04-26 Thread NĂ©lio Laranjeiro
On Thu, Apr 26, 2018 at 06:17:46PM +0200, Adrien Mazarguil wrote: > Flow director rules matching traffic properties above layer 2 do not > target a fixed hash Rx queue (HASH_RXQ_ETH), it actually depends on the > highest protocol layer specified by each flow rule. > > mlx5_fdir_filter_delete() mak

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Vladimir Medvedkin
Hi Stephen, Thanks for comments! Will fix in next version. 2018-04-27 1:20 GMT+03:00 Stephen Hemminger : > On Fri, 27 Apr 2018 01:03:31 +0300 > Medvedkin Vladimir wrote: > > > + /** > > + * Intermediate node found. > > + * Previous rte_rib_tree_lookup_exact

Re: [dpdk-dev] [PATCH] crypto/mrvl: rename PMD to mvsam

2018-04-26 Thread Tomasz Duszynski
On Thu, Apr 26, 2018 at 10:38:12AM -0700, Stephen Hemminger wrote: > On Thu, 26 Apr 2018 19:22:00 +0200 > Tomasz Duszynski wrote: > > > Picking a company stock ticker for a PMD name might not be a best approach > > in a long run since name is too generic. > > > > This patch addresses that and rena

Re: [dpdk-dev] [PATCH] crypto/mrvl: rename PMD to mvsam

2018-04-26 Thread Tomasz Duszynski
On Thu, Apr 26, 2018 at 08:48:27PM +0200, Thomas Monjalon wrote: > 26/04/2018 19:22, Tomasz Duszynski: > > Picking a company stock ticker for a PMD name might not be a best approach > > in a long run since name is too generic. > > > > This patch addresses that and renames mrvl to mvsam. > > Have yo

[dpdk-dev] [PATCH 0/2] fix compilation on FreeBSD

2018-04-26 Thread Thomas Monjalon
The compilation was broken on FreeBSD due to the commit for auxv, implemented only for Linux in the common files. Thomas Monjalon (2): eal: fix build with glibc < 2.16 eal: fix build on FreeBSD lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/bsdapp/eal/eal_cpuflags.

[dpdk-dev] [PATCH 2/2] eal: fix build on FreeBSD

2018-04-26 Thread Thomas Monjalon
The auxiliary vector read is implemented only for Linux. It could be done with procstat_getauxv() for FreeBSD. Since the commit below, the auxiliary vector functions are compiled for every architectures, including x86 which is tested with FreeBSD. This patch is only adding a fake/empty implementa

[dpdk-dev] [PATCH 1/2] eal: fix build with glibc < 2.16

2018-04-26 Thread Thomas Monjalon
The fake getauxval function does not use its parameter. So the compiler raised this error: lib/librte_eal/common/eal_common_cpuflags.c:25:25: error: unused parameter 'type' Fixes: 2ed9bf330709 ("eal: abstract away the auxiliary vector") Cc: acon...@redhat.com Cc: tredae...@redhat.c

[dpdk-dev] [PATCH v2] net/i40e: fix missing some offload capabilities

2018-04-26 Thread Yanglong Wu
MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it. Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API") Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- driv

[dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx

2018-04-26 Thread Yanglong Wu
Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[dpdk-dev] [PATCH v2] net/i40e: fix missing some offload capabilities

2018-04-26 Thread Yanglong Wu
MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it. Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API") Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- driv

[dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx

2018-04-26 Thread Yanglong Wu
Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- v2: rework fix line --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[dpdk-dev] [pull-request] next-net 18.05 RC1

2018-04-26 Thread Ferruh Yigit
The following changes since commit 363e56f9e23cfdd0ba73c9a49a97d95565052baf: mempool/bucket: do not allow one lcore to grab all buckets (2018-04-26 23:34:07 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 80c7d70b5f32cf2

Re: [dpdk-dev] [PATCH v2] ethdev: rename folder to library name

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 10:25 PM, Ferruh Yigit wrote: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named as ethdev. >

[dpdk-dev] [PATCH v7 2/2] app/testpmd: conserve offload flags of mbuf

2018-04-26 Thread Yongseok Koh
This patch is to accommodate an experimental feature of mbuf - external buffer attachment. If mbuf is attached to an external buffer, its ol_flags will have EXT_ATTACHED_MBUF set. Without enabling/using the feature, everything remains same. If PMD delivers Rx packets with non-direct mbuf, ol_flags

[dpdk-dev] [PATCH v7 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as

Re: [dpdk-dev] [PATCH next 00/10] more dynamic logging

2018-04-26 Thread Ferruh Yigit
On 4/27/2018 12:42 AM, Ferruh Yigit wrote: > On 4/25/2018 4:56 PM, Stephen Hemminger wrote: >> This set of patches converts more virtual drivers to use the >> dynamic log type, rather than PMD log type. >> >> Marking these for next since there is no urgency to get >> these into 18.05 and they are c

Re: [dpdk-dev] [PATCH next 00/10] more dynamic logging

2018-04-26 Thread Ferruh Yigit
On 4/27/2018 12:42 AM, Ferruh Yigit wrote: > On 4/25/2018 4:56 PM, Stephen Hemminger wrote: >> This set of patches converts more virtual drivers to use the >> dynamic log type, rather than PMD log type. >> >> Marking these for next since there is no urgency to get >> these into 18.05 and they are c

Re: [dpdk-dev] [PATCH next 00/10] more dynamic logging

2018-04-26 Thread Ferruh Yigit
On 4/25/2018 4:56 PM, Stephen Hemminger wrote: > This set of patches converts more virtual drivers to use the > dynamic log type, rather than PMD log type. > > Marking these for next since there is no urgency to get > these into 18.05 and they are compile tested only. > > Stephen Hemminger (10):

Re: [dpdk-dev] [PATCH next 10/10] net/bond: convert to dynamic logging

2018-04-26 Thread Ferruh Yigit
On 4/25/2018 4:56 PM, Stephen Hemminger wrote: > Signed-off-by: Stephen Hemminger <...> > +#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \ > + rte_log(RTE_LOG_DEBUG, logtype_bond,\ Variable is "bond_logtype", will fix while applying

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix segfault while devarg parsing

2018-04-26 Thread Ferruh Yigit
On 4/27/2018 12:16 AM, Ferruh Yigit wrote: > device.devargs can be null, don't access device.devargs->args without > null check. > > Fixes: e0645348d7c6 ("net/i40e: add support for representor ports") > > Signed-off-by: Ferruh Yigit > --- > Cc: declan.dohe...@intel.com For series, Squashed into

[dpdk-dev] [PATCH 2/2] net/ixgbe: fix segfault while devarg parsing

2018-04-26 Thread Ferruh Yigit
device.devargs can be null, don't access device.devargs->args without null check. Fixes: 3be5d686539c ("net/ixgbe: add support for representor ports") Signed-off-by: Ferruh Yigit --- Cc: declan.dohe...@intel.com --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++--- 1 file changed, 6 insertions(+)

[dpdk-dev] [PATCH 1/2] net/i40e: fix segfault while devarg parsing

2018-04-26 Thread Ferruh Yigit
device.devargs can be null, don't access device.devargs->args without null check. Fixes: e0645348d7c6 ("net/i40e: add support for representor ports") Signed-off-by: Ferruh Yigit --- Cc: declan.dohe...@intel.com --- drivers/net/i40e/i40e_ethdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[dpdk-dev] [PATCH v5 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-26 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: Stephen Hemminger --- MAIN

[dpdk-dev] [PATCH v5 0/4] Hyper-V netvsc PMD (and VMBus)

2018-04-26 Thread Stephen Hemminger
This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Onl

[dpdk-dev] [PATCH v5 1/4] bus/vmbus: add hyper-v virtual bus support

2018-04-26 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v5 3/4] net/netvsc: add documentation

2018-04-26 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 97 ++ doc/guides/rel_n

[dpdk-dev] [PATCH v5 4/4] bus/vmbus and net/netvsc: add meson build support

2018-04-26 Thread Stephen Hemminger
From: Stephen Hemminger Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 16 drivers/net/meson.build| 2

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 00:27:03 +0200 Thomas Monjalon wrote: > 27/04/2018 00:24, Stephen Hemminger: > > The existing slowness of add and delete was fixed at Vyatta/Brocade by > > replacing list with red-black tree. Patches were submitted but never > > merged. > > I don't remember these patches.

Re: [dpdk-dev] [PATCH 00/23] net/sfc: support equal stride super-buffer Rx mode

2018-04-26 Thread Ferruh Yigit
On 4/19/2018 12:36 PM, Andrew Rybchenko wrote: > Add support for dedicated DPDK firmware variant which has equal stride > super-buffer Rx mode. The Rx mode uses bucket mempool manager which > supports allocation of contiguos block of mbufs. > > It allows to achieve higher packet rate on Rx than tr

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 00:27:03 +0200 Thomas Monjalon wrote: > 27/04/2018 00:24, Stephen Hemminger: > > The existing slowness of add and delete was fixed at Vyatta/Brocade by > > replacing list with red-black tree. Patches were submitted but never > > merged. > > I don't remember these patches.

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Arnon Warshavsky
On Fri, Apr 27, 2018 at 1:08 AM, Arnon Warshavsky wrote: > Hi Kevin > >> > + if (rte_config_init() != 0) >> > + return -1; >> > + >> >> I'm confused, is this deliberate? there is now two rte_config_init() >> calls. > > > Please note that there are 2 eal.c files. One under linux an

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-04-26 Thread Thomas Monjalon
27/04/2018 00:24, Stephen Hemminger: > The existing slowness of add and delete was fixed at Vyatta/Brocade by > replacing list with red-black tree. Patches were submitted but never merged. I don't remember these patches. Why they were not merged?

Re: [dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:30 +0300 Medvedkin Vladimir wrote: > This patch series introduces new library librte_rib which potentially could > replace librte_lpm. > > RIB is an alternative to current LPM library. > It solves the following problems > - Increases the speed of control plane operatio

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > + /** > + * Intermediate node found. > + * Previous rte_rib_tree_lookup_exact() returned NULL > + * but node with proper search criteria is found. > + * Validate intermed

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > rib = (struct rte_rib *)rte_zmalloc_socket(mem_name, > + sizeof(struct rte_rib), RTE_CACHE_LINE_SIZE, socket_id); Cast of void * pointer is not required in C.

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > + snprintf(rib->name, sizeof(rib->name), "%s", name); Use strlcpy

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > +/** > + * Check if prefix1 {key1/depth1} > + * is covered by prefix2 {key2/depth2} > + */ > +static inline int __attribute__((pure)) > +rte_rib_is_covered(uint32_t key1, uint8_t depth1, uint32_t key2, uint8_t > depth2) > +{ > +

Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Stephen Hemminger
On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > +static inline int __attribute__((pure)) > +rte_rib_is_right_node(struct rte_rib_node *node) > +{ > + return (node->parent->right == node); > +} > + Minor nit (repeated in several places). DPDK uses Linux (not BSD) style where ex

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Arnon Warshavsky
Hi Kevin > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. Please note that there are 2 eal.c files. One under linux and one under bsd There is a copy of rte_config_init() in each. > Aaron'

[dpdk-dev] [PATCH v4 4/4] Add support for lpm and rib bulk lookup

2018-04-26 Thread Medvedkin Vladimir
Signed-off-by: Medvedkin Vladimir --- examples/l3fwd/l3fwd_lpm.c | 132 + examples/l3fwd/meson.build | 2 +- 2 files changed, 133 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c index a747126..9ad1ddc

[dpdk-dev] [PATCH v4 1/4] Add RIB library

2018-04-26 Thread Medvedkin Vladimir
Signed-off-by: Medvedkin Vladimir --- config/common_base | 6 + doc/api/doxy-api.conf | 1 + lib/Makefile | 2 + lib/librte_rib/Makefile| 23 ++ lib/librte_rib/meson.build | 6 + lib/librte_rib/rte_rib.c | 5

[dpdk-dev] [PATCH v4 3/4] Add autotests for RIB library

2018-04-26 Thread Medvedkin Vladimir
Signed-off-by: Medvedkin Vladimir --- test/test/Makefile | 5 + test/test/meson.build| 8 + test/test/test_rib.c | 308 +++ test/test/test_rib_generate_rt.c | 297 + test/test/test_ri

[dpdk-dev] [PATCH v4 2/4] Add dir24_8 implementation for rib library

2018-04-26 Thread Medvedkin Vladimir
- Fast table modifcations (add/del routes) - Variable length next hops (1/2/4/8 bytes) - Removed RTE_LPM_LOOKUP_SUCCESS to save 1 bit and to eleminate ternary operator. Instead it returns special default value if there is no route. Signed-off-by: Medvedkin Vladimir --- lib/librte_rib/rte_dir2

[dpdk-dev] [PATCH v4 0/4] lib/rib: Add Routing Information Base library

2018-04-26 Thread Medvedkin Vladimir
This patch series introduces new library librte_rib which potentially could replace librte_lpm. RIB is an alternative to current LPM library. It solves the following problems - Increases the speed of control plane operations against lpm such as adding/deleting routes - Adds abstraction from d

Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-26 Thread Arnon Warshavsky
On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor wrote: > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > > Actually the return value did not change, only the warning text did. I would rather keep the word 'prevents' as an intention declaration

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 7:14 PM, Alejandro Lucero wrote: > On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < > step...@networkplumber.org> wrote: > >> On Thu, 26 Apr 2018 13:52:53 +0100 >> Alejandro Lucero wrote: >> >>> Hi Stephen, >>> >>> Thanks for this patch set. >>> >>> I'm happy with it although I h

Re: [dpdk-dev] [PATCH v5 05/11] eal: replace rte_panic instances in eventdev

2018-04-26 Thread Arnon Warshavsky
> > Similar to 1/11 in that there is some allocate before this and maybe you > should jump to the release at the end of the function > > > > Same as I wrote in 1/10 - I want to handle this not in this patchset

Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-26 Thread Arnon Warshavsky
> > -void __rte_experimental > > +int __rte_experimental > > rte_eth_dev_owner_delete(const uint64_t owner_id) > > { > > uint16_t port_id; > > + int error; > > it's inconsistent that this function returns the error code from > rte_eth_dev_shared_data_prepare() and all these other functi

Re: [dpdk-dev] [PATCH v4 0/5] mempool: add bucket driver

2018-04-26 Thread Thomas Monjalon
> Artem V. Andreev (5): > mempool/bucket: implement bucket mempool manager > mempool: implement abstract mempool info API > mempool: support block dequeue operation > mempool/bucket: implement block dequeue operation > mempool/bucket: do not allow one lcore to grab all buckets Applied, t

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-26 Thread Arnon Warshavsky
> > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_private == NULL) { > > + DPAA_SEC_ERR("%s() Canno

Re: [dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver

2018-04-26 Thread Thomas Monjalon
26/04/2018 23:06, Arnon Warshavsky: > By returning from this function in this patch I also aim to terminate the > process, but through the door rather than out the window, :D Thanks for the laugh. Where is the button "Like"?

[dpdk-dev] [PATCH v2] ethdev: rename folder to library name

2018-04-26 Thread Ferruh Yigit
Library folder name and output library name are same except a few flaws including librte_ether. This library is network device abstraction layer, the name "ethdev" fits better than "ether", and library & header files already named as ethdev. Also there is a rte_ether.h in the net library which ca

Re: [dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver

2018-04-26 Thread Arnon Warshavsky
Hi Kevin > /* Any memory allocation failure in initialization is critical > because > >* resources can't be free, so reinitialization is impossible. */ > > What about this comment? Not sure if it is just stale or if there is > something else you need to do. > This comment was origin

Re: [dpdk-dev] how can I get a git version of Latest Major release? (18.02.1)

2018-04-26 Thread Andrii
when its not clear how to get a stable release from git - it sucks. I don't care which part of team it is: web, dev or marketing. now there should be one more stupid joke about broken link. On Thu, Apr 26, 2018 at 7:27 PM, Thomas Monjalon wrote: > 26/04/2018 18:15, Ferruh Yigit: > > On 4/26/2018

Re: [dpdk-dev] [PATCH] app/test: fix shared library build failure

2018-04-26 Thread Parthasarathy, JananeeX M
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Wednesday, April 25, 2018 4:21 AM To: Pattan, Reshma Cc: dev@dpdk.org; Hunt, David ; Parthasarathy, JananeeX M ; Richardson, Bruce ; Yigit, Ferruh Subject: Re: [dpdk-dev] [PATCH] app/test: fix shared library

Re: [dpdk-dev] how can I get a git version of Latest Major release? (18.02.1)

2018-04-26 Thread Thomas Monjalon
I've sent a patch to fix the link in the download page http://dpdk.org/rel http://dpdk.org/ml/archives/web/2018-April/000698.html 26/04/2018 21:25, Andrii: > when its not clear how to get a stable release from git - it sucks. > I don't care which part of team it is: web, dev or marketing.

Re: [dpdk-dev] [PATCH v7 0/4] ethdev: add shared counter support to rte_flow

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 6:29 PM, Declan Doherty wrote: > This patchset contains the revised proposal to manage > tunnel endpoints hardware accleration based on community > feedback on RFC > (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This > proposal is purely enabled through rte_flow APIs wi

Re: [dpdk-dev] [PATCH] net/sfc: do not use RSS context if it is not required

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 5:48 PM, Andrew Rybchenko wrote: > RSS action with only one destination queue and no specific settings > for hash types and key does not require dedicated RSS context and > may be simplified to QUEUE action. > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Roman Zhukov Applied to

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 22:07, Olivier Matz: > On Thu, Apr 26, 2018 at 09:58:00PM +0200, Thomas Monjalon wrote: > > 26/04/2018 21:42, Olivier Matz: > > > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > > > 26/04/2018 18:05, Andrew Rybchenko: > > > > > On 04/26/2018 04:10 AM, Yongseok Koh wr

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 09:58:00PM +0200, Thomas Monjalon wrote: > 26/04/2018 21:42, Olivier Matz: > > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > > 26/04/2018 18:05, Andrew Rybchenko: > > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > > -#define RTE_MBUF_INDIRECT(

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 21:42, Olivier Matz: > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > 26/04/2018 18:05, Andrew Rybchenko: > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > +#define RTE_MBUF_INDIRE

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 10:18:14AM -0700, Yongseok Koh wrote: > [...] > > > /** Mbuf prefetch */ > > > #define RTE_MBUF_PREFETCH_TO_FREE(m) do { \ > > > if ((m) != NULL)\ > > > @@ -1213,11 +1307,157 @@ static inline int rte_pktmbuf_alloc_bulk(struct >

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > 26/04/2018 18:05, Andrew Rybchenko: > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > > > We h

Re: [dpdk-dev] [PATCH v7 4/4] ethdev: add shared counter support to rte_flow

2018-04-26 Thread Thomas Monjalon
26/04/2018 19:29, Declan Doherty: > Add rte_flow_action_count action data structure to enable shared > counters across multiple flows on a single port or across multiple > flows on multiple ports within the same switch domain. Also this enables > multiple count actions to be specified in a single f

Re: [dpdk-dev] [PATCH v7 2/4] ethdev: Add group JUMP action

2018-04-26 Thread Thomas Monjalon
About title, we use uppercase only for acronyms. So it should be: ethdev: add group jump action

Re: [dpdk-dev] [PATCH v7 3/4] ethdev: add mark flow item to rte_flow_item_types

2018-04-26 Thread Thomas Monjalon
26/04/2018 19:29, Declan Doherty: > Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables > flow patterns to specify arbitrary integer values to match aginst > set by the RTE_FLOW_ACTION_TYPE_MARK action in previously matched > flows. In the title, I don't think you need specify rte_f

Re: [dpdk-dev] [PATCH] crypto/mrvl: rename PMD to mvsam

2018-04-26 Thread Thomas Monjalon
26/04/2018 19:22, Tomasz Duszynski: > Picking a company stock ticker for a PMD name might not be a best approach > in a long run since name is too generic. > > This patch addresses that and renames mrvl to mvsam. Have you grep'ed MRVL_CRYPTO after this patch? I did not try but I can say you forgo

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Alejandro Lucero
On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Apr 2018 13:52:53 +0100 > Alejandro Lucero wrote: > > > Hi Stephen, > > > > Thanks for this patch set. > > > > I'm happy with it although I have some concerns regarding how the dynamic > > logs wo

Re: [dpdk-dev] [PATCH] crypto/mrvl: rename PMD to mvsam

2018-04-26 Thread Stephen Hemminger
On Thu, 26 Apr 2018 19:22:00 +0200 Tomasz Duszynski wrote: > Picking a company stock ticker for a PMD name might not be a best approach > in a long run since name is too generic. > > This patch addresses that and renames mrvl to mvsam. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Tomas

[dpdk-dev] [PATCH v7 4/4] ethdev: add shared counter support to rte_flow

2018-04-26 Thread Declan Doherty
Add rte_flow_action_count action data structure to enable shared counters across multiple flows on a single port or across multiple flows on multiple ports within the same switch domain. Also this enables multiple count actions to be specified in a single flow action. This patch also modifies the

[dpdk-dev] [PATCH v7 0/4] ethdev: add shared counter support to rte_flow

2018-04-26 Thread Declan Doherty
This patchset contains the revised proposal to manage tunnel endpoints hardware accleration based on community feedback on RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This proposal is purely enabled through rte_flow APIs with the additions of some new features which were previ

[dpdk-dev] [PATCH v7 2/4] ethdev: Add group JUMP action

2018-04-26 Thread Declan Doherty
Add jump action type which defines an action which allows a matched flow to be redirect to the specified group. This allows physical and logical flow table/group hierarchies to be defined through rte_flow. This breaks ABI compatibility for the following public functions (as it modifes the ordering

[dpdk-dev] [PATCH v7 3/4] ethdev: add mark flow item to rte_flow_item_types

2018-04-26 Thread Declan Doherty
Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables flow patterns to specify arbitrary integer values to match aginst set by the RTE_FLOW_ACTION_TYPE_MARK action in previously matched flows. Add support for specification of new MARK flow item in testpmd's cli. Update testpmd documen

[dpdk-dev] [PATCH v7 1/4] ethdev: Add tunnel encap/decap actions

2018-04-26 Thread Declan Doherty
Add new flow action types and associated action data structures to support the encapsulation and decapsulation of VXLAN and NVGRE tunnel endpoints. The RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP action will cause the matching flow to be encapsulated in the tunnel endpoint overlay defined in the [vxl

[dpdk-dev] [PATCH] crypto/mrvl: rename PMD to mvsam

2018-04-26 Thread Tomasz Duszynski
Picking a company stock ticker for a PMD name might not be a best approach in a long run since name is too generic. This patch addresses that and renames mrvl to mvsam. Signed-off-by: Natalie Samsonov Signed-off-by: Tomasz Duszynski --- MAINTAINERS| 6 +

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Yongseok Koh
On Thu, Apr 26, 2018 at 07:05:01PM +0300, Andrew Rybchenko wrote: > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer is quite similar to mbuf indirection in > > replacing buffer addresses

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: return empty port offload capabilities

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 5:56 PM, Ferruh Yigit wrote: > On 4/26/2018 12:13 PM, Ophir Munk wrote: >> Fix internal report on port specific offload capabilities to be 0 (no >> capabilities). Before this commit port capabilities were a clone of queue >> capabilities, however the current TAP offload capabilities (e

Re: [dpdk-dev] [PATCH v2] net/tap: return empty port offload capabilities

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 12:13 PM, Ophir Munk wrote: > Fix internal report on port specific offload capabilities to be 0 (no > capabilities). Before this commit port capabilities were a clone of queue > capabilities, however the current TAP offload capabilities (e.g. > checksum calculation) are per queue and a

[dpdk-dev] [PATCH] net/sfc: do not use RSS context if it is not required

2018-04-26 Thread Andrew Rybchenko
RSS action with only one destination queue and no specific settings for hash types and key does not require dedicated RSS context and may be simplified to QUEUE action. Signed-off-by: Andrew Rybchenko Reviewed-by: Roman Zhukov --- drivers/net/sfc/sfc_flow.c | 11 +++ 1 file changed, 11

Re: [dpdk-dev] [PATCH] net/sfc: ignore spec bits not covered by mask

2018-04-26 Thread Ferruh Yigit
On 4/25/2018 6:18 PM, Andrew Rybchenko wrote: > mask is a simple bit-mask applied before interpreting the contents > of spec and last. > > Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > Reviewed-b

Re: [dpdk-dev] [PATCH v3 05/11] compress/isal: add queue pair related ops

2018-04-26 Thread Daly, Lee
<...> > > -Original Message- > > From: Daly, Lee > > Sent: Tuesday, April 17, 2018 2:35 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Tucker, > > Greg B ; Jain, Deepak K > > ; Trahe, Fiona ; Daly, > > Lee > > Subject: [PATCH v3 05/11] compress/isal: add queue pair related ops >

Re: [dpdk-dev] [dpdk=-dev][PATCH v8 0/9] switching devices representation

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 5:24 PM, Ferruh Yigit wrote: > On 4/26/2018 11:40 AM, Declan Doherty wrote: >> This patchset follows on from the port rerpesentor patchsets and the >> community discussion that resulted. It outlines the model for >> representing and controlling switching capable devices in a new >> pro

Re: [dpdk-dev] [PATCH] AVX check

2018-04-26 Thread Bruce Richardson
On Thu, Apr 26, 2018 at 06:06:47PM +0200, Riccardo Ravaioli wrote: > Hi all, > > I need to install DPDK on 64-bit Linux machines whose processors might or > might not support AVX instructions. In my current configuration file, > defconfig_x86-64-native-linuxapp-gcc, the parameter CONFIG_RTE_MACHIN

Re: [dpdk-dev] [PATCH] bbdev: change names of baseband devices

2018-04-26 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday 26 April 2018 15:31 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH] bbdev: change names of baseband devices > > Change baseband device name: > - from turbo_sw to base

Re: [dpdk-dev] how can I get a git version of Latest Major release? (18.02.1)

2018-04-26 Thread Thomas Monjalon
26/04/2018 18:15, Ferruh Yigit: > On 4/26/2018 4:58 PM, Thomas Monjalon wrote: > > 25/04/2018 19:23, Andrii: > >> The problem here is that common dpdk user is not able to find a stable > >> repository > >> from a website. > >> That would be great if dpdk.com/download or dpdk.com/dev would contain >

[dpdk-dev] [PATCH v2 3/3] net/mlx4: fix inner RSS support for broken kernels

2018-04-26 Thread Adrien Mazarguil
Linux 4.15 and 4.16 may report inner RSS as a supported capability of the device, however it can't be used due to missing code in the kernel. This triggers an error when creating the default hash QP and prevents this PMD from starting up without a prior call to rte_flow_isolate(). Fixes: 55e8991e

[dpdk-dev] [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error

2018-04-26 Thread Adrien Mazarguil
When creation of a flow rule fails during dev_start(), the usage count of the common RSS context is not decremented, which triggers an assertion failure in debug mode during dev_close(). This is addressed by tracking the initialization status of the common RSS context in order to add missing clean

[dpdk-dev] [PATCH v2 2/3] net/mlx4: fix default RSS hash fields

2018-04-26 Thread Adrien Mazarguil
Using special types value -1 with mlx4_conv_rss_types() is supposed to return a supported set of Verbs RSS hash fields, that is, priv->hw_rss_sup unmodified. Due to the way this function is written and because it is also used to initially populate priv->hw_rss_sup however, this special value works

Re: [dpdk-dev] [dpdk=-dev][PATCH v8 0/9] switching devices representation

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 11:40 AM, Declan Doherty wrote: > This patchset follows on from the port rerpesentor patchsets and the > community discussion that resulted. It outlines the model for > representing and controlling switching capable devices in a new > programmer's guide entry based upon the excellent s

Re: [dpdk-dev] [PATCH] app/pdump: remove unused socket path options

2018-04-26 Thread Thomas Monjalon
> > > The options --server-socket-path and --client-socket-path were said to > > > be deprecated and will be removed soon. > > > No need to wait for removing application options which have no effect, > > > and can confuse the user. > > > > > > Fixes: 660098d61f57 ("pdump: use generic multi-process

[dpdk-dev] [PATCH v1] net/mlx5: fix flow director rule deletion crash

2018-04-26 Thread Adrien Mazarguil
Flow director rules matching traffic properties above layer 2 do not target a fixed hash Rx queue (HASH_RXQ_ETH), it actually depends on the highest protocol layer specified by each flow rule. mlx5_fdir_filter_delete() makes this wrong assumption and causes a crash when attempting to destroy flow

Re: [dpdk-dev] [PATCH] app/test: fix failure on mempool autotest retry

2018-04-26 Thread Thomas Monjalon
25/04/2018 19:00, Andrew Rybchenko: > Single producer / single consumer mempool handle is stored in static > variable and the mempool allocated if stored value is NULL. > If the mempool is freed, NULL should be restored to make sure that > the mempool is allocated once again next time when the test

Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-26 Thread Kevin Traynor
On 04/26/2018 05:05 PM, Kevin Traynor wrote: > On 04/24/2018 11:16 PM, Arnon Warshavsky wrote: >> replace panic calls with log and return value. >> Replied to wrong version. Comments are still relevant for v9, Kevin. >> Signed-off-by: Arnon Warshavsky >> --- >> drivers/crypto/dpaa2_sec/dpaa2_s

Re: [dpdk-dev] how can I get a git version of Latest Major release? (18.02.1)

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 4:58 PM, Thomas Monjalon wrote: > 25/04/2018 19:23, Andrii: >> The problem here is that common dpdk user is not able to find a stable >> repository >> from a website. >> That would be great if dpdk.com/download or dpdk.com/dev would contain >> a direct link to http://dpdk.org/browse/ f

Re: [dpdk-dev] [PATCH v5] ethdev: check Rx/Tx offloads

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 4:50 PM, Ferruh Yigit wrote: > On 4/26/2018 3:37 PM, Wei Dai wrote: >> This patch check if a requested offloading is supported >> in the device capability. >> Any offloading is disabled by default if it is not set >> in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup(). >> A per

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 18:05, Andrew Rybchenko: > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > We have discussed that it would be good to deprecate RTE_MBUF_INDIRECT() > since

Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-26 Thread Kevin Traynor
I think the first line of the commit msg ^^^ should change as it no longer prevents but just warns On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes c

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Change some local functions return type from void to int. > This change does not break ABI as the functions are internal. > Panic thrown from threads was not handled in this patch > > Signed-off-by: Arnon Warshavsky > Acked-by: Anatoly Burakov >

Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_ether/rte_ethdev.c | 42 ++ > lib/librte_ether/rte_ethdev.h | 4 +++- > 2

Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test

2018-04-26 Thread Thomas Monjalon
06/02/2018 03:21, Phil Yang: > Since RTE_MAX_NUMA_NODES is configurable, the existing socket number > could greater than RTE_MAX_NUMA_NODES. Optimize test case to cover this > situation.(i.e RTE_MAX_NUMA_NODES=1) > > Fixes: 45f1b6e8680a ('app: add new tests on eal flags') Cc: sta...@dpdk.org > S

  1   2   3   >