26/04/2018 21:42, Olivier Matz: > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > 26/04/2018 18:05, Andrew Rybchenko: > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > > > > > We have discussed that it would be good to deprecate RTE_MBUF_INDIRECT() > > > since it is not !RTE_MBUF_DIREC(). Is it lost here or intentional (may > > > be I've lost > > > in the thread)? > > > > I think it should be a separate deprecation notice. > > Agree with Andrew that RTE_MBUF_INDIRECT should be deprecated > to avoid confusion with !DIRECT.
What do you mean? We should add a comment? Or poisoining the macro? Or something else? Should it be removed? In which release?
