Re: [dpdk-dev] [PATCH v4 1/2] drivers: add common folder

2018-04-02 Thread Hemant Agrawal
On 4/2/2018 2:39 PM, Pavan Nikhilesh wrote: Add driver/common folder and skeleton makefile for adding commonly used functions across mempool, event and net devices. Signed-off-by: Pavan Nikhilesh --- Acked-by: Hemant Agrawal

[dpdk-dev] Got bug while using valgrind on OVS-DPDK?

2018-04-02 Thread Sam
Hi all, I want to use valgrind to check if there is memleak of OVS-DPDK's ovs-vswitchd, so I use this command: valgrind ovs-vswitchd ... But got errors like this: the system does not support "RDRNAD" > please check that RTE_MACHINE is set correctly Does that mean valgrind does NOT support OV

Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2

2018-04-02 Thread Shreyansh Jain
On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: Some comments are not relevant in a config which only overrides the default config. The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled by default so it can be removed from this file. Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH] [pktgen] [PATCH] Fix the "rte_memcpy" compiling on aarch64 platform

2018-04-02 Thread Bing Zhao
The "rte_memcpy" will be a macro but not a function on aarch64 platform if the flags are not enabled (latest version). In old versions, it will always be a macro to memcpy. Now the preprocessor couldn't handle the "rte_memcpy" properly. Because the definition has the format like "rte_memcpy(d, s

Re: [dpdk-dev] [PATCH v3] net/bnxt: convert to SPDX license tag

2018-04-02 Thread Hemant Agrawal
On 4/3/2018 4:04 AM, Ajit Khaparde wrote: From: Scott Branden Update the license header on bnxt files to be the standard BSD-3-Clause license used for the rest of DPDK, bring the files in compliance with the DPDK licensing policy. Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --

Re: [dpdk-dev] [PATCH] eal/vfio: export internal vfio functions

2018-04-02 Thread Hemant Agrawal
Hi Thomas, On 3/27/2018 9:23 PM, Thomas Monjalon wrote: 14/03/2018 09:00, Hemant Agrawal: This patch moves some of the internal vfio functions from eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. This patch also change the FSLMC bus usages from the internal VFIO functions to exter

[dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error

2018-04-02 Thread Wei Zhao
Vlan tci configuration from testpmd is store in big endian, so it need to be change to little endian before using. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Peng Yuan --- drivers/net/i40e/i40e_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 del

[dpdk-dev] [PATCH] net/i40e: fix flow RSS queue region error

2018-04-02 Thread Wei Zhao
Queue region comparison error in configuration parameters. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Peng Yuan --- drivers/net/i40e/i40e_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_flow.c b/driv

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Shahaf Shuler
Monday, April 2, 2018 6:54 PM, Thomas Monjalon: > 01/04/2018 06:44, Shahaf Shuler: > > > There is the same kind of confusion in the offload capabilities: > > > rte_eth_dev_info.[rt]x_offload_capa > > > rte_eth_dev_info.[rt]x_queue_offload_capa > > > The queue capabilities must be a subset of po

Re: [dpdk-dev] [PATCH] event/octeontx: support device stop flush callback

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Thu, 22 Mar 2018 18:31:08 + > From: "Eads, Gage" > To: Jerin Jacob , "dev@dpdk.org" > > CC: "Van Haaren, Harry" , > "hemant.agra...@nxp.com" , > "pbhagavat...@caviumnetworks.com" , > "nipun.gu...@nxp.com" , > "santosh.shu...@caviumnetworks.com" > Subje

Re: [dpdk-dev] [PATCH] net/mlx5: remove excessive data prefetch

2018-04-02 Thread Shahaf Shuler
Tuesday, March 13, 2018 2:45 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove excessive data prefetch > > On Mon, Mar 12, 2018 at 10:05:45AM -0700, Yongseok Koh wrote: > > In Enhanced Multi-Packet Send (eMPW), entire packet data is prefetched > > to LLC if it isn't inlined.

[dpdk-dev] [PATCH] net/mlx5: fix link status initialization

2018-04-02 Thread Shahaf Shuler
Following commit 7ba5320baa32 ("net/mlx5: fix link status behavior") The initial link status is no longer set as part of the port start. This may cause application to query the link as down while in fact it was already up before the DPDK application start. Fixes: 7ba5320baa32 ("net/mlx5: fix link

[dpdk-dev] [PATCH v2 1/2] net/e1000: convert to new Rx offloads API

2018-04-02 Thread Wei Dai
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Wei Dai --- drivers/net/e1000/e1000_ethdev.h | 8 +++ drivers/net/e1000/em_ethdev.c| 42 ++- drivers/net/e1000/

[dpdk-dev] [PATCH v2 0/2] net/e1000: convert to new Rx/Tx offloads API

2018-04-02 Thread Wei Dai
This patch set convert net/e1000 to new Rx/Tx offloads API. All Rx offloads are per port features. All Tx offloads of e1000 are per queue and also per packet as they are enabled in Tx descriptor. In the new offload API, per queue offload only need to be set in queue_setup(). So if the maimum number

[dpdk-dev] [PATCH v2 2/2] net/e1000: convert to new Tx offloads API

2018-04-02 Thread Wei Dai
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Wei Dai --- drivers/net/e1000/e1000_ethdev.h | 6 drivers/net/e1000/em_ethdev.c| 16 +++ drivers/net/e1000/em_rx

Re: [dpdk-dev] [PATCH v5] eventdev: add device stop flush callback

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Tue, 3 Apr 2018 06:56:49 +0530 > From: Jerin Jacob > To: Gage Eads > CC: dev@dpdk.org, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > bruce.richard...@intel.com, santosh.shu...@caviumnetworks.com, > nipun.gu...@nxp.com, liang.j...@intel.com > Subject: R

Re: [dpdk-dev] [PATCH v5] eventdev: add device stop flush callback

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 13:03:30 -0500 > From: Gage Eads > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, bruce.richard...@intel.com, > santosh.shu...@caviumnetworks.com, nipun.gu...@nxp.com, > liang.j...@i

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, March 30, 2018 9:48 PM > To: dev@dpdk.org > Cc: Ajit Khaparde ; Jerin Jacob > ; Shijith Thotton > ; Santosh Shukla > ; Rahul Lakkireddy > ; John Daley ; Lu, > Wenzhuo ; Ananyev, Konstantin > ; Xing,

Re: [dpdk-dev] [PATCH v9 8/9] doc: add event timer adapter section to programmer's guide

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:53 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 8/9] doc: add event timer adapter section to > programmer's guide >

Re: [dpdk-dev] [PATCH v9 9/9] doc: add event timer adapter documentation

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:54 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 9/9] doc: add event timer adapter documentation > X-Mailer: git-send

Re: [dpdk-dev] [PATCH v9 4/9] mk: update library order in static build

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:49 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 4/9] mk: update library order in static build > X-Mailer: git-send-e

Re: [dpdk-dev] [PATCH v5 0/3] runtime queue setup

2018-04-02 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, April 2, 2018 4:00 AM > To: tho...@monjalon.net; Ananyev, Konstantin > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [PATCH v5 0/3] runtime queue setup > > v5: > - fix first tx queue ch

Re: [dpdk-dev] [PATCH v9 3/9] eventtimer: add common code

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:48 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 3/9] eventtimer: add common code > X-Mailer: git-send-email 1.7.10 >

Re: [dpdk-dev] [PATCH v9 2/9] eventdev: convert to SPDX license tag in header

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:47 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 2/9] eventdev: convert to SPDX license tag in header > X-Mailer: git

Re: [dpdk-dev] [PATCH v9 1/9] eventtimer: introduce event timer adapter

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:46 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 1/9] eventtimer: introduce event timer adapter > X-Mailer: git-send-

Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 14:39:45 -0500 > From: Erik Gabriel Carrillo > To: pbhagavat...@caviumnetworks.com > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com > Subject: [PATCH v9 0/9] eventtimer: introduce event timer adapter > X-Mailer: git-send

Re: [dpdk-dev] [PATCH v2 5/7] bpf: introduce basic RX/TX BPF filters

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Fri, 30 Mar 2018 18:32:41 +0100 > From: Konstantin Ananyev > To: dev@dpdk.org > CC: Konstantin Ananyev > Subject: [dpdk-dev] [PATCH v2 5/7] bpf: introduce basic RX/TX BPF filters > X-Mailer: git-send-email 1.7.0.7 > > Introduce API to install BPF based filters

[dpdk-dev] [PATCH v3] net/bnxt: convert to SPDX license tag

2018-04-02 Thread Ajit Khaparde
From: Scott Branden Update the license header on bnxt files to be the standard BSD-3-Clause license used for the rest of DPDK, bring the files in compliance with the DPDK licensing policy. Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde -- v1->v2: modify first line of SPDX identifer

Re: [dpdk-dev] [RFC PATCH 5/5] test: add few eBPF samples

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Fri, 30 Mar 2018 17:42:22 + > From: "Ananyev, Konstantin" > To: 'Jerin Jacob' > CC: "'dev@dpdk.org'" > Subject: RE: [dpdk-dev] [RFC PATCH 5/5] test: add few eBPF samples > > Hi Jerin, > > > > Add few simple eBPF programs as an example. > > > > > > > > Sign

[dpdk-dev] [PATCH v3 2/2] net/bnxt: fix rx_drop_en setting

2018-04-02 Thread Ajit Khaparde
If Rx descriptors are not available, pkts are dropped by default. Fix rx_drop_en setting in bnxt_dev_info_get_op to reflect it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/d

[dpdk-dev] [PATCH v3 1/2] net/bnxt: switch to the new offload API

2018-04-02 Thread Ajit Khaparde
Update bnxt PMD to new ethdev offloads API. Signed-off-by: Ajit Khaparde -- v1->v2: return an error if requested offload flags do not match supported offload capabilities. v2->v3: modify the code based on review comments. --- drivers/net/bnxt/bnxt_ethdev.c | 58 +-

[dpdk-dev] [PATCH] config: remove useless lines for DPAA2

2018-04-02 Thread Thomas Monjalon
Some comments are not relevant in a config which only overrides the default config. The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled by default so it can be removed from this file. Signed-off-by: Thomas Monjalon --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 --- 1 fil

Re: [dpdk-dev] [PATCH v4 0/7] Change DPAA2 to dynamic logging

2018-04-02 Thread Thomas Monjalon
02/04/2018 16:05, Shreyansh Jain: > ::History:: > v4: > - move CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER to common_base > - rebase over master (db2ed70bbb) > > v3: > - Fixed review comments > - one debug macro un-removed (CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER) >which is continued to be used by d

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Patil, Harish
-Original Message- From: Thomas Monjalon Date: Monday, April 2, 2018 at 1:10 PM To: Harish Patil Cc: "dev@dpdk.org" , Ajit Khaparde , "Jacob, Jerin" , "Thotton, Shijith" , "Shukla, Santosh" , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jin

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Thomas Monjalon
02/04/2018 19:39, Patil, Harish: > >It was also proposed to relax the API and allow "forgetting" port > >offloads in queue offloads: > > http://dpdk.org/ml/archives/dev/2018-March/092978.html > > > >It would mean the offloads applied to a queue result of OR operation: > > rte_eth_conf.[rt]x

Re: [dpdk-dev] [dpdk-stable] [PATCH 4/4] vfio: do not needlessly check for IOVA mode

2018-04-02 Thread Thomas Monjalon
02/04/2018 19:12, Burakov, Anatoly: > On 02-Apr-18 5:29 PM, Thomas Monjalon wrote: > > 01/04/2018 14:26, Anatoly Burakov: > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Anatoly Burakov > > > > It deserves an explanation. > > > > Please Anatoly, think about commit explanations more often. > >

[dpdk-dev] [PATCH v9 9/9] doc: add event timer adapter documentation

2018-04-02 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- MAINTAINERS| 7 +++ doc/api/doxy-api-index.md | 32 +++- doc/guides/rel_notes/release_18_05.rst | 6 ++ 3 files changed, 16 insertions(+), 29 deletions(-) diff --git a/MAINTAIN

[dpdk-dev] [PATCH v9 7/9] test: add event timer adapter auto-test

2018-04-02 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- test/test/Makefile |1 + test/test/test_event_timer_adapter.c | 1831 ++ 2 files changed, 1832 insertions(+) create mode 100644 test/test/test_event_timer_adapter.c diff --git a/test/test/Makefile b/t

[dpdk-dev] [PATCH v9 8/9] doc: add event timer adapter section to programmer's guide

2018-04-02 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- doc/guides/prog_guide/event_timer_adapter.rst | 297 ++ doc/guides/prog_guide/index.rst | 1 + 2 files changed, 298 insertions(+) create mode 100644 doc/gu

[dpdk-dev] [PATCH v9 6/9] eventtimer: add support for meson build system

2018-04-02 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- config/rte_config.h | 1 + lib/librte_eventdev/meson.build | 9 ++--- lib/meson.build | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/config/rte_config.h b/config/rte_config.h index 72c0aa2..117c19f 1

[dpdk-dev] [PATCH v9 4/9] mk: update library order in static build

2018-04-02 Thread Erik Gabriel Carrillo
The introduction of the event timer adapter library adds a dependency on the rte_timer library from the rte_eventdev library. Update the order so that the timer library comes after the eventdev library in the linker command when statically linking applications. Signed-off-by: Erik Gabriel Carrill

[dpdk-dev] [PATCH v9 3/9] eventtimer: add common code

2018-04-02 Thread Erik Gabriel Carrillo
This commit adds the logic that is shared by all event timer adapter drivers; the common code handles instance allocation and some initialization. Signed-off-by: Erik Gabriel Carrillo --- config/common_base| 1 + drivers/event/sw/sw_evdev.c

[dpdk-dev] [PATCH v9 1/9] eventtimer: introduce event timer adapter

2018-04-02 Thread Erik Gabriel Carrillo
Event devices can be coupled with various components to provide new event sources by using event adapters. The event timer adapter is one such adapter; it bridges event devices and timer mechanisms. This library extends the event-driven programming model by introducing a new type of event that rep

[dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver

2018-04-02 Thread Erik Gabriel Carrillo
If an eventdev PMD does not wish to provide event timer adapter ops definitions, the library will fall back to a default software implementation whose entry points are added by this commit. Signed-off-by: Erik Gabriel Carrillo --- lib/Makefile | 2 +- lib/librt

[dpdk-dev] [PATCH v9 2/9] eventdev: convert to SPDX license tag in header

2018-04-02 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- lib/librte_eventdev/rte_eventdev.h | 37 + 1 file changed, 5 insertions(+), 32 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index e79583a..297a93d 100644 --- a/lib/l

[dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

2018-04-02 Thread Erik Gabriel Carrillo
This patch series contains the next iteration of the Event Timer Adapter library, which abstracts timer mechanisms that are tightly coupled with event devices, and extends the event based programming model so that timer expirations are represented as an event. v9 - Addressed comments on previous s

Re: [dpdk-dev] [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases

2018-04-02 Thread Neil Horman
On Mon, Apr 02, 2018 at 06:50:12PM +0200, Thomas Monjalon wrote: > 02/04/2018 14:06, Neil Horman: > > https://dpdk.org/tracker/show_bug.cgi?id=18 > > I really appreciate reading such bug request. No worries. It was there, I had time :) > Maybe we should add a Suggested-by line > Suggested-b

Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag

2018-04-02 Thread Scott Branden
On 18-03-31 02:08 PM, Ferruh Yigit wrote: On 3/30/2018 7:10 PM, Scott Branden wrote: Hi Ferruh, On 18-03-30 03:35 AM, Ferruh Yigit wrote: On 3/29/2018 5:40 PM, Ajit Khaparde wrote: From: Scott Branden Update the license header on bnxt files to be the standard BSD-3-Clause license used fo

[dpdk-dev] [PATCH v2 5/6] net/mlx5: release Tx queue resource earlier than Rx

2018-04-02 Thread Yongseok Koh
Multi-Packet RQ uses mbuf indirection and direct mbufs come from the private Mempool (rxq->mprq_mp) of PMD. To properly release the Mempool, it is better to empty the Tx completeion array (txq->elts) before releasing it. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 16 --

[dpdk-dev] [PATCH v2 6/6] app/testpmd: conserve mbuf indirection flag

2018-04-02 Thread Yongseok Koh
If PMD delivers Rx packets with mbuf indirection, ol_flags should not be overwritten. For mlx5 PMD, if Multi-Packet RQ is enabled, Rx packets could be indirect mbufs. Signed-off-by: Yongseok Koh --- app/test-pmd/csumonly.c | 2 ++ app/test-pmd/macfwd.c | 2 ++ app/test-pmd/macswap.c | 2 ++ 3

[dpdk-dev] [PATCH v2 3/6] net/mlx5: add a function to rdma-core glue

2018-04-02 Thread Yongseok Koh
mlx5dv_create_wq() is added for the Multi-Packet RQ (a.k.a Striding RQ). Signed-off-by: Yongseok Koh --- drivers/net/mlx5/Makefile| 7 ++- drivers/net/mlx5/mlx5_glue.c | 16 drivers/net/mlx5/mlx5_glue.h | 8 3 files changed, 30 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v2 4/6] net/mlx5: add Multi-Packet Rx support

2018-04-02 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH v2 0/6] net/mlx5: add Multi-Packet Rx support

2018-04-02 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH v2 2/6] net/mlx5: separate filling Rx flags

2018-04-02 Thread Yongseok Koh
Filling in fields of mbuf becomes a separate inline function so that this can be reused. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/

[dpdk-dev] [PATCH v2 1/6] mbuf: add buffer offset field for flexible indirection

2018-04-02 Thread Yongseok Koh
When attaching a mbuf, indirect mbuf has to point to start of buffer of direct mbuf. By adding buf_off field to rte_mbuf, this becomes more flexible. Indirect mbuf can point to any part of direct mbuf by calling rte_pktmbuf_attach_at(). Possible use-cases could be: - If a packet has multiple layer

[dpdk-dev] [PATCH] build: meson set toolchain info during config init

2018-04-02 Thread Pavan Nikhilesh
Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 9 - config/meson.build | 8 2 files changed, 8 insertions(+), 9 del

[dpdk-dev] [PATCH v2] eal: abstract away the auxiliary vector

2018-04-02 Thread Aaron Conole
Rather than attempting to load the contents of the auxv directly, prefer to use an exposed API - and if that doesn't exist then attempt to load the vector. This is because on some systems, when a user is downgraded, the /proc/self/auxv file retains the old ownership and permissions. The original

[dpdk-dev] [PATCH v5] eventdev: add device stop flush callback

2018-04-02 Thread Gage Eads
When an event device is stopped, it drains all event queues and ports. These events may contain pointers, so to prevent memory leaks eventdev now supports a user-provided flush callback that is called during the queue drain process. This callback is stored in process memory, so the callback must be

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Patil, Harish
-Original Message- From: Thomas Monjalon Date: Friday, March 30, 2018 at 6:47 AM To: "dev@dpdk.org" Cc: Ajit Khaparde , "Jacob, Jerin" , "Thotton, Shijith" , "Shukla, Santosh" , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jingjing Wu , Adri

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, March 30, 2018 6:48 AM > To: dev@dpdk.org > Cc: Ajit Khaparde ; Jerin Jacob > ; Shijith Thotton > ; > Santosh Shukla ; Rahul Lakkireddy > ; John Daley ; Lu, Wenzhuo > ; Ananyev, Konstantin ; > Xing

Re: [dpdk-dev] [dpdk-stable] [PATCH 4/4] vfio: do not needlessly check for IOVA mode

2018-04-02 Thread Burakov, Anatoly
On 02-Apr-18 5:29 PM, Thomas Monjalon wrote: 01/04/2018 14:26, Anatoly Burakov: Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov It deserves an explanation. Please Anatoly, think about commit explanations more often. I was under the impression that from context of previous patches, it

Re: [dpdk-dev] [PATCH v4 2/2] event/sw: support device stop flush callback

2018-04-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Apr 2018 15:50:42 + > From: "Eads, Gage" > To: Jerin Jacob > CC: "Van Haaren, Harry" , "dev@dpdk.org" > , "hemant.agra...@nxp.com" , > "Richardson, Bruce" , > "santosh.shu...@caviumnetworks.com" , > "nipun.gu...@nxp.com" > Subject: RE: [PATCH v4

[dpdk-dev] [PATCH] doc: add timestamp offload for mlx5 to features table

2018-04-02 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- doc/guides/nics/features/mlx5.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini index c36363915..f8ce08770 100644 --- a/doc/guides/nics/features/mlx5.ini +++ b/doc/guides/nics/features/mlx

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Thomas Monjalon
01/04/2018 06:44, Shahaf Shuler: > > There is the same kind of confusion in the offload capabilities: > > rte_eth_dev_info.[rt]x_offload_capa > > rte_eth_dev_info.[rt]x_queue_offload_capa > > The queue capabilities must be a subset of port capabilities, i.e. every > > queue > > capabilitie

Re: [dpdk-dev] [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases

2018-04-02 Thread Thomas Monjalon
02/04/2018 14:06, Neil Horman: > https://dpdk.org/tracker/show_bug.cgi?id=18 I really appreciate reading such bug request. Maybe we should add a Suggested-by line Suggested-by: Solal Pirelli before the SoB line (chronological order). > Indicated that several mmap call sites in the linux

Re: [dpdk-dev] [PATCH v2] eal/vfio: export internal vfio functions

2018-04-02 Thread Thomas Monjalon
02/04/2018 10:36, Hemant Agrawal: > This patch moves some of the internal vfio functions from > eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. > > This patch also change the FSLMC bus usages from the internal > VFIO functions to external ones with "rte_" prefix > > Signed-off-by: He

Re: [dpdk-dev] [dpdk-stable] [PATCH 4/4] vfio: do not needlessly check for IOVA mode

2018-04-02 Thread Thomas Monjalon
01/04/2018 14:26, Anatoly Burakov: > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov It deserves an explanation. Please Anatoly, think about commit explanations more often.

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-02 Thread Stephen Hemminger
On Sat, 31 Mar 2018 14:48:55 -0400 Neil Horman wrote: > On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: > > On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > > > On Sat, Mar 31, 2018 at 05:09:47PM +0200, Gaëtan Rivet wrote: > > > > On Sat, Mar 31, 2018 at 09:33:43AM

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-02 Thread santosh
Hello David, On Friday 30 March 2018 08:59 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with g

[dpdk-dev] [PATCH] net/octeontx: remove redundent driver name update

2018-04-02 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- drivers/net/octeontx/octeontx_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 90dd249a6..b3512393a 100644 --- a/drivers/net/octeontx/octeontx_e

[dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-04-02 Thread Vipin Varghese
The change adds functional TUN PMD logic to the existing TAP PMD. TUN PMD can be initialized with 'net_tunX' where 'X' represents unique id. PMD supports argument interface, while MAC address and remote are not supported. Signed-off-by: Vipin Varghese --- Changes in V3: - fix the TUN kernel pac

[dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-02 Thread Vipin Varghese
The changes add TUN|TAP specific logs and documentation support. Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 15 +-- drivers/net/tap/rte_eth_tap.c | 28 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics

Re: [dpdk-dev] [PATCH v4 2/2] event/sw: support device stop flush callback

2018-04-02 Thread Eads, Gage
If it's ok with you, I'll resubmit these two patches separately. The sw implementation has some unresolved race conditions with the scheduler service that may take some time to fix, but this shouldn't block the first patch. That patch needs a fix too (v4 includes a now-incorrect comment about st

Re: [dpdk-dev] [PATCH] sec

2018-04-02 Thread Hemant Agrawal
Please ignore it. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Monday, April 02, 2018 9:03 PM > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; Akhil Goyal ; dpdk- > up > Subject: [dpdk-dev] [PATCH] sec > > Signed-off-by: Heman

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-02 Thread Thomas Monjalon
01/04/2018 03:51, Zhang, Qi Z: > > There are some discussions about a specific part of the offload API: > > "To enable per-port offload, the offload should be set on both > > device configuration and queue setup." > > > > It means the application must repeat the port offload flags in > > r

[dpdk-dev] [PATCH v3 8/8] crypto/dpaa2_sec: fix OP storage for physical IOVA mode

2018-04-02 Thread Hemant Agrawal
op storage in fle is just for reference for post dq. So, don't convert it to iova mode. Fixes: 37f96eb01bce ("crypto/dpaa2_sec: support scatter gather") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 -- drivers/crypto/dpaa2_sec/dpaa2_sec_

[dpdk-dev] [PATCH v3 7/8] crypto/dpaa_sec: move mempool allocation to config

2018-04-02 Thread Hemant Agrawal
From: Akhil Goyal Currently, the context mempools are allocated during device probe. Thus, even if the DPAA SEC devices are not used, any application would still allocate the memory required for working with the contexts. This patch moves the allocation to configuration time so that when the CAA

[dpdk-dev] [PATCH v3 5/8] crypto/dpaa_sec: fix to check the portal presence

2018-04-02 Thread Hemant Agrawal
From: Ashish Jain Adding a check to do portal configuration if not already configured before packet enqueue. This check is only done during dpaa_sec_attach_sess_q for initial packets, so this change wont affect the data path and hence performance. Fixes: e79416d10fa3 ("crypto/dpaa_sec: support m

[dpdk-dev] [PATCH v3 6/8] crypto/dpaa_sec: fix incorrect NULL check

2018-04-02 Thread Hemant Agrawal
From: Shreyansh Jain Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Cc: akhil.go...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/c

[dpdk-dev] [PATCH v3 4/8] crypto/dpaa_sec: add macro for device name

2018-04-02 Thread Hemant Agrawal
From: Ashish Jain Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Cc: sta...@dpdk.org Signed-off-by: Ashish Jain --- drivers/crypto/dpaa_sec/dpaa_sec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/d

[dpdk-dev] [PATCH v3 2/8] app/crypto-perf: fix excess crypto device error

2018-04-02 Thread Hemant Agrawal
If number of available devices are more than logical core, no need to through an error. Just use the less number of devices. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Acked-by: Pablo de Lara --- app/test-cr

[dpdk-dev] [PATCH v3 3/8] app/crypto-perf: enable it for non default mempool

2018-04-02 Thread Hemant Agrawal
The current code usages the default mempool ops while creating the mempool for crypto usages. Adding the support for best_mempool_ops to enable it for devices using non default mempools. Signed-off-by: Ashish Jain Signed-off-by: Hemant Agrawal Acked-by: Pablo de Lara --- app/test-crypto-perf/M

[dpdk-dev] [PATCH] sec

2018-04-02 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 50a301d..b31f64c 100644 --- a/drivers

[dpdk-dev] [PATCH v3 1/8] test/crypto: add macro for dpaa sec device name

2018-04-02 Thread Hemant Agrawal
From: Ashish Jain Fixes: b674d6d0381a ("test/crypto: add dpaa crypto test cases") Cc: sta...@dpdk.org Signed-off-by: Ashish Jain Acked-by: Pablo de Lara --- test/test/test_cryptodev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/test_cryptodev.h b/test/test/test_cryptodev.h i

Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's

2018-04-02 Thread Thomas Monjalon
31/03/2018 15:35, Burakov, Anatoly: > On 27-Mar-18 5:24 PM, Thomas Monjalon wrote: > > 22/03/2018 13:36, Anatoly Burakov: > >> --- a/lib/librte_eal/common/include/rte_eal.h > >> +++ b/lib/librte_eal/common/include/rte_eal.h > >> @@ -57,6 +57,9 @@ enum rte_proc_type_t { > >> struct rte_config { >

Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-04-02 Thread Thomas Monjalon
27/03/2018 14:14, Kovacevic, Marko: > From: Marko Kovacevic > > Signed-off-by: Marko Kovacevic No comment at all? This new version doesn't work with the env variable. It is probably worth few words. > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -183,8 +183,6 @@ config () #

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-04-02 Thread Thomas Monjalon
27/03/2018 14:15, Kovacevic, Marko: > From: Marko Kovacevic > > Signed-off-by: Marko Kovacevic No comment at all? Is it a new feature in the IPsec Multi-buffer lib v0.49?

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-02 Thread Zhang, Qi Z
> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > Sent: Monday, April 2, 2018 9:57 PM > To: Zhang, Qi Z > Cc: Zhang, Helin ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Charles (Chas) Williams > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_l

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-02 Thread Chas Williams
On Mon, Apr 2, 2018 at 9:45 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Chas Williams [mailto:3ch...@gmail.com] >> Sent: Monday, April 2, 2018 9:38 PM >> To: Zhang, Qi Z >> Cc: Zhang, Helin ; dev@dpdk.org; Lu, Wenzhuo >> ; Ananyev, Konstantin >> ; Charles (Chas) Williams >>

[dpdk-dev] [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging

2018-04-02 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- config/common_base | 3 - config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 - doc/guides/cryptodevs/dpaa2_sec.rst | 21 +- drivers/crypto/dpaa2_sec/Makefile | 5 - drivers/crypto/dpaa2_sec

[dpdk-dev] [PATCH v4 5/7] bus/fslmc: remove unused debug macros

2018-04-02 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_logs.h | 40 1 file changed, 40 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index 1f3fe8e66..9750b8c8d 100644 --- a/drivers/b

[dpdk-dev] [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints

2018-04-02 Thread Shreyansh Jain
Digest and IV length variable declarations have changed. These were escaping builds as the debugging macro was disabled. During dynamic logging change, they were discoverd. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session") Fixes: 7f0034275a24 ("cryptodev: remove digest length from c

[dpdk-dev] [PATCH v4 2/7] mempool/dpaa2: change to dynamic logging

2018-04-02 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/mempool/dpaa2/Makefile| 6 --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 60 +-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 38 + 3 files changed, 75 insertions(

[dpdk-dev] [PATCH v4 4/7] event/dpaa2: change to dynamic logging

2018-04-02 Thread Shreyansh Jain
Some changes had already been pushed via SHA:72654f090a11 patch. This patch updates them. Cc: nipun.gu...@nxp.com Signed-off-by: Shreyansh Jain Acked-by: Nipun Gupta --- doc/guides/eventdevs/dpaa2.rst| 14 - drivers/event/dpaa2/dpaa2_eventdev.c | 49 +++-

[dpdk-dev] [PATCH v4 1/7] bus/fslmc: change to dynamic logging

2018-04-02 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- drivers/bus/fslmc/Makefile | 5 - drivers/bus/fslmc/fslmc_bus.c| 64 + drivers/bus/fslmc/fslmc_logs.h | 31 +++ drivers/bus/fslmc/fslmc_vfio.c | 151 +++---

[dpdk-dev] [PATCH v4 3/7] net/dpaa2: change into dynamic logging

2018-04-02 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Acked-by: Hemant Agrawal --- config/common_base| 4 - config/defconfig_arm64-dpaa2-linuxapp-gcc | 8 - doc/guides/nics/dpaa2.rst | 42 +++-- drivers/net/dpaa2/Makefile| 6 - drivers/net/dpaa2/base/dpaa2_

[dpdk-dev] [PATCH v4 0/7] Change DPAA2 to dynamic logging

2018-04-02 Thread Shreyansh Jain
::History:: v4: - move CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER to common_base - rebase over master (db2ed70bbb) v3: - Fixed review comments - one debug macro un-removed (CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER) which is continued to be used by dpaa2 mempool driver v2: - Fixed dynamic log identi

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-02 Thread Zhang, Qi Z
> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > Sent: Monday, April 2, 2018 9:38 PM > To: Zhang, Qi Z > Cc: Zhang, Helin ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Charles (Chas) Williams > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_l

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

2018-04-02 Thread Chas Williams
On Mon, Apr 2, 2018 at 8:40 AM, Zhang, Qi Z wrote: > Hi Williams: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams >> Sent: Saturday, March 31, 2018 1:22 AM >> To: Zhang, Helin >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >> Konstantin ; Charles

Re: [dpdk-dev] [PATCH v2 8/8] crypto/dpaa2_sec: fix OP storage for physical IOVA mode

2018-04-02 Thread De Lara Guarch, Pablo
Hi Hemant, > -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Monday, April 2, 2018 8:37 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH v2 8/8] crypto/dpaa2_sec: fix OP storage for physical IOVA > mode > > op st

  1   2   >