If it's ok with you, I'll resubmit these two patches separately. The sw implementation has some unresolved race conditions with the scheduler service that may take some time to fix, but this shouldn't block the first patch. That patch needs a fix too (v4 includes a now-incorrect comment about stop not draining events from ports), so I'll fix and resubmit that.
Thanks, Gage > -----Original Message----- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, April 2, 2018 3:03 AM > To: Eads, Gage <gage.e...@intel.com> > Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; dev@dpdk.org; > hemant.agra...@nxp.com; Richardson, Bruce <bruce.richard...@intel.com>; > santosh.shu...@caviumnetworks.com; nipun.gu...@nxp.com > Subject: Re: [PATCH v4 2/2] event/sw: support device stop flush callback > > > > [Update: Ah I see you do this below already. Still, better check > > > twice I think, the data path isn't running here anyway in case > > > future me decides to call > > > sw_flush_iq() without performing the check] > > > > Agreed, will fix in v5. > > Gage, > > Could please send the v5 so that I can include it in RC1 pull request. >
