-----Original Message----- From: Thomas Monjalon <tho...@monjalon.net> Date: Monday, April 2, 2018 at 1:10 PM To: Harish Patil <harish.pa...@cavium.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Ajit Khaparde <ajit.khapa...@broadcom.com>, "Jacob, Jerin" <jerin.jacobkollanukka...@cavium.com>, "Thotton, Shijith" <shijith.thot...@cavium.com>, "Shukla, Santosh" <santosh.shu...@cavium.com>, Rahul Lakkireddy <rahul.lakkire...@chelsio.com>, John Daley <johnd...@cisco.com>, Wenzhuo Lu <wenzhuo...@intel.com>, Konstantin Ananyev <konstantin.anan...@intel.com>, Beilei Xing <beilei.x...@intel.com>, Qi Zhang <qi.z.zh...@intel.com>, Jingjing Wu <jingjing...@intel.com>, Adrien Mazarguil <adrien.mazarg...@6wind.com>, Nelio Laranjeiro <nelio.laranje...@6wind.com>, Yongseok Koh <ys...@mellanox.com>, Shahaf Shuler <shah...@mellanox.com>, Tomasz Duszynski <t...@semihalf.com>, Jianbo Liu <jianbo....@arm.com>, Alejandro Lucero <alejandro.luc...@netronome.com>, Hemant Agrawal <hemant.agra...@nxp.com>, Shreyansh Jain <shreyansh.j...@nxp.com>, "Mody, Rasesh" <rasesh.m...@cavium.com>, Andrew Rybchenko <arybche...@solarflare.com>, Shrikrishna Khare <skh...@vmware.com>, Maxime Coquelin <maxime.coque...@redhat.com>, Allain Legacy <allain.leg...@windriver.com>, Bruce Richardson <bruce.richard...@intel.com>, Gaetan Rivet <gaetan.ri...@6wind.com>, Olivier Matz <olivier.m...@6wind.com> Subject: Re: Survey for final decision about per-port offload API
>02/04/2018 19:39, Patil, Harish: >> >It was also proposed to relax the API and allow "forgetting" port >> >offloads in queue offloads: >> > http://dpdk.org/ml/archives/dev/2018-March/092978.html >> > >> >It would mean the offloads applied to a queue result of OR operation: >> > rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads >> > >> >1/ Do you agree with above API change? >> >> Yes. But pls confirm that this would still work properly if RX supports >> port-only based offloads and doesn’t support queue based offloads at >>all, >> as advertised in dev_infos_get(). >> >> dev_info->rx_queue_offload_capa = 0 and >> dev_info->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM | ...); > >Yes, of course, no queue offload at all is possible. > Okay, thanks. >
