01/04/2018 06:44, Shahaf Shuler: > > There is the same kind of confusion in the offload capabilities: > > rte_eth_dev_info.[rt]x_offload_capa > > rte_eth_dev_info.[rt]x_queue_offload_capa > > The queue capabilities must be a subset of port capabilities, i.e. every > > queue > > capabilities must be reported as port capabilities. > > But the port capabilities should be reported at queue level only if it can > > be > > applied to a specific queue. > > > > 4/ Do you agree with above statement (to be added in the doc)? > > No. > > The documentation should describe the API from the application side, and not > provide guidelines for the PMDs implementation. > If missing, we should clarify more about what queue and port offload means. > Something like: > "When port offload is enabled, the offload applies on the port along with all > of its associated queues" and > "When queue offload is enabled the offload, the offload applies only on the > specific queue." > > The PMDs then will decide how they report the different offloads they offer.
I don't understand why you want to be free in capabilities implementation. If the capabilities are not strictly standardized, how can they be used by the application? Rewording from application point of view: All the offload capabilities (port-level and queue-level) are reported in rte_eth_dev_info.[rt]x_offload_capa. The offloads reported in rte_eth_dev_info.[rt]x_queue_offload_capa can be applied to a specific queue. Is it OK?
