01/04/2018 03:51, Zhang, Qi Z: > > There are some discussions about a specific part of the offload API: > > "To enable per-port offload, the offload should be set on both > > device configuration and queue setup." > > > > It means the application must repeat the port offload flags in > > rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads, when calling > > respectively rte_eth_dev_configure() and rte_eth_[rt]x_queue_setup for each > > queue. > > > > The PMD must check if there is mismatch, i.e. a port offload not repeated in > > queue setup. > > There is a proposal to do this check at ethdev level: > > http://dpdk.org/ml/archives/dev/2018-March/094023.html > > > > It was also proposed to relax the API and allow "forgetting" port offloads > > in > > queue offloads: > > http://dpdk.org/ml/archives/dev/2018-March/092978.html > > > > It would mean the offloads applied to a queue result of OR operation: > > rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads > > > > 1/ Do you agree with above API change? > > > > > > If we agree with this change, we need to update the documentation and > > remove the checks in PMDs. > > Do you mean we will move offload check from PMD to ethdev, > or just remove specific check in each PMD > or it is not in the scope of this vote?
By "remove the checks", I mean removing the checks in each PMD for the port offloads repeated in queue offloads.
