Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-21 Thread Hanoch Haim (hhaim)
Hi Yongseok, RSS has a DPDK API,application can ask for the reta table size and configure it. In your case you are assuming specific use case and change the size dynamically which solve 90% of the use-cases but break the 10% use-case. Instead, you could provide the application a consistent AP

Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 9:26 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs > > > + > > + if (configured_offloads & DEV_RX_OFFLOAD_CHECKSUM) { > > + PMD_INIT_LOG(NOTICE, "rxcksum not supported"); > > + configured_offloads &= ~DEV_

Re: [dpdk-dev] [PATCH] net/bnxt: switch to the new offload API

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 9:27 PM, Ajit Khaparde: >Hi Shahaf, >Well, the application could. >While we can't ignore the advantages of enabling the offloads. >I felt if we should really mandate applications to request all the supported >offloads? Sorry, I don’t understand the question here. Can you

Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets

2018-03-21 Thread gowrishankar muthukrishnan
On Wednesday 21 March 2018 03:54 PM, Burakov, Anatoly wrote: +    config->numa_node_count = max_socket_id + 1; In some IBM servers, socket ID number does not seem to be in sequence. For an instance, 0 and 8 for a 2 node server. In this case, numa_node_count would mislead users if wrongly

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-21 Thread Shreyansh Jain
Hello Anatoly, > -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Wednesday, March 21, 2018 8:18 PM > To: Shreyansh Jain > Cc: dev@dpdk.org; Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK > [...] > >> > > > > Whi

[dpdk-dev] [PATCH v4 3/4] net/ixgbe: convert to new Rx offloads API

2018-03-21 Thread Wei Dai
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 93 +++--- drivers/net/ixgbe/ixgbe_ipsec.c | 8 +- dr

[dpdk-dev] [PATCH v4 4/4] net/ixgbe: convert to new Tx offloads API

2018-03-21 Thread Wei Dai
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 56 +--- drivers/net/ixgbe/ixgbe_ipsec.c | 5 ++- drivers

[dpdk-dev] [PATCH v4 2/4] net/ixgbe: support VLAN strip per queue offloading in VF

2018-03-21 Thread Wei Dai
VLAN strip is a per queue offloading in VF. With this patch it can be enabled or disabled on any Rx queue in VF. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH v4 1/4] net/ixgbe: support VLAN strip per queue offloading in PF

2018-03-21 Thread Wei Dai
VLAN strip is a per queue offloading in PF. With this patch it can be enabled or disabled on any Rx queue in PF. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 109 +-- drivers/net/ixgbe/ixgbe_ethdev.h | 4 +- drivers/net/ixgbe/ixgbe_pf.c

[dpdk-dev] [PATCH v4 0/4] net/ixgbe: convert to new offloads API

2018-03-21 Thread Wei Dai
This patch set adds support of per queue VLAN strip offloading in ixgbe PF and VF. This patch support new offloads API in ixgbe PF and VF. --- v4: don't support header spliting any more v3: Rx header spliting capability is only enabled in #ifdef RTE_HEADER_SPLIT_ENABLE. Tx vector tranmit

Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container

2018-03-21 Thread Wang, Xiao W
Hi Thomas, Rivet, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, March 22, 2018 5:38 AM > To: Thomas Monjalon > Cc: Wang, Xiao W ; Chen, Junjie J > ; dev@dpdk.org; maxime.coque...@redhat.com; > y...@fridaylinux.org; Wang, Zhihong ; Bie, Tiwei >

Re: [dpdk-dev] [PATCH v2 2/3] bus/pci: expose sysfs parsing API

2018-03-21 Thread Wang, Xiao W
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, March 22, 2018 4:45 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; maxime.coque...@redhat.com; y...@fridaylinux.org; Wang, > Zhihong ; Bie, Tiwei ; Chen, > Junjie J ; Xu, Rosen ; Daly, > Dan

Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-21 Thread Dai, Wei
Thanks Zhang Qi > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 21, 2018 10:24 PM > To: Dai, Wei ; Ananyev, Konstantin > ; tho...@monjalon.net > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx > offloads > > > > > -Origina

Re: [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes

2018-03-21 Thread Thomas Monjalon
20/02/2018 18:30, Thomas Monjalon: > This table does not fit in the page: > http://dpdk.org/doc/guides-18.02/nics/overview.html#id1 > because there are a lot of drivers, > and the vdev_netvsc is truncated in length. > > Both fixes are relevant for 18.02 backport. > > Thomas Monjalon (2): > do

Re: [dpdk-dev] [PATCH] maintainers: resign from GSO lib maintenance

2018-03-21 Thread Thomas Monjalon
> > > I will not be directly working on the DPDK project anymore. > > > > > > Signed-off-by: Mark Kavanagh > > Acked-by: Helin Zhang > Acked-by: Jiayu Hu Applied

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

2018-03-21 Thread Thomas Monjalon
12/02/2018 10:54, Maxime Coquelin: > Hi Yuanhan, > > On 02/12/2018 10:44 AM, Yuanhan Liu wrote: > > On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > >> I was doing terrible reviews jobs recently, and to not hold back > >> the vhost/virtio development, it's better for me to resign. >

Re: [dpdk-dev] [PATCH] maintainers: update vhost lib and pmd

2018-03-21 Thread Thomas Monjalon
12/02/2018 09:23, Maxime Coquelin: > Hi Jianfeng, > > On 02/11/2018 02:04 AM, Jianfeng Tan wrote: > > Signed-off-by: Jianfeng Tan > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 4f1f33b..38e5fb8 100644 > > --- a/MAIN

Re: [dpdk-dev] mlx5 reta size is dynamic

2018-03-21 Thread Yongseok Koh
On Wed, Mar 21, 2018 at 06:56:33PM +, Hanoch Haim (hhaim) wrote: > Hi mlx5 driver expert, > > DPDK: 17.11 > Any reason mlx5 driver change the rate table size dynamically based on the rx- > queues# ? The device only supports 2^n-sized indirection table. For example, if the number of Rx queues

Re: [dpdk-dev] [PATCH] drivers: rename bbdev directory to baseband

2018-03-21 Thread Thomas Monjalon
12/03/2018 12:44, Mokhtar, Amr: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > The drivers directory contains some sub-directories > > for each kind of device (or bus, mem): > > net, crypto, event, raw > > They are not suffixed with "dev" because it is obvious. > > > > For consi

Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container

2018-03-21 Thread Gaëtan Rivet
On Wed, Mar 21, 2018 at 09:32:18PM +0100, Thomas Monjalon wrote: > Hi, > > 21/03/2018 14:21, Xiao Wang: > > +#endif /* VFIO_PRESENT */ > > #endif /* _RTE_VFIO_H_ */ > > Please keep the empty line which was present between endif. > > > + rte_vfio_create_container; > > + rte_vfio_destroy_cont

Re: [dpdk-dev] [PATCH v3 3/5] vhost: add apis for datapath configuration

2018-03-21 Thread Maxime Coquelin
On 02/27/2018 11:13 AM, Zhihong Wang wrote: This patch adds APIs for datapath configuration. The eid and did of the vhost-user socket can be configured to identify the actual device. When the default software datapath is used, eid and did are set to -1. When alternative datapath is used, eid a

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-21 Thread Thomas Monjalon
21/03/2018 20:47, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > behavior in PMDs is to strip the CRC independent from this flag. > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Setting both KEEP_CRC

Re: [dpdk-dev] [PATCH v3 2/5] vhost: support selective datapath

2018-03-21 Thread Maxime Coquelin
On 02/27/2018 11:13 AM, Zhihong Wang wrote: This patch introduces support for selective datapath in DPDK vhost-user lib to enable various types of virtio-compatible devices to do data transfer with virtio driver directly to enable acceleration. The default datapath is the existing software impl

Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver

2018-03-21 Thread Maxime Coquelin
On 03/21/2018 02:21 PM, Xiao Wang wrote: ifcvf driver uses vdev as a control domain to manage ifc VFs that belong to it. It registers vDPA device ops to vhost lib to enable these VFs to be used as vhost data path accelerator. Live migration feature is supported by ifc VF and this driver enable

Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver

2018-03-21 Thread Thomas Monjalon
21/03/2018 14:21, Xiao Wang: > ifcvf driver uses vdev as a control domain to manage ifc VFs that belong > to it. It registers vDPA device ops to vhost lib to enable these VFs to be > used as vhost data path accelerator. Not everybody work at Intel. Please explain what means ifcvf and what is a con

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-21 Thread Maxime Coquelin
Hi Xiao, On 03/15/2018 05:49 PM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Sunday, March 11, 2018 2:24 AM To: Wang, Xiao W ; dev@dpdk.org Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang, Cunming ; Xu, Rosen ; Chen,

Re: [dpdk-dev] [PATCH v2 2/3] bus/pci: expose sysfs parsing API

2018-03-21 Thread Thomas Monjalon
21/03/2018 14:21, Xiao Wang: > Some existing sysfs parsing functions are helpful for the later vDPA > driver, this patch make them global and expose them to shared lib. > > Signed-off-by: Xiao Wang > --- > /* parse driver */ > snprintf(filename, sizeof(filename), "%s/driver", dirname)

Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container

2018-03-21 Thread Thomas Monjalon
Hi, 21/03/2018 14:21, Xiao Wang: > +#endif /* VFIO_PRESENT */ > #endif /* _RTE_VFIO_H_ */ Please keep the empty line which was present between endif. > + rte_vfio_create_container; > + rte_vfio_destroy_container; > + rte_vfio_bind_group_no; > + rte_vfio_unbind_group_no; > +

[dpdk-dev] [PATCH v2 1/2] doc: announce ethdev CRC strip flag deprecation

2018-03-21 Thread Ferruh Yigit
Make CRC stripping default behavior, deprecate flag DEV_RX_OFFLOAD_CRC_STRIP. Signed-off-by: Ferruh Yigit --- v2: * Make CRC behavior active in this release --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/

[dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-21 Thread Ferruh Yigit
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default behavior in PMDs is to strip the CRC independent from this flag. Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Setting both KEEP_CRC & CRC_STRIP is INVALID - Setting only CRC_STR

Re: [dpdk-dev] [PATCH] net/bnxt: switch to the new offload API

2018-03-21 Thread Ajit Khaparde
Hi Shahaf, Well, the application could. While we can't ignore the advantages of enabling the offloads. I felt if we should really mandate applications to request all the supported offloads? Thanks Ajit On Wed, Mar 21, 2018 at 12:08 PM, Ferruh Yigit wrote: > On 3/6/2018 7:40 PM, Ajit Khaparde wr

Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs

2018-03-21 Thread Ferruh Yigit
On 3/8/2018 7:07 PM, Pavan Nikhilesh wrote: > Use the new Rx/Tx offload APIs and remove the old style offloads. > > Signed-off-by: Pavan Nikhilesh > --- > > Checkpatch reports falsepositive for PRIx64 > > drivers/net/octeontx/octeontx_ethdev.c | 82 > ++ > dri

Re: [dpdk-dev] [PATCH] net/bnxt: switch to the new offload API

2018-03-21 Thread Ferruh Yigit
On 3/6/2018 7:40 PM, Ajit Khaparde wrote: > Update bnxt PMD to new ethdev offloads API. > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 59 > +- > 1 file changed, 41 insertions(+), 18 deletions(-) > > diff --git a/drivers/net/bnxt/

[dpdk-dev] mlx5 reta size is dynamic

2018-03-21 Thread Hanoch Haim (hhaim)
Hi mlx5 driver expert, DPDK: 17.11 Any reason mlx5 driver change the rate table size dynamically based on the rx- queues# ? There is a hidden assumption that the user wants to distribute the packets evenly which is not always correct. /* If the requested number of RX queues is not a power of tw

[dpdk-dev] i40e mbuf->rss indication

2018-03-21 Thread Hanoch Haim (hhaim)
Hi All, DPDK:17.11 When i40e is configured with RSS enabled and hash.type=toeplitz m->hash.rss = some weird number ((m->ol_flags&PKT_RX_RSS_HASH) == PKT_RX_RSS_HASH The hash value is correct and match the MS Toeplitz standard. Is this expected? The above works fine with ixgbe/mlx5 Thanks, Hano

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-21 Thread Ferruh Yigit
On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: > The flow is created with any steering being applied in the NIC when the > device is handling a single Rx queue. > > Fixes: cede123a158f ("net/mlx5: fix flow creation with a single target queue") This patch is from current release and still in next-n

Re: [dpdk-dev] [PATCH v7] kernel folder for Linux and BSD modules

2018-03-21 Thread Thomas Monjalon
Hi, About the title, please start with a verb: move kernel modules directories 22/02/2018 07:09, Hemant Agrawal: > --- /dev/null > +++ b/kernel/freebsd/BSDmakefile.meson > @@ -0,0 +1,43 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2017 Intel Corporation. All rights reserved. > +# All

[dpdk-dev] [PATCH 0/4] bnxt patchset

2018-03-21 Thread Ajit Khaparde
Patchset adding support for Broadcom® NetXtreme® S-Series BCM58800 family of data center System-on-Chip (SoC) devices. Please apply. Darren Edamura (1): igb_uio: bind error if pcie bridge Scott Branden (3): introduce Broadcom Stingray net/bnxt: add support for Stingray PF devices ids

[dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-03-21 Thread Ajit Khaparde
From: Scott Branden Allow kernel artifacts to be located in output directory specific by RTE_KERNELDIR_OUT. If RTE_KERNELDIR_OUT not specified than source directory RTE_KERNEL is used. Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- mk/rte.module.mk | 9 ++--- 1 file change

[dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids

2018-03-21 Thread Ajit Khaparde
From: Scott Branden Add support for Stingray PF devices ids: BCM58802 = 0xd802 BCM58804 = 0xd804 BCM58808 = 0x16f0 Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethde

[dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray

2018-03-21 Thread Ajit Khaparde
From: Scott Branden Add Broadcom Stingray machine support based on armv8. For product brief see: https://www.broadcom.com/products/ethernet-connectivity/controllers/bcm58800 Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- config/defconfig_arm64-stingray-linuxapp-gcc | 16 ++

[dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge

2018-03-21 Thread Ajit Khaparde
From: Darren Edamura Probe function should exit immediately if pcie bridge detected Signed-off-by: Darren Edamura Signed-off-by: Rahul Gupta Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [dpdk-dev] [dpdk-stable] [PATCH] vfio: fix headers to include C++ support

2018-03-21 Thread Thomas Monjalon
22/02/2018 18:13, Anatoly Burakov: > Fixes: 279b581c897d ("vfio: expose functions") > Cc: gaetan.ri...@6wind.com > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-21 Thread Gaëtan Rivet
Hello Keith, On Wed, Mar 21, 2018 at 05:32:24PM +, Wiles, Keith wrote: > > > > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet wrote: > > > > This library offers a quick way to parse parameters passed with a > > key=value syntax. > > > > A single function is needed and finds the relevant eleme

Re: [dpdk-dev] [PATCH v6 0/6] Improvements for DPDK IPC

2018-03-21 Thread Thomas Monjalon
> Anatoly Burakov (6): > eal: add internal flag indicating init has completed > eal: abstract away IPC socket path generation > eal: don't hardcode socket filter value in IPC > eal: lock IPC directory on init and send > eal: simplify IPC sync request timeout code > eal: ignore messages

[dpdk-dev] [PATCH v2 1/1] net/ixgbe: Add access and locking APIs for MDIO

2018-03-21 Thread Shweta Choudaha
From: Shweta Choudaha Add ixgbe MDIO lock/unlock and access APIs to read and write registers using specific device address. This provides MDIO access to any devices that are not associated with the autoprobed PHY.Export these APIs via the map file Signed-off-by: Shweta Choudaha Reviewed-by: Cha

[dpdk-dev] [PATCH v2 0/1] net/ixgbe: Add read/write PMD MDIO API

2018-03-21 Thread Shweta Choudaha
From: Shweta Choudaha Hi, I am updating this patch to separate MDIO access APIs and MDIO locking APIs. This is done so that calling function can batch MDIO access at a higher level as taking MDIO lock can be expensive. Thanks, Shweta Shweta Choudaha (1): net/ixgbe: Add access and loc

Re: [dpdk-dev] [PATCH v3 00/10] net/mlx5: clean driver

2018-03-21 Thread Ferruh Yigit
On 3/18/2018 6:33 AM, Shahaf Shuler wrote: > Monday, March 5, 2018 2:21 PM, Nelio Laranjeiro: >> - Removes unused SR-IOV flag. >> - Adds missing documentation on some functions. >> - Removes the spin-lock on the private structure. >> - Standardize the return values of all functions as discussed on

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-21 Thread Wiles, Keith
> On Mar 21, 2018, at 12:15 PM, Gaetan Rivet wrote: > > This library offers a quick way to parse parameters passed with a > key=value syntax. > > A single function is needed and finds the relevant element within the > text. No dynamic allocation is performed. It is possible to chain the > pars

[dpdk-dev] [PATCH v2 17/18] ethdev: add device matching field name

2018-03-21 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_class_eth.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_

[dpdk-dev] [PATCH v2 18/18] app/testpmd: add show device command

2018-03-21 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v2 15/18] bus/vdev: add device matching field driver

2018-03-21 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev.c b/d

[dpdk-dev] [PATCH v2 16/18] ethdev: register ether layer as a class

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 2 +- lib/librte_ether/Makefile| 3 +- lib/librte_ether/rte_class_eth.c | 65 3 files changed, 68 insertions(+), 2 deletions(-) create mode 100644 lib/librte_ether/rte_class_eth.

[dpdk-dev] [PATCH v2 13/18] bus/vdev: fix find device implementation

2018-03-21 Thread Gaetan Rivet
If start is set and a device before it matches the data, this device is returned. This produces induces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/rte_bus_vdev.h | 3 +++ drivers

[dpdk-dev] [PATCH v2 14/18] bus/vdev: implement device iteration

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 2 +- drivers/bus/vdev/vdev.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vdev/Makefile b/drivers/bus/vdev/Makefile index 24d424a38..52728833c 100644 --- a/driver

[dpdk-dev] [PATCH v2 12/18] bus/pci: add device matching field id

2018-03-21 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_common.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/b

[dpdk-dev] [PATCH v2 11/18] bus/pci: implement device iteration and comparison

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 2 +- drivers/bus/pci/pci_common.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile index f3df1c4ce..73498dc77 100644 --- a/dr

[dpdk-dev] [PATCH v2 10/18] bus/pci: fix find device implementation

2018-03-21 Thread Gaetan Rivet
If start is set, and a device before it matches the data passed for comparison, then this first device is returned. This produces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_com

[dpdk-dev] [PATCH v2 09/18] eal/dev: implement device iteration

2018-03-21 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 159 lib/librte_eal/common/include/rte_dev.h | 25 + lib/librte_eal/r

[dpdk-dev] [PATCH v2 06/18] eal/class: add device iteration

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index a2e5f5551..47ebaba31 100644 --- a/lib/librte_eal/common/include/rte_class.h ++

[dpdk-dev] [PATCH v2 08/18] eal/dev: implement device iteration initialization

2018-03-21 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for both abstraction layer. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 58 + lib/librte_eal/common/include/rte_dev.h | 23

[dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-21 Thread Gaetan Rivet
This library offers a quick way to parse parameters passed with a key=value syntax. A single function is needed and finds the relevant element within the text. No dynamic allocation is performed. It is possible to chain the parsing of each pairs for quickly scanning a list. This utility is privat

[dpdk-dev] [PATCH v2 05/18] eal/dev: add device iterator interface

2018-03-21 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v2 07/18] eal/bus: add device iteration

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 6fb08341a..46911afa7 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/

[dpdk-dev] [PATCH v2 02/18] eal: introduce device class abstraction

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile| 1 + lib/librte_eal/common/Makefile| 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 ++ lib/librte_eal/li

[dpdk-dev] [PATCH v2 03/18] eal/class: register destructor

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index beb0ba86c..a2e5f5551 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v2 01/18] eal: introduce dtor macros

2018-03-21 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index c7803e41c..500fc3adb 100644 --- a/lib/librte_eal/c

[dpdk-dev] [PATCH v2 00/18] Device querying

2018-03-21 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Gaëtan Rivet
On Wed, Mar 21, 2018 at 03:41:56PM +, Bruce Richardson wrote: > On Wed, Mar 21, 2018 at 03:31:31PM +0100, Gaëtan Rivet wrote: > > On Wed, Mar 21, 2018 at 03:14:05PM +0100, Gaëtan Rivet wrote: > > > Hi Bruce, > > > > > > On Wed, Mar 21, 2018 at 01:35:09PM +, Bruce Richardson wrote: > > > >

Re: [dpdk-dev] [PATCH v2 01/10] lib/librte_vhost: add vhost user private info structure

2018-03-21 Thread Zhang, Roy Fan
Hi Maxime, Thanks a lot for the fast reply. > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 21, 2018 1:03 PM > To: Zhang, Roy Fan ; dev@dpdk.org; Kulasek, > TomaszX ; Wodkowski, PawelX > > Cc: jianjay.z...@huawei.com; y...@friday

[dpdk-dev] [PATCH] ethdev: Fix issue in Doxygen for TM API

2018-03-21 Thread Ben Shelton
The rte_tm_node_wfq_weight_mode_update() API function operates on non-leaf nodes, not leaf nodes. Signed-off-by: Ben Shelton --- lib/librte_ether/rte_tm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h index 2b25a87..f735

[dpdk-dev] [PATCH] vhost: avoid concurrency when logging dirty pages

2018-03-21 Thread Maxime Coquelin
This patch aims at fixing a migration performance regression faced since atomic operation is used to log pages as dirty when doing live migration. Instead of setting a single bit by doing an atomic read-modify-write operation to log a page as dirty, this patch write 0xFF to the corresponding byte,

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 03:29:57PM +, Shahaf Shuler wrote: > Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > > 21/03/2018 15:28, Ferruh Yigit: > > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > > 21/03/2018 1

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 03:31:31PM +0100, Gaëtan Rivet wrote: > On Wed, Mar 21, 2018 at 03:14:05PM +0100, Gaëtan Rivet wrote: > > Hi Bruce, > > > > On Wed, Mar 21, 2018 at 01:35:09PM +, Bruce Richardson wrote: > > > On Wed, Mar 21, 2018 at 11:20:25AM +0100, Gaëtan Rivet wrote: > > > > Hi, > >

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > 21/03/2018 15:28, Ferruh Yigit: > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > 21/03/2018 11:54, Ferruh Yigit: > > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > 21/03/2018 15:28, Ferruh Yigit: > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > 21/03/2018 11:54, Ferruh Yigit: > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > >>> IMHO, it should be allowed to specify queue offloads

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO enablement

2018-03-21 Thread Shahaf Shuler
Thursday, March 15, 2018 1:00 PM, Shahaf Shuler: > TSO should be set if either of the TSO offload flags is requested. > > Fixes: dbccb4cddcd2 ("net/mlx5: convert to new Tx offloads API") > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/ml

Re: [dpdk-dev] rte_eth_dev_count() returns 0 in shared library mode.

2018-03-21 Thread Venkatesh N
Thank Yigit. It worked for me. I think if the same information is provided in the doc folder then it can avoid confusion. Many blogs said to build it as static library. Regards, Venky On Tue, Mar 20, 2018 at 5:54 PM, Ferruh Yigit wrote: > On 3/19/2018 3:34 PM, Venkatesh N wrote: >> Hi Everyone,

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: multiple fix and improvements in flows

2018-03-21 Thread Shahaf Shuler
Tuesday, March 13, 2018 4:18 PM, Nelio Laranjeiro: > This series apply on top of [1] > > Changes in v2: > - rebase on top of series [2] which drops priv locks. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp > dk.org%2Fdev%2Fpatchwork%2Fpatch%2F36058%2F&data=02%7C

Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK

2018-03-21 Thread Burakov, Anatoly
On 21-Mar-18 1:45 PM, Shreyansh Jain wrote: Hello Anatoly, This is not necessarily right chain to reply to, but reusing this email for another issue in DPAA2 so that all issues can be at a single place. On Thu, Mar 15, 2018 at 7:31 PM, Shreyansh Jain wrote: Hello Anatoly, On Tue, Mar 13, 201

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Thomas Monjalon
21/03/2018 15:28, Ferruh Yigit: > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > 21/03/2018 11:54, Ferruh Yigit: > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > >>> IMHO, it should be allowed to specify queue offloads on port level. > >>> It should simply enable these offloads on all queues.

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Gaëtan Rivet
On Wed, Mar 21, 2018 at 03:14:05PM +0100, Gaëtan Rivet wrote: > Hi Bruce, > > On Wed, Mar 21, 2018 at 01:35:09PM +, Bruce Richardson wrote: > > On Wed, Mar 21, 2018 at 11:20:25AM +0100, Gaëtan Rivet wrote: > > > Hi, > > > > > > I have had issues compiling a few things here, have you checked >

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > 21/03/2018 11:54, Ferruh Yigit: >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: >>> IMHO, it should be allowed to specify queue offloads on port level. >>> It should simply enable these offloads on all queues. Also it will >>> match dev_info [rt]x_off

[dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tuned parameter values. Signed-off-by: Remy Horton ---

[dpdk-dev] [PATCH v2 3/4] net/i40e: add TxRx tuning parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton ---

[dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton ---

[dpdk-dev] [PATCH v2 2/4] net/e1000: add TxRx tuning parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton ---

[dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patchset allows individual PMDs to specify their preferred parameter values, and if so indicated by a

Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dai, Wei > Sent: Wednesday, March 21, 2018 10:09 PM > To: Ananyev, Konstantin ; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx > offloads > > Hi

Re: [dpdk-dev] [PATCH V15 2/5] eal: add uevent pass and process function

2018-03-21 Thread Tan, Jianfeng
On 3/21/2018 1:27 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be example to show uevent mechanism how to pass the uevent and process the uevent. In fact, how to pass the uevent to eal/linux

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Gaëtan Rivet
Hi Bruce, On Wed, Mar 21, 2018 at 01:35:09PM +, Bruce Richardson wrote: > On Wed, Mar 21, 2018 at 11:20:25AM +0100, Gaëtan Rivet wrote: > > Hi, > > > > I have had issues compiling a few things here, have you checked > > build status before submitting? > > > > On Wed, Mar 21, 2018 at 03:51:32

Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads

2018-03-21 Thread Dai, Wei
Hi, Konstantin Thanks for your feedback. > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 20, 2018 8:00 PM > To: Dai, Wei ; tho...@monjalon.net > Cc: dev@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx > offloads > > >

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Thomas Monjalon
21/03/2018 11:54, Ferruh Yigit: > On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > IMHO, it should be allowed to specify queue offloads on port level. > > It should simply enable these offloads on all queues. Also it will > > match dev_info [rt]x_offload_capa which include both port and queue > >

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Xu, Rosen
-Original Message- From: Richardson, Bruce Sent: Wednesday, March 21, 2018 21:35 To: Gaëtan Rivet Cc: Xu, Rosen ; dev@dpdk.org; Doherty, Declan ; shreyansh.j...@nxp.com; Zhang, Tianfei ; Wu, Hao Subject: Re: [PATCH V2 3/5] Add Intel FPGA BUS Lib Code On Wed, Mar 21, 2018 at 11:20:25

Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code

2018-03-21 Thread Shreyansh Jain
On Wed, Mar 21, 2018 at 7:05 PM, Bruce Richardson wrote: > On Wed, Mar 21, 2018 at 11:20:25AM +0100, Gaėtan Rivet wrote: >> Hi, >> >> I have had issues compiling a few things here, have you checked >> build status before submitting? >> >> On Wed, Mar 21, 2018 at 03:51:32PM +0800, Rosen Xu wrote: >

Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API

2018-03-21 Thread Dai, Wei
Hi, Konstantin Thanks for your patient guidance! > IXGBE_WRITE_REG(hw, IXGBE_SRRCTL(rxq->reg_idx), srrctl); in > ixgbe_dev_rx_init( ). > > Same case is also in the code line: IXGBE_WRITE_REG(hw, > IXGBE_VFSRRCTL(i), srrctl); in ixgbevf_dev_rx_init( ). > > Yes, HW can enable/disable it on a per que

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 10:14 AM, Remy Horton wrote: > > On 20/03/2018 15:03, Ferruh Yigit wrote: >> On 3/16/2018 3:36 PM, Remy Horton wrote: > [..] > >>> struct rte_eth_dev_preferred_size { >>> uint16_t burst; >>> uint16_t ring; >>> uint16_t nb_queues; >>> }; >>> struct rte_eth_dev_info { >>>

[dpdk-dev] [PATCH 0/3] net/sfc: support Medford2 family adapters

2018-03-21 Thread Andrew Rybchenko
dpdk-web patch will follow. Andrew Rybchenko (3): net/sfc: support link speeds up to 100G net/sfc: support runtime VI window size net/sfc: support Medford2 family adapters doc/guides/nics/sfc_efx.rst| 23 ++- doc/guides/rel_notes/release_18_05.rst | 1 + dr

[dpdk-dev] [PATCH 2/3] net/sfc: support runtime VI window size

2018-03-21 Thread Andrew Rybchenko
Medford2 uses a configurable VI window size, and requires updates to register accesses to use a runtime VI window size rather than the *_STEP register constants used for earlier controllers. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_dp_rx.h | 2 ++ driv

[dpdk-dev] [PATCH 1/3] net/sfc: support link speeds up to 100G

2018-03-21 Thread Andrew Rybchenko
Add 25G, 50G and 100G. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.c| 11 ++- drivers/net/sfc/sfc_ethdev.c | 6 ++ drivers/net/sfc/sfc_port.c | 12 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/ne

  1   2   >