Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > 21/03/2018 15:28, Ferruh Yigit: > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > 21/03/2018 11:54, Ferruh Yigit: > > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > > >>> IMHO, it should be allowed to specify queue offloads on port level. > > > >>> It should simply enable these offloads on all queues. Also it > > > >>> will match dev_info [rt]x_offload_capa which include both port > > > >>> and queue offloads. > > > > Why not abandon port-level config entirely? Then you just have queue-level > configs, with the restriction that on some NICs all queues must be configured > the same way. It can be up to the NIC drivers - or possibly ethdev layer - to > identify and report an error in such cases.
I would love that. And this was part of the original proposal when we first modified the offloads API. However Konstantin explained to me it will not work with Intel devices. There are cases were port configuration should be set on the PF w/o any queues created to enable offload on the VF. > > /Bruce
