21/03/2018 11:54, Ferruh Yigit: > On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > IMHO, it should be allowed to specify queue offloads on port level. > > It should simply enable these offloads on all queues. Also it will > > match dev_info [rt]x_offload_capa which include both port and queue > > offloads. > > > > Yes, we lose possibility to enable on port level, but disable on queue > > level by suggested changes, but I think it is OK - if you don't need > > it for all queues, just control separately on queue level. > > What I understand was queue offload can only enable more, but it seems it can > both enable or disable.
Yes, queue offload should only enable more. An offload enabled at port level, cannot be disabled at queue level. A port offload can be repeated in queue configuration. If a port offload is not repeated in queue configuration, there should be no impact: it is still in the port configuration, thus applying to all queues. About capabilities, the queue offloads must be a subset of port offloads. The queue capabilities show which offloads can be enabled per queue.
