Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Hemant Agrawal
> > > > Subject: Re: [dpdk-dev] Sharing Common libs between PMDs > > > > > -Original Message- > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > > > > Richardson > > > > > Sent: Wednesday, March 14, 2018 3:05 PM > > > > > To: Jerin Jacob > > > > > Cc: Liron Himi ; de

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-14 Thread Shahaf Shuler
Thursday, March 15, 2018 12:41 AM, Ferruh Yigit: > On 3/14/2018 5:49 AM, Shahaf Shuler wrote: > > Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: > >>> > >>> Again - the application should follow the API which currently > >>> dictates how > >> to set port offload. It is not depends on the rx_queue_o

Re: [dpdk-dev] [PATCH v6 4/4] doc: add details on ethdev offloads API

2018-03-14 Thread Shahaf Shuler
Thursday, March 15, 2018 3:58 AM, Patil, Harish: > >2.12.0 > > > Hi Shahaf, > Have a minor question here. > In the documentation it is stated that: > "To enable per-port offload, the offload should be set on both device > configuration and queue setup.” > Our NIC supports only port-level offloads.

[dpdk-dev] [PATCH] Add i40e Promiscuous disable in i40evf_dev_stop

2018-03-14 Thread Rosen Xu
Signed-off-by: Rosen Xu --- drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index fd003fe..f395b02 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c

[dpdk-dev] [PATCH v3 2/2] event/sw: support device stop flush callback

2018-03-14 Thread Gage Eads
This commit also adds a flush callback test to the sw eventdev's selftest suite. Signed-off-by: Gage Eads --- drivers/event/sw/sw_evdev.c | 25 ++- drivers/event/sw/sw_evdev_selftest.c | 80 +++- 2 files changed, 102 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v3 1/2] eventdev: add device stop flush callback

2018-03-14 Thread Gage Eads
When an event device is stopped, it drains all event queues. These events may contain pointers, so to prevent memory leaks eventdev now supports a user-provided flush callback that is called during the queue drain process. This callback is stored in process memory, so the callback must be registere

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Verma, Shally
@Trahe, Fiona>> We're proposing, in the interest of getting the API out in 18.05, to stick with mbufs - acknowledging >> that they're not optimal for storage and we may propose changes in 18.08. [Shally] Sounds good to us too. @Ahmed Mansour . I am assuming that transferring from mbuf to regular

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for queue setup

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 15, 2018 1:41 AM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for > queue

Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add parameters for deferred queue setup

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 15, 2018 1:39 AM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add parameters for > def

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 15, 2018 11:22 AM > To: Ananyev, Konstantin ; > tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, March 14, 2018 8:36 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue > se

Re: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup

2018-03-14 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, March 14, 2018 8:32 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ether: support deferre

Re: [dpdk-dev] [PATCH v6 4/4] doc: add details on ethdev offloads API

2018-03-14 Thread Patil, Harish
-Original Message- From: dev on behalf of Shahaf Shuler Date: Wednesday, October 4, 2017 at 1:18 AM To: "konstantin.anan...@intel.com" , "tho...@monjalon.net" , "arybche...@solarflare.com" , "Jacob, Jerin" , "ferruh.yi...@intel.com" Cc: "dev@dpdk.org" Subject: [dpdk-dev] [PATCH v6 4/4]

Re: [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scanned after PCI Bus

2018-03-14 Thread Xu, Rosen
-Original Message- From: Richardson, Bruce Sent: Tuesday, March 06, 2018 19:36 To: Ga?tan Rivet Cc: Xu, Rosen ; Shreyansh Jain ; dev@dpdk.org; Doherty, Declan ; Zhang, Tianfei Subject: Re: [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scann

Re: [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scanned after PCI Bus

2018-03-14 Thread Xu, Rosen
-Original Message- From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] Sent: Tuesday, March 06, 2018 20:00 To: Richardson, Bruce Cc: Xu, Rosen ; Shreyansh Jain ; dev@dpdk.org; Doherty, Declan ; Zhang, Tianfei Subject: Re: [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus

Re: [dpdk-dev] Question on AESNI PMD

2018-03-14 Thread Luse, Paul E
So what do you think - would you like me to clean up my DPDK hack a little and propose a change to support different external buf_addrs for src/dest or did you have something else in mind? Also, it look like I ran into a case where a data buffer of > 32K (the next increment I tried was 64K) see

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: convert to new Tx offloads API

2018-03-14 Thread Ananyev, Konstantin
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h > index 30095fa..d7f0535 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.h > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h > @@ -223,6 +223,7 @@ struct ixgbe_tx_queue { > uint8_t hthresh; /**< Host threshold

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 5:49 AM, Shahaf Shuler wrote: > Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: >>> >>> Again - the application should follow the API which currently dictates how >> to set port offload. It is not depends on the rx_queue_offloads capabilities. >>> For example, PMD which don't support qu

Re: [dpdk-dev] [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API

2018-03-14 Thread Ananyev, Konstantin
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Wednesday, March 7, 2018 1:06 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v2 3/4] net/ixgbe: convert to new Rx offloads API > > Ethdev Rx offloads API has changed since: > commit ce17e

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, March 14, 2018 7:53 AM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v7 5/7

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Carrillo, Erik G
Hi Pavan, > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, March 14, 2018 8:31 AM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v7 5/7

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Bruce Richardson
On Wed, Mar 14, 2018 at 09:02:47PM +, Ferruh Yigit wrote: > On 3/14/2018 6:53 PM, Ananyev, Konstantin wrote: > > > > > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Wednesday, March 14, 2018 5:52 PM > >> To: Shreyansh Jain ; Ho

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 6:53 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Wednesday, March 14, 2018 5:52 PM >> To: Shreyansh Jain ; Horton, Remy >> ; dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Zhang,

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-14 Thread Wu, Jingjing
<...> > +static int > +config_rx_offload(const char *name, uint64_t *offload, int on) > +{ > + uint64_t local = *offload; > + > + if (!strcmp(name, "vlan_strip")) { > + if (on) > + local |= DEV_RX_OFFLOAD_VLAN_STRIP; > + else > +

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Ahmed Mansour
Hi All, Sticking with mbufs until at least 1805 works for us. We also see storage as the main use case, but ipcomp maybe an important customer use case in the future. Nonetheless, I see the mbuf formatting as inherently external to the compressdev APIs. An application doing ipcomp should just do t

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Adrien Mazarguil
On Wed, Mar 14, 2018 at 10:40:59AM -0700, Yongseok Koh wrote: > On Wed, Mar 14, 2018 at 01:18:56PM +0100, Adrien Mazarguil wrote: > > On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > > > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > > > This behavior is mixed

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Wednesday, March 14, 2018 5:52 PM > To: Shreyansh Jain ; Horton, Remy > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei > ; Thomas Monjalon > Subject: Re: [dp

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Trahe, Fiona
Hi Shally, Ahmed, et al, Following internal and community feedback we've decided that there's still too much churn in this. We're proposing, in the interest of getting the API out in 18.05, to stick with mbufs - acknowledging that they're not optimal for storage and we may propose changes in 18

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Trahe, Fiona
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, March 14, 2018 5:50 PM > To: Shreyansh Jain > Cc: Trahe, Fiona ; Richardson, Bruce > ; Liron Himi > ; dev@dpdk.org; Jozwiak, TomaszX > > Subject: Re: [dpdk-dev] Sharing Common libs betw

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 5:23 PM, Shreyansh Jain wrote: >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Wednesday, March 14, 2018 10:13 PM >> To: Remy Horton ; dev@dpdk.org >> Cc: Wenzhuo Lu ; Jingjing Wu >> ; Qi Zhang ; Beilei Xing >> ; Shreyansh Jain ; >> Thomas M

[dpdk-dev] [PATCH] net/mlx5: fix compilation error of rdma-core on ARM

2018-03-14 Thread Yongseok Koh
rdma-core v16 has a bug. The following compilation error occurs on ARM hosts. In file included from /auto/mswg/yskoh/git/dpdk.org/drivers/net/mlx5/mlx5_glue.h:16:0, from /auto/mswg/yskoh/git/dpdk.org/drivers/net/mlx5/mlx5_glue.c:11: /usr/include/infiniband/mlx5dv.h:144:2: error: unknown type name

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Jerin Jacob
-Original Message- > Date: Wed, 14 Mar 2018 17:38:14 + > From: Shreyansh Jain > To: "Trahe, Fiona" , "Richardson, Bruce" > , Jerin Jacob > CC: Liron Himi , "dev@dpdk.org" , > "Jozwiak, TomaszX" > Subject: RE: [dpdk-dev] Sharing Common libs between PMDs > > > -Original Message-

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for queue setup

2018-03-14 Thread Ananyev, Konstantin
> +} > + > +cmdline_parse_inst_t cmd_queue_setup = { > + .f = cmd_queue_setup_parsed, > + .data = NULL, > + .help_str = "queue setup", It probably would be good to add an ability to specify rx/tx queue offloads by this command. Konstantin > + .tokens = { > + (voi

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Yongseok Koh
On Wed, Mar 14, 2018 at 01:18:56PM +0100, Adrien Mazarguil wrote: > On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > > This behavior is mixed between what should be handled by the application > > > and what is un

Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add parameters for deferred queue setup

2018-03-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, March 2, 2018 4:13 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add para

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Wednesday, March 14, 2018 9:41 PM > To: Richardson, Bruce ; Jerin Jacob > > Cc: Liron Himi ; dev@dpdk.org; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: Re: [dpdk-dev] Sharing Common libs betwe

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add command for queue setup

2018-03-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, March 2, 2018 4:13 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2 3/4] app/testpmd: add comm

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Andrew Rybchenko
On 03/14/2018 07:53 PM, Burakov, Anatoly wrote: On 14-Mar-18 4:12 PM, Andrew Rybchenko wrote: On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, March 14, 2018 10:13 PM > To: Remy Horton ; dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4

Re: [dpdk-dev] [PATCH v2 6/8] net/mrvl: add extended statistics

2018-03-14 Thread Ferruh Yigit
On 3/12/2018 8:42 AM, Tomasz Duszynski wrote: > Add extended statistics implementation. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Tomasz Duszynski <...> > @@ -1674,6 +1784,94 @@ mrvl_eth_filter_ctrl(struct rte_eth_dev *dev > __rte_unused, > } > } > > +/** > + * DPDK callba

Re: [dpdk-dev] [PATCH 5/5] net/mlx5: add a parameter for Netlink support in VF

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:39PM +0100, Nelio Laranjeiro wrote: > All Netlink request the PMD will do can also be done by a iproute2 command > line interface, letting the operator configure the VF behavior without > having to modify the application nor reaching PMD limits (e.g. MAC > address numb

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: use Netlink to enable promisc/allmulti

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:38PM +0100, Nelio Laranjeiro wrote: > VF devices are not able to receive promisc or allmulti traffic unless it > fully requests it though Netlink. This will cause the request to be > processed by the PF which will handle the request and enable it. > > This requires t

Re: [dpdk-dev] [PATCH 1/5] net/mlx5: add VF information in configuration

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:35PM +0100, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro Perhaps with a line that states the reason given similar code was dropped by prior patch "net/mlx5: fix sriov flag", for instance: Subsequent patches will need a convenient method to determine if

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: retrieve device index from Netlink

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:36PM +0100, Nelio Laranjeiro wrote: > This patch new file is not compiled yet, it starts a series necessary to > fix some issues with VF devices. > > Signed-off-by: Nelio Laranjeiro The fact this new file is not compiled in at this point won't be obvious when runnin

Re: [dpdk-dev] [PATCH 3/5] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:37PM +0100, Nelio Laranjeiro wrote: > VF devices are not able to receive traffic unless it fully requests it > though Netlink. This will cause the request to be processed by the PF > which will add/remove the MAC address to the VF table if the VF is trusted. > > Sign

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Burakov, Anatoly
On 14-Mar-18 4:12 PM, Andrew Rybchenko wrote: On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all

Re: [dpdk-dev] [PATCH v1 0/5] add framework to load and execute BPF code

2018-03-14 Thread Alejandro Lucero
I tried to start a discussion about eBPF support with DPDK in last DPDK meeting in Santa Clara: https://dpdksummit.com/Archive/pdf/2017USA/DPDK%20support%20for%20new%20hardware%20offloads.pdf In slide 17 I have some points which, IMHO, are worth to discuss before adding this support. I can see c

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 3:48 PM, Remy Horton wrote: > > On 14/03/2018 14:43, Ferruh Yigit wrote: > [..] >>> lib/librte_ether/rte_ethdev.c | 18 ++ >>> lib/librte_ether/rte_ethdev.h | 15 +++ >> >> Can you please remove deprecation notice in this patch. > > Done. > >>> + /* Def

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Andrew Rybchenko
On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total objec

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, March 14, 2018 3:05 PM > To: Jerin Jacob > Cc: Liron Himi ; dev@dpdk.org > Subject: Re: [dpdk-dev] Sharing Common libs between PMDs > > On Wed, Mar 14, 2018 at 08:25:45PM +053

Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-14 Thread Andrew Rybchenko
Hi Santosh, On 03/14/2018 06:49 PM, santosh wrote: Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] RFCv1 -> RFCv2: - add driver ops to calculate required memory size and populate mempool objects, remove extra flags which were required before to cont

Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-14 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] > RFCv1 -> RFCv2: > - add driver ops to calculate required memory size and populate > mempool objects, remove extra flags which were required before > to control it > - transition of octeontx and dpaa drive

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 14:43, Ferruh Yigit wrote: [..] lib/librte_ether/rte_ethdev.c | 18 ++ lib/librte_ether/rte_ethdev.h | 15 +++ Can you please remove deprecation notice in this patch. Done. + /* Defaults for drivers that don't implement preferred +* q

Re: [dpdk-dev] [PATCH] net/i40e: add log when setting input set

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Sunday 11 February 2018 06:56 > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: add log when setting input set > > This patch adds log when setting input set since

Re: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 10:51 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski >> Sent: Friday, March 9, 2018 9:40 AM >> To: dev@dpdk.org >> Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; >> j...@semih

Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib

2018-03-14 Thread Stephen Hemminger
On Wed, 14 Mar 2018 13:08:55 +0100 Nélio Laranjeiro wrote: > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > On Tue, 13 Mar 2018 13:28:25 +0100 > > Nelio Laranjeiro wrote: > > > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > > > wrapper

Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Sunday 11 February 2018 07:10 > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > configuration > > Remove unnecessary FDIR mask config

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, March 14, 2018 8:14 PM > To: Remy Horton ; dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4

Re: [dpdk-dev] [PATCH v2] net/mrvl: convert license headers to SPDX tags

2018-03-14 Thread Ferruh Yigit
On 3/12/2018 7:37 AM, Hemant Agrawal wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski >> Sent: Monday, March 12, 2018 1:02 PM >> To: dev@dpdk.org >> Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; >> j...@semihalf.com; jian

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Bruce Richardson
On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Wed, 14 Mar 2018 09:34:40 + > > From: Liron Himi > > To: "dev@dpdk.org" > > CC: Liron Himi > > Subject: [dpdk-dev] Sharing Common libs between PMDs > > > > Hi, > > > > We have several PMDs i

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Jerin Jacob
-Original Message- > Date: Wed, 14 Mar 2018 09:34:40 + > From: Liron Himi > To: "dev@dpdk.org" > CC: Liron Himi > Subject: [dpdk-dev] Sharing Common libs between PMDs > > Hi, > > We have several PMDs in DPDK that are using the same underlying common > libraries. > In addition, we

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/7/2018 12:08 PM, Remy Horton wrote: > The optimal values of several transmission & reception related > parameters, such as burst sizes, descriptor ring sizes, and number > of queues, varies between different network interface devices. This > patch allows individual PMDs to specify preferred pa

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Burakov, Anatoly
On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a ne

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf drv

2018-03-14 Thread Rybalchenko, Kirill
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tushar Mulkar > Sent: Wednesday 14 February 2018 12:00 > To: Zhang, Helin ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link_state update for > i40e_ethdev_vf d

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 12:28, Shreyansh Jain wrote: [..] + /* Use default specified by driver, if nb_rc_desc is zero */ ^^^ Should be '_rx_' [..] Other than the above; Ok - v2 on the way :) Acked-by

[dpdk-dev] [PATCH v2 11/11] maintainers: claim responsibility for octeontx timvf

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a646ca3e1..4fac167d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -737,6 +737,10 @@ M: Santosh Shukla F: drivers/event/octeontx/ F: doc/guides/eventdevs/octeo

[dpdk-dev] [PATCH v2 10/11] doc: update eventdev OcteonTx documentation

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/octeontx.rst index 4fabe54f9..f4f5473fd 100644 --- a/doc/guides/eventdevs/octeontx.rst +++ b/doc/guides/event

[dpdk-dev] [PATCH v2 09/11] event/octeontx: add option to use fpavf as chunk pool

2018-03-14 Thread Pavan Nikhilesh
Add compile-time configurable option to force TIMvf to use Octeontx FPAvf pool manager as its chunk pool. When FPAvf is used as pool manager the TIMvf automatically frees the chunks to FPAvf through gpool-id. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 22 +

[dpdk-dev] [PATCH v2 08/11] event/octeontx: optimize timer adapter resolution parameters

2018-03-14 Thread Pavan Nikhilesh
When application sets `RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES` flag while creating adapter underlying driver is free to optimize the resolution for best possible configuration. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 48 +++- driver

[dpdk-dev] [PATCH v2 04/11] event/octeontx: add support to start and stop timer device

2018-03-14 Thread Pavan Nikhilesh
When application requests to start the timer adapter through `rte_event_timer_adapter_start`, Octeontx TIMvf ring does the following: - Uses mbox to communicate TIMpf driver about, * SCLK frequency used to convert ns<->cycles. * program the ring control parameters and start the ring. * get th

[dpdk-dev] [PATCH v2 05/11] event/octeontx: add multiproducer timer arm and cancel

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/Makefile | 5 + drivers/event/octeontx/meson.build| 1 + drivers/event/octeontx/timvf_evdev.c | 7 +- drivers/event/octeontx/timvf_evdev.h | 32 drivers/event/octeontx/timvf_worker.c | 59 +++ drivers/event/oct

[dpdk-dev] [PATCH v2 07/11] event/octeontx: add burst mode for timer arm

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 1 + drivers/event/octeontx/timvf_evdev.h | 3 ++ drivers/event/octeontx/timvf_worker.c | 36 + drivers/event/octeontx/timvf_worker.h | 95 +++ 4 files changed, 135 insertions

[dpdk-dev] [PATCH v2 06/11] event/octeontx: add single producer timer arm variant

2018-03-14 Thread Pavan Nikhilesh
When application creates the timer adapter by passing `RTE_EVENT_TIMER_ADAPTER_F_SP_PUT` flag, we can optimize the arm sequence by removing the locking overhead. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 15 --- drivers/event/octeontx/timvf_evdev.h | 2

[dpdk-dev] [PATCH v2 03/11] event/octeontx: add support to create and free timer adapter

2018-03-14 Thread Pavan Nikhilesh
When the application requests to create a timer device, Octeontx TIM create does the following: - Get the requested TIMvf ring based on adapter_id. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate the chunk pool

[dpdk-dev] [PATCH v2 02/11] usertools: add Cavium TIM as an event device

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 18d938607..f6cbb2bb7 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -22,10 +22

[dpdk-dev] [PATCH v2 00/11] event/octeontx: add event timer adapter driver

2018-03-14 Thread Pavan Nikhilesh
The event timer adapter[1] provides APIs to configure an event timer device that allows an application to arm timers which on expiry push events to an event device such as OcteonTx SSO. The OcteonTx TIM is a co-processor that can be configured as an event timer adapter which can be used by an appli

[dpdk-dev] [PATCH v2 01/11] mempool/octeontx: probe timvf PCIe devices

2018-03-14 Thread Pavan Nikhilesh
On Octeontx HW, each event timer device is enumerated as separate SRIOV VF PCIe device. In order to expose as a event timer device: On PCIe probe, the driver stores the information associated with the PCIe device and later when appliacation requests for a event timer device through `rte_event_time

Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 8:08 PM > To: wangyunjian ; dev@dpdk.org > Cc: ca...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by > adding retry >

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Pavan Nikhilesh
Hi Gabriel, Please make sure that the unit tests are generic, I could see that some places it is verifying whether event port is used or service cores are used, but doesn't verify if actually event port/service core are needed i.e. INTERNAL_PORT capability. On Thu, Mar 08, 2018 at 03:54:04PM -060

Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API

2018-03-14 Thread Gaëtan Rivet
Hi, On Wed, Mar 14, 2018 at 11:19:31AM +, Burakov, Anatoly wrote: > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > Some existing sysfs parsing functions are helpful for the later vDPA > > driver, this patch make them global and expose them to shared lib. > > > > Signed-off-by: Xiao Wang > > ---

Re: [dpdk-dev] [PATCH v5] vfio: change to use generic multi-process channel

2018-03-14 Thread Burakov, Anatoly
On 04-Mar-18 2:57 PM, Jianfeng Tan wrote: Previously, vfio uses its own private channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Test: 1. Bind two NICs to vfio-pci. 2. Start the primary and seco

Re: [dpdk-dev] [PATCH] event/sw: code refractor for counter set

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 21:10, Vipin Varghese wrote: Counter variable 'out_pkts' had been set to 0, then updated. Current code change elimates double assignment to direct assignment. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH] event/sw: move stats code for better cache access

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:17, Vipin Varghese wrote: variables 'out_pkts_total' and 'out_pkts_total' will be in registers. Hence shifting the code after the loop, helps the update from registers. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

[dpdk-dev] [PATCH v2] test/crypto: add MRVL to hash test cases

2018-03-14 Thread Tomasz Duszynski
MRVL Crypto PMD supports most of the hash algorithms covered by test suites thus specific bits should be set in pmd_masks. Otherwise blockcipher authonly test returns success even though no real tests have been executed. Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") Cc: sta...@d

Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:08, Vipin Varghese wrote: For most run cases 'sw->started' holds true. Adding a branch prediction suggestion to compiler helps as this is first conditional check just after entering the function. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 2 +-

Re: [dpdk-dev] [PATCH] hash: fix missing spinlock unlock in add key

2018-03-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, March 4, 2018 2:59 PM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Pavan Nikhilesh > ; sta...@dpdk.org > Subject: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 8:00 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Pavan Nikhilesh
Hi Gabriel, On Thu, Mar 08, 2018 at 03:54:04PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/Makefile |1 + > test/test/test_event_timer_adapter.c | 1234 > ++ > 2 files changed, 1235 insertions

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 13 March 2018 21:22 >To: Verma, Shally ; Ahmed Mansour >; dev@dpdk.org >Cc: De Lara Guarch, Pablo ; Athreya, Narayana >Prasad ; >Gupta, Ashish ; Sahu, Sunila >; Challa, Mahipal >; Jain, Deepak K ; Hemant >Ag

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-14 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Sent: Tuesday, March 13, 2018 2:25 PM > Switch from using deprecated bitfields in rxmode to offloads variable. > > Signed-off-by: Ferruh Yigit > --- > drivers/net/bonding/rte_eth_bond_api.c | 3 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 9 +++-- > 2 files c

Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-14 Thread Trahe, Fiona
Hi Shally, Sorry about the delay in responding. Comments below. If you want to push next update to github we can continue dev there. Regards, Fiona > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, February 1, 2018 11:07 AM > To: Trahe,

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, March 2, 2018 4:13 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable defe

Re: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup

2018-03-14 Thread Ananyev, Konstantin
Hi Qi, > > The patch let etherdev driver expose the capability flag through > rte_eth_dev_info_get when it support deferred queue configuraiton, > then base on the flag rte_eth_[rx|tx]_queue_setup could decide > continue to setup the queue or just return fail when device already > started. > > S

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Remy Horton [mailto:remy.hor...@intel.com] > Sent: Wednesday, March 7, 2018 5:39 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: [RFC PATCH v1 1/4] ethdev: add support for PMD-tun

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-03-14 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, March 7, 2018 12:16 PM > To: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana > Prasad > ; Murthy, Nidadavolu > ; Sahu, > Sunila ; Gupta, Ashish ; > Doherty, Declan > ; Keating, Brian

Re: [dpdk-dev] [PATCH] net/bonding: set MTU on slave configure

2018-03-14 Thread Radu Nicolau
On 2/23/2018 4:01 AM, Chas Williams wrote: From: Chas Williams When a slave is configured make sure that the slave's MTU matches the bonding's idea of the MTU. Signed-off-by: Chas Williams --- Acked-by: Radu Nicolau

Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > On Tue, 13 Mar 2018 13:28:25 +0100 > Nelio Laranjeiro wrote: > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > > wrapper can be useful for other PMD which may need to communicate also with > > th

Re: [dpdk-dev] [PATCH 1/3] eal/vfio: add support for multiple container

2018-03-14 Thread Burakov, Anatoly
On 09-Mar-18 11:08 PM, Xiao Wang wrote: From: Junjie Chen Currently eal vfio framework binds vfio group fd to the default container fd, while in some cases, e.g. vDPA (vhost data path acceleration), we want to set vfio group to a new container and program DMA mapping via this new container, so

  1   2   >