Hi, On Wed, Mar 14, 2018 at 11:19:31AM +0000, Burakov, Anatoly wrote: > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > Some existing sysfs parsing functions are helpful for the later vDPA > > driver, this patch make them global and expose them to shared lib. > > > > Signed-off-by: Xiao Wang <xiao.w.w...@intel.com> > > --- > > drivers/bus/pci/linux/pci.c | 9 ++++----- > > drivers/bus/pci/linux/pci_init.h | 8 ++++++++ > > drivers/bus/pci/rte_bus_pci_version.map | 8 ++++++++ > > 3 files changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > > index abde64119..81e5e5650 100644 > > --- a/drivers/bus/pci/linux/pci.c > > +++ b/drivers/bus/pci/linux/pci.c > > @@ -32,7 +32,7 @@ > > extern struct rte_pci_bus rte_pci_bus; > > -static int > > +int > > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > > Here and in other places - shouldn't this too be prefixed with rte_? >
A public PCI function should be prefixed by rte_pci_ yes. Additionally, if this function was to be exposed, then there should be a BSD implementation as well (shared map file). I don't know how BSD works, I'm not sure parsing the filesystem is the way to get a PCI driver name. If so, maybe the function should be called another, generic, way, that would work for both linux and BSD (and ideally, having a real BSD implementation). > > -- > Thanks, > Anatoly -- Gaëtan Rivet 6WIND
