On 14/03/2018 14:43, Ferruh Yigit wrote:
[..]
lib/librte_ether/rte_ethdev.c | 18 ++++++++++++++++++
lib/librte_ether/rte_ethdev.h | 15 +++++++++++++++
Can you please remove deprecation notice in this patch.
Done.
+ /* Defaults for drivers that don't implement preferred
+ * queue parameters.
[..]
Not sure about having these defaults here. It is OK to have defaults in driver,
in application or in config file, but I am not sure if putting them into device
abstraction layer hides them.
What about not providing any default in ethdev layer, and get zero as invalid
when using them?
This is something I have been thinking about, and I am going to remove
them for the V2. Original motive was to avoid breaking testpmd for PMDs
that don't give defaults (i.e. almost all of them). The alternative is
to put place-holders into all the PMDs themselves, but I am not sure if
this is appropriate.
