Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, January 11, 2018 4:23 PM > To: ch...@att.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and > transmit > > Hi, > > > Date: Thu, 19 Oct 20

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-12 Thread Zhang, Helin
Hi Qi Could you help to rebase on the latest dpdk-next-net-intel? It cannot be applied now. Thanks! Regards, Helin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai,

Re: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Van Haaren, Harry > Sent: Friday, January 12, 2018 1:36 AM > To: David C Harton; Wu, Jingjing; Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash >

Re: [dpdk-dev] [PATCH v3] net/i40e: fix port segmentation fault when restart

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, January 3, 2018 4:20 PM > To: Zhao1, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix port segmentation fault when > restart > > > > > -Original Message---

Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, January 12, 2018 2:48 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API > > > > > -Original Message

Re: [dpdk-dev] [PATCH] net/i40e: fix setting MAC address on i40evf

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, January 11, 2018 1:18 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Wu, Jingjing; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix setting MAC address on i40evf > > > >

Re: [dpdk-dev] [PATCH 1/1] timer: fix reset on service cores

2018-01-12 Thread Pavan Nikhilesh
On Fri, Jan 12, 2018 at 03:31:05PM -0600, Erik Gabriel Carrillo wrote: > The return value of rte_lcore_has_role is misinterpreted in the timer > reset function. The return values of rte_lcore_has_role will be changed > in a future DPDK release, but this commit fixes this call site until > that hap

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-12 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dai, Wei > Sent: Friday, January 12, 2018 11:04 AM > To: Wu, Yanglong; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF > > > -Original Message- > > From: Wu, Yang

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-12 Thread Neil Horman
On Fri, Jan 12, 2018 at 03:55:10PM +, Ferruh Yigit wrote: > On 1/12/2018 2:37 PM, Neil Horman wrote: > > On Fri, Jan 12, 2018 at 11:50:12AM +, Ferruh Yigit wrote: > >> On 1/11/2018 9:29 PM, Neil Horman wrote: > >>> On Thu, Jan 11, 2018 at 08:06:48PM +, Ferruh Yigit wrote: > On 12/1

Re: [dpdk-dev] [PATCH v3] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-12 Thread Chas Williams
Tested-by: Chas Williams On Fri, Jan 12, 2018 at 8:18 AM, Maxime Coquelin wrote: > Hi Anatoly, > > > On 01/12/2018 12:10 PM, Burakov, Anatoly wrote: > >> >> >> +#if defined(RTE_ARCH_X86) >>> +static bool >>> +pci_one_device_iommu_support_va(struct rte_pci_device *dev) >>> +{ >>> +#define VTD_C

Re: [dpdk-dev] [PATCH] net/mlx5: fix parsing all-multicast from flow item

2018-01-12 Thread Yongseok Koh
> On Jan 11, 2018, at 12:20 AM, Nélio Laranjeiro > wrote: > > On Wed, Jan 10, 2018 at 11:51:53PM -0800, Yongseok Koh wrote: >> As the dst_mac of allmulti is already masked with the mask, it has 0x01 in >> the first octet. Checking the least significant bit only can't distinguish >> it from broa

Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2018-01-12 Thread Mody, Rasesh
> From: Mody, Rasesh > Sent: Thursday, January 11, 2018 11:03 AM > To: 'Ferruh Yigit' ; Thomas Monjalon > ; Patil, Harish > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch > option > > Hi Ferruh, > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf

[dpdk-dev] [PATCH] net/qede: replace config option with run-time arg

2018-01-12 Thread Rasesh Mody
This patch adds support for handling run-time driver arguments. We have removed config option for per VF Tx switching and added a run-time argument vf_txswitch. By default, the VF Tx switching is enabled however it can be disabled using run-time argument. Sample usage to disable per port VF Tx swi

[dpdk-dev] [PATCH 1/1] timer: fix reset on service cores

2018-01-12 Thread Erik Gabriel Carrillo
The return value of rte_lcore_has_role is misinterpreted in the timer reset function. The return values of rte_lcore_has_role will be changed in a future DPDK release, but this commit fixes this call site until that happens. Fixes: 351f463456f8 ("timer: allow reset on service cores") Cc: sta...@d

[dpdk-dev] [PATCH 3/3] lib/cmdline: Cross platform fixes for cmdline_flow

2018-01-12 Thread Georgios Katsikas
Signed-off-by: Georgios Katsikas --- app/test-pmd/Makefile | 2 + app/test-pmd/cmdline.c| 4 + app/test-pmd/testpmd.h| 14 - lib/librte_cmdline/Makefile | 3 + lib/librte_cmdline/cmdline_flow.c | 555 ++-- lib/librte_cmd

[dpdk-dev] [PATCH 2/3] app/testpmd: Added new line and parenthesized macros

2018-01-12 Thread Georgios Katsikas
Signed-off-by: Georgios Katsikas --- lib/librte_cmdline/cmdline_flow.h | 2 +- lib/librte_ether/rte_flow.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_cmdline/cmdline_flow.h b/lib/librte_cmdline/cmdline_flow.h index 45219d5..7066254 100644 --- a/lib/

[dpdk-dev] [PATCH 1/1] doc: announce API change to lcore role function

2018-01-12 Thread Erik Gabriel Carrillo
This an API/ABI change notice for DPDK 18.05 announcing a change in the meaning of the return values of the rte_lcore_has_role() function. Signed-off-by: Erik Gabriel Carrillo --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/d

Re: [dpdk-dev] [PATCH v1 1/5] rawdev: introduce raw device library support

2018-01-12 Thread Trahe, Fiona
Hi Shreyansh, /// snip /// > > [Fiona] Yes. I'm probably overcomplicating it. > > I was considering scanned devices and e.g. a case where 2 PMDs > > inadvertently pick the same name. > > One idea would be each driver would register a type string with the lib > > layer and > > all its device name

Re: [dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation

2018-01-12 Thread Ferruh Yigit
On 1/11/2018 3:35 PM, Tomasz Duszynski wrote: > From: Natalie Samsonov Commit title updated to [1] assuming hif is an abbreviation (btw, what is hif?) [1] net/mrvl: fix HIF objects allocation > > 1. Add checking for non-EAL threads. > > 2. Create hif objects on first use since sometimes on pr

Re: [dpdk-dev] [PATCH 0/5] net/mrvl: fix recently found pmd issues

2018-01-12 Thread Ferruh Yigit
On 1/11/2018 3:35 PM, Tomasz Duszynski wrote: > Following commits provide fixes for a few recently > found NET MRVL PMD issues. > > Natalie Samsonov (5): > net/mrvl: fix multiple probe issue > net/mrvl: fix hif objects allocation > net/mrvl: fix oversize bpool handling > net/mrvl: fix shad

Re: [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address

2018-01-12 Thread Ferruh Yigit
On 1/12/2018 6:46 PM, Ferruh Yigit wrote: > On 1/3/2018 1:32 PM, Olivier Matz wrote: >> This operation is already done by the ethdev layer, it should not >> be done by the driver. >> >> Signed-off-by: Olivier Matz > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bnxt: remove useless copy when setting MAC address

2018-01-12 Thread Ferruh Yigit
On 1/3/2018 1:32 PM, Olivier Matz wrote: > This operation is already done by the ethdev layer, it should not > be done by the driver. > > Signed-off-by: Olivier Matz Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address

2018-01-12 Thread Ferruh Yigit
On 1/12/2018 6:40 PM, Ferruh Yigit wrote: > On 1/3/2018 1:32 PM, Olivier Matz wrote: >> This operation is already done by the ethdev layer, it should not >> be done by the driver. >> >> Signed-off-by: Olivier Matz > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address

2018-01-12 Thread Ferruh Yigit
On 1/3/2018 1:32 PM, Olivier Matz wrote: > This operation is already done by the ethdev layer, it should not > be done by the driver. > > Signed-off-by: Olivier Matz Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/thunderx: Convert ThunderX VNIC PMD to new offload API

2018-01-12 Thread Ferruh Yigit
On 1/3/2018 1:12 PM, maciej.cze...@caviumnetworks.com wrote: > From: Maciej Czekaj > > This patch removes all references to old-style offload API > replacing them with new offload flags. > > Signed-off-by: Maciej Czekaj <...> > > dev_info->default_txconf = (struct rte_eth_txconf) { >

[dpdk-dev] [PATCH v3] app/procinfo: add compilation option in config file

2018-01-12 Thread Anatoly Burakov
Unlike every other DPDK application's compilation, proc_info's compilation cannot be turned off on Linux. Fix it by adding a config option to base linuxapp config. Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") Cc: maryam.tah...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Bura

Re: [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions

2018-01-12 Thread Ferruh Yigit
On 1/12/2018 6:14 PM, Ferruh Yigit wrote: > On 12/27/2017 6:28 PM, Stephen Hemminger wrote: >> The TAP device does not use these definitions in current version. >> And kernel version is not the correct way to detect features. >> >> Signed-off-by: Stephen Hemminger > > Fixes: 7c2d03d65f5e ("ne

Re: [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions

2018-01-12 Thread Ferruh Yigit
On 12/27/2017 6:28 PM, Stephen Hemminger wrote: > The TAP device does not use these definitions in current version. > And kernel version is not the correct way to detect features. > > Signed-off-by: Stephen Hemminger Fixes: 7c2d03d65f5e ("net/tap: remove Linux version check") Cc: sta...@

Re: [dpdk-dev] [PATCH] app/testpmd: make txonly mode generate multiple flows

2018-01-12 Thread Thomas Monjalon
+Cc Wenzhuo Wenzhuo, please could you check this list? https://dpdk.org/dev/patchwork/project/dpdk/list/?q=testpmd Thanks a lot 15/12/2017 22:11, Yongseok Koh: > Testpmd can generate multiple flows without taking much cost and this could > be a simple traffic generator for developer's qui

Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file

2018-01-12 Thread Burakov, Anatoly
On 12-Jan-18 6:02 PM, Thomas Monjalon wrote: 12/01/2018 18:49, Anatoly Burakov: Unlike every other DPDK application's compilation, proc_info's compilation cannot be turned off on Linux. Fix it by adding a config option to base linuxapp config. Fixes: 22561383ea17 ("app: replace dump_cfg by proc

Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function

2018-01-12 Thread Thomas Monjalon
12/01/2018 19:01, Carrillo, Erik G: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 12/01/2018 00:09, Carrillo, Erik G: > > > Hi Aaron, > > > > > > From: Aaron Conole [mailto:acon...@redhat.com] > > > > > > > > Hi Erik, > > > > > > > > Erik Gabriel Carrillo writes: > > > > > > > > > Updat

Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file

2018-01-12 Thread Thomas Monjalon
12/01/2018 18:49, Anatoly Burakov: > Unlike every other DPDK application's compilation, proc_info's > compilation cannot be turned off on Linux. Fix it by adding a > config option to base linuxapp config. > > Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") > Cc: maryam.tah...@intel.com

Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function

2018-01-12 Thread Carrillo, Erik G
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 11, 2018 5:17 PM > To: Carrillo, Erik G > Cc: dev@dpdk.org; Aaron Conole ; > pbhagavat...@caviumnetworks.com; Van Haaren, Harry > > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or

Re: [dpdk-dev] [PATCH] bus/fslmc: add support for scanned device count

2018-01-12 Thread Ferruh Yigit
On 1/2/2018 1:08 PM, Shreyansh Jain wrote: > FSLMC bus detects a multiple type of logical objects representing > components of the datapath. > > Using the type of device, a newly introduced API > rte_fslmc_get_device_count can return the count of devices > scanned of that device type. > > Signed-

Re: [dpdk-dev] [PATCH] app/testpmd: add eth peer CLI command

2018-01-12 Thread Thomas Monjalon
> > This command will simulate the process of setting the eth-peer from > > command line. > > > > It will be useful to preform extra testing. > > > > usage: > > testpmd> set eth-peer . > > > > Signed-off-by: Wisam Jaddo > Acked-by: Wenzhuo Lu The patch has not been received on the mailing l

Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()

2018-01-12 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 12, 2018 5:24 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for > rte_smp_mb() > > Hi, > > 18/12/2017 16:34,

[dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file

2018-01-12 Thread Anatoly Burakov
Unlike every other DPDK application's compilation, proc_info's compilation cannot be turned off on Linux. Fix it by adding a config option to base linuxapp config. Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") Cc: maryam.tah...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Bura

Re: [dpdk-dev] [PATCH] test/memzone: Fix test_memzone_basic & test_memzone_free issues.

2018-01-12 Thread Burakov, Anatoly
On 11-Jan-18 9:41 AM, Phil Yang wrote: 1. test_memzone_basic: No need to free a NULL memzone. It will cause test termination. 2. test_memzone_free: Out of mz[RTE_MAX_MEMZONE] memory bound while reserving memzone for mz. It will flush variable i. Fix by extend to mz[RTE_MAX_MEMZONE + 1]. Signed-o

Re: [dpdk-dev] [PATCH v3 1/2] mempool: fix first memory area notification

2018-01-12 Thread Thomas Monjalon
24/12/2017 13:47, Pavan Nikhilesh: > Mempool creation needs to be completed first before notifying mempool to > register the mempool area. > > Fixes: 12b8cc1a7e86 ("mempool: notify memory area to pool") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > Acked-by: Santosh Shukla Series

Re: [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier

2018-01-12 Thread Thomas Monjalon
08/01/2018 05:40, Pavan Nikhilesh: > Use smp barrier instead of IO barrier when sending mbox request as the > write has to be reflected between cores not IO devices. > > Fixes: 6da9d24574db ("event/octeontx: add mailbox support") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > Acked-b

Re: [dpdk-dev] [PATCH 1/2] eal: make max vfio groups configurable

2018-01-12 Thread Burakov, Anatoly
On 29-Dec-17 7:58 AM, Pavan Nikhilesh wrote: Make max vfio groups compile-time configurable so that platforms can choose vfio group limit. Signed-off-by: Pavan Nikhilesh --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()

2018-01-12 Thread Thomas Monjalon
Hi, 18/12/2017 16:34, Konstantin Ananyev: > test/test/test_mb.c | 315 > [...] > +REGISTER_TEST_COMMAND(mb_autotest, test_mb); For readability, do you agree to rename "mb" to "barrier" in function and file name?

[dpdk-dev] [PATCH v2] member: fix memory leak on error

2018-01-12 Thread Anatoly Burakov
rte_member may have allocated a tailq entry or setum before failure, so free them. Fixes: 857ed6c68cf2 ("member: implement main API") Cc: yipeng1.w...@intel.com Signed-off-by: Anatoly Burakov --- Notes: v2: free setsum as well lib/librte_member/rte_member.c | 3 ++- 1 file changed, 2 inser

Re: [dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model

2018-01-12 Thread Thomas Monjalon
Hi, Please find few comments. Sorry for the late review. We need also to get the acknowledgement from Olivier. 04/12/2017 02:50, Jia He: > --- a/config/common_armv8a_linuxapp > +++ b/config/common_armv8a_linuxapp > @@ -49,3 +49,5 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n > CONFIG_RTE_LIBRTE_AVP_PMD=n >

Re: [dpdk-dev] [PATCH V7 2/3] ring: introduce new header file to include common functions

2018-01-12 Thread Thomas Monjalon
04/12/2017 02:50, Jia He: > move the common part of rte_ring.h into rte_ring_generic.h. > move the memory barrier part into update_tail(). > > no functional changes here. [...] > --- /dev/null > +++ b/lib/librte_ring/rte_ring_generic.h > @@ -0,0 +1,195 @@ > +/*- > + * BSD LICENSE > + * > + * C

Re: [dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-12 Thread Thomas Monjalon
Hi, All the code is using ARM64, but the title suggests AArch64. What is the difference between AArch64 and ARM64 (and ARMv8)? 04/01/2018 11:20, Herbert Guan: > +/** > + * Beginning of customization section > + **/ > +#define

[dpdk-dev] [PATCH v4 12/13] app/eventdev: add pipeline atq worker functions

2018-01-12 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c | 281 +- 1 file changed, 280 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c index 6c9ac6119..f4cfd3cc7 100644 --- a/

[dpdk-dev] [PATCH v4 11/13] app/eventdev: add pipeline atq test

2018-01-12 Thread Pavan Nikhilesh
This is a pipeline test case that aims at testing the following with ``all types queue`` eventdev scheme. 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The atq queue test functions as same as ``pipeline_queue`` test. The diffe

[dpdk-dev] [PATCH v4 10/13] app/eventdev: add pipeline queue worker functions

2018-01-12 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.h | 80 + app/test-eventdev/test_pipeline_queue.c | 289 ++- 2 files changed, 368 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_common.h b/app/test-eventde

[dpdk-dev] [PATCH v4 09/13] app/eventdev: add pipeline queue test

2018-01-12 Thread Pavan Nikhilesh
This is a pipeline queue test case that aims at testing the following: 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The pipeline queue test configures the eventdev with Q queues and P ports, where Q is (nb_ethdev * nb_stages)

[dpdk-dev] [PATCH v4 08/13] app/eventdev: launch pipeline lcores

2018-01-12 Thread Pavan Nikhilesh
The event master lcore's test termination and the logic to print the mpps are common for the queue and all types queue test. Move them as the common function. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 67 app/test-eventdev/tes

[dpdk-dev] [PATCH v4 07/13] app/eventdev: add Tx service setup

2018-01-12 Thread Pavan Nikhilesh
Setup one port event port for Tx and link the respective event queue. Register the Tx function as a service to be called from a service core. The Tx function dequeues the events from the event queue and transmits the packet to its respective ethernet port. Signed-off-by: Pavan Nikhilesh --- app/

[dpdk-dev] [PATCH v4 06/13] app/eventdev: add event port setup and Rx adapter setup

2018-01-12 Thread Pavan Nikhilesh
Setup one port per worker and link to all queues and setup producer port based on Rx adapter capabilities. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 114 +++ app/test-eventdev/test_pipeline_common.h | 5 ++ 2 files changed, 119 in

[dpdk-dev] [PATCH v4 05/13] app/eventdev: add pipeline ethport setup and destroy

2018-01-12 Thread Pavan Nikhilesh
Add common ethdev port setup and destroy along with event dev destroy. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 91 app/test-eventdev/test_pipeline_common.h | 3 ++ 2 files changed, 94 insertions(+) diff --git a/app/test-eve

[dpdk-dev] [PATCH v4 04/13] app/eventdev: add pipeline opt dump and check functions

2018-01-12 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 84 app/test-eventdev/test_pipeline_common.h | 3 ++ 2 files changed, 87 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c

[dpdk-dev] [PATCH v4 03/13] app/eventdev: add mempool setup and destroy

2018-01-12 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 29 + app/test-eventdev/test_pipeline_common.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/te

[dpdk-dev] [PATCH v4 02/13] app/eventdev: add pipeline test setup and destroy

2018-01-12 Thread Pavan Nikhilesh
Pipeline test has the queue and all types queue variants. Introduce test_pipeline_common* to share the common code between those tests. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/Makefile | 2 ++ app/test-eventdev/test_pipeline_common.c | 44 ++

[dpdk-dev] [PATCH v4 01/13] app/eventdev: add packet distribution logs

2018-01-12 Thread Pavan Nikhilesh
Add logs for packet distribution across worker cores to be printed along with the test results. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v4 Changes: - remove Tx queue locking by using Tx service ml discussion : http://dpdk.org/ml/archives/dev/2018-January/086730.html v3 C

Re: [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for internal usages

2018-01-12 Thread Thomas Monjalon
07/12/2017 11:28, Hemant Agrawal: > other vfio based module e.g. fslmc will also need to use > the clear_group call. > So, exposing it and renaming it to *rte_vfio_clear_group* > > Signed-off-by: Hemant Agrawal > --- > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h > +++ b/lib/librte_eal/linuxapp/e

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] pmdinfogen: fix cross compilation for ARM BE

2018-01-12 Thread Thomas Monjalon
18/12/2017 08:56, Hemant Agrawal: > Cross compiling DPDK for BE mode on ARM results into errors > "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" > > The original code assumes the sh_size to be 32 bit, while it can > be Elf32_Word or Elf64_Xword based on 32bit or 64 bit systems. > >

Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option

2018-01-12 Thread Thomas Monjalon
12/01/2018 16:52, Pavan Nikhilesh: > Hi Thomas, > > The patchset depends on the following patchset > http://dpdk.org/dev/patchwork/patch/32038/ OK thanks !

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-12 Thread Ferruh Yigit
On 1/12/2018 2:37 PM, Neil Horman wrote: > On Fri, Jan 12, 2018 at 11:50:12AM +, Ferruh Yigit wrote: >> On 1/11/2018 9:29 PM, Neil Horman wrote: >>> On Thu, Jan 11, 2018 at 08:06:48PM +, Ferruh Yigit wrote: On 12/13/2017 3:17 PM, Neil Horman wrote: > Document the need to add the __

Re: [dpdk-dev] [PATCHv4 4/5] dpdk: add __experimental tag to appropriate api calls

2018-01-12 Thread Ferruh Yigit
On 1/12/2018 2:25 PM, Neil Horman wrote: > On Fri, Jan 12, 2018 at 11:50:01AM +, Ferruh Yigit wrote: >> On 1/11/2018 9:24 PM, Neil Horman wrote: >>> On Thu, Jan 11, 2018 at 08:06:33PM +, Ferruh Yigit wrote: On 12/13/2017 3:17 PM, Neil Horman wrote: > Append the __experimental tag t

Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option

2018-01-12 Thread Pavan Nikhilesh
Hi Thomas, The patchset depends on the following patchset http://dpdk.org/dev/patchwork/patch/32038/ Thanks, Pavan On Fri, Jan 12, 2018 at 04:46:47PM +0100, Thomas Monjalon wrote: > 12/12/2017 17:36, Olivier MATZ: > > On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote: > > > Remove

[dpdk-dev] [RFC 1/2] vhost-user: don't allocate new queue once device is running

2018-01-12 Thread Maxime Coquelin
Once the device is created, it is not possible to hot-add new queues. If it happens, it could confuse the application, as the new queue might not be initialized but nr_vring is incremented. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 20 +--- 1 file changed

[dpdk-dev] [RFC 2/2] vhost-user: add support for VHOST_USER_SET_QUEUE_NUM

2018-01-12 Thread Maxime Coquelin
With some guest drivers, the number of queues setup by the guest driver can be less than the number of queues declared in Qemu. This is the case for example with Windows virtio-net driver, which only setups as much queue pairs as the number of vCPUs. When it happens, depending on QEMU version, th

[dpdk-dev] [RFC 0/2] vhost-user: add VHOST_USER_SET_QUEUE_NUM support

2018-01-12 Thread Maxime Coquelin
Hi this two-patches series first ensure that no queues will be allocated while the device is in a running state, and then implements support for VHOST_USER_SET_QUEUE_NUM vhost-user protocol request. The goal is to prevent the device to either corrupt some guest memory when disabling guest notifica

Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option

2018-01-12 Thread Thomas Monjalon
12/12/2017 17:36, Olivier MATZ: > On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote: > > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config > > option for controlling datapath log level. > > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to > >

Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency

2018-01-12 Thread Thomas Monjalon
12/01/2018 16:04, Burakov, Anatoly: > On 12-Jan-18 2:59 PM, Thomas Monjalon wrote: > > 12/01/2018 15:17, Anatoly Burakov: > >> proc_info app is compiled unconditionally on Linux, but it's > >> actually dependent on librte_ethdev library, which prevents > >> DPDK from building without librte_ethdev

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2018-01-12 Thread Thomas Monjalon
21/11/2017 08:05, Aleksey Baulin: > On Mon, Nov 20, 2017 at 4:36 PM, Wiles, Keith wrote: > > > On Nov 19, 2017, at 4:16 PM, Aleksey Baulin > > wrote: > > > -#define unlikely(x) __builtin_expect((x),0) > > > +#define unlikely(x) __builtin_expect(!!(x), 0) > > > > I have not looked at the generat

Re: [dpdk-dev] [PATCH 1/6 v2] event/dpaa2: replace static with dynamic logging

2018-01-12 Thread Hemant Agrawal
On 1/13/2018 2:52 AM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 83 --- drivers/event/dpaa2/dpaa2_eventdev.h | 12 - drivers/event/dpaa2/dpaa2_eventdev_logs.h | 37 ++ drivers/event/dpaa2/dpaa2_

Re: [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for internal usages

2018-01-12 Thread Burakov, Anatoly
On 07-Dec-17 10:28 AM, Hemant Agrawal wrote: other vfio based module e.g. fslmc will also need to use the clear_group call. So, exposing it and renaming it to *rte_vfio_clear_group* Signed-off-by: Hemant Agrawal Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v3 0/3] improve failsafe performance

2018-01-12 Thread Ferruh Yigit
On 12/19/2017 5:14 PM, Matan Azrad wrote: > This fail-safe series should improve some cycles in failsafe data path. > It is obvious that we cannot improve a lot because the most of data path > functionality are done by the sub devices data path. > So the expectation from this series is just to imp

[dpdk-dev] [PATCH 6/6 v2] net/dpaa2: support atomic queues

2018-01-12 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/Makefile | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 7 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 5 + drivers/net/dpaa2/dpaa2_rxtx.c | 43 +--- 4 files changed, 53 insertions(+), 3 deletions(-) di

[dpdk-dev] [PATCH 4/6 v2] event/dpaa2: have separate structure to hold dqrr entries

2018-01-12 Thread Nipun Gupta
This patch provides cleaner approach to store the DQRR entries, which are yet to be consumed in case of atomic queues. Also, this patch changes the storage of the DQRR entry index into the mbuf->seqn instead of ev->opaque Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c

[dpdk-dev] [PATCH 5/6 v2] bus/fslmc: add flag to configure DCA in QBMAN multi Tx

2018-01-12 Thread Nipun Gupta
With the current QBMAN multi-tx API, we need to create separate enqueue descriptors for each of the packet which is required to be enqueued to the hardware, once we support Atomic Queues (with DCA) in dpaa2 drivers. Creating enqueue descriptor for each packet is costly and have significant performa

[dpdk-dev] [PATCH 3/6 v2] event/dpaa2: use dqrr index to cosume the DQRR entry

2018-01-12 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 83b572f..37e3e1c 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/dri

[dpdk-dev] [PATCH 2/6 v2] bus/fslmc: introduce API to consume dqrr using index

2018-01-12 Thread Nipun Gupta
A new API qbman_swp_dqrr_idx_consume is defined which takes input as DQRR index to consume corresponding DQRR entry. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 7 +++ drivers/bus/fslmc/qbman/qbman_portal.c | 7 +++ drivers/bus/fslmc/rt

[dpdk-dev] [PATCH 1/6 v2] event/dpaa2: replace static with dynamic logging

2018-01-12 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 83 --- drivers/event/dpaa2/dpaa2_eventdev.h | 12 - drivers/event/dpaa2/dpaa2_eventdev_logs.h | 37 ++ drivers/event/dpaa2/dpaa2_hw_dpcon.c | 1 + 4 files changed, 82

[dpdk-dev] [PATCH 0/6 v2] support atomic queues in dpaa2 ethernet with eventdev

2018-01-12 Thread Nipun Gupta
These patches assume that DPAA2 series is already applied [1]. This patch series supports atomic queues in DPAA2 Ethernet driver with eventdev. Also other changes such as dynamic logging is supported with these changes. Patch 1 - support dynamic logging in eventdev Patch 2,3,4 - Cleanups and perf

Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency

2018-01-12 Thread Burakov, Anatoly
On 12-Jan-18 2:59 PM, Thomas Monjalon wrote: 12/01/2018 15:17, Anatoly Burakov: proc_info app is compiled unconditionally on Linux, but it's actually dependent on librte_ethdev library, which prevents DPDK from building without librte_ethdev library enabled. Fixes: 22561383ea17 ("app: replace d

Re: [dpdk-dev] [dpdk-stable] [PATCH] vfio: fix error check when checking if vfio is enabled

2018-01-12 Thread Thomas Monjalon
22/12/2017 11:30, Anatoly Burakov: > rte_eal_check_module() might return -1, which would have been a > "not false" condition for mod_available. Fix that to only report > vfio being enabled if rte_eal_check_module() returns 1. > > Fixes: 221f7c220d6b ("vfio: move global config out of PCI files") >

[dpdk-dev] [PATCH v5] kernel folder for Linux and BSD modules

2018-01-12 Thread Hemant Agrawal
This patch moves the kernel modules code from EAL to a common place. - Separate the kernel module code from user space code. Signed-off-by: Hemant Agrawal Tested-by: Bruce Richardson --- v5: rearrange kernel compliation as per Bruce's suggestion v4: update the path in MAINTAINERS v3: move conti

Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency

2018-01-12 Thread Thomas Monjalon
12/01/2018 15:17, Anatoly Burakov: > proc_info app is compiled unconditionally on Linux, but it's > actually dependent on librte_ethdev library, which prevents > DPDK from building without librte_ethdev library enabled. > > Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") > Cc: maryam.ta

Re: [dpdk-dev] [PATCH] eal: fix end for bounded malloc elements

2018-01-12 Thread Thomas Monjalon
21/12/2017 17:54, Anatoly Burakov: > In cases when alignment is bigger than boundary, we may incorrectly > calculate end of a bounded malloc element. > > Consider this: suppose we are allocating a bounded malloc element > that should be of 128 bytes in size, bounded to 128 bytes and > aligned on a

Re: [dpdk-dev] [PATCH v1 1/5] rawdev: introduce raw device library support

2018-01-12 Thread Shreyansh Jain
Hello Fiona, Apologies for delay in my response. Some comments inline... On Monday 08 January 2018 08:21 PM, Trahe, Fiona wrote: -Original Message- From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] Sent: Monday, January 8, 2018 2:10 PM To: Trahe, Fiona Cc: Hemant Agrawal ; Xu, Ro

Re: [dpdk-dev] [PATCH] eal: protect malloc stats with lock

2018-01-12 Thread Thomas Monjalon
21/12/2017 18:32, Anatoly Burakov: > When we're gathering statistics, we are traversing the freelist, > which may change under our feet in multithreaded scenario. This > is verified by occasional segfaults when running malloc autotest > on a machine with big amount of cores. > > This patch protect

Re: [dpdk-dev] [PATCH] event/dpaa2: return correct number of event ports

2018-01-12 Thread Hemant Agrawal
On 1/3/2018 10:14 PM, Nipun Gupta wrote: In the info get API we were returning number of event ports as MAX number of LCORE's. After this change actual number of event ports (i.e. number of DPIO's) is provided in the info get API. Signed-off-by: Nipun Gupta --- This patch is dependent on https:

Re: [dpdk-dev] [PATCH v3] doc: ethdev ABI change deprecation notice

2018-01-12 Thread Neil Horman
On Fri, Jan 12, 2018 at 10:29:46AM +, Kirill Rybalchenko wrote: > Signed-off-by: Kirill Rybalchenko > > Acked-by: Marko Kovacevic > --- > doc/guides/rel_notes/deprecation.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-12 Thread Neil Horman
On Fri, Jan 12, 2018 at 11:50:12AM +, Ferruh Yigit wrote: > On 1/11/2018 9:29 PM, Neil Horman wrote: > > On Thu, Jan 11, 2018 at 08:06:48PM +, Ferruh Yigit wrote: > >> On 12/13/2017 3:17 PM, Neil Horman wrote: > >>> Document the need to add the __experimental tag to appropriate functions >

Re: [dpdk-dev] [PATCH] eal: fix memory leak in memzone when no room in config

2018-01-12 Thread Thomas Monjalon
21/12/2017 19:07, Anatoly Burakov: > We check if there's space in config after we allocated the memzone, > but if there isn't, we never free it back. This patch adds memzone > free if there's no room in memzone config. > > Fixes: ff909fe21f0a ("mem: introduce memzone freeing") > Cc: sergio.gonzale

Re: [dpdk-dev] [PATCHv4 4/5] dpdk: add __experimental tag to appropriate api calls

2018-01-12 Thread Neil Horman
On Fri, Jan 12, 2018 at 11:50:01AM +, Ferruh Yigit wrote: > On 1/11/2018 9:24 PM, Neil Horman wrote: > > On Thu, Jan 11, 2018 at 08:06:33PM +, Ferruh Yigit wrote: > >> On 12/13/2017 3:17 PM, Neil Horman wrote: > >>> Append the __experimental tag to api calls appearing in the EXPERIMENTAL >

[dpdk-dev] [PATCH] app: fix proc_info app dependency

2018-01-12 Thread Anatoly Burakov
proc_info app is compiled unconditionally on Linux, but it's actually dependent on librte_ethdev library, which prevents DPDK from building without librte_ethdev library enabled. Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") Cc: maryam.tah...@intel.com Cc: sta...@dpdk.org Signed-off-b

Re: [dpdk-dev] [PATCH] bus/fslmc: add support for scanned device count

2018-01-12 Thread Thomas Monjalon
12/01/2018 13:59, Shreyansh Jain: > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, January 12, 2018 5:15 PM > > To: Shreyansh Jain > > Cc: dev@dpdk.org; ferruh.yi...@intel.com > > Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: add support for scan

Re: [dpdk-dev] [PATCH v3 3/3] net/failsafe: improve Rx sub-devices iteration

2018-01-12 Thread Gaëtan Rivet
On Fri, Jan 12, 2018 at 01:29:17PM +, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Friday, January 12, 2018 12:29 PM > > Hi Matan, > > > > The other commits make sense to me so no issue there. > > I'm just surprised by this one so a quick question. > > > > On Tue, Dec 19, 2017 at 0

Re: [dpdk-dev] [RFC v3] Compression API in DPDK :SW ZLIB PMD

2018-01-12 Thread Verma, Shally
Hi Fiona > I think a common draft repo would be the best way forward. Let's talk to the > maintainers about getting one set up. Sure. Please share us details when it is available. I assume it will be created once API spec move from RFC to 1st version? Thanks Shally From: Trahe, Fiona [mailto:f

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-12 Thread Verma, Shally
Hi Fiona > -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 12 January 2018 00:24 > To: Verma, Shally ; Ahmed Mansour > ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; > Gupta, Ashish ; Sahu, Sunila > ; De Lara Guarch, Pablo > ; Challa, Mahipal > ; Jain, Deepa

Re: [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert to new ethdev offloads API

2018-01-12 Thread Ferruh Yigit
On 12/26/2017 9:23 AM, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. This patch does three things: 1- Convert

Re: [dpdk-dev] [PATCH v3 3/3] net/failsafe: improve Rx sub-devices iteration

2018-01-12 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Friday, January 12, 2018 12:29 PM > Hi Matan, > > The other commits make sense to me so no issue there. > I'm just surprised by this one so a quick question. > > On Tue, Dec 19, 2017 at 05:14:29PM +, Matan Azrad wrote: > > Connecting the sub-devices each other b

Re: [dpdk-dev] [PATCH v3] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-12 Thread Maxime Coquelin
Hi Anatoly, On 01/12/2018 12:10 PM, Burakov, Anatoly wrote: +#if defined(RTE_ARCH_X86) +static bool +pci_one_device_iommu_support_va(struct rte_pci_device *dev) +{ +#define VTD_CAP_MGAW_SHIFT    16 +#define VTD_CAP_MGAW_MASK    (0x3fULL << VTD_CAP_MGAW_SHIFT) +#define X86_VA_WIDTH 47 /* From

  1   2   >