On 1/3/2018 1:12 PM, maciej.cze...@caviumnetworks.com wrote:
> From: Maciej Czekaj <maciej.cze...@caviumnetworks.com>
>
> This patch removes all references to old-style offload API
> replacing them with new offload flags.
>
> Signed-off-by: Maciej Czekaj <maciej.cze...@caviumnetworks.com>
<...>
>
> dev_info->default_txconf = (struct rte_eth_txconf) {
> .tx_free_thresh = NICVF_DEFAULT_TX_FREE_THRESH,
> - .txq_flags =
> - ETH_TXQ_FLAGS_NOMULTSEGS |
> - ETH_TXQ_FLAGS_NOREFCOUNT |
> - ETH_TXQ_FLAGS_NOMULTMEMP |
> - ETH_TXQ_FLAGS_NOVLANOFFL |
> - ETH_TXQ_FLAGS_NOXSUMSCTP,
> + .txq_flags = ETH_TXQ_FLAGS_IGNORE,
I am not sure about this, Shahafs may comment better, shouldn't application
decide to set "ETH_TXQ_FLAGS_IGNORE" or not, instead of having this in default
configuration?
<...>
> + if ((conf_tx_offloads & tx_offload_capa) != conf_tx_offloads) {
> + PMD_INIT_LOG(ERR, "Some Tx offloads are not supported "
> + "requested 0x%lx supported 0x%lx\n",
> + conf_tx_offloads, tx_offload_capa);
This is broken for 32bits, using PRIx64 instead of "lx" makes your code more
portable.
