On 12-Jan-18 2:59 PM, Thomas Monjalon wrote:
12/01/2018 15:17, Anatoly Burakov:
proc_info app is compiled unconditionally on Linux, but it's
actually dependent on librte_ethdev library, which prevents
DPDK from building without librte_ethdev library enabled.
Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
Cc: maryam.tah...@intel.com
Cc: sta...@dpdk.org
nit: please insert a blank line here
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
---
DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
+ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
+DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
+endif
DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
What about pdump and testpmd?
I guess a lot of things do not compile without ethdev, isn't it?
True, however one can still disable testpmd compilation with a config
option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a
new config option (i.e. CONFIG_RTE_PROC_INFO)?
--
Thanks,
Anatoly
