Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-12 Thread Jerin Jacob
-Original Message- > Date: Wed, 13 Dec 2017 07:21:01 + > From: Shahaf Shuler > To: "Ananyev, Konstantin" , "dev@dpdk.org" > , "Nicolau, Radu" , > "arybche...@solarflare.com" > Subject: Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev > offloads API > > Tuesday, Decem

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags

2017-12-12 Thread Shahaf Shuler
>> We can do it. yes. >+1 for Ferruh. --txqflags argument was very handy in testing features in batch >mode. Let us have something equivalent. It is there. Checkout v2 of the series, an equivalent parameter was added: tx-offloads. --Shahaf From: Maciej Czekaj [mailto:maciej.cze...@cavium

Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Tuesday, December 12, 2017 7:12 PM, Ananyev, Konstantin: > > -Original Message- > > From: Shahaf Shuler [mailto:shah...@mellanox.com] > > Sent: Tuesday, December 12, 2017 12:26 PM > > To: dev@dpdk.org; Ananyev, Konstantin > ; > > Nicolau, Radu ; arybche...@solarflare.com > > Subject: [PATCH

[dpdk-dev] [PATCH] security: fix enum start value

2017-12-12 Thread Akhil Goyal
enum should be initialized with 1 so that unitialized(memset) memory may not be treated as a valid enum value. Fixes: c261d1431bd8 ("security: introduce security API and framework") Signed-off-by: Akhil Goyal --- lib/librte_security/rte_security.h | 8 1 file changed, 4 insertions(+),

[dpdk-dev] [PATCH 3/3] net/sfc: fix DMA memory leak after kvarg processing failure

2017-12-12 Thread Andrew Rybchenko
Fixes: e56fa9c23e7a ("net/sfc: add kvarg control for MAC statistics update period") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_

[dpdk-dev] [PATCH 1/3] net/sfc: stop periodic DMA if MAC stats upload fails

2017-12-12 Thread Andrew Rybchenko
Fixes: 3b257f7e6c0f ("net/sfc: request MAC stats upload immediately on port start") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_port.c b/driver

[dpdk-dev] [PATCH 2/3] net/sfc: fix multicast address list copy memory leak

2017-12-12 Thread Andrew Rybchenko
Fixes: 295f647a38a2 ("net/sfc: set multicast address list in started state only") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_port.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/12/2017 08:08 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 07:34:31PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/11/2017 07

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-12 Thread Hemant Agrawal
On 12/12/2017 10:27 PM, Olivier MATZ wrote: On Mon, Dec 11, 2017 at 09:56:40AM -0800, Ferruh Yigit wrote: On 12/10/2017 9:27 PM, Hemant Agrawal wrote: Hi all, Most templates are showing copyright first and SPDX later i.e. the typical way for writing the license. However some projects h

Re: [dpdk-dev] [PATCH v4 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-12 Thread Tiwei Bie
On Mon, Dec 11, 2017 at 04:15:03PM +0100, Maxime Coquelin wrote: > QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues > declared in QEMU command line before the guest is started. > It has the effect in DPDK vhost-user backend to allocate vrings > for all queues declared by QEMU. > > If t

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-12 Thread Neil Horman
On Tue, Dec 12, 2017 at 02:33:13PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Monday, December 11, 2017 7:36 PM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; Mcnamara, John ; > > Richardson, Bruce > > Subject

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-12 Thread Neil Horman
On Tue, Dec 12, 2017 at 03:11:33PM +, Wiles, Keith wrote: > > > > On Dec 11, 2017, at 1:36 PM, Neil Horman wrote: > > > > Hey all- > > A few days ago, I was lamenting the fact that, when reviewing patches I > > would frequently complain about ABI changes that were actually considered >

[dpdk-dev] [PATCH 5/7] event/sw: modify eventdev sw test

2017-12-12 Thread Pavan Nikhilesh
Modify test_eventdev_sw to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh --- drivers/event/sw/selftest_sw.c | 71 +- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/event/sw/selftest_sw.c b/dri

[dpdk-dev] [PATCH 7/7] doc: update eventdev documentation

2017-12-12 Thread Pavan Nikhilesh
Update octeontx and software eventdev documentation to include new selftest feature. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst | 13 + doc/guides/eventdevs/sw.rst | 12 2 files changed, 25 insertions(+) diff --git a/doc/guides/eventdevs/

[dpdk-dev] [PATCH 4/7] event/sw: move eventdev sw test to driver

2017-12-12 Thread Pavan Nikhilesh
Move software eventdev specific test (test_eventdev_sw) to driver/event/sw. Signed-off-by: Pavan Nikhilesh --- test/test/test_eventdev_sw.c => drivers/event/sw/selftest_sw.c | 0 test/test/Makefile | 1 - 2 files changed, 1 deletion(-) rename test/tes

[dpdk-dev] [PATCH 6/7] event/sw: add selftest to device arguments

2017-12-12 Thread Pavan Nikhilesh
Add selftest as a device argument that can be enabled by suppling 'self_test=1' as a vdev parameter --vdev="event_sw,self_test=1" The selftest is run after vdev creation is successfully complete. Signed-off-by: Pavan Nikhilesh --- drivers/event/sw/Makefile | 2 ++ drivers/event/sw/s

[dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver

2017-12-12 Thread Pavan Nikhilesh
Move octeontx eventdev specific test (test_eventdev_octeontx.c) to driver/event/octeontx. Signed-off-by: Pavan Nikhilesh --- .../event/octeontx/selftest_octeontx.c | 0 test/test/Makefile | 1 - 2 files chang

[dpdk-dev] [PATCH 3/7] event/octeontx: add selftest to device arguments

2017-12-12 Thread Pavan Nikhilesh
Add selftest as a device argument that can be enabled by suppling 'self_test=1' as a vdev parameter --vdev="event_octeontx,self_test=1" The selftest is run after vdev creation is successfully complete. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/Makefile | 3 ++- dr

[dpdk-dev] [PATCH 2/7] event/octeontx: modify octeontx eventdev test

2017-12-12 Thread Pavan Nikhilesh
Modify test_eventdev_octeontx to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/selftest_octeontx.c | 449 + 1 file changed, 258 insertions(+), 191 deletions(-) diff --git a/drivers/event/octeontx/selft

[dpdk-dev] [PATCH v3] eventdev: use links map to unlink queues

2017-12-12 Thread Pavan Nikhilesh
The octeontx event device doesn't store the queues to port mapping as a result it cannot return the exact number of queues unlinked from a port when application wants to unlink all the queues mapped (supplies queues param as NULL). Using links_map we can determine the exact queues mapped to a spec

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: update contribution guideline for dependent work

2017-12-12 Thread Ferruh Yigit
On 12/12/2017 7:54 AM, Olivier MATZ wrote: > Hi, > > On Mon, Dec 11, 2017 at 02:26:34PM +, Mcnamara, John wrote: >> From: Yigit, Ferruh >>> Changing some part of the libraries but not updating all dependent code >>> cause maintenance problems. >>> >>> ... >>> >>> Signed-off-by: Ferruh Yigit >

[dpdk-dev] [PATCH] kni: fix build dependency

2017-12-12 Thread Ferruh Yigit
kni library has a dependency to new PCI library, adding that dependency. build error: CC rte_kni.o In file included from dpdk/lib/librte_kni/rte_kni.c:48:0: dpdk/build/include/rte_kni.h:49:21: fatal error: rte_pci.h: No such file or directory #include ^ Fixes: c7

Re: [dpdk-dev] Minutes of technical board meeting 2017-12-06

2017-12-12 Thread Jay Rolette
On Tue, Dec 12, 2017 at 11:26 AM, Richardson, Bruce < bruce.richard...@intel.com> wrote: > Topic: Management of old patches in patchwork > * Unanimous agreement that old patches should be rejected in patchwork > after a reasonable period, set initially at 3 releases (9 months). > * After a rele

[dpdk-dev] Minutes of technical board meeting 2017-12-06

2017-12-12 Thread Richardson, Bruce
Attendees: Bruce, Hemant, Jerin, Konstantin, Olivier, Thomas, Yuanhan Absent: Stephen, Jan Due to discontinued involvement in DPDK, Jan has now resigned from the technical board. The tech board wishes to thank him for his contributions to DPDK and tech-board over the last few years and wish him

Re: [dpdk-dev] [PATCH v2] eventdev: use links map to unlink queues

2017-12-12 Thread Pavan Nikhilesh Bhagavatula
On Tue, Dec 12, 2017 at 04:08:12PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Tuesday, December 12, 2017 3:34 AM > > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > > ; Van Haaren, Harry > > ; Eads

Re: [dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-12 Thread Bruce Richardson
On Tue, Dec 12, 2017 at 04:59:34PM +, Bruce Richardson wrote: > This patchset changes the meson+ninja build system to always create both > static and shared libraries when doing a build. The applications compiled > as part of a build use either the shared or static libraries depending on > what

Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-12 Thread Ananyev, Konstantin
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, December 12, 2017 12:26 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > Nicolau, Radu ; > arybche...@solarflare.com > Subject: [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API > > Ethdev

[dpdk-dev] [PATCH 5/6] build: symlink drivers to library directory

2017-12-12 Thread Bruce Richardson
With the introduction of bus drivers, we now have a situation where driver libraries will start to depend upon each other. Because of this, the driver libs need to be discoverable by the dynamic loader. There are three options to fix this: 1. Force the user to put the $libdir/dpdk/drivers folder i

[dpdk-dev] [PATCH 4/6] build: change default library type to static

2017-12-12 Thread Bruce Richardson
Now that we always build both static and shared libraries, the default library type only applies to apps and examples. To avoid issues with paths when doing actual development with DPDK, change the default app build to static. This makes sure that testpmd, and any examples built as part of a develo

[dpdk-dev] [PATCH 6/6] examples: enable linking examples both static and shared

2017-12-12 Thread Bruce Richardson
Since the DPDK build now includes both static and shared libraries, we need a new way to enable building the examples using either method from the one installation. To do this, we add in a default "shared" target, and a separate "static" target which links in the DPDK static libraries. In both case

[dpdk-dev] [PATCH 1/6] build: remove library special cases

2017-12-12 Thread Bruce Richardson
The EAL and compat libraries were special-cases in the library build process, the former because of it's complexity, and the latter because it only consists of a single header file. By reworking the EAL meson.build files, we can eliminate the need for it to be a special case, by having it build up

[dpdk-dev] [PATCH 3/6] build: build all libs and drivers as both static and shared

2017-12-12 Thread Bruce Richardson
This patch changes the build process to group all .o files for a driver or library into a static archive first, and then link the .o files together into a shared library. This eliminates the need for separate static or shared object builds when packaging, for instance. The "default_library" config

[dpdk-dev] [PATCH 2/6] eal: fix list of source files to meson build

2017-12-12 Thread Bruce Richardson
Header files should not be listed in the sources list. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/meson.build | 8 1 file changed, 8 deletions(-) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index f806d8e42..198a553c4 100644 --- a/l

[dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-12 Thread Bruce Richardson
This patchset changes the meson+ninja build system to always create both static and shared libraries when doing a build. The applications compiled as part of a build use either the shared or static libraries depending on what the default_library build setting is. NOTE: The main difficulty with thi

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-12 Thread Olivier MATZ
On Mon, Dec 11, 2017 at 09:56:40AM -0800, Ferruh Yigit wrote: > On 12/10/2017 9:27 PM, Hemant Agrawal wrote: > > Hi all, > > Most templates are showing copyright first and SPDX later i.e. the > > typical way for writing the license. > > > > However some projects has followed it other way arou

Re: [dpdk-dev] [PATCH] doc: add i40e limitation of DCB function

2017-12-12 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Tuesday, December 12, 2017 7:19 AM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add i40e limitation of DCB function > > This patch adds limitation of DCB functio

Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option

2017-12-12 Thread Olivier MATZ
On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote: > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config > option for controlling datapath log level. > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to > control global and module specific log lev

Re: [dpdk-dev] [PATCH 0/3] generic channel for multi-process communication

2017-12-12 Thread Burakov, Anatoly
On 12-Dec-17 7:34 AM, Tan, Jianfeng wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Monday, December 11, 2017 6:00 PM To: Tan, Jianfeng; dev@dpdk.org Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net Subject: Re: [PATCH 0/3] generic channel for multi-pro

Re: [dpdk-dev] [PATCH v2] eventdev: use links map to unlink queues

2017-12-12 Thread Eads, Gage
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, December 12, 2017 3:34 AM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Van Haaren, Harry > ; Eads, Gage ; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Rao, Nikhil > ; sa

Re: [dpdk-dev] [PATCH 01/13] examples/eventdev: add Rx adapter support

2017-12-12 Thread Eads, Gage
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, December 12, 2017 2:18 AM > To: Eads, Gage ; > jerin.jacobkollanukka...@cavium.com; Van Haaren, Harry > ; Rao, Nikhil ; > hemant.agra...@nxp.com; Ma, Liang J > Cc: dev@dpd

Re: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable using wrong index

2017-12-12 Thread Doherty, Declan
On 20/11/2017 7:15 AM, Lilijun (Jerry) wrote: Hi all, In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave(). I think this variable is only a index for array internals->ac

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: update contribution guideline for dependent work

2017-12-12 Thread Olivier MATZ
Hi, On Mon, Dec 11, 2017 at 02:26:34PM +, Mcnamara, John wrote: > From: Yigit, Ferruh > > Changing some part of the libraries but not updating all dependent code > > cause maintenance problems. > > > > ... > > > > Signed-off-by: Ferruh Yigit > > > > > integration testing. > > > > +* If

Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection

2017-12-12 Thread santosh
On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote: > Use of rte_eal_mbuf_default_mempool_ops() API will > allow to override pool handler through "--mbuf-pool-ops-name" > eal command line argument. > > Signed-off-by: Jerin Jacob > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-12 Thread Wiles, Keith
> On Dec 11, 2017, at 1:36 PM, Neil Horman wrote: > > Hey all- > A few days ago, I was lamenting the fact that, when reviewing patches I > would frequently complain about ABI changes that were actually considered safe > because they were part of the EXPERIMENTAL api set. John M. asked me

Re: [dpdk-dev] [PATCH] test/mempool: improve default mempool ops selection

2017-12-12 Thread santosh
On Friday 17 November 2017 11:37 PM, Jerin Jacob wrote: > Use of rte_eal_mbuf_default_mempool_ops() API will > allow to override pool handler through "--mbuf-pool-ops-name" > eal command line argument. > > Signed-off-by: Jerin Jacob > --- > test/test/test_mempool.c | 4 ++-- > 1 file changed, 2

Re: [dpdk-dev] [RFC PATCH 3/3] doc: ethdev ABI change deprecation notice

2017-12-12 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev > Sent: Friday, December 1, 2017 2:48 PM > To: dev@dpdk.org; dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [RFC PATCH 3/3] doc: ethdev ABI change deprecation notice > > Signed-o

Re: [dpdk-dev] [PATCH] doc: fix issues in metrics example

2017-12-12 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mattias Rönnblom > Sent: Wednesday, November 29, 2017 9:29 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Mattias Rönnblom > Subject: [dpdk-dev] [PATCH] doc: fix issues in metrics example > > The metrics example d

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Nelio Laranjeiro
Hi Anoob, On Tue, Dec 12, 2017 at 07:34:31PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: > > Hi Anoob, > > > > On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: > > > Hi Nelio, > > > > > > > > > On 12/11/2017 07:34 PM, Nelio Laranje

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-12 Thread Mcnamara, John
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Monday, December 11, 2017 7:36 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Mcnamara, John ; > Richardson, Bruce > Subject: [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging > > Hey all- > A few

Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection

2017-12-12 Thread Olivier MATZ
On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote: > Use of rte_eal_mbuf_default_mempool_ops() API will > allow to override pool handler through "--mbuf-pool-ops-name" > eal command line argument. > > Signed-off-by: Jerin Jacob > --- > test/test/test_mempool_perf.c | 15 +++

Re: [dpdk-dev] [PATCH] test/mempool: improve default mempool ops selection

2017-12-12 Thread Olivier MATZ
Hi Jerin, On Fri, Nov 17, 2017 at 11:37:03PM +0530, Jerin Jacob wrote: > Use of rte_eal_mbuf_default_mempool_ops() API will > allow to override pool handler through "--mbuf-pool-ops-name" > eal command line argument. > > Signed-off-by: Jerin Jacob > --- > test/test/test_mempool.c | 4 ++-- > 1

Re: [dpdk-dev] [PATCH v2] doc: update oldest supported kernel in Linux guide

2017-12-12 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, November 28, 2017 10:02 PM > To: dev@dpdk.org > Cc: step...@networkplumber.org; bl...@debian.org > Subject: [dpdk-dev] [PATCH v2] doc: update oldest supported kernel in Linux > gui

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-12 Thread Bruce Richardson
On Mon, Dec 11, 2017 at 02:36:15PM -0500, Neil Horman wrote: > Hey all- > A few days ago, I was lamenting the fact that, when reviewing patches I > would frequently complain about ABI changes that were actually considered safe > because they were part of the EXPERIMENTAL api set. John M. ask

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/12/2017 07:14 PM, Nelio Laranjeiro wrote: Hi Anoob, On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by:

[dpdk-dev] [PATCH v3 4/4] power: clean up of kvm files

2017-12-12 Thread Marko Kovacevic
rename private header file rte_power_kvm_vm.c to power_kvm_vm.c. This prevents the private functions from leaking into the documentation. Change any private functions from rte_ to just . Reserve the rte_ for public functions Signed-off-by: Marko Kovacevic Acked-By: David Hunt --- lib/librte_p

[dpdk-dev] [PATCH v3 3/4] power: clean up of acpi files

2017-12-12 Thread Marko Kovacevic
Rename private header file rte_power_acpi_cpufreq.c to power_acpi_cpufreq.c.This prevents the private functions from leaking into the documentation. Change any private functions from rte_ to just .Reserve the rte_ for public functions. Signed-off-by: Marko Kovacevic Acked-By: David Hunt --- l

[dpdk-dev] [PATCH v3 2/4] power: clean up of power common header

2017-12-12 Thread Marko Kovacevic
Rename private header file rte_power_common.h to power_common.h to prevent private functions from leaking into the documentation. Signed-off-by: Marko Kovacevic Acked-By: David Hunt --- lib/librte_power/{rte_power_common.h => power_common.h} | 6 +++--- lib/librte_power/rte_power.c

[dpdk-dev] [PATCH v3 1/4] power: changed unsigned to unsigned int

2017-12-12 Thread Marko Kovacevic
Since this patch-set attempts to clean up the power library, and there are many instances of "unsigned" caught by checkpatch, it was decided to clean these up first rather than have them included in the later patches in the patch set. And would also minimise this type of error being caught by check

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-12 Thread Anoob Joseph
Hi Akhil, Radu On 12/12/2017 02:25 PM, Akhil Goyal wrote: Hi Anoob, On 12/11/2017 12:51 PM, Anoob wrote: Hi Akhil, Can you confirm if you are fine with the approach explained inline. Thanks, Anoob On 12/06/2017 03:13 PM, Radu Nicolau wrote: Hi, On 12/6/2017 7:30 AM, Anoob wrote: Hi Akh

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Nelio Laranjeiro
Hi Anoob, On Tue, Dec 12, 2017 at 06:13:08PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: > > Mellanox INNOVA NIC needs to have final target queue actions to perform > > inline crypto. > > > > Signed-off-by: Nelio Laranjeiro > > > > --- > > > >

Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info

2017-12-12 Thread Shreyansh Jain
On Tuesday 12 December 2017 04:33 PM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad Sent: Tuesday, December 12, 2017 10:46 AM To: Nikhil Agarwal ; dev@dpdk.org Cc: Hunt, David ; nikhil.agar...@nxp.com; hemant.agra...@nxp

Re: [dpdk-dev] [PATCH v3] doc: add a restriction to multi-process support

2017-12-12 Thread Chen, Junjie J
Done! Cheers JJ > -Original Message- > From: Mcnamara, John > Sent: Tuesday, December 12, 2017 8:41 PM > To: Chen, Junjie J ; Gonzalez Monroy, Sergio > ; Tahhan, Maryam > ; dev@dpdk.org > Subject: RE: [PATCH v3] doc: add a restriction to multi-process support > > > > > -Original Me

[dpdk-dev] [PATCH 3/3] examples/ipsec_secgw: create session mempools for ethdevs

2017-12-12 Thread Radu Nicolau
Also moved offloaded packets from cryptodev queues Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 42 +- examples/ipsec-secgw/ipsec.c | 31 ++-- examples/ipsec-secgw/ipsec.h | 4 ++-- 3 files changed,

[dpdk-dev] [PATCH 2/3] net/ixgbe: implemented security session get size

2017-12-12 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@

[dpdk-dev] [PATCH v2 10/10] app/testpmd: fix on the flight VLAN configuration

2017-12-12 Thread Shahaf Shuler
On ethdev there is an API to configure VLAN offloads after the port was started and without reconfiguration of the port or queues. In the current design of the application, when the Rx offloads are changed (through "port config all" CLI command) the port configuration is overwritten, therefore the

[dpdk-dev] [PATCH 1/3] lib/librte_security: added get size

2017-12-12 Thread Radu Nicolau
Signed-off-by: Radu Nicolau --- lib/librte_security/rte_security.c | 7 +++ lib/librte_security/rte_security.h | 12 lib/librte_security/rte_security_driver.h| 14 ++ lib/librte_security/rte_security_version.map | 1 + 4 files changed, 34 ins

[dpdk-dev] [PATCH v2 09/10] app/testpmd: enforce offloads caps

2017-12-12 Thread Shahaf Shuler
In the current design it was possible for offload to be set even though the device is not supporting it. A warning message was printed instead. This is a wrong behaviour, as application should set only the offloads reported by the capabilities of the device. This patch adds verification for the o

[dpdk-dev] [PATCH v2 08/10] app/testpmd: remove txqflags

2017-12-12 Thread Shahaf Shuler
Since testpmd is now using the new Ethdev offloads API and there is a way configure each of the tx offloads from CLI or command line, there is no need for the txqflags configuration anymore. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v2 06/10] app/testpmd: cleanup internal Tx offloads flags field

2017-12-12 Thread Shahaf Shuler
The tx_ol_flags field was used in order to control the different Tx offloads set. After the conversion to the new Ethdev Tx offloads API it is not needed anymore as the offloads configuration is stored in ethdev structs. Signed-off-by: Shahaf Shuler --- app/test-pmd/cmdline.c | 49 +

[dpdk-dev] [PATCH v2 07/10] app/testpmd: add command line option for Tx offloads

2017-12-12 Thread Shahaf Shuler
This patch adds command line option to set hex value for the ports Tx offloads flags. Signed-off-by: Shahaf Shuler --- app/test-pmd/parameters.c | 17 +++-- app/test-pmd/testpmd.c| 4 app/test-pmd/testpmd.h| 2 ++ doc/guides/testpmd_

[dpdk-dev] [PATCH v2 05/10] app/testpmd: fix flowgen forwarding ol flags

2017-12-12 Thread Shahaf Shuler
The mbuf ol_flags were taken directly from testpmd internal enumeration leading to incorrect values. addressing only insertion offload flags as the checksum flags by the application design are only with csum forwarding. Fixes: e9e23a617eb8 ("app/testpmd: add flowgen forwarding engine") Cc: cchemp

[dpdk-dev] [PATCH v2 03/10] app/testpmd: support check of single port stop

2017-12-12 Thread Shahaf Shuler
This patch adds supports for checking if a single port is stopped. currently there is a function to check only for all ports. Signed-off-by: Shahaf Shuler --- app/test-pmd/testpmd.c | 16 app/test-pmd/testpmd.h | 1 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --gi

[dpdk-dev] [PATCH v2 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") Convert the application to use the new API. This patch mandates the port to be stopped when configure the Tx offloads. This is because the PMD must be aware to the offloads changes on the de

[dpdk-dev] [PATCH v2 02/10] app/testpmd: convert to new Ethdev Rx offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") Convert the application to use the new API. The is no functionality changes rather simple conversion of the flags. Signed-off-by: Shahaf Shuler --- app/test-pmd/cmdline.c| 51 +

[dpdk-dev] [PATCH v2 00/10] convert testpmd to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
This series is to convert testpmd application to the new offloads API [1]. on v2: - Splited the patchset to multiple patches to help with the review. - Removed wrong comments. - Removed redundent parenthesis. - Fixed port print parameters. - Introduced a new method to check if single port is

[dpdk-dev] [PATCH v2 01/10] app/testpmd: fix port configuration print

2017-12-12 Thread Shahaf Shuler
The print of the port configuration was only according to configuration of the first port. Fixes: f2c5125a686a ("app/testpmd: use default Rx/Tx port configuration") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- app/test-pmd/config.c | 48 +++

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags

2017-12-12 Thread Maciej Czekaj
-- Oryginal message -- Thursday, December 7, 2017 1:05 AM, Ferruh Yigit: On 12/4/2017 10:48 PM, Shahaf Shuler wrote: Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit: On 11/23/2017 4:08 AM, Shahaf Shuler wrote: Since testpmd is now using the new Ethdev offloads API there is no need for the

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-12 Thread Anoob Joseph
Hi Nelio, On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v3: * removed PASSTHRU test for ingress. * removed check on configured queues for the queue ac

Re: [dpdk-dev] [PATCH v3] doc: add a restriction to multi-process support

2017-12-12 Thread Mcnamara, John
> -Original Message- > From: Chen, Junjie J > Sent: Wednesday, November 29, 2017 5:17 PM > To: Gonzalez Monroy, Sergio ; Mcnamara, > John ; Tahhan, Maryam ; > dev@dpdk.org > Cc: Chen, Junjie J > Subject: [PATCH v3] doc: add a restriction to multi-process support > > This patch add a res

[dpdk-dev] [PATCH v2 39/39] examples/skeleton: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler Acked-by: Bruce Richardson --- examples/skeleton/basicfwd.c | 31

[dpdk-dev] [PATCH v2 35/39] examples/packet_ordering: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/packet_ordering/main.c | 32

[dpdk-dev] [PATCH v2 37/39] examples/rxtx_callbacks: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler Acked-by: Bruce Richardson --- examples/rxtx_callbacks/main.c |

[dpdk-dev] [PATCH v2 36/39] examples/ptpclient: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/ptpclient/ptpclient.c | 28 +

[dpdk-dev] [PATCH v2 38/39] examples/server_node_efd: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/server_node_efd/server/init.c | 33 +

[dpdk-dev] [PATCH v2 34/39] examples/flow_filtering: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/flow_filtering/main.c | 26 +++--

[dpdk-dev] [PATCH v2 33/39] examples/flow_classify: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/flow_classify/flow_classify.c | 31 +

[dpdk-dev] [PATCH v2 31/39] examples/ethtool: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/ethtool/ethtool-app/main.c | 7 ++- 1 file chang

[dpdk-dev] [PATCH v2 30/39] examples/distributor: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler Acked-by: Bruce Richardson --- examples/distributor/main.c | 25

[dpdk-dev] [PATCH v2 32/39] examples/eventdev_pipeline: convert to new offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/eventdev_pipeline_sw_pmd/main.c | 29 +++

[dpdk-dev] [PATCH v2 29/39] examples/vm_power_manager: convert to new offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler Acked-by: David Hunt --- examples/vm_power_manager/main.c | 31 +

[dpdk-dev] [PATCH v2 28/39] examples/vmdq_dcb: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/vmdq_dcb/main.c | 27 ++- 1

[dpdk-dev] [PATCH v2 27/39] examples/vmdq: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/vmdq/main.c | 29 +++-- 1 fi

[dpdk-dev] [PATCH v2 24/39] examples/quota_watermark: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/quota_watermark/qw/init.c | 37 +

[dpdk-dev] [PATCH v2 26/39] examples/vhost: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/vhost/main.c | 41 ++

[dpdk-dev] [PATCH v2 25/39] examples/tep_termination: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/tep_termination/vxlan_setup.c | 36 +

[dpdk-dev] [PATCH v2 20/39] examples/netmap_compat: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/netmap_compat/bridge/bridge.c | 8 +++- exa

[dpdk-dev] [PATCH v2 23/39] examples/qos_sched: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/qos_sched/init.c | 30 +++---

[dpdk-dev] [PATCH v2 22/39] examples/qos_meter: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/qos_meter/main.c | 61 ++

[dpdk-dev] [PATCH v2 21/39] examples/performance-thread: convert to new offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/performance-thread/l3fwd-thread/main.c | 41

[dpdk-dev] [PATCH v2 19/39] examples/multi_process: convert to new ethdev offloads API

2017-12-12 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/multi_process/l2fwd_fork/main.c | 35 +

  1   2   >