Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Tan, Jianfeng
On 9/29/2017 6:00 PM, Burakov, Anatoly wrote: On 29-Sep-17 2:03 AM, Tan, Jianfeng wrote: + Reshma and Jan. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly Sent: Thursday, September 28, 2017 11:30 PM To: dev@dpdk.org Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-09-29 Thread Tan, Jianfeng
Hi Yuanhan, On 9/29/2017 4:28 PM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:55:59PM +, Jianfeng Tan wrote: static int +share_device(int vid) +{ + uint32_t i, vring_num; + int len; + int fds[8]; + struct rte_vhost_memory *mem; + struct vhost_params *param

[dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app

2017-09-29 Thread Xiaoyun Li
To make the performance can be tuning on different NICs or platforms. We need to make the number of descriptors and Rx/TX threshold as arguments when starting l3fwd application. Signed-off-by: Xiaoyun Li --- v2 * Modify commit log. * Update the change in guides doc. doc/guides/sample_app_ug/l3_

[dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- MAINTAINERS| 10 ++ config/common_base | 23 +++ doc/guides/rel_notes/release_17_11.rst | 10 ++ mk/rte.app.mk | 13 + 4 files changed, 56 insert

[dpdk-dev] [PATCH v1 5/6] bbdev: documentation

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- doc/api/doxy-api-index.md| 1 + doc/api/doxy-api.conf| 1 + doc/guides/bbdevs/index.rst | 40 ++ doc/guides/bbdevs/null.rst | 77 doc/guides/bbdevs/turbo_sw.rst |

[dpdk-dev] [PATCH v1 4/6] bbdev: sample app

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- examples/Makefile |1 + examples/bbdev_app/Makefile | 50 ++ examples/bbdev_app/main.c | 1260 +++ 3 files changed, 1311 insertions(+) create mode 100644 examples/bbdev_app/Makefile create mode 100644 examp

[dpdk-dev] [PATCH v1 0/6] Wireless Base Band Device (bbdev)

2017-09-29 Thread Amr Mokhtar
Hello, As a follow-up on the Wireless Base Band Device (bbdev) RFC [1].. Coming up is the patchwork of the initial release. This release supports the Turbo Code FEC with two virtual devices (vdev): 1. Null Turbo 2. Turbo_sw The full documentation of the BBDEV library is located at doc/guides/pr

[dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- lib/Makefile |3 + lib/librte_bbdev/Makefile | 59 ++ lib/librte_bbdev/rte_bbdev.c | 1065 lib/librte_bbdev/rte_bbdev.h | 637 +++ lib/librte_bbdev/rte

[dpdk-dev] [PATCH v1 2/6] bbdev: PMD drivers (null/turbo_sw)

2017-09-29 Thread Amr Mokhtar
Signed-off-by: Amr Mokhtar --- drivers/Makefile |2 + drivers/bbdev/Makefile | 41 + drivers/bbdev/null/Makefile| 54 + drivers/bbdev/null/bbdev_null.c| 350 + drivers/bbdev/null

[dpdk-dev] [PATCH v7 5/8] net/i40e: finish integration FDIR with generic flow API

2017-09-29 Thread Beilei Xing
rte_eth_fdir_* structures are still used in FDIR functions. This patch adds i40e private FDIR related structures and functions to finish integration FDIR with generic flow API. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 83 ++- drivers/net/i40e/i40e_fdir.c | 489 +

[dpdk-dev] [PATCH v7 8/8] net/i40e: enable cloud filter for GTP-C and GTP-U

2017-09-29 Thread Beilei Xing
This patch sets TEID of GTP-C and GTP-U as filter type by replacing existed filter types inner_mac and TUNNEL_KEY. This configuration will be set when adding GTP-C or GTP-U filter rules, and it will be invalid only by NIC core reset. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v7 7/8] net/i40e: add cloud filter parsing function for GTP

2017-09-29 Thread Beilei Xing
This patch adds i40e_flow_parse_gtp_filter parsing function for GTP-C and GTP-U to support cloud filter. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 2 + drivers/net/i40e/i40e_flow.c | 153 + 2 files changed, 155 insertions(+) diff

[dpdk-dev] [PATCH v7 4/8] ethdev: add GTP items to support flow API

2017-09-29 Thread Beilei Xing
This patch adds GTP, GTPC and GTPU items for generic flow API, and also exposes item fields through the flow command. Signed-off-by: Beilei Xing Acked-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 40 ++ app/test-pmd/config.c |

[dpdk-dev] [PATCH v7 3/8] net/i40e: support RSS for new pctype

2017-09-29 Thread Beilei Xing
Enable RSS for new pctypes after downloading new profile. Signed-off-by: Beilei Xing Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index

[dpdk-dev] [PATCH v7 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Beilei Xing
This patch adds FDIR support for GTP-C and GTP-U. The input set of GTP-C and GTP-U is TEID. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 30 + drivers/net/i40e/i40e_fdir.c | 214 - drivers/net/i40e/i40e_flow.c | 267

[dpdk-dev] [PATCH v7 2/8] net/i40e: update ptype and pctype info

2017-09-29 Thread Beilei Xing
Update new packet type and new pctype info when downloading profile. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 312 drivers/net/i40e/i40e_ethdev.h | 24 drivers/net/i40e/rte_pmd_i40e.c | 6 +- 3 files changed, 341 insertion

[dpdk-dev] [PATCH v7 1/8] mbuf: support GTP in software packet type parser

2017-09-29 Thread Beilei Xing
Add support of GTP-C and GTP-U tunnels in rte_net_get_ptype(). Signed-off-by: Beilei Xing Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 32 2 files changed, 34 insertions(+) diff --git a/lib/librte_mbuf/

[dpdk-dev] [PATCH v7 0/8] net/i40e: GPT-C and GTP-U enabling

2017-09-29 Thread Beilei Xing
This patch set enables RSS/FDIR/cloud filter for GPT-C and GTP-U. It depends on Kirill's patch: http://www.dpdk.org/dev/patchwork/patch/29325/ v7 changes: - Distinguish GTP-C request and response message in mbuf description. - Clarify GTP-C response message is not supported. - Version_type 0x30

Re: [dpdk-dev] [PATCH] doc: Adds reference to use mlockall() in the Programmer's guide

2017-09-29 Thread Mcnamara, John
Hi Eelco, Thanks for that. It is always good to get doc improvements. Some minor comments below. > -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Friday, September 29, 2017 1:51 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [PATCH] doc: Adds refer

[dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2017-09-29 Thread Stephen Hemminger
The Linux kernel style policy about strings is that strings should be always put on one line. This makes sense since a typical use case is for a user to type the error message into a search engine or grep, and it won't be found if split across lines. This patch just re-enables that check. Yes, lot

Re: [dpdk-dev] [PATCH v2 2/4] net/mrvl: add mrvl net pmd driver

2017-09-29 Thread Stephen Hemminger
On Thu, 28 Sep 2017 12:22:36 +0200 Tomasz Duszynski wrote: > + > +struct mrvl_rxq; > +struct mrvl_txq; These forward decl should not be nececessary > +static inline int > +mrvl_get_bpool_size(int pp2_id, int pool_id) No tab here please Why does this need to be inlined? Is it in critical

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 6:10 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C > and GTP-U > > On 29 Septem

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-09-29 Thread Wu, Jingjing
> +static void > +cmd_queue_region_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_queue_region_result *res = parsed_result; > + int ret = 0; > +#ifdef RTE_LIBRTE_

Re: [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code

2017-09-29 Thread Wu, Jingjing
> -Original Message- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 8:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Jain, Deepak K ; Kulasek, TomaszX > ; Chilikin, Andrey ; > sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix runtime dead code > > From: Tomasz Kulasek

[dpdk-dev] [PATCH v5 5/5] app/testpmd: add traffic management forwarding mode

2017-09-29 Thread Jasvinder Singh
This commit extends the testpmd application with new forwarding engine that demonstrates the use of ethdev traffic management APIs and softnic PMD for QoS traffic management. In this mode, 5-level hierarchical tree of the QoS scheduler is built with the help of ethdev TM APIs such as shaper profil

[dpdk-dev] [PATCH v5 4/5] net/softnic: add TM hierarchy related ops

2017-09-29 Thread Jasvinder Singh
Implement ethdev TM hierarchy related APIs in SoftNIC PMD. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Acked-by: Lu, Wenzhuo --- v5 change: - add macro for the tc period - add more comments drivers/net/softnic/rte_eth_softnic_internals.h | 41 + drivers/net/softnic/rt

[dpdk-dev] [PATCH v5 3/5] net/softnic: add TM capabilities ops

2017-09-29 Thread Jasvinder Singh
Implement ethdev TM capability APIs in SoftNIC PMD. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Acked-by: Lu, Wenzhuo --- drivers/net/softnic/rte_eth_softnic.c | 12 +- drivers/net/softnic/rte_eth_softnic_internals.h | 32 ++ drivers/net/softnic/rte_eth_softn

[dpdk-dev] [PATCH v5 2/5] net/softnic: add traffic management support

2017-09-29 Thread Jasvinder Singh
Add ethdev Traffic Management API support to SoftNIC PMD. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh Acked-by: Lu, Wenzhuo --- v5 changes: - change function name rte_pmd_softnic_run_tm() to run_tm() v3 changes: - add more confguration parameters (tm rate, tm queue sizes

[dpdk-dev] [PATCH v5 1/5] net/softnic: add softnic PMD

2017-09-29 Thread Jasvinder Singh
Add SoftNIC PMD to provide SW fall-back for ethdev APIs. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- v5 changes: - change function name rte_pmd_softnic_run_default() to run_default() v4 changes: - Implemented feedback from Ferruh [1] - rename map file to rte_pmd_eth_s

[dpdk-dev] [PATCH v5 0/5] net/softnic: sw fall-back pmd for traffic mgmt and others

2017-09-29 Thread Jasvinder Singh
The SoftNIC PMD is intended to provide SW fall-back options for specific ethdev APIs in a generic way to the NICs not supporting those features. Currently, the only implemented ethdev API is Traffic Management (TM), but other ethdev APIs such as rte_flow, traffic metering & policing, etc can be ea

Re: [dpdk-dev] [PATCH v6 5/8] net/i40e: finish integration FDIR with generic flow API

2017-09-29 Thread Wu, Jingjing
> + > + ret = i40e_fdir_filter_programming(pf, pctype, filter, add); > + if (ret < 0) { > + PMD_DRV_LOG(ERR, "fdir programming fails for PCTYPE(%u).", > + pctype); > + return ret; > + } > + The i40e_check_fdir_programming_status only repor

Re: [dpdk-dev] [PATCH v6 2/8] net/i40e: update ptype and pctype info

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 9:23 PM > To: Xing, Beilei > Cc: Chilikin, Andrey ; dev@dpdk.org > Subject: RE: [PATCH v6 2/8] net/i40e: update ptype and pctype info > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Frida

Re: [dpdk-dev] [PATCH v6 3/8] net/i40e: support RSS for new pctype

2017-09-29 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, September 29, 2017 1:19 PM > To: Wu, Jingjing > Cc: Chilikin, Andrey ; dev@dpdk.org > Subject: [PATCH v6 3/8] net/i40e: support RSS for new pctype > > Enable RSS for new pctypes after downloading > new profile. > > Signed-off-by

Re: [dpdk-dev] [PATCH v6 2/8] net/i40e: update ptype and pctype info

2017-09-29 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, September 29, 2017 1:19 PM > To: Wu, Jingjing > Cc: Chilikin, Andrey ; dev@dpdk.org > Subject: [PATCH v6 2/8] net/i40e: update ptype and pctype info > > Update new packet type and new pctype info when downloading > profile. > >

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 6:10 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C > and GTP-U > > On 29 Septem

[dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-09-29 Thread Michal Jastrzebski
Coverity reports check_after_deref: Null-checking rq suggests that it may be null, but it has already been dereferenced on all paths leading to the check. This patch removes NULL checking of "rq" from function vmxnet3_dev_rx_queue_reset as it is already checked against NULL one level up the callsta

[dpdk-dev] [PATCH] app/testpmd: fix runtime dead code

2017-09-29 Thread Michal Jastrzebski
From: Tomasz Kulasek Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD is defined and function compiles entirely. The fix is about to place printf function into #else branch of conditional compilation, since it is known at compile time if i40e is supported. No need to check it at ru

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-29 Thread Wu, Jingjing
Hi, Shijith Only removing the PCI reset in uio device open function is not enough. We faced an issue like: 1. Here is a FVL NIC, generate VF on one port, and then pass-through the VF by vfio-pci to VM: For example: echo 1 > /sys/bus/pci/devices/\:07\:00.1/sriov_numvfs modprobe vfio-pci echo

Re: [dpdk-dev] [PATCH v2 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-09-29 Thread Maxime Coquelin
On 09/29/2017 02:34 PM, Yuanhan Liu wrote: On Sun, Sep 24, 2017 at 06:19:19PM +0200, Maxime Coquelin wrote: static int -vhost_user_iotlb_msg(struct virtio_net *dev, struct VhostUserMsg *msg) +is_vring_iotlb_update(struct vhost_virtqueue *vq, struct vhost_iotlb_msg *imsg) { + struct v

[dpdk-dev] [PATCH] doc: Adds reference to use mlockall() in the Programmer's guide

2017-09-29 Thread Eelco Chaudron
When I was adding mlockall() to the testpmd application it was suggested to add a reference to the use case of mlockall(). Signed-off-by: Eelco Chaudron --- doc/guides/prog_guide/writing_efficient_code.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/guides/prog_guide/

Re: [dpdk-dev] [PATCH v2 19/19] vhost: enable IOMMU support

2017-09-29 Thread Yuanhan Liu
On Sun, Sep 24, 2017 at 06:19:21PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index fb48f3012..598c65b56 100644 >

Re: [dpdk-dev] [PATCH v2 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-09-29 Thread Yuanhan Liu
On Sun, Sep 24, 2017 at 06:19:19PM +0200, Maxime Coquelin wrote: > static int > -vhost_user_iotlb_msg(struct virtio_net *dev, struct VhostUserMsg *msg) > +is_vring_iotlb_update(struct vhost_virtqueue *vq, struct vhost_iotlb_msg > *imsg) > { > + struct vhost_vring_addr *ra; > + uint64_t s

[dpdk-dev] [PATCH v5 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-09-29 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add TM hierarchy nodes (leaf and nonleaf). - command for runtime update of node weight. - command to commit the TM hierarchy Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v5 change: - add s

[dpdk-dev] [PATCH v5 1/3] app/test-pmd: add CLI for TM capability and stats

2017-09-29 Thread Jasvinder Singh
Add following CLIs to testpmd application for device traffic management; - commands to display TM capability information. (per port, per hierarchy level and per hierarchy node) - command to display hiearchy node type - stats collection Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitresc

[dpdk-dev] [PATCH v5 2/3] app/test-pmd: add CLI for shaper and wred profiles

2017-09-29 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add/del shaper profile for TM hieraqrchy nodes. - commands to add/update shared shapers - commands to add/del WRED profiles for TM hiearchy leaf nodes. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitres

Re: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush

2017-09-29 Thread Wu, Jingjing
> + /* update the local VSI info with updated queue map */ > + (void)rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, > + sizeof(vsi->info.tc_mapping)); > + (void)rte_memcpy(&vsi->info.queue_mapping, > + &ctxt.info.queue_m

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Xing, Beilei > Sent: Friday, September 29, 2017 7:30 PM > To: Sean Harte > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C > and GTP-U > > > > > -Original Message- > >

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-29 Thread santosh
On Friday 29 September 2017 12:23 PM, Olivier MATZ wrote: > On Fri, Sep 29, 2017 at 11:16:20AM +0100, santosh wrote: >> Hi Olivier, >> >> >> On Friday 29 September 2017 09:32 AM, Olivier MATZ wrote: >>> On Mon, Sep 25, 2017 at 10:52:31PM +0100, santosh wrote: Hi Olivier, On Mon

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 6:10 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C > and GTP-U > > On 29 Sept

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-29 Thread Olivier MATZ
On Fri, Sep 29, 2017 at 11:16:20AM +0100, santosh wrote: > Hi Olivier, > > > On Friday 29 September 2017 09:32 AM, Olivier MATZ wrote: > > On Mon, Sep 25, 2017 at 10:52:31PM +0100, santosh wrote: > >> Hi Olivier, > >> > >> > >> On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: > >> >

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-29 Thread santosh
On Friday 29 September 2017 11:16 AM, santosh wrote: > Hi Olivier, > > > On Friday 29 September 2017 09:32 AM, Olivier MATZ wrote: >> On Mon, Sep 25, 2017 at 10:52:31PM +0100, santosh wrote: >>> Hi Olivier, >>> >>> >>> On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: >>> > +{ > +

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Yuanhan Liu
On Fri, Sep 29, 2017 at 11:09:23AM +0100, Burakov, Anatoly wrote: > On 29-Sep-17 2:24 AM, Yuanhan Liu wrote: > >On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: > +/** Path of primary/secondary communication unix socket file. */ > +#define PRIMARY_SECONDARY_UNIX_PATH_FMT "%s/.

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-29 Thread santosh
Hi Olivier, On Friday 29 September 2017 09:32 AM, Olivier MATZ wrote: > On Mon, Sep 25, 2017 at 10:52:31PM +0100, santosh wrote: >> Hi Olivier, >> >> >> On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: >> +{ + struct rte_eth_dev *dev; + const char *tmp; + + RT

Re: [dpdk-dev] [PATCH v7 0/2] net/i40e: API to configure queue regions for RSS

2017-09-29 Thread Peng, Yuan
Tested-by: Peng Yuan - Tested Branch: dpdk-next-net/master - Tested Commit: 9d660ac14ed6aa8688141b33fd6cd69fe3f0e5dd - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1572]

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Sean Harte
On 29 September 2017 at 10:33, Xing, Beilei wrote: > > >> -Original Message- >> From: Sean Harte [mailto:sea...@gmail.com] >> Sent: Friday, September 29, 2017 4:15 PM >> To: Xing, Beilei >> Cc: Wu, Jingjing ; Chilikin, Andrey >> ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6 6/8] net

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Burakov, Anatoly
On 29-Sep-17 2:24 AM, Yuanhan Liu wrote: On Thu, Sep 28, 2017 at 01:50:20PM +, Tan, Jianfeng wrote: +/** Path of primary/secondary communication unix socket file. */ +#define PRIMARY_SECONDARY_UNIX_PATH_FMT "%s/.%s_unix" +static inline const char * +eal_primary_secondary_unix_path(void) +{ +

Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication

2017-09-29 Thread Burakov, Anatoly
On 29-Sep-17 2:03 AM, Tan, Jianfeng wrote: + Reshma and Jan. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly Sent: Thursday, September 28, 2017 11:30 PM To: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/second

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 5:30 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support > flow API > > On 29 September

[dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-09-29 Thread Wei Zhao
This patch add a API configuration of queue region in rss. It can parse the parameters of region index, queue number, queue start index, user priority, traffic classes and so on. According to commands from command line, it will call i40e private API and start the process of set or flush queue regio

[dpdk-dev] [PATCH v7 0/2] net/i40e: API to configure queue regions for RSS

2017-09-29 Thread Wei Zhao
The patches mainly finish following functions: 1) Command line for input queue region configure parameters. 2) Set or flush queue region configutation. v2: -fix bug for packet into queue region code. -change code style for DPDK C programing. -change that "flowtype" name to " hw_flowtype " in stru

[dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush

2017-09-29 Thread Wei Zhao
This feature enable queue regions configuration for RSS in PF, so that different traffic classes or different packet classification types can be separated to different queues in different queue regions.This patch can set queue region range, it include queue number in a region and the index of first

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 4:15 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C > and GTP-U > > On 29 Sept

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-09-29 Thread Sean Harte
On 29 September 2017 at 09:54, Xing, Beilei wrote: > > >> -Original Message- >> From: Sean Harte [mailto:sea...@gmail.com] >> Sent: Friday, September 29, 2017 4:15 PM >> To: Xing, Beilei >> Cc: Wu, Jingjing ; Chilikin, Andrey >> ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v6 4/8] eth

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Sergio Gonzalez Monroy
On 29/09/2017 09:15, Eelco Chaudron wrote: On 29/09/17 10:07, Sergio Gonzalez Monroy wrote: On 12/09/2017 14:08, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk.

[dpdk-dev] [PATCH v6 4/4] test: flow classify library unit tests

2017-09-29 Thread Bernard Iremonger
Add flow_classify_autotest program. Set up IPv4 ACL field definitions. Create table_acl for use by librte_flow_classify API's. Create an mbuf pool for use by rte_flow_classify_query. For each of the librte_flow_classify API's: add bad parameter tests add bad pattern tests add bad action tests add

[dpdk-dev] [PATCH v6 3/4] test: add packet burst generator functions

2017-09-29 Thread Bernard Iremonger
add initialize_tcp_header function add initialize_stcp_header function add initialize_ipv4_header_proto function add generate_packet_burst_proto function Signed-off-by: Bernard Iremonger --- test/test/packet_burst_generator.c | 191 + test/test/packet_burst_ge

[dpdk-dev] [PATCH v6 2/4] examples/flow_classify: flow classify sample application

2017-09-29 Thread Bernard Iremonger
The flow_classify sample application exercises the following librte_flow_classify API's: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query It sets up the IPv4 ACL field definitions. It creates table_acl and adds and deletes rules using the librt

[dpdk-dev] [PATCH v6 1/4] librte_flow_classify: add librte_flow_classify library

2017-09-29 Thread Bernard Iremonger
From: Ferruh Yigit The following library APIs's are implemented: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query The following librte_table ACL API's are used: f_create to create a table ACL. f_add to add an ACL rule to the table. f_del to de

[dpdk-dev] [PATCH v6 0/4] flow classification library

2017-09-29 Thread Bernard Iremonger
DPDK works with packets, but some network administration tools works based on flow information. This library is suggested to provide a helper API to convert packet based information to the flow records. Basically the library consist of APIs to validate, create and destroy the rule and to query

Re: [dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support

2017-09-29 Thread Kavanagh, Mark B
Thanks for your comments Jiayu - please find responses inline. Thanks, Mark From: Hu, Jiayu >Sent: Friday, September 29, 2017 4:13 AM >To: Kavanagh, Mark B >Cc: dev@dpdk.org; Tan, Jianfeng ; Ananyev, Konstantin >; Yigit, Ferruh ; >tho...@monjalon.net >Subject: Re: [PATCH v5 2/6] gso: add TCP/IP

Re: [dpdk-dev] [PATCH v6] net/i40e: queue region set and flush

2017-09-29 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, September 29, 2017 4:12 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v6] net/i40e: queue region set and flush > > This feature enable queue regions configuration f

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 4:15 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support > flow API > > On 29 September

Re: [dpdk-dev] [PATCH v6 1/8] mbuf: support GTP in software packet type parser

2017-09-29 Thread Xing, Beilei
> -Original Message- > From: Sean Harte [mailto:sea...@gmail.com] > Sent: Friday, September 29, 2017 4:15 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 1/8] mbuf: support GTP in software > packet type parser > > On 29 Se

Re: [dpdk-dev] How to use ixgbe module log?

2017-09-29 Thread Burakov, Anatoly
On 29-Sep-17 2:42 AM, Sam wrote: My question is not clear. Actually ixgbevf driver in my system is kernel module, like this: [root@yf-mos-corp-host175 ~]# modinfo ixgbevf filename:  /lib/modules/3.10.0-514.10.2.el7.mt20170307.x86_64/kernel/drivers/net/ethernet/intel/ixgbevf/ixgbevf.ko v

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-29 Thread Olivier MATZ
On Mon, Sep 25, 2017 at 10:52:31PM +0100, santosh wrote: > Hi Olivier, > > > On Monday 25 September 2017 08:37 AM, Olivier MATZ wrote: > > Hi, > > > > On Mon, Sep 11, 2017 at 08:48:37PM +0530, Santosh Shukla wrote: > >> Now that dpdk supports more than one mempool drivers and > >> each mempool dr

Re: [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the secondary process

2017-09-29 Thread Yuanhan Liu
On Thu, Sep 28, 2017 at 01:55:59PM +, Jianfeng Tan wrote: > static int > +share_device(int vid) > +{ > + uint32_t i, vring_num; > + int len; > + int fds[8]; > + struct rte_vhost_memory *mem; > + struct vhost_params *params; > + struct rte_vhost_vring vring; > + > +

Re: [dpdk-dev] [PATCH v5 2/6] librte_table: fix acl lookup function

2017-09-29 Thread Iremonger, Bernard
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, September 20, 2017 1:24 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Yigit, Ferruh ; Ananyev, Konstantin > ; adrien.mazarg...@6wind.com > Cc: sta...@dpdk.org > Subject: RE: [PATCH v5 2/6] librte_table: fix a

Re: [dpdk-dev] [PATCH v5 1/3] net/i40e: queue region set and flush

2017-09-29 Thread Zhao1, Wei
Hi, jingjing All will be fix in v6 > -Original Message- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 12:55 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v5 1/3] net/i40e: queue region set and flush > > > +static int > > +i40e_vsi_updat

Re: [dpdk-dev] [PATCH v5 1/6] librte_table: fix acl entry add and delete functions

2017-09-29 Thread Iremonger, Bernard
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, September 20, 2017 1:21 PM > To: Singh, Jasvinder ; Iremonger, Bernard > ; dev@dpdk.org; Yigit, Ferruh > ; Ananyev, Konstantin > ; adrien.mazarg...@6wind.com > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subje

Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-29 Thread santosh
Hi Olivier, On Friday 29 September 2017 09:20 AM, Olivier MATZ wrote: > On Fri, Sep 29, 2017 at 05:53:43AM +0100, santosh wrote: >> Hi Olivier, >> >> >> On Monday 25 September 2017 11:18 PM, santosh wrote: >>> On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote: On Thu, Sep 07, 2017 at

Re: [dpdk-dev] DPDK Community Survey 2017

2017-09-29 Thread Jain, Deepak K
HI, As earlier agreed in DPDK Userspace, the closure date for this survey has been extended by a week. Survey will now close at midnight GMT on Sunday October 8th 2017. Gentle reminder in case you have not filled the survey. Many thanks, Deepak From: Jain, Deepak K Sent: Friday, September 2

[dpdk-dev] [PATCH v6] net/i40e: queue region set and flush

2017-09-29 Thread Wei Zhao
This feature enable queue regions configuration for RSS in PF, so that different traffic classes or different packet classification types can be separated to different queues in different queue regions.This patch can set queue region range, it include queue number in a region and the index of first

[dpdk-dev] [PATCH v6] app/testpmd: add API for configuration of queue region

2017-09-29 Thread Wei Zhao
This patch add a API configuration of queue region in rss. It can parse the parameters of region index, queue number, queue start index, user priority, traffic classes and so on. According to commands from command line, it will call i40e private API and start the process of set or flush queue regio

[dpdk-dev] [PATCH v6] net/i40e: API to configure queue regions for RSS

2017-09-29 Thread Wei Zhao
The patches mainly finish following functions: 1) Command line for input queue region configure parameters. 2) Set or flush queue region configutation. v2: -fix bug for packet into queue region code. -change code style for DPDK C programing. -change that "flowtype" name to " hw_flowtype " in stru

Re: [dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-29 Thread Olivier MATZ
On Fri, Sep 29, 2017 at 05:53:43AM +0100, santosh wrote: > Hi Olivier, > > > On Monday 25 September 2017 11:18 PM, santosh wrote: > > On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote: > >> On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote: > >>> + * Mempool handler usually ge

Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-29 Thread Sean Harte
On 29 September 2017 at 06:19, Beilei Xing wrote: > This patch adds FDIR support for GTP-C and GTP-U. The > input set of GTP-C and GTP-U is TEID. > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.h | 30 + > drivers/net/i40e/i40e_fdir.c | 200 ++--

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-09-29 Thread Sean Harte
On 29 September 2017 at 06:18, Beilei Xing wrote: > This patch adds GTP, GTPC and GTPU items for > generic flow API, and also exposes item fields > through the flow command. > > Signed-off-by: Beilei Xing > Acked-by: Adrien Mazarguil > --- > app/test-pmd/cmdline_flow.c | 40

Re: [dpdk-dev] [PATCH v6 1/8] mbuf: support GTP in software packet type parser

2017-09-29 Thread Sean Harte
On 29 September 2017 at 06:18, Beilei Xing wrote: > Add support of GTP-C and GTP-U tunnels in rte_net_get_ptype(). > > Signed-off-by: Beilei Xing > Acked-by: Olivier Matz > --- > lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ > lib/librte_mbuf/rte_mbuf_ptype.h | 24 > 2 file

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Eelco Chaudron
On 29/09/17 10:07, Sergio Gonzalez Monroy wrote: On 12/09/2017 14:08, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When using testpmd for performance testing,

[dpdk-dev] [PATCH v2] app/testpmd: adds mlockall() to avoid pages being swapped out

2017-09-29 Thread Eelco Chaudron
v2: * Moved mlockall() after rte_eal_init() to allow rte_log() to be used * Check for mlockall() return value, and add an rte_log() Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When u

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Sergio Gonzalez Monroy
On 12/09/2017 14:08, Eelco Chaudron wrote: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing the kernel from paging any of its memory to disk. When using testpmd for performance testing, depending on the code path taken, we see a couple

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-29 Thread Eelco Chaudron
On 25/09/17 09:53, Olivier MATZ wrote: [SNIP] I did not at add a log, as the rte log subsystem is not yet initialized. However we could add a printf("WARNING: mlockall() failed with error %s") like message. What do you think? Since it's not critical, maybe NOTICE is better than WARNING. One mor

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-29 Thread Basierski, SebastianX
-Original Message- From: Tan, Jianfeng Sent: Wednesday, September 20, 2017 2:56 AM To: Basierski, SebastianX ; skh...@vmware.com Cc: dev@dpdk.org Subject: RE: [PATCH] pmd_virtio: Unchecked return value from library Hi, Thank you for those fixes. > -Original Message- > From: Ba

Re: [dpdk-dev] [PATCH v6 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-29 Thread Xing, Beilei
Seems you didn't address my questions except the memory access error in your last version. > -Original Message- > From: Rybalchenko, Kirill > Sent: Thursday, September 28, 2017 9:33 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Sub

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability

2017-09-29 Thread Andrew Rybchenko
On 09/28/2017 07:48 PM, Raslan Darawsheh wrote: Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. I think it should be on top [1] and ideally follow a new offload API without addition of a new bit field which will be removed soon. Also, pleas

[dpdk-dev] [PATCH v6 4/5] test: increase port_id range

2017-09-29 Thread Zhiyong Yang
Increase port_id range from 8 bit to 16 bits in test code, and remove some unnecessary cast operations. Signed-off-by: Zhiyong Yang --- test/test/test_kni.c| 12 +-- test/test/test_link_bonding.c | 40 ++--- test/test/test_link_bondin

[dpdk-dev] [PATCH v6 5/5] librte_mbuf: modify port initialization value

2017-09-29 Thread Zhiyong Yang
In order to support more than 256 virtual ports, the field "port" in rte_mbuf has been increased to 16 bits. The initialization/reset value of the field "port" should be changed from 0xff to 0x accordingly. Signed-off-by: Zhiyong Yang --- lib/librte_mbuf/rte_mbuf.c | 2 +- lib/librte_mbuf/rt

[dpdk-dev] [PATCH v6 3/5] examples: increase port_id range

2017-09-29 Thread Zhiyong Yang
Modify port_id related code in examples accordingly since port_id definition in lib and pmd changes. Fix some original checkpatch issues and remove some unnecessary cast at the same time. Signed-off-by: Zhiyong Yang --- examples/bond/main.c | 16 +-- examples/dist

[dpdk-dev] [PATCH v6 0/5] increase port_id range

2017-09-29 Thread Zhiyong Yang
port_id is currently defined as uint8_t, which is limited to the range 0 to 255. A larger range is required for vdev scalability. It is necessary for a redefinition of port_id to extend it from 1 bytes to 2 bytes. All ethdev APIs and usages related to port_id will be changed at the same time. Dis

[dpdk-dev] [PATCH v6 1/5] net/bonding: remove bonding APIs using ABI versioning

2017-09-29 Thread Zhiyong Yang
There are two bonding APIs using ABI versioning, and both have port_id as parameter. Since we are already breaking ABI, no need to keep older versions of APIs. Signed-off-by: Zhiyong Yang Reviewed-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_8023ad.c| 149 +-

  1   2   >