Seems you didn't address my questions except the memory access error in your
last version.
> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Thursday, September 28, 2017 9:33 PM
> To: dev@dpdk.org
> Cc: Rybalchenko, Kirill <kirill.rybalche...@intel.com>; Chilikin, Andrey
> <andrey.chili...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Wu,
> Jingjing <jingjing...@intel.com>
> Subject: [PATCH v6 1/2] net/i40e: get information about protocols defined in
> ddp profile
>
> This patch adds new package info types to get list of protocols, pctypes and
> ptypes defined in a profile
>
> ---
> v3
> info_size parameter always represents size of the info buffer in bytes
>
> v6
> fix bug with wrong usage of info_size parameter
>
> Signed-off-by: Kirill Rybalchenko <kirill.rybalche...@intel.com>
> ---
> drivers/net/i40e/rte_pmd_i40e.c | 174
> ++++++++++++++++++++++++++++++++++++++++
> drivers/net/i40e/rte_pmd_i40e.h | 25 ++++++
> 2 files changed, 199 insertions(+)
>
> diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> b/drivers/net/i40e/rte_pmd_i40e.c index c08e07a..f57e59b 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.c
> +++ b/drivers/net/i40e/rte_pmd_i40e.c
> @@ -1706,6 +1706,26 @@ rte_pmd_i40e_process_ddp_package(uint8_t
> port, uint8_t *buff,
> return status;
> }
>
> +/* Get number of tvl records in the section */ static unsigned int
> +i40e_get_tlv_section_size(struct i40e_profile_section_header *sec) {
> + unsigned int i, nb_rec, nb_tlv = 0;
> + struct i40e_profile_tlv_section_record *tlv;
> +
> + if (!sec)
> + return nb_tlv;
> +
> + /* get number of records in the section */
> + nb_rec = sec->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + for (i = 0; i < nb_rec; ) {
> + tlv = (struct i40e_profile_tlv_section_record *)&sec[1 + i];
> + i += tlv->len;
> + nb_tlv++;
> + }
> + return nb_tlv;
> +}
> +
> int rte_pmd_i40e_get_ddp_info(uint8_t *pkg_buff, uint32_t pkg_size,
> uint8_t *info_buff, uint32_t info_size,
> enum rte_pmd_i40e_package_info type)
> @@ -1860,6 +1880,160 @@ int rte_pmd_i40e_get_ddp_info(uint8_t
> *pkg_buff, uint32_t pkg_size,
> return I40E_SUCCESS;
> }
>
> + /* get number of protocols */
> + if (type == RTE_PMD_I40E_PKG_INFO_PROTOCOL_NUM) {
> + struct i40e_profile_section_header *proto;
> +
> + if (info_size < sizeof(uint32_t)) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + proto = i40e_find_section_in_profile(SECTION_TYPE_PROTO,
> + (struct
> i40e_profile_segment *)
> + i40e_seg_hdr);
> + *(uint32_t *)info_buff = i40e_get_tlv_section_size(proto);
> + return I40E_SUCCESS;
> + }
> +
> + /* get list of protocols */
> + if (type == RTE_PMD_I40E_PKG_INFO_PROTOCOL_LIST) {
> + uint32_t i, j, nb_rec, nb_rec_buf;
> + struct rte_pmd_i40e_proto_info *pinfo;
> + struct i40e_profile_section_header *proto;
> + struct i40e_profile_tlv_section_record *tlv;
> +
> + proto = i40e_find_section_in_profile(SECTION_TYPE_PROTO,
> + (struct
> i40e_profile_segment *)
> + i40e_seg_hdr);
> + nb_rec = i40e_get_tlv_section_size(proto);
If number of records is different with number of TLV, I think it's better to
change nb_rec with nb_tlv, a little confused here.
> + nb_rec_buf = info_size / sizeof(struct
> rte_pmd_i40e_proto_info);
How about changing nb_rec_buf with nb_proto_info?
> + if (nb_rec_buf < nb_rec) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pinfo = (struct rte_pmd_i40e_proto_info *)info_buff;
> + for (i = 0; i < nb_rec_buf; i++) {
> + pinfo[i].proto_id = RTE_PMD_I40E_PROTO_UNUSED;
> + memset(pinfo[i].name, 0,
> RTE_PMD_I40E_DDP_NAME_SIZE);
> + }
> + if (nb_rec == 0)
> + return I40E_SUCCESS;
Why not check nb_rec just when getting the value?
<...>
Same comments for RTE_PMD_I40E_PKG_INFO_PCTYPE_LIST and
RTE_PMD_I40E_PKG_INFO_PTYPE_LIST.
