Re: [dpdk-dev] [PATCH v5 03/20] rte_device: make driver pointer const

2016-12-23 Thread Stephen Hemminger
On Fri, 23 Dec 2016 16:57:54 +0100 Jan Blunck wrote: > From: Stephen Hemminger > > The info in rte_device about driver is immutable and > shouldn't change. > > Acked-by: Jan Blunck > Acked-by: Shreyansh Jain > --- > lib/librte_eal/common/include/rte_dev.h | 2 +- > 1 file changed, 1 inserti

Re: [dpdk-dev] [PATCH v5 05/20] e1000: localize mapping from eth_dev to pci

2016-12-23 Thread Stephen Hemminger
On Fri, 23 Dec 2016 16:57:56 +0100 Jan Blunck wrote: > From: Stephen Hemminger > > Create one macro for where PCI device information is extracted > from ethernet device. Makes later changes easier to review, and test. > > Acked-by: Jan Blunck Go ahead and add missing signed-off-by. I overloo

[dpdk-dev] [PATCH] examples/ip_pipeline: fix coremask limitation

2016-12-23 Thread Sankar Chokkalingam
Issue: coremask used in IP Pipeline is limited to 64 cores. Solution: Modified coremask as an array of uint64_t to support RTE_MAX_LCORE Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax") Fixes: eb32fe7c5574 ("examples/ip_pipeline: rework initialization parameters") Fixes: b4

[dpdk-dev] [PATCH v2 2/2] ethdev: clarify xstats Api documentation

2016-12-23 Thread Olivier Matz
Reword the Api documentation of xstats ethdev. CC: sta...@dpdk.org Signed-off-by: Olivier Matz --- v1-> v2: - replace "@see rte_eth_xstats_get_names" by "see rte_eth_xstats_get_names()" as suggested by John lib/librte_ether/rte_ethdev.h | 45 --- 1 fil

Re: [dpdk-dev] [PATCH 20/25] net/qede: add PCI ids for new chip variant

2016-12-23 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:39 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > Add PCI IDs for new asic type (defined as CHIP_NUM_AH_xxx). > > It supports 50G, 40G, 25G and 10G speeds. > > > > Signed-off-by: Rasesh Mody > > --- > >

Re: [dpdk-dev] [PATCH 01/25] net/qede/base: add request for PF FLR before load request

2016-12-23 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:33 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > Add a request for PF FLR before a load request > > What does FLR stands for? Function Level Reset or FLR > > > > Fix the location of the PF FLR initia

Re: [dpdk-dev] [PATCH v14 1/8] ethdev: add Tx preparation

2016-12-23 Thread Kulasek, TomaszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, December 22, 2016 15:25 > To: Kulasek, TomaszX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v14 1/8] ethdev: add Tx preparation > > Hi Tomasz, > > 2016-12-22 14:05, Tomasz

[dpdk-dev] [PATCH v15 8/8] testpmd: use Tx preparation in csum engine

2016-12-23 Thread Tomasz Kulasek
Since all current drivers supports Tx preparation API, it is used in csum forwarding engine by default for all drivers. Adding additional step to the csum engine costs about 3-4% of performance drop, on my setup with ixgbe driver. It's caused mostly by the need of reaccessing and modification of p

[dpdk-dev] [PATCH v15 6/8] vmxnet3: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
From: "Ananyev, Konstantin" Signed-off-by: Konstantin Ananyev Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c |6 drivers/net/vmxnet3/vmxnet3_ethdev.h |2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 56 ++ 3 files changed, 64 insertions

[dpdk-dev] [PATCH v15 7/8] ena: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
From: Konstantin Ananyev Signed-off-by: Konstantin Ananyev --- drivers/net/ena/ena_ethdev.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 555fb31..51af723 100644 --- a/drivers/n

Re: [dpdk-dev] [PATCH v5 19/20] ethdev: Move dev_info filling of PCI information into drivers

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:58, Jan Blunck: > --- a/drivers/net/thunderx/nicvf_ethdev.c > +++ b/drivers/net/thunderx/nicvf_ethdev.c > @@ -1338,6 +1338,8 @@ nicvf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > > PMD_INIT_FUNC_TRACE(); > > + dev_info->pci_dev = pci_

[dpdk-dev] [PATCH v15 5/8] ixgbe: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c |3 ++ drivers/net/ixgbe/ixgbe_ethdev.h |5 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 57 ++ drivers/net/ixgbe/ixgbe_rxtx.h |2 ++ 4 files changed, 66

[dpdk-dev] [PATCH v15 4/8] i40e: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c |3 ++ drivers/net/i40e/i40e_rxtx.c | 74 +++- drivers/net/i40e/i40e_rxtx.h |8 + 3 files changed, 84 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH v15 2/8] e1000: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/e1000/e1000_ethdev.h | 11 drivers/net/e1000/em_ethdev.c|5 +++- drivers/net/e1000/em_rxtx.c | 48 +- drivers/net/e1000/igb_ethdev.c |4 +++ drivers/net/e100

[dpdk-dev] [PATCH v15 3/8] fm10k: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek Acked-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k.h|6 + drivers/net/fm10k/fm10k_ethdev.c |5 drivers/net/fm10k/fm10k_rxtx.c | 50 +- 3 files changed, 60 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v15 1/8] ethdev: add Tx preparation

2016-12-23 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prepare` uint16_t rte_eth_tx_prepare(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */

[dpdk-dev] [PATCH v15 0/8] add Tx preparation

2016-12-23 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO

Re: [dpdk-dev] [PATCH v5 15/20] szedata2: localize handling of pci resources

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:58, Jan Blunck: > #define SZEDATA2_PCI_RESOURCE_PTR(dev, offset, type) \ > - ((type)((uint8_t *) \ > - ((dev)->pci_dev->mem_resource[PCI_RESOURCE_NUMBER].addr) \ > - + (offset))) > + ((type)((uint8_t *)(rsc)->addr) + (offset))) There is this error: use of und

Re: [dpdk-dev] [PATCH] nfp: add support for rx interrupts

2016-12-23 Thread Ferruh Yigit
On 12/19/2016 6:05 PM, Alejandro Lucero wrote: > This is supported with UIO and VFIO modules. With UIO, LSC interrupt > is disabled. > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] nfp: avoid modulo operations for handling ring wrapping

2016-12-23 Thread Ferruh Yigit
On 12/19/2016 4:13 PM, Alejandro Lucero wrote: > Having those modulo operations implies costly instructions execution, > what can be avoided with conditionals and unlikely clauses. > > This change makes the software ring read and write indexes to be now > always within the ring size which has to b

Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Jan Blunck
On Fri, Dec 23, 2016 at 5:17 PM, Thomas Monjalon wrote: > 2016-12-23 16:58, Jan Blunck: >> +/** >> + * @internal >> + * Helper macro for drivers that need to convert to struct rte_pci_device. >> + */ >> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, >> device) > > Do you p

Re: [dpdk-dev] [PATCH v5 05/20] e1000: localize mapping from eth_dev to pci

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:57, Jan Blunck: > From: Stephen Hemminger > > Create one macro for where PCI device information is extracted > from ethernet device. Makes later changes easier to review, and test. > > Acked-by: Jan Blunck Missing Signed-off-by: line

Re: [dpdk-dev] [PATCH v5 03/20] rte_device: make driver pointer const

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:57, Jan Blunck: > From: Stephen Hemminger > > The info in rte_device about driver is immutable and > shouldn't change. > > Acked-by: Jan Blunck > Acked-by: Shreyansh Jain There's no Signed-off-by

Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:58, Jan Blunck: > +/** > + * @internal > + * Helper macro for drivers that need to convert to struct rte_pci_device. > + */ > +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device) Do you prefer to rename to RTE_DEV_TO_PCI? > + struct rte_device *device

[dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Jan Blunck
This makes struct rte_eth_dev independent of struct rte_pci_device by replacing it with a pointer to the generic struct rte_device. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- app/test/virtual_pmd.c | 4 ++-- drivers/net/bnx2x/bnx2x_ethdev.c| 4 ++-- driver

[dpdk-dev] [PATCH v5 19/20] ethdev: Move dev_info filling of PCI information into drivers

2016-12-23 Thread Jan Blunck
Only the drivers itself can decide if it could fill PCI information fields of dev_info. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- drivers/net/bnx2x/bnx2x_ethdev.c| 1 + drivers/net/bnxt/bnxt_ethdev.c | 2 ++ drivers/net/cxgbe/cxgbe_ethdev.c| 2 ++ drivers/n

[dpdk-dev] [PATCH v5 18/20] ethdev: Decouple interrupt handling from PCI device

2016-12-23 Thread Jan Blunck
The struct rte_intr_handle is an abstraction layer for different types of interrupt mechanisms. It is embedded in the low-level device (e.g. PCI). On allocation of a struct rte_eth_dev a reference to the intr_handle should be stored for devices supporting interrupts. Signed-off-by: Jan Blunck Ack

[dpdk-dev] [PATCH v5 17/20] vmxnet3: use eth_dev->data->drv_name instead of pci_drv name

2016-12-23 Thread Jan Blunck
Signed-off-by: Jan Blunck --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 93c9ac9..9c8b65f 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/driver

[dpdk-dev] [PATCH v5 16/20] nfp: localize rte_pci_device handling

2016-12-23 Thread Jan Blunck
This simplifies later changes to ethdev. Signed-off-by: Jan Blunck --- drivers/net/nfp/nfp_net.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index e315dd8..c9b3ef9 100644 --- a/drivers/net/nfp/nfp_net

[dpdk-dev] [PATCH v5 14/20] qede: localize mapping of eth_dev to pci

2016-12-23 Thread Jan Blunck
This simplifies later changes to ethdev. Signed-off-by: Jan Blunck Acked-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 001166a..aefc

[dpdk-dev] [PATCH v5 15/20] szedata2: localize handling of pci resources

2016-12-23 Thread Jan Blunck
This changes the driver to handle the PCI resource directly instead of repeatedly going through eth_dev. Signed-off-by: Jan Blunck --- drivers/net/szedata2/rte_eth_szedata2.c | 72 - drivers/net/szedata2/rte_eth_szedata2.h | 58 +++--- 2 files

[dpdk-dev] [PATCH v5 13/20] fm10k: localize mapping from eth_dev to pci

2016-12-23 Thread Jan Blunck
This simplifies later changes to ethdev. Signed-off-by: Jan Blunck --- drivers/net/fm10k/fm10k_ethdev.c | 77 ++-- 1 file changed, 43 insertions(+), 34 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index fe74f6d

[dpdk-dev] [PATCH v5 12/20] bnx2x: localize mapping from eth_dev to pci

2016-12-23 Thread Jan Blunck
Use device private information to minimize the places that assume eth_dev contains pci_dev. Signed-off-by: Jan Blunck Acked-by: Harish Patil --- drivers/net/bnx2x/bnx2x_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/d

[dpdk-dev] [PATCH v5 11/20] virtio: Don't depend on struct rte_eth_dev's pci_dev

2016-12-23 Thread Jan Blunck
We don't need to depend on rte_eth_dev->pci_dev to differentiate between the virtio_user and the virtio_pci case. Instead we can use the private virtio_hw struct to get that information. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- drivers/net/virtio/virtio_ethdev.c | 24 -

[dpdk-dev] [PATCH v5 10/20] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle

2016-12-23 Thread Jan Blunck
This adds a helper to get the rte_intr_handle from the virtio_hw. This is safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC which is only set if we found a PCI device during initialization. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- drivers/net/virtio/virti

[dpdk-dev] [PATCH v5 09/20] virtio: Don't fill dev_info->driver_name

2016-12-23 Thread Jan Blunck
This is overwritten in rte_eth_dev_info_get(). Signed-off-by: Jan Blunck Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 1bd60e9..5c8afb5 1006

[dpdk-dev] [PATCH v5 08/20] broadcom: localize mapping from eth_dev to pci

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger Use existing information about pci and interrupt handle to minimize the number of places that assume eth_dev contains pci_device information. Signed-off-by: Stephen Hemminger Acked-by: Jan Blunck --- drivers/net/bnxt/bnxt_ethdev.c | 22 +- drivers/n

[dpdk-dev] [PATCH v5 07/20] i40e: localize mapping of eth_dev to pci

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger Simplify later changes to eth_dev. Signed-off-by: Stephen Hemminger Acked-by: Jan Blunck --- drivers/net/i40e/i40e_ethdev.c| 77 --- drivers/net/i40e/i40e_ethdev.h| 3 ++ drivers/net/i40e/i40e_ethdev_vf.c | 58 ++

[dpdk-dev] [PATCH v5 06/20] ixgbe: localize mapping from eth_dev to pci_device

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger Since later changes will change where PCI information is, localize mapping in one macro. Signed-off-by: Stephen Hemminger Acked-by: Jan Blunck --- drivers/net/ixgbe/ixgbe_ethdev.c | 120 ++- drivers/net/ixgbe/ixgbe_ethdev.h | 3 +

[dpdk-dev] [PATCH v5 05/20] e1000: localize mapping from eth_dev to pci

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger Create one macro for where PCI device information is extracted from ethernet device. Makes later changes easier to review, and test. Acked-by: Jan Blunck --- drivers/net/e1000/e1000_ethdev.h | 2 + drivers/net/e1000/em_ethdev.c| 50 +++- drivers/net

[dpdk-dev] [PATCH v5 04/20] pmd: remove useless reset of dev_info->dev_pci

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger Since rte_eth_dev_info_get does memset() on dev_info before calling device specific code, the explicit assignment of NULL in all these virtual drivers has no effect. Signed-off-by: Stephen Hemminger Acked-by: Jan Blunck --- app/test/virtual_pmd.c| 1

[dpdk-dev] [PATCH v5 03/20] rte_device: make driver pointer const

2016-12-23 Thread Jan Blunck
From: Stephen Hemminger The info in rte_device about driver is immutable and shouldn't change. Acked-by: Jan Blunck Acked-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_dev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_dev.h

[dpdk-dev] [PATCH v5 00/20] Decouple ethdev from PCI device

2016-12-23 Thread Jan Blunck
This repost addresses the review comments of Thomas Monjalon to completely remove the ethdev helper to further decrease the coupling of the ethdev and the eal layers. This required me to squash together all patches using the rte_eth_dev_to_pci() helper into "Decouple from PCI device" patch. As disc

[dpdk-dev] [PATCH v5 02/20] eal: Allow passing const rte_intr_handle

2016-12-23 Thread Jan Blunck
Both register/unregister and enable/disable don't necessarily require the rte_intr_handle to be modifiable. Therefore lets constify it. Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/eal_interrupts.c | 24 ++ lib/librte_eal/common/include/rte_interrupts.h | 8 ++-- lib/libr

Re: [dpdk-dev] [PATCH] app/testpmd: fix flow command compilation errors

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:52, Adrien Mazarguil: > A missing include causes the following compilation errors: > > error: use of undeclared identifier 'AF_INET' > error: use of undeclared identifier 'AF_INET6' > > Fixes: ef6e38550f07 ("app/testpmd: add items ipv4/ipv6 to flow command") > > Signed-off-by: Ad

[dpdk-dev] [PATCH v5 01/20] eal: define container_of macro

2016-12-23 Thread Jan Blunck
This macro is based on Jan Viktorin's original patch but also checks the type of the passed pointer against the type of the member. Signed-off-by: Jan Viktorin Signed-off-by: Shreyansh Jain [jblu...@infradead.org: add type checking and __extension__] Signed-off-by: Jan Blunck --- lib/librte_ea

[dpdk-dev] [PATCH] app/testpmd: fix flow command compilation errors

2016-12-23 Thread Adrien Mazarguil
A missing include causes the following compilation errors: error: use of undeclared identifier 'AF_INET' error: use of undeclared identifier 'AF_INET6' Fixes: ef6e38550f07 ("app/testpmd: add items ipv4/ipv6 to flow command") Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 1

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > This patch consists of semantic/formatting changes. It also includes > comment additions. As far as I can see majority of the changes are formatting, but not all. Functional changes are hard to detect in this patch, what do you think separating formattin

Re: [dpdk-dev] [PATCH 22/25] net/qede/base: add support for new firmware

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > Add support for 8.14.x.x firmware. Is it possible to list what has been changed with new FW here? > > Signed-off-by: Rasesh Mody > --- <...>

Re: [dpdk-dev] [PATCH 20/25] net/qede: add PCI ids for new chip variant

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > Add PCI IDs for new asic type (defined as CHIP_NUM_AH_xxx). > It supports 50G, 40G, 25G and 10G speeds. > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/base/ecore_dev.c | 7 +- > drivers/net/qede/qede_ethdev.c| 29 ++

Re: [dpdk-dev] [PATCH 08/25] net/qede/base: fix updating VF queue zone id

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > Pass the absolute qzone_id when creating queues. > > Fixes: 5cdd769a ("qede: add L2 support") If there will a new version of the patch, please fix Fixes format, but if no new version will be send I can fix them. > > Signed-off-by: Rasesh Mody Again,

Re: [dpdk-dev] [PATCH 01/25] net/qede/base: add request for PF FLR before load request

2016-12-23 Thread Ferruh Yigit
On 12/3/2016 9:11 AM, Rasesh Mody wrote: > Add a request for PF FLR before a load request What does FLR stands for? > > Fix the location of the PF FLR initiation to be after ecore_get_hw_info() > (which invokes ecore_hw_info_port_num()) > > Signed-off-by: Rasesh Mody > --- <...>

Re: [dpdk-dev] [PATCH v2 1/8] net/qede: fix to get vendor/device id info

2016-12-23 Thread Ferruh Yigit
On 12/23/2016 12:49 AM, Rasesh Mody wrote: > The vendor_id and device_id are used to determine device type. If you > don't have them, then check for determining device type fails and is > always set to default device type. > > Fixes: ec94dbc57362 ("qede: add base driver") > > Signed-off-by: Rases

Re: [dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs

2016-12-23 Thread Ferruh Yigit
On 12/23/2016 12:48 AM, Harish Patil wrote: > Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. > > Signed-off-by: Harish Patil Series applied to dpdk-next-net/master, thanks. Removed PMD_DRV_LOG in first patch.

Re: [dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs

2016-12-23 Thread Ferruh Yigit
On 12/23/2016 12:48 AM, Harish Patil wrote: > Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. > > Signed-off-by: Harish Patil > --- <...> > > -#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER > -#define PMD_DRV_LOG_RAW(level, fmt, args...) \ > - RTE_LOG(level, PMD, "%s(): " fmt, __func__,

Re: [dpdk-dev] [PATCH v4 00/23] Decouple ethdev from PCI device

2016-12-23 Thread Thomas Monjalon
2016-12-22 16:26, Thomas Monjalon: > I think it would easier to read if RTE_PCI_DEV macro was introduced at > the beginning with container_of macro and used in the "localize patches". > So the patches > [PATCH v4 19/23] drivers: Replace per-PMD macros with > rte_eth_dev_to_pci() helper > and

Re: [dpdk-dev] [PATCH] doc: update release notes for rte_flow

2016-12-23 Thread Thomas Monjalon
2016-12-23 15:00, Adrien Mazarguil: > Cc: John McNamara > Cc: Thomas Monjalon > Signed-off-by: Adrien Mazarguil Applied, thanks

[dpdk-dev] [PATCH] doc: update release notes for rte_flow

2016-12-23 Thread Adrien Mazarguil
Cc: John McNamara Cc: Thomas Monjalon Signed-off-by: Adrien Mazarguil --- doc/guides/rel_notes/release_17_02.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst index 23f335a..b4101d0 100644 --

Re: [dpdk-dev] [PATCH v3 2/4] net/mlx5: add software support for rte_flow

2016-12-23 Thread Adrien Mazarguil
On Fri, Dec 23, 2016 at 12:19:30PM +, Ferruh Yigit wrote: > On 12/21/2016 3:19 PM, Nelio Laranjeiro wrote: > > Introduce initial software validation for rte_flow rules. > > > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx5.h | 2 + > > drivers/net/mlx5/mlx5_flow

Re: [dpdk-dev] [PATCH v3 2/2] app/test: add SGL tests to cryptodev QAT suite

2016-12-23 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, December 23, 2016 12:51 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH v3 2/2] app/test: add SGL tests to cryptodev QAT suite

Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: add SGL capability to Intel QuickAssist driver

2016-12-23 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, December 23, 2016 12:51 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH v3 1/2] crypto/qat: add SGL capability to Intel QuickAs

Re: [dpdk-dev] [PATCH 0/4] enhancement to i40e PF host driver

2016-12-23 Thread Vincent JARDIN
Thanks for this update. Still, I would like to get good arguments why DPDK should be a PF because it creates fragmentations. Please, first, let's reply to: http://dpdk.org/ml/archives/dev/2016-December/053107.html Having both Linux and DPDK being PF, it means that we double the combinations

[dpdk-dev] [PATCH v3 0/2] Add scatter-gather list capability to Intel(R) QuickAssist Technology driver

2016-12-23 Thread Arek Kusztal
This patchset adds scatter-gather list (SGL) capability to Intel(R) QuickAssist Technology driver and corresponding tests to QAT cryptodev test suite. v2: - removed _priv member from rte_crypto_op - added cookie pool to qat_qp for sgl array entries v3: - fixed sgl data len computation error - re

[dpdk-dev] [PATCH v3 1/2] crypto/qat: add SGL capability to Intel QuickAssist driver

2016-12-23 Thread Arek Kusztal
This commit adds scatter-gather list capability to Intel QuickAssist Technology driver. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 - doc/guides/rel_notes/release_17_02.rst | 2 + drivers/crypto/qat/qat_adf/qat_algs.h | 15 - drivers/crypto/qat/qat_crypt

[dpdk-dev] [PATCH v3 2/2] app/test: add SGL tests to cryptodev QAT suite

2016-12-23 Thread Arek Kusztal
This commit adds GCM tests to use within scatter-gather list. Test use direct chained mbufs created based on the input parameter for max size for in place operations and out of place operations. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev.c | 356 + app/t

Re: [dpdk-dev] [PATCH v2 5/5] ethtool: dispaly bus info and firmware version

2016-12-23 Thread Ferruh Yigit
On 12/6/2016 7:16 AM, Qiming Yang wrote: > This patch enhances the ethtool example to support to show > bus information and firmware version, in the same way that > the Linux kernel ethtool does. > > Signed-off-by: Qiming Yang > --- > v2 changes: > * modified the commit log > --- > --- > exampl

Re: [dpdk-dev] [PATCH v2 0/5] example/ethtool: add bus info and fw version get

2016-12-23 Thread Ferruh Yigit
On 12/22/2016 3:31 PM, Thomas Monjalon wrote: > 2016-12-22 15:05, Ferruh Yigit: >> On 12/22/2016 2:47 PM, Thomas Monjalon wrote: >>> 2016-12-22 14:36, Ferruh Yigit: On 12/22/2016 11:07 AM, Thomas Monjalon wrote: > I think it is OK to add a new dev_ops and a new API function for firmware >>

Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

2016-12-23 Thread Thomas Monjalon
2016-12-23 11:27, Jan Blunck: > On Fri, Dec 23, 2016 at 9:30 AM, Thomas Monjalon > wrote: > > 2016-12-22 19:13, Jan Blunck: > >> On Thu, Dec 22, 2016 at 4:21 PM, Thomas Monjalon > >> wrote: > >> > 2016-12-21 16:09, Jan Blunck: > >> >> PCI drivers could use this helper instead of directly accessin

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: add rte_flow rule creation

2016-12-23 Thread Ferruh Yigit
On 12/21/2016 3:19 PM, Nelio Laranjeiro wrote: > Convert Ethernet, IPv4, IPv6, TCP, UDP layers into ibv_flow and create > those rules when after validation (i.e. NIC supports the rule). > > VLAN is still not supported in this commit. > > Signed-off-by: Nelio Laranjeiro <...> > +static struct r

Re: [dpdk-dev] [PATCH v3 2/4] net/mlx5: add software support for rte_flow

2016-12-23 Thread Ferruh Yigit
On 12/21/2016 3:19 PM, Nelio Laranjeiro wrote: > Introduce initial software validation for rte_flow rules. > > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_flow.c| 202 > ++-- > drivers/net/mlx5/

Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-23 Thread Shreyansh Jain
On Friday 23 December 2016 04:57 PM, Jan Blunck wrote: On Fri, Dec 23, 2016 at 12:11 PM, Shreyansh Jain wrote: On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain wrote: On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: On

Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-23 Thread Jan Blunck
On Fri, Dec 23, 2016 at 12:11 PM, Shreyansh Jain wrote: > On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: >> >> On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain >> wrote: >>> >>> On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: On Wed, 21 Dec 2016 16:09:44 +010

[dpdk-dev] examples/vhost: how to use vhost-switch between VMs?

2016-12-23 Thread wang . yong19
Dear Mr. Liu, There are some descriptions in dpdk-16.11\doc\guides\sample_app_ug\vhost.rst, "The sample application performs simple packet switching between virtual machines based on Media Access Control (MAC) address or Virtual Local Area Network (VLAN) tag." So, we runned the vhost-switch s

Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-23 Thread Shreyansh Jain
On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain wrote: On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: On Wed, 21 Dec 2016 16:09:44 +0100 Jan Blunck wrote: Only the device itself can decide its PCI or not. Signed-off-b

Re: [dpdk-dev] [PATCH v4 10/23] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle

2016-12-23 Thread Jan Blunck
On Wed, Dec 21, 2016 at 9:08 PM, Stephen Hemminger wrote: > On Wed, 21 Dec 2016 16:09:33 +0100 > Jan Blunck wrote: > >> This adds a helper to get the rte_intr_handle from the virtio_hw. This is >> safe to do since the usage of the helper is guarded by RTE_ETH_DEV_INTR_LSC >> which is only set if

Re: [dpdk-dev] [PATCH v2 3/3] crypto/qat: fix iv size in PMD capabilities

2016-12-23 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, December 23, 2016 8:25 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Doherty, Declan > ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 3/3] crypto/qat: fix iv size in P

Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()

2016-12-23 Thread Jan Blunck
On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain wrote: > On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: >> >> On Wed, 21 Dec 2016 16:09:44 +0100 >> Jan Blunck wrote: >> >>> Only the device itself can decide its PCI or not. >>> >>> Signed-off-by: Jan Blunck >>> Acked-by: Shreyans

Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

2016-12-23 Thread Jan Blunck
On Fri, Dec 23, 2016 at 9:30 AM, Thomas Monjalon wrote: > 2016-12-22 19:13, Jan Blunck: >> On Thu, Dec 22, 2016 at 4:21 PM, Thomas Monjalon >> wrote: >> > 2016-12-21 16:09, Jan Blunck: >> >> PCI drivers could use this helper instead of directly accessing fields of >> >> rte_eth_dev to map to rte_

Re: [dpdk-dev] [PATCH 1/3] ethdev: New API to free consumed buffers in TX ring

2016-12-23 Thread Adrien Mazarguil
Hi Billy, On Tue, Dec 20, 2016 at 09:15:50AM -0500, Billy McFall wrote: > Thank you for your responses, see inline. > > On Tue, Dec 20, 2016 at 7:58 AM, Adrien Mazarguil > wrote: > > On Tue, Dec 20, 2016 at 12:17:10PM +, Ananyev, Konstantin wrote: > >> > >> > >> > -Original Message-

[dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities query

2016-12-23 Thread Qiming Yang
Add two new commands "show port cap " and "show port cap all"to diaplay what offload capabilities supported in ports. It will not only display all the capabilities of the port, but also the enabling condition for each capability in the running time. Signed-off-by: Qiming Yang --- v2 changes: * fi

Re: [dpdk-dev] [PATCH] acl: remove invalid test

2016-12-23 Thread Ananyev, Konstantin
> -Original Message- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Friday, December 23, 2016 1:48 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [PATCH] acl: remove invalid test > > On Mon, Dec 19, 2016 at 06:48:52PM +, Ananyev, Konstantin wrote: >

Re: [dpdk-dev] [PATCH v5 00/26] Generic flow API (rte_flow)

2016-12-23 Thread Thomas Monjalon
> Adrien Mazarguil (26): > ethdev: introduce generic flow API > doc: add rte_flow prog guide > doc: announce deprecation of legacy filter types > cmdline: add support for dynamic tokens > cmdline: add alignment constraint > app/testpmd: implement basic support for rte_flow > app/testp

Re: [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter

2016-12-23 Thread Adrien Mazarguil
Hi all, On Wed, Dec 21, 2016 at 03:54:50AM +, Xing, Beilei wrote: > Hi Ferruh, > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Wednesday, December 21, 2016 2:12 AM > > To: Xing, Beilei ; Wu, Jingjing > > ; Zhang, Helin > > Cc: dev@dpdk.org; Lu, Wenzhuo ; Adrien Mazarguil >

Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

2016-12-23 Thread Thomas Monjalon
2016-12-22 19:13, Jan Blunck: > On Thu, Dec 22, 2016 at 4:21 PM, Thomas Monjalon > wrote: > > 2016-12-21 16:09, Jan Blunck: > >> PCI drivers could use this helper instead of directly accessing fields of > >> rte_eth_dev to map to rte_pci_device. > > [...] > >> +/** > >> + * @internal > >> + * Help

[dpdk-dev] [PATCH v2 3/3] crypto/qat: fix iv size in PMD capabilities

2016-12-23 Thread Arek Kusztal
This patch sets iv size in qat PMD to 12 bytes to be conformant with nist SP800-38D. Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cryp

[dpdk-dev] [PATCH v2 2/3] crypto/aesni_gcm: fix iv size in PMD capabilities

2016-12-23 Thread Arek Kusztal
This patch sets iv size in aesni gcm PMD to 12 bytes to be conformant with nist SP800-38D. Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations") Signed-off-by: Arek Kusztal --- drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[dpdk-dev] [PATCH v2 0/3] Fix iv sizes in crypto drivers capabilities

2016-12-23 Thread Arek Kusztal
This patchset fixes iv (initialization vector) size values in qat and aesni gcm pmds to be conformant with nist SP800-38D. v2: - added missing signed-off-by line Arek Kusztal (3): crypto/aesni_gcm: fix J0 padding bytes for GCM crypto/aesni_gcm: fix iv size in PMD capabilities crypto/qat: fi

[dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM

2016-12-23 Thread Arek Kusztal
This commit fixes pre-counter block (J0) padding by clearing four most significant bytes before setting initial counter value. Fixes: b2bb3597470c ("crypto/aesni_gcm: move pre-counter block to driver") Signed-off-by: Arek Kusztal --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +++- 1 file cha

[dpdk-dev] Example(Load_balancer) Tx flush bug

2016-12-23 Thread Maple
From: Maple To: Cc: Subject: [PATCH] Example(Load_balancer) Tx flush bug Date: Thu, 22 Dec 2016 09:57:48 +0800 Message-Id: <1482371868-19669-1-git-send-email-liuj...@raisecom.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <2016122122394164225...@raisecom.com> References: <2016122122394164225..

Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter

2016-12-23 Thread Adrien Mazarguil
Hi, On Thu, Dec 22, 2016 at 10:44:32AM +, Ferruh Yigit wrote: > On 12/22/2016 9:19 AM, Zhao1, Wei wrote: > > Hi, Yigit > > > >> -Original Message- > >> From: Yigit, Ferruh > >> Sent: Wednesday, December 21, 2016 1:01 AM > >> To: Zhao1, Wei ; dev@dpdk.org > >> Cc: Lu, Wenzhuo > >> Sub

[dpdk-dev] [PATCH 3/3] crypto/qat: fix iv size in PMD capabilities

2016-12-23 Thread Arek Kusztal
This patch sets iv size in qat PMD to 12 bytes to be conformant with nist SP800-38D. Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery") --- drivers/crypto/qat/qat_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/

[dpdk-dev] [PATCH 2/3] crypto/aesni_gcm: fix iv size in PMD capabilities

2016-12-23 Thread Arek Kusztal
This patch sets iv size in aesni gcm PMD to 12 bytes to be conformant with nist SP800-38D. Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations") Signed-off-by: Arek Kusztal --- drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[dpdk-dev] [PATCH 0/3] Fix iv sizes in crypto drivers capabilities

2016-12-23 Thread Arek Kusztal
This patchset fixes iv (initialization vector) size values in qat and aesni gcm pmds to be conformant with nist SP800-38D. Arek Kusztal (3): crypto/aesni_gcm: fix J0 padding bytes for GCM crypto/aesni_gcm: fix iv size in PMD capabilities crypto/qat: fix iv size in PMD capabilities drivers/

[dpdk-dev] [PATCH 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM

2016-12-23 Thread Arek Kusztal
This commit fixes pre-counter block (J0) padding by clearing four most significant bytes before setting initial counter value. Fixes: b2bb3597470c ("crypto/aesni_gcm: move pre-counter block to driver") Signed-off-by: Arek Kusztal --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +++- 1 file cha