> -----Original Message----- > From: Michal Miroslaw [mailto:mirq-li...@rere.qmqm.pl] > Sent: Friday, December 23, 2016 1:48 AM > To: Ananyev, Konstantin <konstantin.anan...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [PATCH] acl: remove invalid test > > On Mon, Dec 19, 2016 at 06:48:52PM +0000, Ananyev, Konstantin wrote: > > Hi Michal, > > > > > -----Original Message----- > > > From: Michał Mirosław [mailto:mirq-li...@rere.qmqm.pl] > > > Sent: Wednesday, December 14, 2016 5:24 PM > > > To: dev@dpdk.org > > > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com> > > > Subject: [PATCH] acl: remove invalid test > > > > > > rte_acl_add_rules() has no way of checking rule size. > > > > > > This was hidden because the test effectively checked that > > > adding a rule with userdata == 0 failed. > > I suppose that changes have to be inside: > > [PATCH v2] acl: allow zero verdict. > > The 'allow zero verdict' patch depends on this one if we are to not have > a breaking tests inbetween.
Exactly, that's why I think they either has to be in one series of patches, with this one coming first and ' PATCH v2] acl: allow zero verdict' as the second one, or just merge them into one. Konstantin >Otherwise, it is an independent change. > > I guess I can merge them, though, if you prefer it that way. > > Best Regards, > Michał Mirosław
