2015-03-04 22:50, David Marchand:
> 143 files changed, 310 insertions(+), 685 deletions(-)
Great job.
As it removes more lines than it adds, it's probably a good cleanup patchset ;)
--
Thomas
When there is no more things to remove, it's becoming perfect.
On Wed, Mar 4, 2015 at 9:40 PM, Zhang, Helin wrote:
>> * 32-bit (yes, KNI works fine, after a few tweaks hugepage init strategy)
> Interesting! How did you get it works?
In a nutshell: The current (circa r1.8.0) approach does mmap starting
from the bottom of the address space, then does a second
There is no remaining reference to this errno.
Signed-off-by: David Marchand
---
app/test/test_errno.c |2 +-
lib/librte_eal/common/eal_common_errno.c |2 --
lib/librte_eal/common/include/rte_errno.h |1 -
3 files changed, 1 insertion(+), 4 deletions(-)
diff --g
No static entry remaining, the rte_tailq api is for "internal use" only, get rid
of the static slots.
Signed-off-by: David Marchand
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map |1 -
lib/librte_eal/common/Makefile|2 +-
lib/librte_eal/common/eal_common_tailqs
Use dynamic tailq rather than static entries.
Signed-off-by: David Marchand
---
lib/librte_acl/rte_acl.c | 33 +++
lib/librte_acl/rte_acl.h |1 -
lib/librte_distributor/rte_distributor.c | 16 +--
lib/librte_ea
This register system makes it possible to reserve a tailq for the dpdk
libraries.
The "dynamic" tailqs are right after the "static" tailqs in shared mem.
Primary process is responsible for writing the tailq names, so that secondary
processes can find them.
This is a temp commit, "static" tailqs ar
A lot of places just protect against concurrent access and I can not see the
gain of having those macros.
Signed-off-by: David Marchand
---
lib/librte_eal/common/include/rte_eal.h | 58 ---
lib/librte_mempool/rte_mempool.c| 10 --
2 files changed, 7 in
The "reserve" macros and functions do not check if the requested entry is free.
They do nothing more than the lookup function (which itself "creates" entries
...).
The rte_tailq api is marked as "internal use" in documentation and these macros
are only used in test application, so just get rid of t
No need to cast everywhere, define a common macro for this, plus it can be used
in future commits.
Signed-off-by: David Marchand
---
lib/librte_eal/common/include/rte_tailq.h | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_t
Only keep inclusion where really needed.
Signed-off-by: David Marchand
---
app/test-pipeline/config.c |1 -
app/test-pipeline/init.c |1 -
app/test-pipeline/main.c |1 -
app/test-pipel
There is no reason why we should use the "reserve" tailq api, since the pci
entry is already statically reserved.
Signed-off-by: David Marchand
---
lib/librte_eal/bsdapp/eal/eal_pci.c |2 +-
lib/librte_eal/linuxapp/eal/eal_pci.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Hopefully, this is the last reference to pm.
Signed-off-by: David Marchand
---
lib/librte_eal/common/include/rte_tailq_elem.h |2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_tailq_elem.h
b/lib/librte_eal/common/include/rte_tailq_elem.h
index 3013869..01
This is a first cleanup at trying to remove references to other dpdk libraries
from eal.
This cleanup is focused on rte_tailq api which has been marked as "for internal
use" for quite some time now.
Rather than have a static list in eal for all users of rte_tailq, a new register
system is introduc
Anyone to carefully review this patch?
2015-01-27 11:38, Stephen Hemminger:
> On Tue, 27 Jan 2015 11:11:39 +0100
> Thomas Monjalon wrote:
>
> > Hi Stephen,
> >
> > 2015-01-22 22:23, stephen at networkplumber.org:
> > > From: Stephen Hemminger
> > >
> > > The ixgbe driver was including CRC in
2015-02-19 14:53, Bruce Richardson:
> On Sat, Feb 14, 2015 at 09:59:05AM -0500, Stephen Hemminger wrote:
> > The malloc family returns void * and therefore cast is unnecessary.
> > Use calloc rather than zmalloc with multiply for array.
> >
> > Signed-off-by: Stephen Hemminger
>
> Looks like a g
Hi Keith,
On 03/04/2015 05:47 PM, Wiles, Keith wrote:
> Hi Olivier
>
> On 3/4/15, 10:40 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> On 03/04/2015 05:11 PM, Wiles, Keith wrote:
>>>
>>>
>>> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote:
>>>
Hi Keith,
On 02/28/2015 05:56 PM, Keith Wile
2015-03-04 11:26, Neil Horman:
> +#trap on ctrl-c to clean up
> +trap cleanup_and_exit SIGINT
I think INT is preffered over SIGINT.
You may also add QUIT and TERM.
With QUIT, you can replace cleanup_and_exit calls by a simple exit.
> + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD`
Hi Keith,
On 03/04/2015 05:11 PM, Wiles, Keith wrote:
>
>
> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote:
>
>> Hi Keith,
>>
>> On 02/28/2015 05:56 PM, Keith Wiles wrote:
>>> When building an external application like Pktgen and using the proper
>>> makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk file
2015-03-04 10:42, Neil Horman:
> On Wed, Mar 04, 2015 at 04:15:18PM +0100, Thomas Monjalon wrote:
> > 2015-03-04 09:39, Neil Horman:
> > > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote:
> > > > Hi Neil,
> > > >
> > > > I remove parts that I agree and reply to those which deserve
Hi Olivier,
On 3/4/15, 11:04 AM, "Olivier MATZ" wrote:
>Hi Keith,
>
>On 03/04/2015 05:47 PM, Wiles, Keith wrote:
>> Hi Olivier
>>
>> On 3/4/15, 10:40 AM, "Olivier MATZ" wrote:
>>
>>> Hi Keith,
>>>
>>> On 03/04/2015 05:11 PM, Wiles, Keith wrote:
On 3/4/15, 3:08 AM, "Olivier MATZ"
On 3/4/15, 10:47 AM, "Wiles, Keith" wrote:
>Hi Olivier
>
>On 3/4/15, 10:40 AM, "Olivier MATZ" wrote:
>
>>Hi Keith,
>>
>>On 03/04/2015 05:11 PM, Wiles, Keith wrote:
>>>
>>>
>>> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote:
>>>
Hi Keith,
On 02/28/2015 05:56 PM, Keith Wiles wrote:
>>>
Hi Olivier
On 3/4/15, 10:40 AM, "Olivier MATZ" wrote:
>Hi Keith,
>
>On 03/04/2015 05:11 PM, Wiles, Keith wrote:
>>
>>
>> On 3/4/15, 3:08 AM, "Olivier MATZ" wrote:
>>
>>> Hi Keith,
>>>
>>> On 02/28/2015 05:56 PM, Keith Wiles wrote:
When building an external application like Pktgen and using
2015-03-04 09:39, Neil Horman:
> On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote:
> > Hi Neil,
> >
> > I remove parts that I agree and reply to those which deserve more
> > discussion.
> >
> > 2015-03-04 06:49, Neil Horman:
> > > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas M
On 3/4/15, 3:08 AM, "Olivier MATZ" wrote:
>Hi Keith,
>
>On 02/28/2015 05:56 PM, Keith Wiles wrote:
>> When building an external application like Pktgen and using the proper
>> makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would
>> use with example applications in the same RTE_SDK
On 03/04/2015 03:31 PM, Bruce Richardson wrote:
> On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote:
>> On 03/04/2015 03:08 PM, Bruce Richardson wrote:
>>> On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote:
On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote
On 03/04/2015 03:08 PM, Bruce Richardson wrote:
> On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote:
>> On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote:
>>> On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
Hi Panu,
2015-03-04 08:17, Panu Matilainen:
> With
On Wed, 4 Mar 2015 20:55:05 +
Thomas Monjalon wrote:
> Anyone to carefully review this patch?
>
> 2015-01-27 11:38, Stephen Hemminger:
> > On Tue, 27 Jan 2015 11:11:39 +0100
> > Thomas Monjalon wrote:
> >
> > > Hi Stephen,
> > >
> > > 2015-01-22 22:23, stephen at networkplumber.org:
>
On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson wrote:
> On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote:
> > Right, but then there's "ivshmem" that doesn't fit that description
> either
> > AFAICS.
>
> Ah, yes, forgotten about that one! :-)
Well, this is out of scope, but this
2015-03-04 13:49, Bruce Richardson:
> On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote:
> > On 03/04/2015 03:31 PM, Bruce Richardson wrote:
> > >On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote:
> > >>On 03/04/2015 03:08 PM, Bruce Richardson wrote:
> > >>>On Wed, Mar 0
From: Xuelin Shi
This module uses type conversion between struct and int.
Also truncation and comparison is used with this int.
It is not safe for different endian arch.
Add ifdef for big endian struct to fix this issue.
Signed-off-by: Xuelin Shi
---
lib/librte_lpm/rte_lpm.h | 19
On Wed, Mar 04, 2015 at 02:57:50PM +0100, David Marchand wrote:
> On Wed, Mar 4, 2015 at 2:49 PM, Bruce Richardson intel.com
> > wrote:
>
> > On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote:
> > > Right, but then there's "ivshmem" that doesn't fit that description
> > either
> > >
Hi Neil,
I remove parts that I agree and reply to those which deserve more discussion.
2015-03-04 06:49, Neil Horman:
> On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote:
> > 2015-02-02 13:18, Neil Horman:
> > > +# Validate that we have all the arguments we need
> > > +res=$(validat
On Wed, Mar 04, 2015 at 03:41:49PM +0200, Panu Matilainen wrote:
> On 03/04/2015 03:31 PM, Bruce Richardson wrote:
> >On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote:
> >>On 03/04/2015 03:08 PM, Bruce Richardson wrote:
> >>>On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote
On Wed, Mar 04, 2015 at 03:24:12PM +0200, Panu Matilainen wrote:
> On 03/04/2015 03:08 PM, Bruce Richardson wrote:
> >On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote:
> >>On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote:
> >>>On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
Added code that saves the pointers to the detached devices, during
driver loading, and during driver unloading, go over the list,
and re-attach them by calling device_probe_and_attach
on each device.
Signed-off-by: Raz Amir
---
lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32 +++
On Wed, Mar 04, 2015 at 06:28:05AM -0500, Neil Horman wrote:
> On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote:
> > On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
> > >Hi Panu,
> > >
> > >2015-03-04 08:17, Panu Matilainen:
> > >>With symbol versioning its vital that developers test
2015-02-11 14:28, Butler, Siobhan A:
> Hi all,
>
> In creating documentation for DPDK 1.8.0 dpdk.org used a separate repository
> 'dpdk-doc' to work on the conversion of old documentation from PDF to .rst
> with sphinx for maintainability and usability purposes.
> Now that the conversion has bee
On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
> Hi Panu,
>
> 2015-03-04 08:17, Panu Matilainen:
>> With symbol versioning its vital that developers test their code in
>> shared library mode, otherwise we'll be playing "add the forgotten
>> symbol export" from here to eternity.
>
> Yes we must impr
Hi Team,
Guest machine is not pingable from Host machine after creating a bridge with
datapath_type "netdev" in the configuration database and adding dpdk ports.
Can anyone please let me know what is the issue.
Thanks in advance.
Thanks & Regards
Arkajit Ghosh
=-=-=
Noti
2015-02-26 19:57 GMT+09:00 Thomas Monjalon :
> 2015-02-26 18:06, Tetsuya Mukawa:
>> 2015-02-26 16:03 GMT+09:00 Thomas Monjalon :
>> > 2015-02-25 16:49, Stephen Hemminger:
>> >> Build fails if HOTPLUG is disabled
>>
>> Hi Stephen,
>>
>> I appreciate for you reporting.
>>
>> >
>> > OK thanks for repo
On 2015/03/02 19:22, Bruce Richardson wrote:
> On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote:
>> Hi,
>>
>> I got a error while building master branch on FreeBSD.
>> Here is a log.
>>
>> $ gmake T=x86_64-native-bsdapp-clang config
>> cc: error: unknown argument: '-fdirectives-only'
2015-03-04 13:05, Panu Matilainen:
> On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
> > Hi Panu,
> >
> > 2015-03-04 08:17, Panu Matilainen:
> >> With symbol versioning its vital that developers test their code in
> >> shared library mode, otherwise we'll be playing "add the forgotten
> >> symbol ex
Understood.
I already sent the updated patch, so I will fix this and resend it soon.
-Original Message-
From: Bruce Richardson [mailto:bruce.richard...@intel.com]
Sent: 04 March 2015 12:13
To: Raz Amir
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices,
This patch removes below limitation from hotplug section of
programmer's guide.
- The framework can only be enabled with Linux. BSD is not supported.
Signed-off-by: Tetsuya Mukawa
---
doc/guides/prog_guide/port_hotplug_framework.rst | 2 --
1 file changed, 2 deletions(-)
diff --git a/doc/guide
The patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option from DPDK.
Signed-off-by: Tetsuya Mukawa
---
config/common_bsdapp | 6 --
config/common_linuxapp | 5 -
lib/librte_eal/common/eal_common_dev.c | 2 --
lib/librte_eal/common/eal_common_
This patch adds Hotplug support to BSD.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 169 +-
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 +
lib/librte_eal/common/include/rte_pci.h | 1 +
lib/librte_ether/rte_ethdev.c
Acked-by: Tommy Long
-Original Message-
From: Xie, Huawei
Sent: Tuesday, March 3, 2015 2:26 AM
To: dev at dpdk.org
Cc: haifeng.lin at huawei.com; mukawa at igel.co.jp; Long, Thomas; Xie, Huawei
Subject: [PATCH] lib/librte_vhost: remove vhost device from data plane when
receive VHOST_S
Added code that saves the pointers to the detached devices, during
driver loading, and during driver unloading, go over the list,
and re-attach them by calling device_probe_and_attach
on each device.
Signed-off-by: Raz Amir
---
lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32 +++
On 3/4/2015 10:56 AM, Ouyang Changchun wrote:
> The dpdk_nic_bind script will not allow ports to be bound or unbound if none
> of the
> kernel modules supported by DPDK is loaded. This patch relaxes this
> restriction by
> checking if a DPDK module is actually requested. The example below
> illu
> > Static analysis report some issues against current DPDK version. Most of
> > them need only cosmetic code changes (changing type of variable).
> >
> > One issue related with ring pmd fix real memory leak problem.
> >
> > PATCH v2 changes:
> > - remove patch 5/5 as it was NACKed
> > - reword
There was a request for an abi validation utilty for the ongoing ABI stability
work. As it turns out there is a abi compliance checker in development that
seems to be under active development and provides fairly detailed ABI compliance
reports. Its not yet intellegent enough to understand symbol
On 3/4/2015 4:19 PM, Wodkowski, PawelX wrote:
> On 2015-03-04 02:58, Qiu, Michael wrote:
>> On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote:
-Original Message-
From: Qiu, Michael
Sent: Tuesday, March 03, 2015 11:00 AM
To: Wodkowski, PawelX; dev at dpdk.org
Subject: Re:
2015-03-03 16:23, Thomas Monjalon:
> There are some compilation errors when debug options are enabled.
> We should start thinking to test every patch with an all-yes configuration.
> Unfortunately, we cannot force this kind of configuration because
> some libraries depend on the availability of som
Hi Stephen,
On 3/4/2015 8:52 AM, Stephen Hemminger wrote:
> On Fri, 27 Feb 2015 11:38:25 +0100
> David Marchand wrote:
>
>> Ok, so after looking at this patchset, I would say this is the right
>> direction, but still this is too limited.
>> The ethdev part and the vfio eventfds part look accepta
Move the rte.extvars.mk to an internal directory and
update rte.vars.mk to find the file in the new location.
Signed-off-by: Keith Wiles
---
mk/internal/rte.extvars.mk | 81 ++
mk/rte.extvars.mk | 81 ---
Thank you.
See answers inline (mostly ack, but not only), and I will send the updated
patch soon.
> -Original Message-
> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> Sent: 03 March 2015 15:33
> To: Raz Amir
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH]
Hi Thomas,
On 03/03/2015 04:23 PM, Thomas Monjalon wrote:
> error: format ?%p? expects argument of type ?void *?,
> but argument 5 has type ?const struct rte_mempool *? [-Werror=format=]
>
> mp type is (const struct rte_mempool *) and must be casted into a simpler
> type to be printed.
I was a bi
> -Original Message-
> From: Zhang, Helin
> Sent: Wednesday, March 4, 2015 8:34 AM
> To: Chilikin, Andrey; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type
> in rte_mbuf
>
>
>
> > -Original Message-
> > From: Chilikin, Andrey
> > Sent:
The dpdk_nic_bind script will not allow ports to be bound or unbound if none of
the
kernel modules supported by DPDK is loaded. This patch relaxes this restriction
by
checking if a DPDK module is actually requested. The example below illustrates
this
problem:
In virtio test, on the guest
1. Bin
On Wed, 04 Mar 2015 09:57:24 +0200
Vlad Zolotarov wrote:
>
>
> On 03/04/15 02:33, Stephen Hemminger wrote:
> > On Tue, 3 Mar 2015 21:48:43 +0200
> > Vlad Zolotarov wrote:
> >
> >> + next_desc:
> >> + /*
> >> + * The code in this whole file uses the volatile pointer to
> >>
Hi,
In the dpdk_qat example, the function alloc_memzone_region does the
allocation for the memory of a crypto session context. Now in a real
application, the sessions will be torn down as well. So if a similar
strategy is followed as that of alloc_memzone_region, then how can the
memory be returne
On Wed, 04 Mar 2015 09:59:38 +0200
Vlad Zolotarov wrote:
> > Checkpatch warnings (edited to remove ones that should be ok)
>
> I was unaware that checkpatch rules apply here - at least looking at the
> current code it looks like it... ;)
> But I'm all for it! I'll fix all the issues and respi
On Wed, Mar 04, 2015 at 10:26:24AM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Wednesday, March 04, 2015 10:23 AM
> > To: Thomas Monjalon
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-
On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote:
> From: Xuelin Shi
>
> This module uses type conversion between struct and int.
> Also truncation and comparison is used with this int.
> It is not safe for different endian arch.
>
> Add ifdef for big endian struct to
Hi Marc,
On 03/03/2015 02:27 PM, Marc Sune wrote:
>
> On 03/03/15 14:03, Bruce Richardson wrote:
>> On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote:
>> [...]
>> I believe that the global option of overriding the CFLAGS is already
>> sufficiently
>> covered - including being documented in
On Wed, Mar 04, 2015 at 10:24:44AM +0100, Thomas Monjalon wrote:
> Hi Panu,
>
> 2015-03-04 08:17, Panu Matilainen:
> > With symbol versioning its vital that developers test their code in
> > shared library mode, otherwise we'll be playing "add the forgotten
> > symbol export" from here to eternity
On Wed, Mar 04, 2015 at 04:15:18PM +0100, Thomas Monjalon wrote:
> 2015-03-04 09:39, Neil Horman:
> > On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote:
> > > Hi Neil,
> > >
> > > I remove parts that I agree and reply to those which deserve more
> > > discussion.
> > >
> > > 2015-0
Hi Tetsuya, Hi Bruce,
On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote:
> On 2015/03/02 19:22, Bruce Richardson wrote:
>> On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote:
>>> Hi,
>>>
>>> I got a error while building master branch on FreeBSD.
>>> Here is a log.
>>>
>>> $ gmake T=x86_64-n
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> Sent: Wednesday, March 04, 2015 10:23 AM
> To: Thomas Monjalon
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file
>
> On Tue, Mar 03, 2015
Hi Panu,
2015-03-04 08:17, Panu Matilainen:
> With symbol versioning its vital that developers test their code in
> shared library mode, otherwise we'll be playing "add the forgotten
> symbol export" from here to eternity.
Yes we must improve the sanity checks.
A lot of options must be tested (or
On Tue, Mar 03, 2015 at 10:03:45PM +0100, Thomas Monjalon wrote:
> 2015-03-03 16:38, Bruce Richardson:
> > The ENQUEUE_PTRS and DEQUEUE_PTRS macros defined in rte_ring.h are
> > not meant to be global and are not prefixed with the RTE_ prefix.
> > Therefore undef the macros at end of file to avoid
On Wed, Mar 04, 2015 at 02:07:20AM +, Wang, Zhihong wrote:
>
>
> > -Original Message-
> > From: Richardson, Bruce
> > Sent: Monday, March 02, 2015 6:32 PM
> > To: Wang, Zhihong
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules
> > b
On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote:
> Hi Tetsuya, Hi Bruce,
>
> On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote:
> >On 2015/03/02 19:22, Bruce Richardson wrote:
> >>On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote:
> >>>Hi,
> >>>
> >>>I got a error while buildi
On Wed, Mar 04, 2015 at 11:07:41AM +0200, Raz Amir wrote:
> Thank you.
>
> See answers inline (mostly ack, but not only), and I will send the updated
> patch soon.
>
>
>
> > -Original Message-
>
> > From: Bruce Richardson [mailto:bruce.richardson at intel.com]
>
> > Sent: 03 March 20
Hi Keith,
On 02/28/2015 05:56 PM, Keith Wiles wrote:
> When building an external application like Pktgen and using the proper
> makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would
> use with example applications in the same RTE_SDK directory the rte.extXYZ.mk
> files are missing som
On 03/04/2015 02:33 AM, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> + * TODO:
>> + *- Get rid of "volatile" crap and let the compiler do its
>> + * job.
>> + *- Use the proper memory barri
On 03/04/15 02:36, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> - Only x540 and 82599 devices support LRO.
>> - Add the appropriate HW configuration.
>> - Add RSC aware rx_pkt_burst() handlers:
>> - Implemented bulk allocation
On 03/04/15 02:34, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +
>> +if (!bulk_alloc) {
>> +__le64 dma =
>> + rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(nmb));
>> +/*
>> +
On 03/04/15 02:33, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +next_desc:
>> +/*
>> + * The code in this whole file uses the volatile pointer to
>> + * ensure the read ordering of the status and the rest of t
Hi Vadim,
On 02/27/2015 06:09 PM, Vadim Suraev wrote:
> >Indeed, this function looks useful, and I also have a work in progress
> >on this topic, but currently it is not well tested.
> I'm sorry, I didn't know. I'll not interfere with my patch))
That not what I wanted to say :)
You are very we
On 03/03/15 15:23, Thomas Monjalon wrote:
> The function print_client_stats was used in the example without being
> clearly exported in the map file. So it breaks linking with shared library
> when debug is enabled.
> It's better to remove this function as it probably could be implemented
> with st
On Wed, Mar 04, 2015 at 01:54:49PM +0100, Thomas Monjalon wrote:
> Hi Neil,
>
> I remove parts that I agree and reply to those which deserve more discussion.
>
> 2015-03-04 06:49, Neil Horman:
> > On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote:
> > > 2015-02-02 13:18, Neil Horman
On 03/04/15 02:33, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov wrote:
>
>> +lro_bulk_alloc: 1, /**< RX LRO with bulk alloc is ON(1) /
>> OFF(0) */
> This is an internal decision and should not be exposed in the API.
> We need less knobs not more.
On 2015-03-04 02:58, Qiu, Michael wrote:
> On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote:
>>> -Original Message-
>>> From: Qiu, Michael
>>> Sent: Tuesday, March 03, 2015 11:00 AM
>>> To: Wodkowski, PawelX; dev at dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast fro
Reported-by: Butler, Siobhan A
Signed-off-by: Cunming Liang
---
Fixes: 1733be6d3147(doc: new eal multi-pthread feature)
doc/guides/prog_guide/env_abstraction_layer.rst | 82 -
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git a/doc/guides/prog_guide/env_abs
> -Original Message-
> From: Chilikin, Andrey
> Sent: Monday, March 2, 2015 7:48 PM
> To: Zhang, Helin; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v4 01/18] mbuf: redefinition of packet_type in
> rte_mbuf
>
> Hi Helin,
>
> I see that you have removed "uint16_t reserved" member fro
With symbol versioning its vital that developers test their code in
shared library mode, otherwise we'll be playing "add the forgotten
symbol export" from here to eternity. By defaulting to shared we
should catch more of these cases early, but without taking away anybodys
ability to build static.
Fixes: 36ec8585b298 ("ethdev: release port")
Signed-off-by: Panu Matilainen
---
lib/librte_ether/rte_ether_version.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index 0d46578..a2d25a6 100644
--- a/lib/libr
On Tue, Mar 03, 2015 at 11:18:47PM +0100, Thomas Monjalon wrote:
> 2015-02-02 13:18, Neil Horman:
> > There was a request for an abi validation utiltyfor the ongoing ABI
> > stability
> > work. As it turns out there is a abi compliance checker in development that
> > seems to be under active deve
On Wed, Mar 04, 2015 at 01:05:07PM +0200, Panu Matilainen wrote:
> On 03/04/2015 11:24 AM, Thomas Monjalon wrote:
> >Hi Panu,
> >
> >2015-03-04 08:17, Panu Matilainen:
> >>With symbol versioning its vital that developers test their code in
> >>shared library mode, otherwise we'll be playing "add th
> -Original Message-
> From: Wodkowski, PawelX
> Sent: Monday, March 02, 2015 8:32 PM
> To: Richardson, Bruce; Wang, Zhihong
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules
> breaking
>
> On 2015-03-02 11:32, Bruce Richardson wrote:
> >
Tested-by: Jiajia, SunX
- Tested Commit: 8bfc4e3c4cb922d9c7e6b8934fdaffba268c7ed2
- OS: Fedora20 3.11.10-301.fc20.x86_64
- GCC: gcc version 4.8.3
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection
[8086:10fb]
- Target x86_64-n
Hi,
> -Original Message-
> From: Richardson, Bruce
> Sent: Tuesday, March 3, 2015 7:44 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org; Cao, Waterman
> Subject: Re: [PATCH] tools/dpdk_nic_bind: Fix can't bind virtio-pci issue
>
> On Thu, Feb 26, 2015 at 12:57:49PM +0800, Ouyang Changchun
> -Original Message-
> From: Richardson, Bruce
> Sent: Monday, March 02, 2015 6:32 PM
> To: Wang, Zhihong
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] A fix to work around strict-aliasing rules
> breaking
>
> On Mon, Mar 02, 2015 at 05:03:50PM +0800, zhihong.wang at intel.com
On 3/3/2015 9:38 PM, Wodkowski, PawelX wrote:
>> -Original Message-
>> From: Qiu, Michael
>> Sent: Tuesday, March 03, 2015 11:00 AM
>> To: Wodkowski, PawelX; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer
>> to
>> integer of different size
>>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, March 3, 2015 11:24 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 4/7] virtio: fix build with debug enabled
>
> With CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_INIT=y:
> erro
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, March 3, 2015 11:24 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 3/7] virtio: fix build with mempool debug
> enabled
>
> The mempool header forces error on -Wcast-qual
97 matches
Mail list logo
