2015-03-04 11:26, Neil Horman: > +#trap on ctrl-c to clean up > +trap cleanup_and_exit SIGINT
I think INT is preffered over SIGINT. You may also add QUIT and TERM. With QUIT, you can replace cleanup_and_exit calls by a simple exit. > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD` May be simpler "git log -1 --format=%H" > +log "INFO" "We're going to check and make sure that applications built" > +log "INFO" "against DPDK DSOs from tag $TAG1 will still run when executed" > +log "INFO" "against DPDK DSOs built from tag $TAG2." I think it may be removed as no app is run. > +# Make sure we configure SHARED libraries > +# Also turn off IGB and KNI as those require kernel headers to build > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET So you prefer modifying defconfig instead of .config, right? (you sent it while I was answering on v2) > +# Checking abi compliance relies on using the dwarf information in > +# The shared objects. Thats only included in the DSO's if we build > +# with -g > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g [...] > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g Already exported. > + OLDNAME=`basename $i | sed -e"s/1.dump/0.dump/"` Could be OLDNAME=$(basename $i 1.dump)0.dump > + LIBNAME=`basename $i | sed -e"s/-ABI-1.dump//"` Could be LIBNAME=$(basename $i -ABI-1.dump) Thanks
