Hi,
These tests don't seem related to the patchset.
It would be more interesting to test vlan, stop/restart, Rx checks
and Rx performance improvement.
--
Thomas
2014-11-04 05:57, Zhang, XiaonanX:
> Tested-by: Xiaonan Zhang
>
> - Tested Commit: Yong Wang
> - OS: Fedora20 3.15.8-200.fc20.x86_6
From: Simon Kuenzer
Enable users to specify the lcore id that is used as master lcore.
Signed-off-by: Simon Kuenzer
Signed-off-by: Thomas Monjalon
---
changes in v2:
- rebase on HEAD including common options for BSD and Linux
- use strtol() instead of atoi() to check syntax errors
- unit test
> On Nov 4, 2014, at 1:29 PM, Neil Horman wrote:
>
> On Tue, Nov 04, 2014 at 02:44:39PM +, Wiles, Roger Keith wrote:
>>
>>> On Nov 4, 2014, at 5:27 AM, Neil Horman wrote:
>>>
>>> On Tue, Nov 04, 2014 at 04:52:48AM +, Wiles, Roger Keith wrote:
> On Nov 3, 2014, at 5:42 PM, Ne
On 11/3/14, 7:49 AM, "Yan Freedland" wrote:
>Hi
>
>I am trying to initialize the environment for 3 processes and 2 ports.
>Currently I fail in vmxnet3_dev_start (0).
>The exact place is as follows:
>
> /* Activate device by register write */
> VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_C
2014-11-03 13:02, Aaron Campbell:
> > On Jul 8, 2014, at 5:28 AM, Simon Kuenzer
> > wrote:
> >
> > + else if (!strcmp(lgopts[option_index].name,
> > OPT_MASTER_LCORE)) {
> > + if (!coremask_ok) {
> > + RTE_LOG(ERR, EA
From: "Chen Jing D(Mark)"
1. Function i40e_vsi_* name change to i40e_dev_* since PF can contains
more than 1 VSI after VMDQ enabled.
2. i40e_dev_rx/tx_queue_setup change to have capability of setup
queues that belongs to VMDQ pools.
3. Add queue mapping. This will do a convertion between qu
From: "Chen Jing D(Mark)"
Change i40e_macaddr_add and i40e_macaddr_remove functions to support
multiple macaddr add/delete. In the meanwhile, support macaddr ops
on different pools.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_i40e/i40e_ethdev.c | 90 +-
From: "Chen Jing D(Mark)"
The change includes several parts:
1. Get maximum number of VMDQ pools supported in dev_init.
2. Fill VMDQ info in i40e_dev_info_get.
3. Setup VMDQ pools in i40e_dev_configure.
4. i40e_vsi_setup change to support creation of VMDQ VSI.
Signed-off-by: Chen Jing D(Mark)
-
From: "Chen Jing D(Mark)"
Assign new VMDQ arguments with correct values.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
From: "Chen Jing D(Mark)"
Assign new VMDQ arguments with correct values.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_e1000/igb_ethdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/librte_pmd_e1000/igb_ethdev.c
b/lib/librte_pmd_e1000/igb_ethdev.c
inde
From: "Chen Jing D(Mark)"
The change includes several parts:
1. Clear pool bitmap when trying to remove specific MAC.
2. Define RSS, DCB and VMDQ flags to combine rx_mq_mode.
3. Use 'struct' to replace 'union', which to expand the rx_adv_conf
arguments to better support RSS, DCB and VMDQ.
4. F
From: "Chen Jing D(Mark)"
v3:
- Fix comments style.
- Simplify words in comments.
- Add variable defintion for BSD config file.
- Code rebase to latest DPDK repo.
v2:
- Fix a few typos.
- Add comments for RX mq mode flags.
- Remove '\n' from some log messages.
- Remove 'Acked-by' in commit log.
Data_ring is a pre-mapped guest ring buffer that vmxnet3
backend has access to directly without a need for buffer
address mapping and unmapping during packet transmission.
It is useful in reducing device emulation cost on the tx
path. There are some additional cost though on the guest
driver for p
This patch includes two small performance optimizations
on the rx path:
(1) It adds unlikely hints on various infrequent error
paths to the compiler to make branch prediction more
efficient.
(2) It also moves a constant assignment out of the pkt
polling loop. This saves one branching per packet.
Only supports IPv4 so far.
Signed-off-by: Yong Wang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index 2017d4b..e2fb8a8 100644
--
This change makes vmxnet3 consistent with other pmds in
terms of dev_stop behavior: rather than releasing tx/rx
rings, it only resets the ring structure and release the
pending mbufs.
Verified with various tests (test-pmd and pktgen) over
vmxnet3 that dev stop/restart works fine.
Signed-off-by: Y
Signed-off-by: Yong Wang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index 986e5e5..0b6363f 100644
--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
+++ b/lib/librte_pm
Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.
Signed-off-by: Yong Wang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index
This patch series include various fixes and improvement to the
vmxnet3 pmd driver.
V2:
- Add more commit descriptions
- Add a new patch that improve tx performance for small packet
Yong Wang (6):
vmxnet3: Fix VLAN Rx stripping
vmxnet3: Add VLAN Tx offload
vmxnet3: Fix dev stop/restart bug
Hi all,
Can anybody answer my queries ?
thanks & Regards,
Srikanth
On Thu, Oct 30, 2014 at 9:09 AM, Srikanth Akula
wrote:
> Hello All ,
>
> I am currently trying to implement QOS scheduler using DPDK 1.6 . I have
> configured 1 subport , 4096 pipes for the sub port and 4 TC's and 4 Queues .
>
'PFINT_ICR0_ENA' shouldn't be cleared in user space ISR,
otherwise adminq interrupts might be missed during
co-working with VF initialization.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_i40e/i40e_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
Extract a function to replace duplicated codes in one copy and zero copy TX
function.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 139 +-
1 file changed, 58 insertions(+), 81 deletions(-)
diff --git a/examples/vhost/main.c b/examp
As HW vlan strip will reduce the packet length by minus length of vlan tag,
so it need restore the packet length by plus it.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/examples/vhost/main.c b/example
This patch set fix packet length issue in vhost app, and enhance code by
extracting a function to replace duplicated codes in one copy and zero copy
TX function.
-v3 change:
Extract a function to replace duplicated codes in one copy and zero copy TX
function
-v2 change:
Update data length by p
> On Nov 4, 2014, at 5:27 AM, Neil Horman wrote:
>
> On Tue, Nov 04, 2014 at 04:52:48AM +, Wiles, Roger Keith wrote:
>>
>>> On Nov 3, 2014, at 5:42 PM, Neil Horman wrote:
>>>
>>> On Mon, Nov 03, 2014 at 03:26:50PM -0800, Stephen Hemminger wrote:
On Mon, 3 Nov 2014 16:50:15 +
Hi,
Sure I can start with Clean-up as I need to familiarize with the code
first and then follow-up with Patch reviews.
Thanks,
Ravi
On Sun, Nov 2, 2014 at 1:32 PM, Thomas Monjalon
wrote:
> Hi,
>
> There are many ways of contributing to DPDK.
> Apart features and fixes, I'd suggest these 4 activ
These changes are a conversion of the TestPMD Application User Guide from an
MSWord file to Sphinx rst files.
The following changes since commit 03e801bc790ab2478ad36ea44ce706c9d1a012ae:
i40e: fix PF interrupt handler (2014-11-04 11:20:11 +0100)
are available in the git repository at:
git:/
On Tue, Nov 04, 2014 at 02:44:39PM +, Wiles, Roger Keith wrote:
>
> > On Nov 4, 2014, at 5:27 AM, Neil Horman wrote:
> >
> > On Tue, Nov 04, 2014 at 04:52:48AM +, Wiles, Roger Keith wrote:
> >>
> >>> On Nov 3, 2014, at 5:42 PM, Neil Horman wrote:
> >>>
> >>> On Mon, Nov 03, 2014 at 03
This patch is for testing the port hotplug framework.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_e1000/em_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_e1000/em_ethdev.c b/lib/librte_pmd_e1000/em_ethdev.c
index 3f2897e..90ec2d7 100644
--- a/l
The patch introduces following commands.
- port [attach|detach] [p|v] [ident]
- attach: attaching a port
- detach: detaching a port
- p: physical port
- v: virtual port
- ident: pci address of physical device.
Or device name and paramerters of virtual device.
(ex. :02:00
This patch adds finalization code to free resources allocated by the
PMD.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_pmd_pcap/rte_eth_pcap.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c
b/lib/librte_pmd_pcap/rte_eth_pc
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration.
Signed-off-by: Tetsuya Mukawa
---
config/common_linuxapp | 5 +
1 file changed, 5 insertions(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index c5751bd..f94ec65 100644
--- a/config/common_linuxapp
+++
The patch adds rte_eal_dev_attach_pdev() and rte_eal_dev_detach_pdev().
rte_eal_dev_attach_pdev() receives a PCI address of the device and
returns an attached port number.
rte_eal_dev_detach_pdev() receives a port number, and returns a PCI
address actually detached.
Signed-off-by: Tetsuya Mukawa
The functions are used for probe and close a device.
First the function tries to find a device that has the specfied PCI address.
Then, probe or close the device.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 58 +
lib/librte_eal/comm
The function tries to find a driver for the specified device, and then
close the driver.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_pci.c
b/lib/librte_eal/comm
pci_close_all_drivers() will be implemented after the patch.
To share a part of code between thses 2 functions, The patch fixes
pci_probe_all_drivers() first.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_pci.c | 28
1 file changed, 20 insertions
The function is used for closing the specified driver and device.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/eal_private.h | 11 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 58 +
2 files changed, 69 insertions(+)
diff --git a/lib/librte_
The function is called by port hotplug framework, so change scope of the
function to global.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/eal_private.h | 11 +++
lib/librte_eal/linuxapp/eal/eal_pci.c | 6 +++---
2 files changed, 14 insertions(+), 3 deletions(-)
The patch fixes pci_scan_one() not to register same pci devices twice.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c
b/lib/librte_eal/linuxapp/eal/eal_pci
The patch adds functions for unmapping igb_uio resources. The patch is only
for Linux and igb_uio environment. VFIO and BSD are not supported.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +
lib/librte_eal/linuxapp/eal/eal_pci_uio.c
The patch adds rte_eal_dev_attach_vdev() and rte_eal_dev_detach_vdev().
rte_eal_dev_attach_vdev() receives virtual device name and parameters,
and returns an attached port number.
rte_eal_dev_detach_vdev() receives a port number, and returns device
name actually detached.
Signed-off-by: Tetsuya M
The patch adds rte_eal_dev_init_one() and rte_eal_dev_close_one().
These are used for attaching and detaching virtual devices.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_dev.c | 74 +
lib/librte_eal/common/include/rte_dev.h | 6 +++
lib/l
The function removes a specified devargs from devargs_list.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_devargs.c | 13 +
lib/librte_eal/common/include/rte_devargs.h | 18 ++
2 files changed, 31 insertions(+)
diff --git a/lib/librte_eal/common
The patch fixes rte_eal_devargs_add() not to register same device twice.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/eal_common_devargs.c | 32 ++
1 file changed, 32 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_devargs.c
b/lib/librte_eal/c
This function is used by virtual PMDs to support port hotplug framework.
So change scope of the function to global.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 2 +-
lib/librte_ether/rte_ethdev.h | 10 ++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git
The function returns whether a PMD supports detach function, or not.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 9 +
lib/librte_ether/rte_ethdev.h | 11 +++
2 files changed, 20 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rt
The function returns a unique identifier name of a ethdev specified by
port identifier.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 17 +
lib/librte_ether/rte_ethdev.h | 12
2 files changed, 29 insertions(+)
diff --git a/lib/librte_ether/rte_et
The function returns a port identifier of a ethdev specified by pci
address.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 13 +
lib/librte_ether/rte_ethdev.h | 13 +
2 files changed, 26 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/l
The function returns a pci address of a ethdev specified by port
identifier.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 12
lib/librte_ether/rte_ethdev.h | 13 +
2 files changed, 25 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/li
The patch adds rte_eth_dev_save() and rte_eth_dev_get_changed_port().
rte_eth_dev_save() is used for saving current rte_eth_dev structures.
rte_eth_dev_get_changed_port() receives the rte_eth_dev structures, then
compare these with current values to know which port is actually
attached or detached.
rte_eth_dev_shutdown() is called when PCI device is closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index efd631b..b623
The patch adds function pointer to rte_pci_driver and eth_driver
structure. These function pointers are used when ports are detached.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 7 +++
lib/librte_ether/rte_ethdev.h | 4
2 files changed, 11 inser
This patch adds rte_eth_dev_free(). The function is used for changing a
attached status of the device that has specified name.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_ether/rte_ethdev.c | 16
lib/librte_ether/rte_ethdev.h | 11 +++
2 files changed, 27 insertions(+)
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by
eal_compare_pci_addr().
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 16 +---
lib/librte_eal/common/eal_common_pci.c| 2 +-
lib/librte_eal/common/include/rte_pci.h | 29
To remove assumption, do like followings.
- Add 'attached' member to rte_eth_dev structure.
This member is used for indicating the port is attached, or not.
- Add rte_eth_dev_allocate_new_port().
This function is used for allocating new port.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eth
This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver
structure. The flags indicates the driver can detach devices at runtime.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/i
This patch series adds a dynamic port hotplug framework to DPDK.
With the patches, DPDK apps can attach or detach ports at runtime.
The basic concept of the port hotplug is like followings.
- DPDK apps must have resposibility to manage ports.
DPDK apps only know which ports are attached or detac
> > 'PFINT_ICR0_ENA' shouldn't be cleared in user space ISR,
> > otherwise adminq interrupts might be missed during
> > co-working with VF initialization.
> >
> > Signed-off-by: Helin Zhang
>
> Acked-by : Jing Chen
Applied
Thanks
--
Thomas
> From: Chen, Jing D
> Sent: Tuesday, November 04, 2014 10:01 AM
> To: dev at dpdk.org
> Cc: Ananyev, Konstantin; thomas.monjalon at 6wind.com; De Lara Guarch, Pablo;
> Chen, Jing D
> Subject: [PATCH v3 0/6] i40e VMDQ support
>
> From: "Chen Jing D(Mark)"
>
> v3:
> - Fix comments style.
> - Sim
2014-11-04 05:50, Chen, Jing D:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2014-10-16 18:07, Chen Jing D:
> > > + /** Specify the queue range belongs to VMDQ pools if VMDQ
> > applicable. */
> > > + uint16_t vmdq_queue_base;
> > > + uint16_t vmdq_queue_num;
> >
> > Please ex
Hello Jijiang,
On 10/27/2014 03:13 AM, Jijiang Liu wrote:
> Add test cases in testpmd to test VxLAN Tx Checksum offload, which include
> - IPv4 and IPv6 packet
> - outer L3, inner L3 and L4 checksum offload for Tx side.
>
> Signed-off-by: Jijiang Liu
I'm trying to port the test of TSO in csu
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 04, 2014 4:54 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Ananyev, Konstantin
> Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support
>
> 2014-11-04 05:50, Chen, Jing D
> -Original Message-
> From: Zhang, Helin
> Sent: Tuesday, November 04, 2014 4:08 PM
> To: dev at dpdk.org
> Cc: Cao, Waterman; Cao, Min; Xu, HuilongX; Chen, Jing D; Zhang, Helin
> Subject: [PATCH] i40e: fix of PF interrupt handling
>
> 'PFINT_ICR0_ENA' shouldn't be cleared in user space
On Tue, Nov 04, 2014 at 04:52:48AM +, Wiles, Roger Keith wrote:
>
> > On Nov 3, 2014, at 5:42 PM, Neil Horman wrote:
> >
> > On Mon, Nov 03, 2014 at 03:26:50PM -0800, Stephen Hemminger wrote:
> >> On Mon, 3 Nov 2014 16:50:15 +
> >> "Wiles, Roger Keith" wrote:
> >>
> >>>
> On Nov
Tested-by: Xiaonan Zhang
- Tested Commit: Yong Wang
- OS: Fedora20 3.15.8-200.fc20.x86_64
- GCC: gcc version 4.8.3 20140624
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection
[8086:10fb]
- Default x86_64-native-linuxapp-gcc co
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 04, 2014 6:17 AM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Ananyev, Konstantin
> Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support
>
> 2014-10-16 18:07, Ch
Hi,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 04, 2014 2:37 AM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Ananyev, Konstantin
> Subject: Re: [PATCH v2 2/6] igb: change for VMDQ arguments expansion
>
> 2014-10-16 18:07, Che
Hi,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, November 04, 2014 2:34 AM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Ananyev, Konstantin
> Subject: Re: [PATCH v2 4/6] i40e: add VMDQ support
>
> Hi Jing,
>
> 2014-10-16 18:07, Chen Jin
> On Nov 3, 2014, at 5:42 PM, Neil Horman wrote:
>
> On Mon, Nov 03, 2014 at 03:26:50PM -0800, Stephen Hemminger wrote:
>> On Mon, 3 Nov 2014 16:50:15 +
>> "Wiles, Roger Keith" wrote:
>>
>>>
On Nov 3, 2014, at 10:06 AM, Neil Horman wrote:
On Mon, Nov 03, 2014 at 02:25:51P
69 matches
Mail list logo
