> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 04, 2014 4:54 PM > To: Chen, Jing D > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support > > 2014-11-04 05:50, Chen, Jing D: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2014-10-16 18:07, Chen Jing D: > > > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > > > applicable. */ > > > > + uint16_t vmdq_queue_base; > > > > + uint16_t vmdq_queue_num; > > > > > > Please explain what mean the values in vmdq_queue_base and > > > vmdq_queue_num. > > > > I thinks the name is self- explanatory, I also add some comments for them. > > As previous max_rx/tx_queues indicates how many queues available, > these > > 2 variables defines the queue ranges for VM usage. > > I understand clearly now. > > > What kind of explanations you needs me to add? > > You cannot put a doxygen comment which apply to 2 fields. > Try do describe precisely the meaning of each field. > Example: /**< first queue ID in the range for VMDQ pool */ > and /**< size of the queue range for VMDQ pool */
Thanks! Got you. > > -- > Thomas
